TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
64,956 Commits 2 Branches 0 Tags 294 MiB
26f995459c
Commit Graph

5200 Commits

Author SHA1 Message Date
Yoshiyuki Hirano
1ac2a2292f Add accept-charset to the output of form_with in JS guide [ci skip] 2017-10-15 02:11:18 +09:00
Yoshiyuki Hirano
92a19f7671 Add unpermitted_parameters.action_controller hook to instrument guide [ci skip] 2017-10-14 08:11:14 +09:00
Yoshiyuki Hirano
8c3e345521 Add Action Cable notifications to instrument guide [ci skip] 2017-10-13 23:31:00 +09:00
Yoshiyuki Hirano
bf5e693fd1 Add process.action_mailer notification to Instrumentation guide [ci skip] 2017-10-13 22:26:13 +09:00
Aditya Kapoor
0efc132a81 fix the description for the select_all [ci skip] 2017-10-12 15:54:09 +05:30
Michael Coyne
04a7b7165a
Update security guide for signed cookie rotations 
The example was slightly incorrect. This commit also adds a test case
for this example to cookies middleware unit tests.
 2017-10-09 21:15:02 -04:00
Ryuta Kamizono
992572aecf Merge pull request #30839 from yhirano55/use_form_with_in_engine_guide 
Use `form_with` instead of `form_for` in engine guide [ci skip]
 2017-10-09 11:56:25 +09:00
Yoshiyuki Hirano
639fded77b Use form_with instead of form_for in engine guide [ci skip] 2017-10-09 11:36:37 +09:00
Ryuta Kamizono
fde880b09a Merge pull request #30838 from yhirano55/fix_rails_routes_log_in_getting_started_guide 
Fix the result of `rails routes` in Guide [ci skip]
 2017-10-09 10:14:37 +09:00
Yoshiyuki Hirano
c3d1fd13da Fix the result of rails routes in Guide [ci skip] 2017-10-09 09:54:35 +09:00
yuuji.yaginuma
2ee33e6c56 Fix default of String#to_time [ci skip] 
The default of `String#to_time` is `:local` since b79adc4.
 2017-10-08 18:37:19 +09:00
Ryuta Kamizono
142831159c Merge pull request #30822 from akshay-vishnoi/fix-typo 
[ci skip] Fix typo
 2017-10-07 15:05:37 +09:00
Akshay Vishnoi
823c17e4ab [ci skip] Fix typo 2017-10-07 11:29:59 +05:30
Yoshiyuki Hirano
ce9cd1b67d Update Instrumentation guide for Active Storage [ci skip] 2017-10-07 12:20:58 +09:00
Yoshiyuki Hirano
62f6d4ed39 Add v5.1 to earlier releases list in guide [ci skip] 2017-10-07 11:20:53 +09:00
Yauheni Dakuka
de2afdc457 Cosmetic fixes [ci skip] 2017-10-06 09:02:56 +03:00
Eileen M. Uchitelle
df2814671c Merge pull request #30734 from oreoshake/patch-1 
Encourage html-safe API in layouts/rendering guide
 2017-10-04 08:43:21 -04:00
Antonio Tapiador del Dujo
e42100cf42 Add link to Rack website 
Resemble links to Bundler and Yarn,
based on feedback by @kamipo

[ci skip]
 2017-10-02 15:01:07 +02:00
Patrick Davey
88dc74b784 Fix broken link to recaptcha.net [ci skip] 
The link to recaptcha.net returns a 404. As far as I can tell, the new
link ought to be to https://developers.google.com/recaptcha/ .
 2017-10-01 08:47:24 +13:00
Conrad Beach
7c68fc98d8 [ci skip] Fix typo. 2017-09-28 16:51:09 -06:00
Kasper Timm Hansen
fbcc4bfe9a
Deprecate secret_token, long since usurped by secret_key_base. 
See the changelog entry.

Remove `secrets.secret_token` from the bug report templates,
since we don't accept bug reports for Rails versions that
don't support a `secret_key_base`.

[ claudiob & Kasper Timm Hansen ]
 2017-09-28 20:46:01 +02:00
Neil Matatall
521266f913 Encourage html-safe API in layouts/rendering guide 
While the code example was not unsafe, it
encourages the use of confusingly unsafe APIs
(specifically `html_safe`). We have a safe
alternative and we should encourage people to use
it under all circumstances.
 2017-09-27 07:14:37 -10:00
Ryuta Kamizono
a151d8ad89 Add newlines before/after the git_source in bug report templates 
[ci skip]
 2017-09-27 17:55:43 +09:00
bogdanvlviv
3e0a858aed
Change :github git source for bug report templates 
:github source uses `git://` url by default, `https://` is recommended.
See http://bundler.io/v1.15/guides/git.html#security

We do the same in our `Gemfile` and templates.
 2017-09-27 00:02:11 +03:00
Javan Makhmali
aa1cf119a6 Merge pull request #30713 from yhirano55/add_a_space_to_refinery_cms 
Add a space to RefineryCMS in Engine guide [ci skip]
 2017-09-26 16:21:14 -04:00
hupfis
8f24923d7a Fix typo in 'find_in_batches' example 2017-09-26 13:28:46 +02:00
Kasper Timm Hansen
f60bf5af9f
[ci skip] Don't mention unrotatable secret_key_base. 2017-09-25 21:46:41 +02:00
Yoshiyuki Hirano
e65f2c4f9d Add an space to RefineryCMS in Engine guide [ci skip] 
* According to the official website, it seems that "RefineryCMS" is "Refinery CMS".
* See at: http://www.refinerycms.com/
 2017-09-26 04:03:12 +09:00
Ryuta Kamizono
9befc197f9 Merge pull request #30704 from ydakuka/new-fixes 
New missing backquotes [ci skip]
 2017-09-25 23:12:35 +09:00
Yauheni Dakuka
5657280a62 new missing backquotes [ci skip] 2017-09-25 15:08:08 +03:00
Ryuta Kamizono
018b16f988 Merge pull request #30615 from yhirano55/update_form_helpers_guide 
Update Form Helpers guide [ci skip]
 2017-09-25 08:05:10 +09:00
Kasper Timm Hansen
38308e6d13
[ci skip] Attempt a new explanation for rotations. 
It's become clear to me that the use case is still a bit muddy
and the upgrade path is going to be tough for people to figure
out.

This attempts at understanding it better through documentation,
but still needs follow up work.

[ Michael Coyne & Kasper Timm Hansen ]
 2017-09-24 21:41:16 +02:00
Kasper Timm Hansen
92afe55b17
[ci skip] RotationConfiguration is an implementation detail, not public API. 2017-09-24 19:02:12 +02:00
Kasper Timm Hansen
36888b9387 Merge pull request #29716 from mikeycgto/active-support-key-rotator 
Add Key Rotation to MessageEncryptor and MessageVerifier and simplify the Cookies middleware
 2017-09-24 18:57:52 +02:00
Kasper Timm Hansen
abd4fd4369
[ci skip] Fix the with order and explain it. 2017-09-24 18:46:28 +02:00
Kasper Timm Hansen
f6b3d34a1c Merge pull request #30593 from BigChief45/guides/action-mailer-parameterized 
Update Action Mailer Basics [ci skip]
 2017-09-24 18:38:14 +02:00
Michael Coyne
8b0af54bbe Add key rotation cookies middleware 
Using the action_dispatch.cookies_rotations interface, key rotation is
now possible with cookies. Thus the secret_key_base as well as salts,
ciphers, and digests, can be rotated without expiring sessions.
 2017-09-24 12:23:38 -04:00
Ryuta Kamizono
6aa56460d5 Merge pull request #30668 from yhirano55/fix_api_guide 
Fix rails middleware list in api_app guide [ci skip]
 2017-09-24 13:47:26 +09:00
Yoshiyuki Hirano
5d8945fd49 Fix email in Active Support Instrumentation [ci skip] 
* `s/ddh/dhh/`
 2017-09-24 11:25:15 +09:00
Jaime Alvarez
50bc497a9f Update Action Mailer Basics [skip ci] 2017-09-24 00:56:44 +00:00
Yoshiyuki Hirano
6b12d02e15 Fix rails middleware list in api_app guide [ci skip] 
* `MyApi::Application::Routes` is not middleware.
 2017-09-24 05:55:50 +09:00
Yoshiyuki Hirano
9b917789fa Update link in The Asset Pipeline guide [ci skip] 2017-09-21 08:08:04 +09:00
Anton Chumakov
8c2ca4d4fc Update Rails Guides about :autosave option 2017-09-20 22:37:19 +03:00
Sean Griffin
eddb9baf39 Merge pull request #30624 from bogdanvlviv/deprecate_Module_reachable 
Deprecate `Module#reachable?` method
 2017-09-20 13:11:34 -06:00
Eileen M. Uchitelle
057de4f7c9 Merge pull request #30616 from yhirano55/update_layouts_and_rendering 
Update Layouts and Rendering in Rails [ci skip]
 2017-09-20 13:01:31 -04:00
Javan Makhmali
30767f980f Merge pull request #30623 from manojmj92/manojmj92-oo-key-patch 
make documentation consistent with  KeyError message
 2017-09-20 07:29:12 -04:00
Manoj M J
80f46653e2 Fix error message documentation 2017-09-20 13:08:00 +05:30
Claudio B
2f8ecdb21d Use credentials, not secrets, for Active Storage (#30650) 
According to #30067:

> This PR will deprecate secrets.yml* and instead adopt
> config/credentials.yml.enc to signify what these secrets are specifically
> for: Keeping API keys, database passwords, and any other integration
> credentials in one place.

[ci skip] since only comments are being edited.
 2017-09-19 17:08:32 -05:00
Yauheni Dakuka
fe15175039 Update action_controller_overview.md [ci skip] 2017-09-19 11:42:19 +03:00
Yoshiyuki Hirano
9291a81369 Use ApplicationJob instead of ActiveJob::Base in guide [ci skip] 2017-09-18 22:15:46 +09:00