TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
36,274 Commits 2 Branches 0 Tags 294 MiB
28cb11045b
Commit Graph

9049 Commits

Author SHA1 Message Date
Steve Klabnik
1a9055073d Revert "make new rails apps log to STDOUT" 
This reverts commit b7d9d6e2cd5082d269dafbc0316e2107febe1451.

Per discussion with @jeremy and @rubys on Campfire.
 2013-03-15 10:38:00 -07:00
Steve Klabnik
9caba4172e Merge pull request #9691 from hone/stdout_logging 
Rails default logging to STDOUT
 2013-03-15 10:09:09 -07:00
Terence Lee
b7d9d6e2cd make new rails apps log to STDOUT 2013-03-15 10:05:10 -07:00
Arun Agrawal
106e15927f Warning removed unused variable task_name 
warning: assigned but unused variable - task_name
 2013-03-15 13:33:07 +01:00
Sam Ruby
3008994d1e Add support for generate scaffold password:digest 
* adds password_digest attribute to the migration
* adds has_secure_password to the model
* adds password and password_confirmation password_fields to _form.html
* omits password entirely from index.html and show.html
* adds password and password_confirmation to the controller
* adds unencrypted password and password_confirmation to the controller test
* adds encrypted password_digest to the fixture
 2013-03-13 16:06:33 -04:00
Carlos Antonio da Silva
cd9f7508df Move some railties changelog entries to the top [ci skip] 2013-03-13 14:03:14 -03:00
Carlos Antonio da Silva
d25a82280f Stop calling "super" twice in Rails::Server#app 
Cache the value of "super" in a variable and use it instead.
 2013-03-12 10:10:18 -03:00
Carlos Antonio da Silva
816e7d1449 Replace assert_(no_)match args from regexps to strings to remove warnings 
Using regexps as arguments without parentheses end up raising:

    warning: ambiguous first argument; put parentheses or even spaces
 2013-03-11 15:54:43 -03:00
Rafael Mendonça França
99a8252768 Merge pull request #9666 from sikachu/master-fix-test_test_failure 
Make sure that the test case is run under test env
 2013-03-11 11:35:00 -07:00
Prem Sichanugrist
773425420f Make sure that the test case is run under test env 
* Unset $RAILS_ENV that got set by abstract_unit to trigger the default.
* split out environment setting since Ruby 1.9.3 doesn't support inline
  ENV setting.
 2013-03-11 14:31:27 -04:00
Steve Klabnik
dbd8bec525 Mention that debugging can be slow. 
https://github.com/rails/rails/pull/3180\#issuecomment-14705821 has
mention of rendering going from 1-2ms to 4 seconds with this on,
which seems reasonable: debugging is slow.
 2013-03-11 11:28:28 -07:00
Prem Sichanugrist
1f8953382f Fix test failure introduced in 3ed41e57 
I forgot to run the test suit after changing the task name. 💣
 2013-03-11 11:58:36 -04:00
Rafael Mendonça França
90a97156e4 Merge pull request #9080 from sikachu/master-rails-test 
Add `rails test` command to run the test suite
 2013-03-11 08:15:54 -07:00
Vipul A M
647a9abb02 Cleanup tests for unused variables 2013-03-11 16:03:10 +05:30
Teng Siong Ong
72cf273bfd Make sure that debugger isn't included in production environment. 2013-03-09 18:17:32 -08:00
Prem Sichanugrist
3ed41e579e Make sure that rails test load test in test env 2013-03-09 17:38:39 -05:00
Prem Sichanugrist
b51673fbd9 Update Rake tasks to call rails test instead 
Also, print out deprecation warning for other rake tasks except
`rake test` and `rake` (default)
 2013-03-09 17:38:39 -05:00
Dalibor Nasevic
df85dfa6fa Improve wording for rails test command 2013-03-09 16:03:55 -05:00
Prem Sichanugrist
1a0c58b298 Load fixtures only when running suites, or -f 
* `rails test -f` will run the test suites with all fixtures loaded
* New application will now generated without `fixtures :all` line
  enabled by default.
 2013-03-09 16:03:55 -05:00
Prem Sichanugrist
176b57c543 Add support for MiniTest flags in TestRunner 
Any flags that got set will be passed through to MiniTest::Unit.runner,
such as `-n`, `-s-, and `-v`.
 2013-03-09 16:03:55 -05:00
Prem Sichanugrist and Chris Toomey
b4df25366a Add rails test command to run the test suite 
To run the whole test suite:

    $ rails test

To run the test file(s):

    $ rails test test/unit/foo_test.rb [test/unit/bar_test.rb ...]

To run the test suite

    $ rails test [models,helpers,units,controllers,mailers,...]

For more information, see `rails test --help`.

This command will eventually replacing `rake test:*`, and `rake test`
command will actually invoking `rails test` instead.
 2013-03-09 16:03:54 -05:00
Jon Leighton
9ae81be072 Fix race condition in test 
This should fix travis. For real this time! This is the one!

The readpartial(100) meant that an earlier assert_stdout could chomp up
the output that a later assert_stdout wants, meaning that the later
assertion fails.

Reading only 1 byte at a time ensure that we don't read any more than is
necessary to verify the assertion.
 2013-03-09 20:32:01 +00:00
Yves Senn
a58e660837 Use "Fixes" in place of "Fix" in changelogs for consistency [ci skip]. 2013-03-09 20:57:17 +01:00
Jon Leighton
72be5bb557 Bump up timeouts 
This should fix travis.

Also ensuring that we don't try to kill when pid is nil.
 2013-03-09 17:52:32 +00:00
wangjohn
ff25b0e55f Renumbering the comments in the application boot process. 2013-03-09 12:42:02 -05:00
Agis Anastasopoulos
3e61a55a8b Remove extra whitespace and fix a comment 
minor comment fix for consistency
 2013-03-09 15:32:54 +02:00
Carlos Antonio da Silva
11dd15a5c2 Fix failing test regarding console change to fix sandboxing 
Introduced in be3e10cd26bc8ec29c6474d03a08a8e733108e7d.
 2013-03-08 21:48:28 -03:00
Vijay Dev
e3c56ad913 Merge pull request #8670 from sanemat/fix/rake-desc 
Add rake test description
 2013-03-08 11:21:01 -08:00
Jon Leighton
e5fc096bea The console --sandbox transaction should not be joinable 
Thanks @neerajdotname for noticing this bug.
 2013-03-08 15:10:46 +00:00
Jon Leighton
be3e10cd26 Fix rails console --sandbox 
I've also added a proper acceptance test which reproduced the issue.

Closes #9513, #9515.
 2013-03-08 13:58:56 +00:00
Nihad Abbasov
f9be80f51c add prompt to 422 page to check logs 2013-03-04 13:06:06 +04:00
José Valim
9ee6f3cc8e Bring config.allow_concurrency back 
Since the Rack::Lock still exists in development,
let's provide a way to disable it explicitly.
 2013-03-03 13:20:44 -07:00
Guillermo Iguaran
8fe904b5ca Merge pull request #9512 from Jacke/master 
New 404, 422, 500 pages, they are more stylish and bring ruby essence…
 2013-03-02 14:06:37 -08:00
José Valim
dd5a80dc3d Remove hard coded references to Active Record in railties 2013-03-02 13:52:32 -07:00
Akira Matsuda
2d4068dbef ✂️ extra blank line 2013-03-02 11:16:50 +09:00
Stanislav
40f1642b67 New beauty pages(404, 422, 500) 
moving changelog note to unreleased section

New beauty pages(404, 422, 500)
 2013-03-02 00:24:54 +06:00
Sammy Larbi
20e041579f Support creating a table migration generator 
Sometimes you want to create a table without an associated model and
test, which is also not a join table. With this commit, you can now
do that.

Example:

    rails g migration create_posts title:string
or
    rails g migration CreatePosts title:string

This commit also moves the template the model generator uses for the
migration to the migration templates folder, as it seems a more
sensible place for it now that it is shared code.
 2013-03-01 06:13:30 -06:00
José Valim
dc53fe9240 Ensure plugins generated with plugin new can boot the dummy application 2013-02-28 12:09:04 -07:00
Santiago Pastorino
45aabe6152 There's no need to access Railties through self.class 
Closes #9386
 2013-02-27 13:11:45 -02:00
Xavier Noria
62b783e531 Merge pull request #9442 from czarneckid/adjust-generator-language 
Use less hyperbole in the language re: allowed parameters
 2013-02-26 08:57:48 -08:00
Rafael Mendonça França
0f75e2c51f Update CHANGELOGS 2013-02-26 13:45:57 -03:00
David Czarnecki
3f9baeb2ec Use less hyperbole in the language re: allowed parameters 2013-02-26 10:49:47 -05:00
Guillermo Iguaran
30859a0bfd Merge pull request #9419 from banyan/change-default-root-route-helper 
Change default root route helper
 2013-02-25 20:03:08 -08:00
José Valim
670a267394 Apparently we can't get away from adding lib to the load path 2013-02-25 20:42:36 -07:00
José Valim
882f2da956 Plugins can use a similar bootscript to Rails apps 2013-02-25 19:49:13 -07:00
Guillermo Iguaran
94bebde8a7 Bump sass-rails and coffee-rails to 4.0.0.beta1 in Gemfile 2013-02-25 16:40:35 -05:00
robertomiranda
ed6d8f0ac6 Remove sprockets-rails from the Gemfile generator 2013-02-25 15:32:00 -05:00
Kohei Hasegawa
33d92bf69e Change default root route helper 2013-02-26 03:25:59 +09:00
David Heinemeier Hansson
c0bc9ce38c Preparing for 4.0.0.beta1 release 2013-02-25 08:31:50 -06:00
Guillermo Iguaran
ebe9590def Revert "Use sass compressor as the default CSS compressor" 
This reverts commit 3eef1c7c5d0c4538efb9e061b6fe68011f0352b1.
The css compressor should be set in sass-rails plugin. Check
339529f9f6
for the fix.
 2013-02-25 09:20:22 -05:00