TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
6,092 Commits 2 Branches 0 Tags 294 MiB
2f61985540
Commit Graph

715 Commits

Author SHA1 Message Date
Jeremy Kemper
2f61985540 Mark that render tests crash Ruby 1.9 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8410 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-15 02:29:45 +00:00
Jeremy Kemper
ee0ea35d91 Ruby 1.9 compat: helpers 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8409 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-15 02:29:36 +00:00
Jeremy Kemper
525cac7f82 Note that filters test crashes Ruby 1.9 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8408 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-15 02:29:24 +00:00
Jeremy Kemper
a3143eaa98 Ruby 1.9 compat: account for new, non-flattening Array#to_s 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8407 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-15 02:29:15 +00:00
Jeremy Kemper
f85089aabb Fixes for standalone tests 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8406 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-15 02:29:04 +00:00
Jeremy Kemper
11dde5ca2f Ruby 1.9 compat: cookies 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8405 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-15 02:28:53 +00:00
Jeremy Kemper
93ec552e9b Fix up template handler tests. Closes #10437. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8372 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-10 20:41:59 +00:00
Jeremy Kemper
bafd698acb render :xml and :json preserve custom content types. Closes #10388. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8342 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-09 22:11:37 +00:00
Jeremy Kemper
db885e81b9 Ignore illegal seeks on body rewind. Catches CGI errors depending on your httpd. Closes #10404 [Curtis Hawthorne] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8327 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-07 04:20:20 +00:00
David Heinemeier Hansson
8f24701ae1 Fixed send_file/binary_content for testing (closes #8044) [tolsen] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8318 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-05 23:23:04 +00:00
David Heinemeier Hansson
2af36bbbd4 Fix typos (closes #10378) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8301 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-05 18:54:41 +00:00
David Heinemeier Hansson
3a622d0045 Fix broken test (closes #10364) [chuyeow] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8271 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-05 02:34:36 +00:00
David Heinemeier Hansson
9663f9952a Make sure that setting the format with a symbol works too 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8261 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-03 19:49:22 +00:00
David Heinemeier Hansson
e03f13c553 Fixed that verification violations with no specified action didn't halt the chain (now they do with a 400 Bad Request) [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8245 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-30 21:04:57 +00:00
Rick Olson
0a9bc591e7 Raise UnknownHttpMethod exception for unknown HTTP methods. Closes #10303 [tarmo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8235 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-29 02:08:51 +00:00
Michael Koziarski
6a611e1e95 Make sure the optimisation code for routes doesn't get used if :host, :anchor or :port are provided in the hash arguments. [pager, Koz] Closes #10292 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8227 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-28 04:11:37 +00:00
David Heinemeier Hansson
45d679bcb8 Added protection from trailing slashes on page caching (closes #10229) [devrieda] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8226 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-28 00:29:43 +00:00
David Heinemeier Hansson
5e94f053cb Fixed to_s bug with namespace routes (closes #10283) [johnb] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8216 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-26 22:41:28 +00:00
Rick Olson
87e506da53 Add #prepend_view_path and #append_view_path instance methods on ActionController::Base for consistency with the class methods. [rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8214 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-26 03:59:23 +00:00
Rick Olson
1af084ecda Refactor sanitizer helpers into HTML classes and make it easy to swap them out with custom implementations. Closes #10129. [rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8213 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-26 03:45:54 +00:00
David Heinemeier Hansson
9e76b59c85 Fixed that named routes living under resources shouldn't have double slashes (closes #10198) [isaacfeliu] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8206 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-25 22:24:23 +00:00
Michael Koziarski
ec93d61fb9 Make sure that cookie sessions use a secret that is at least 30 chars in length. [Koz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8184 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-21 21:31:45 +00:00
Michael Koziarski
41fb4904e2 Refactor cookie_only option to survive multiple requests and add regression tests. References #10048. [theflow] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8176 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-21 04:28:59 +00:00
Michael Koziarski
0c12d6c6dc Ensure that the routing optimisation code isn't used when additional arguments are passed to the named route. Closes #10209 [bscofield, Koz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8169 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-20 21:25:25 +00:00
Michael Koziarski
6d0e5eaf06 memoize host with port and refactor the tests which depend on it changing 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8164 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-17 05:41:47 +00:00
Michael Koziarski
5ce6d74531 Fix Tests broken in [8134] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8135 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-14 09:36:35 +00:00
David Heinemeier Hansson
31e2a2d9bb Fixed handling of non-domain hosts (closes #9479) [purp] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8108 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-07 14:57:51 +00:00
David Heinemeier Hansson
9a8d583a91 Fixed that ActionController::CgiRequest#host_with_port() should handle standard port (closes #10082) [moro] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8088 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-06 16:36:10 +00:00
Michael Koziarski
788ece4799 Make rescue_from behave like rescue when dealing with subclasses. Closes #10079 [fxn] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8081 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-06 06:02:24 +00:00
Jeremy Kemper
82314608b5 Factor Integration::Runner behavior out of IntegrationTest. Introduce Session#request_count which counts processed requests. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8064 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-01 07:59:24 +00:00
Jeremy Kemper
d44ce1cb73 Integration tests: get_ and post_via_redirect take a headers hash. Closes #9130. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8047 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-27 20:38:08 +00:00
Rick Olson
742694e0eb Simplfy #view_paths implementation. ActionView templates get the exact object, not a dup. [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8035 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-26 05:45:41 +00:00
Michael Koziarski
2cc0cac3ef Introduce TestCase subclasses for testing rails applications allowing tests to be DRY'd up a bit and to provide a path toward tidying up our monkeypatching of test/unit. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8022 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-26 02:21:21 +00:00
Jeremy Kemper
4d2ae8a699 Partials also set 'object' to the default partial variable. Closes #8823. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8018 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-25 21:32:01 +00:00
Michael Koziarski
12d8d48b71 Refactor the default rendering out to a method called default_render to provide a hook for plugin authors. Closes #9953 [cjheath] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8011 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-25 06:38:01 +00:00
Jeremy Kemper
4c2920e89c Remove unnecessary returns from builtin filters since render/return is now sufficient. Closes #9952 [Josh Peek] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8009 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-24 04:47:40 +00:00
Jeremy Kemper
79670fb975 request.parameters doesn't overwrite request.request_parameters. Closes #9949 [nullstyle] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7992 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-22 21:10:56 +00:00
David Heinemeier Hansson
f777ff72f9 Changed before_filter halting to happen automatically on render or redirect but no longer on simply returning false [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7984 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-21 18:58:17 +00:00
Rick Olson
c9fecf20ff Ensure that cookies handle array values correctly. Closes #9937 [queso] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7978 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-20 17:30:01 +00:00
Jeremy Kemper
a2172e75f5 Dispatcher: fix that to_prepare should only run once in production. Closes #9889. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7944 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-16 16:36:52 +00:00
Jeremy Kemper
5cb6a9aabd Improve the error message for assert_redirected_to. Closes #7337 [mikong, sandofsky] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7934 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-16 05:07:23 +00:00
Jeremy Kemper
ae8179f05c Expand Routes::DynamicSegment test coverage. Closes #7122 [Kevin Clark] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7898 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-15 04:27:31 +00:00
Jeremy Kemper
86a9c212c0 Skip memcache tests unless it's installed 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7893 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-15 01:47:35 +00:00
Jeremy Kemper
6e56cc013f Wrap test with uses_mocha 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7888 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-14 22:54:28 +00:00
Jeremy Kemper
d0df7f2b12 Memcached sessions: add session data on initialization; don't silently discard exceptions; add unit tests. Closes #9823. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7885 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-14 20:46:06 +00:00
Michael Koziarski
bd03bf9f5e Make sure that custom inflections are picked up by map.resources by triggering a routing reload when new inflections are defined. Closes #9815 [mislav, kampers] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7849 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-13 03:28:35 +00:00
Jeremy Kemper
4db4661a67 rescue_from accepts :with => lambda { |exception| ... } or a normal block. Closes #9827. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7822 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-10 02:34:42 +00:00
Michael Koziarski
4aabe46341 Add :status to redirect_to allowing users to choose their own response code without manually setting headers. Closes #8297 [codahale, chasgrundy] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7820 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-09 23:07:36 +00:00
Jeremy Kemper
8a2fa23cd1 Add tests for [7727]. Closes #6090 [dkubb, mpalmer, tarmo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7793 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-08 03:33:30 +00:00
Jeremy Kemper
d9f3c435f9 Fix url_for, redirect_to, etc. with :controller => :symbol instead of 'string'. Closes #8562, #9525. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7776 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-07 19:12:02 +00:00