TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
38,683 Commits 2 Branches 0 Tags 294 MiB
33354aa23e
Commit Graph

9933 Commits

Author SHA1 Message Date
kennyj
33354aa23e Reset @column_defaults when assigning . 2013-07-14 03:02:47 +09:00
Ankit Gupta
9f85c41eec Typo fix [skip ci] 2013-07-12 21:29:31 +01:00
Akira Matsuda
956671831d Avoid creating an extra Range instance 2013-07-10 16:23:04 +09:00
Aaron Patterson
a4c0281dad fix visibility of the relation construction methods 2013-07-09 17:24:10 -07:00
Aaron Patterson
8004c91eb6 pass arel to select_all rather than depend on method_missing 2013-07-09 17:18:52 -07:00
Akira Matsuda
54eee8b5f2 Make sure that a joins Relation can be merged with has_many :through + association proxy 
Closes #11248.
 2013-07-10 00:40:11 +09:00
namusyaka
a8bd220768 Fix: attribute_for_inspect truncate upto (51 => 50) characters. 2013-07-09 20:01:48 +09:00
Rafael Mendonça França
f9fec4f46b Merge pull request #11174 from vipulnsward/remove_column_passing 
Stop sending column info to `substitute_at` as it doesn't get utilized.
 2013-07-09 02:58:15 -07:00
Vipul A M
fd2ddb3eb8 Remove redundant test about push_with_attributes removal. 2013-07-09 11:02:13 +05:30
Aaron Patterson
16e4d013d8 close our connection when we are done 2013-07-08 16:36:46 -07:00
Aaron Patterson
2e0b0c1dab remove dead code 2013-07-08 16:30:10 -07:00
Aaron Patterson
b0c0e9f38b if we remove the connection from the pool, we should close it 2013-07-08 16:21:47 -07:00
Aaron Patterson
e5f0c0c548 use latches rather than mucking with the scheduler 2013-07-08 16:10:57 -07:00
Aaron Patterson
24c4195bab refactor to_sql so it does not depend on the to_sql implementation of 
the connection
 2013-07-08 14:31:10 -07:00
Rafael Mendonça França
7d384ddb2d Merge pull request #11274 from arunagw/deprecation-removed-build-fixed 
Deprecation removed build fixed
 2013-07-07 07:52:11 -07:00
Arun Agrawal
bb9244e67f Removed unused test for DateTime.local_offset 
see discussion here #11274
 2013-07-07 12:04:54 +02:00
Rafael Mendonça França
8f25e08dda Merge pull request #11336 from ankit8898/performance-bm 
Some performance benchmarking for take vs limit
 2013-07-06 16:01:43 -07:00
Ankit Gupta
a7ff577383 Some performance benchmarking for take vs limit 
Also added a dummy progress bar during insert of records so it shows something is happening.
Performance report
          Model.take     6198.9 (±13.4%) i/s -     121743 in  20.042671s
         Model.take!     6173.6 (±13.6%) i/s -     121242 in  20.057006s
Model.all limit(100)      107.8 (±15.8%) i/s -       2106 in  20.022316s
 Model.all take(100)      105.2 (±15.2%) i/s -       2061 in  20.062509s
 2013-07-06 23:05:34 +01:00
Rafael Mendonça França
7948d78905 Merge pull request #11306 from jetthoughts/11288_remove_extra_queries_for_belongs_to_with_touch 
#11288: Removed duplicated touching

Conflicts:
	activerecord/CHANGELOG.md
 2013-07-06 17:33:26 -03:00
Vipul A M
e7e28a71be Extract common query to a constant. 
Perf ref: https://gist.github.com/vipulnsward/8209749201dfdd678c97
 2013-07-06 20:44:53 +05:30
Yves Senn
b54ef7ebde Revert "Merge pull request #11299 from arunagw/disable_implicit_join_references_removed" 
`disable_implicit_join_references=` was only deprecated on `master`,
not with rails 4.0. We can remove it after 4.1

This reverts commit 3c719ead414ffd29e71efce185698af979052abb, reversing
changes made to d5c3bf9722abd5733a769c8d789de3f74dbfb92d.
 2013-07-05 16:44:32 +02:00
Paul Nikitochkin
1ecc3e83b6 #11288: Removed duplicated touching 
if belongs to model with touch option on touch

Closes #11288
 2013-07-05 17:13:54 +03:00
Paul Nikitochkin
1894682cf7 Cleanup belongs to tests 
simplified logic to calculate number of queries by using assert_queries
 2013-07-05 02:08:55 +03:00
Carlos Antonio da Silva
3c719ead41 Merge pull request #11299 from arunagw/disable_implicit_join_references_removed 
Remove deprecated `ActiveRecord::Base.disable_implicit_join_references=`
 2013-07-04 11:42:24 -07:00
Arun Agrawal
6dd7f7c04e Remove deprecated ActiveRecord::Base.disable_implicit_join_references=. 2013-07-04 19:48:42 +02:00
Rashmi Yadav
77b587f942 Removed unsued deprecation require 2013-07-04 19:41:45 +02:00
Rafael Mendonça França
4573825061 Merge pull request #11297 from ankit8898/master 
SQL keywords in UPPERCASE
 2013-07-04 10:22:36 -07:00
ankit8898
46a0eacef8 SQL Keywords to be in UPPERCASE 2013-07-04 18:16:45 +01:00
Yves Senn
8b5439cdf9 remove leftover if after deprecation removal (68563128). 2013-07-04 15:04:31 +02:00
Yves Senn
8ee599ea86 Remove deprecated nil-passing to SchemaCache methods. 2013-07-04 10:40:52 +02:00
Yves Senn
8c7c4f77e0 replace artificial space with RDoc markup (follow up #11285). [ci skip] 2013-07-04 10:21:20 +02:00
Yves Senn
6d554b263b Remove deprecated block filter from ActiveRecord::Migrator#migrate. 2013-07-04 10:09:12 +02:00
Yves Senn
715603794c Merge pull request #11285 from ankit8898/master 
Fixing the broken wikipedia link for Optimistic Concurrency control [ci skip]
 2013-07-04 01:08:04 -07:00
ankit8898
962925bffd [ci skip] Separated full stop from the Optimistic_concurrency_control wiki link d4e3f8ba826cd42aa3c242149 2013-07-04 08:51:02 +01:00
Yves Senn
685631285f Remove deprecated String constructor from ActiveRecord::Migrator. 2013-07-04 09:49:03 +02:00
Arun Agrawal
50cbc03d18 Remove deprecated scope use without passing a callable object. 
Removed tests from deprecated code.
 2013-07-03 23:23:11 +02:00
Arun Agrawal
9105c59af0 Remove deprecated transaction_joinable= 
in favor of `begin_transaction`
with `:joinable` option.
 2013-07-03 23:23:11 +02:00
Arun Agrawal
b23501112e Remove deprecated decrement_open_transactions. 2013-07-03 23:23:11 +02:00
Arun Agrawal
51c97e7e19 removed deprecated increment_open_transactions 2013-07-03 23:23:11 +02:00
Aaron Patterson
b785e921d1 method transplanting between modules isn't supported on 1.9 2013-07-03 14:18:54 -07:00
Yves Senn
fca29750e4 remove deprecated PostgreSQLAdapter#outside_transaction? method. 2013-07-03 20:49:57 +02:00
Aaron Patterson
efb6c16b40 refactor the method cache objects to have a superclass 2013-07-03 11:37:41 -07:00
Aaron Patterson
55ac7db11b keep a cache of writer methods 2013-07-03 10:58:07 -07:00
Aaron Patterson
f208cc8108 move the reader method cache in to the read module 2013-07-03 10:58:07 -07:00
Aaron Patterson
a2b847ae49 keep a cache of the reader methods so we can reuse them 2013-07-03 10:58:07 -07:00
Vipul A M
28d1d3f0fb Remove deprecated ActiveRecord::Fixtures.find_table_name in favour of ActiveRecord::Fixtures.default_fixture_model_name. 2013-07-03 15:28:05 +05:30
Neeraj Singh
0e8027fb34 Removed deprecated method columns_for_remove 2013-07-03 08:21:10 +05:30
Carlos Antonio da Silva
9adbbe93a9 Merge pull request #10565 from prathamesh-sonpatki/rake-db 
Improved grammar and replaced 'dbs' slang with 'databases'
 2013-07-02 19:39:32 -07:00
Carlos Antonio da Silva
970c311432 Merge pull request #11258 from frodsan/remove_deprecated_distinct 
Remove deprecated SchemaStatements#distinct
 2013-07-02 19:03:32 -07:00
Aaron Patterson
127d16e0be reduce the amount of code Ruby has to parse 2013-07-02 17:47:56 -07:00