TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
1,615 Commits 2 Branches 0 Tags 294 MiB
383b6afd1c
Commit Graph

612 Commits

Author SHA1 Message Date
David Heinemeier Hansson
383b6afd1c Made JavaScriptHelper tests pass regardless of hash order #1656 [Sam Stephenson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1794 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-10 05:11:23 +00:00
David Heinemeier Hansson
2abe3d2cd9 Added that nil options are not included in tags, so tag("p", :ignore => nil) now returns <p /> not <p ignore="" /> but that tag("p", :ignore => "") still includes it #1465 [michael@schuerig.de] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1789 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-09 17:28:35 +00:00
David Heinemeier Hansson
1d7aa9fe81 Fixed that UrlHelper#link_to_unless/link_to_if used html_escape on the name if no link was to be applied. This is unnecessary and breaks its use with images #1649 [joergd@pobox.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1786 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-09 17:08:23 +00:00
David Heinemeier Hansson
165f82d180 Added even more goodies to script.aculo.us #1677 [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1783 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-09 17:01:12 +00:00
David Heinemeier Hansson
14f06c2cc1 Fixed SQL Server test #1678 [Tom Ward] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1782 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-09 16:59:35 +00:00
Jamis Buck
8266867881 Improved error message for DoubleRenderError 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1779 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-09 15:31:06 +00:00
Jeremy Kemper
37f90e0f6b r2932@asus: jeremy | 2005-07-08 14:21:36 -0700 
Silence find_by_session_id also.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1771 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-08 16:36:26 +00:00
Nicholas Seckar
c18961f185 Routes now raise an exception if a path component is misconfigured. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1769 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-08 08:56:24 +00:00
Nicholas Seckar
4a3ec21b62 Fix routes to generate proper URLs when given Fixnum defaults 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1768 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-08 08:45:51 +00:00
Nicholas Seckar
3c4295c4e0 Allow RouteSet#recognition_failed to be used to handle unknown URL forwarding 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1766 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-07 21:20:59 +00:00
Nicholas Seckar
f4bfacb24f Enable routes to recognize uppercase controller names. Closes #1635 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1765 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-07 19:51:20 +00:00
Nicholas Seckar
5727dc2f42 Properly unescape recognized path components. Fixes #1651. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1764 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-07 19:43:03 +00:00
Nicholas Seckar
e3af27c51b Improved testing of functional test setup. 
Fixed functional test setup so that :controller and :action
are stored into path_parameters using string keys.

Added with_routing test helper which can be used to dynamically
replace the current set of routes inside a unit test.



git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1763 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-07 19:23:35 +00:00
David Heinemeier Hansson
b9b6cb95d3 Fixed routing to allow for testing of *path components #1650 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1762 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-07 16:16:36 +00:00
David Heinemeier Hansson
b640a64760 Added :handle as an option to sortable_element to restrict the drag handle to a given class #1642 [thejohnny] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1760 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-07 14:34:26 +00:00
David Heinemeier Hansson
94209e2fb7 Added a bunch of script.aculo.us features: Effect.ScrollTo, to smoothly scroll the page to an element, better Firefox flickering handling on SlideUp/SlideDown, Removed a possible memory leak in IE with draggables, Added support for cancelling dragging my hitting ESC #1644 [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1759 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-07 14:18:16 +00:00
David Heinemeier Hansson
75157bbf64 Fixed that named routes didn't use the default values for action and possible other parameters #1534 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1758 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-07 14:16:05 +00:00
David Heinemeier Hansson
5a9a93d28f Fixed JavascriptHelper#visual_effect to use camelize such that :blind_up will work #1639 [pelletierm@eastmedia.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1754 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-07 08:46:31 +00:00
David Heinemeier Hansson
e5b86efea9 Fixed that a SessionRestoreError was thrown if a model object was placed in the session that wasn't available to all controllers. This means that it's no longer necessary to use the 'model :post' work-around in ApplicationController to have a Post model in your session. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1741 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-06 18:43:32 +00:00
David Heinemeier Hansson
212cc3845a Fixed routing snafu 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1736 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-06 10:45:14 +00:00
David Heinemeier Hansson
853ea55674 Made documentation ready for release (AP) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1731 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-06 09:32:00 +00:00
David Heinemeier Hansson
744058b699 Retract the session fix until 0.13.1 to preserve the truthfulness of the book 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1730 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-06 08:58:34 +00:00
David Heinemeier Hansson
2186ed83dd Make new AJAX helpers aware of more of their options #1622 [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1729 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-06 08:32:04 +00:00
David Heinemeier Hansson
93ec99c246 Partly tuned docs for release (AP) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1728 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-06 08:27:11 +00:00
David Heinemeier Hansson
8dbaae6012 Fixed that a SessionRestoreError was thrown if a model object was placed in the session that wasn't available to all controllers 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1725 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-06 07:06:02 +00:00
David Heinemeier Hansson
38e78c6260 Fixed documentation snafu with send_file -- the option is :stream, not :streaming #1621 [evl] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1723 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-06 05:23:42 +00:00
Jeremy Kemper
c9901176be benchmark helper takes an optional log level, defaults to :info. Chose symbols log levels rather than Logger::FOO constants for simplicity. Added benchmark helper test suite. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1719 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-05 19:33:25 +00:00
David Heinemeier Hansson
607ce7f0a0 Move URI to the end for greater overview 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1716 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-05 18:14:19 +00:00
David Heinemeier Hansson
84afbbbc03 Fix syntax error 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1715 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-05 18:02:02 +00:00
David Heinemeier Hansson
977b4be208 Changed logging of SQL statements to use the DEBUG level instead of INFO. Added logging of the request URI in the benchmark statement (makes it easy to grep for slow actions). Changed the default logging level in config/environment.rb to INFO for production (so SQL statements won't be logged) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1714 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-05 17:23:41 +00:00
David Heinemeier Hansson
4fe0248f57 Fixed routing regression on index exception 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1713 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-05 15:31:51 +00:00
Jamis Buck
3b1d271e02 Routing fix 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1712 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-05 15:06:09 +00:00
Jeremy Kemper
870cca6829 r2866@asus: jeremy | 2005-07-05 13:23:10 -0700 
Silence ARStore session activity in the logs.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1711 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-05 15:04:44 +00:00
Jeremy Kemper
1e6603e6e7 r2850@asus: jeremy | 2005-07-05 13:08:32 -0700 
Don't be strict about the order in which AR store methods are called.  Allow e.g. session close followed by session close.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1710 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-05 14:50:07 +00:00
David Heinemeier Hansson
56fa64e995 Fixed transparent background for Safari with auto completer 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1708 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-05 10:31:28 +00:00
David Heinemeier Hansson
5eee938643 Added javascript_include_tag :defaults shortcut that'll include all the default javascripts included with Action Pack (prototype, effects, controls, dragdrop) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1707 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-05 10:23:51 +00:00
David Heinemeier Hansson
74961dbbe9 Backed out of #1694 as it broke requests that hit the cache with wrong argument type nil (expected Module) on WEBrick 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1705 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-05 09:45:30 +00:00
David Heinemeier Hansson
26ccf4cb53 Fixed recognize bug introduced with #1694 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1704 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-05 09:38:20 +00:00
David Heinemeier Hansson
25c33a99f9 Fixed Prototype bug #1602 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1700 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-05 07:55:37 +00:00
Jeremy Kemper
9933ec82b2 r2840@asus: jeremy | 2005-07-05 00:42:27 -0700 
Ticket 1233 - Cache recognized routes
 r2842@asus:  jeremy | 2005-07-05 00:53:16 -0700
 update changelog
 r2843@asus:  jeremy | 2005-07-05 00:54:11 -0700
 cache recognized routes.  clear cache with clear_recognized_routes_cache\!


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1694 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-05 02:46:49 +00:00
Jeremy Kemper
d80d9a52bd r2837@asus: jeremy | 2005-07-05 00:34:31 -0700 
Don't restrict sessid compat. check to a single run.  Reset cached column info before checking in case it's stale (may happen if you change table_name).  Make the test a private class method.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1693 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-05 02:29:42 +00:00
Jeremy Kemper
fa158ff07a r2829@asus: jeremy | 2005-07-04 23:31:55 -0700 
cache protected_instance_variables


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1690 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-05 01:31:03 +00:00
Jeremy Kemper
d2b9e39c85 r2828@asus: jeremy | 2005-07-04 22:02:44 -0700 
cache controller_name and controller_path


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1689 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-05 01:30:49 +00:00
Jeremy Kemper
c6f819edb7 r2827@asus: jeremy | 2005-07-04 21:30:06 -0700 
precompute action_name


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1688 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-05 01:30:44 +00:00
Jeremy Kemper
9ad1f49985 r2810@asus: jeremy | 2005-07-04 19:29:54 -0700 
correct marshaling and fingerprinting logic


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1682 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-04 21:26:54 +00:00
Jeremy Kemper
fd901df35d r2807@asus: jeremy | 2005-07-04 18:15:18 -0700 
Fingerprint the marshaled data.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1679 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-04 21:26:41 +00:00
David Heinemeier Hansson
128e352614 Fixed that hashes was not working properly when passed by GET to lighttpd #849 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1677 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-04 19:21:48 +00:00
Jeremy Kemper
452442dde8 r2790@asus: jeremy | 2005-07-04 16:30:58 -0700 
smart active record session class.  session class is pluggable; a basic SqlBypass class is provided.  set CGI::Session::ActiveRecordStore.session_class = SqlBypass and set SqlBypass.connection = SomeARConnection.  Further tests pending.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1671 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-04 18:30:27 +00:00
Jeremy Kemper
e7b142aef7 r2789@asus: jeremy | 2005-07-04 16:17:35 -0700 
require active_record_store only if ActiveRecord is already defined. define DEFAULT_SESSION_OPTIONS only if it is undefined.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1670 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-04 18:30:22 +00:00
Jamis Buck
fcdcd9b9fa Hashes sent via multipart post should be converted to strings #1032 [me@julik.nl] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1664 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-04 15:31:37 +00:00