TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
5,796 Commits 2 Branches 0 Tags 294 MiB
3ba23348de
Commit Graph

5796 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jeremy Kemper
2559feb539 Refactor and test boot.rb. Include tests from and closes #9834. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7998 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-23 05:36:52 +00:00
Jeremy Kemper
24077a1ffc Hash#to_xml handles symbol values. Closes #9954. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7997 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-23 00:42:16 +00:00
Jeremy Kemper
902533e6f0 Reinstate test_change_column_nullability for all adapters. Closes #9945 [lawrence] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7996 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-22 23:52:04 +00:00
Jeremy Kemper
e829e12e16 test_select_rows shouldn't depend on implicit result ordering. Closes #9898 [lawrence] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7995 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-22 23:50:12 +00:00
Jeremy Kemper
3334609ecb Expand form helper test coverage. Closes #9950 [robinjfisher] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7993 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-22 21:17:20 +00:00
Jeremy Kemper
79670fb975 request.parameters doesn't overwrite request.request_parameters. Closes #9949 [nullstyle] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7992 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-22 21:10:56 +00:00
David Heinemeier Hansson
f777ff72f9 Changed before_filter halting to happen automatically on render or redirect but no longer on simply returning false [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7984 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-21 18:58:17 +00:00
Rick Olson
7042163d76 Ensure that mysql quotes table names with database names correctly. Closes #9911 [crayz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7980 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-20 21:17:31 +00:00
Rick Olson
c9fecf20ff Ensure that cookies handle array values correctly. Closes #9937 [queso] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7978 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-20 17:30:01 +00:00
Michael Koziarski
17ac677a2d typo in test name 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7977 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-19 02:51:44 +00:00
Michael Koziarski
62fd6532e5 Remove more potential clashes with asset methods and resource routes. Closes #9928 [gbuesing] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7976 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-19 02:46:41 +00:00
Michael Koziarski
3facc8578b Few more tests for Sexy Migrations 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7975 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-19 02:25:23 +00:00
Michael Koziarski
637c685a42 Forgotten changelog entry 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7974 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-19 02:25:09 +00:00
Michael Koziarski
6ddde027c4 Add t.belongs_to and t.references to sexy migrations [arthurgeek] 
Test harness for Sexy Migrations. [Koz]
Closes #9775


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7973 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-19 02:09:06 +00:00
Michael Koziarski
210f7e29e2 Move all Schema creation into schema.rb for Mysql. Closes #9899 [mikong, lawrence] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7972 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-19 01:52:50 +00:00
Michael Koziarski
b1c3fc22c9 Rename image_path path_to_image to avoid conflicting with named routes. Closes #9924 [gbuesing] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7970 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-19 00:52:55 +00:00
Jeremy Kemper
2fac5d1a8b SQL Server: test for affected row count. References #9558 [lawrence, ryepup] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7968 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-18 23:47:59 +00:00
Jeremy Kemper
a9f790a748 Use SecureRandom to generate unique ids, if available. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7966 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-18 18:25:31 +00:00
Jeremy Kemper
b98dcdec07 Merge [7832] from 1-2-stable: Correct RAILS_GEM_VERSION regexp. Use =version gem requirement instead of ~>version so you don't get surprised by a beta gem in production. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7964 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-18 17:28:55 +00:00
David Heinemeier Hansson
d6f49e4af1 Fixed incorrect migration number if script/generate executed outside of Rails root (closes #7080) [jeremymcanally] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7963 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-18 15:54:01 +00:00
David Heinemeier Hansson
34df379467 Docfix (cloases #9832) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7961 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-18 15:49:11 +00:00
Michael Koziarski
2833706699 Read in binary mode to make sure windows support keeps working. [lawrence] Closes #9912 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7959 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-17 22:50:34 +00:00
Michael Koziarski
8ed1e885b7 Use a smaller binary fixture so we don't overflow column size limitations in some commercial / legacy databases. Closes #7987 [roderickvd, lawrence] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7958 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-17 21:35:46 +00:00
Michael Koziarski
ac3cf43182 Raise an intelligible error message when migration aren't named correctly [bronson] Closes #9909 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7957 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-17 21:35:19 +00:00
Jeremy Kemper
011a209174 caches_page uses a single after_filter instead of one per action. Closes #9891. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7949 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-16 22:24:55 +00:00
Sam Stephenson
45107ecaf8 Update Prototype to 1.6.0_rc1 and script.aculo.us to 1.8.0 preview 0. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7947 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-16 21:08:29 +00:00
Michael Koziarski
534600eb7c More Performant Cookie Regexp for Integration tests. [Ola Bini] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7946 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-16 20:19:27 +00:00
Jeremy Kemper
cfffedb4d8 Hash#symbolize_keys behaves well with integer keys. Closes #9890. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7945 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-16 18:56:13 +00:00
Jeremy Kemper
a2172e75f5 Dispatcher: fix that to_prepare should only run once in production. Closes #9889. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7944 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-16 16:36:52 +00:00
Jeremy Kemper
f575757ca4 Qualified column names work in hash conditions, like :conditions => { 'comments.created_at' => ... }. Closes #9733. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7943 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-16 08:08:08 +00:00
Jeremy Kemper
cfbd790ad3 Fix regression where the association would not construct new finder SQL on save causing bogus queries for "WHERE owner_id = NULL" even after owner was saved. Closes #8713. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7942 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-16 07:24:23 +00:00
Jeremy Kemper
889352835a remove empty dirs missed by git-svn 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7941 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-16 07:04:03 +00:00
Jeremy Kemper
a72c1ec43e Refactor association create and build so before & after callbacks behave consistently. Closes #8854. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7935 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-16 05:07:58 +00:00
Jeremy Kemper
5cb6a9aabd Improve the error message for assert_redirected_to. Closes #7337 [mikong, sandofsky] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7934 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-16 05:07:23 +00:00
Jeremy Kemper
cfe36d1609 Test link_to 'back', :back 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7933 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-16 05:06:55 +00:00
Jeremy Kemper
9b6207c3d0 Quote table names. Defaults to column quoting. Closes #4593. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7932 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-16 05:06:33 +00:00
Jeremy Kemper
e7ed4c9354 Fix join table docs error in schema_statements. Closes #9880 [lawrence] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7931 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-16 05:05:47 +00:00
Jeremy Kemper
197c888576 Moving SQL Server tests to the extracted adapter. References #9884. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7930 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-16 05:05:22 +00:00
Jeremy Kemper
faa455a435 Missed mailer adds. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7929 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-16 05:05:03 +00:00
Jeremy Kemper
cf2ee1451b Fix silent failure of rxml templates. Closes #9879. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7921 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-15 20:30:48 +00:00
Jeremy Kemper
ea1eafb6b1 Don't assume ActiveSupport module is already defined 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7917 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-15 10:12:47 +00:00
Michael Koziarski
ff4f90c81a Simple changes to bring AWS up to date with view_paths and render :text. Tests still fail though. [Koz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7916 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-15 08:59:48 +00:00
Jeremy Kemper
3397d971ff Complete AWS -> ARes changeover. Closes #8717 [kampers] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7914 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-15 08:45:23 +00:00
Jeremy Kemper
671228942d Alias association #build to #new so it behaves predictably. Closes #8787. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7913 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-15 08:09:04 +00:00
Jeremy Kemper
333463679a Revert [7894] and apply to adapter instead. References #9588. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7912 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-15 07:57:06 +00:00
Jeremy Kemper
656a20a4d3 Multibyte: String#slice supports regexp argument. Closes #9646. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7910 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-15 07:38:52 +00:00
Jeremy Kemper
660a696a3f Test that change_column quotes column names. Closes #9537 [lawrence] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7909 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-15 07:33:53 +00:00
Jeremy Kemper
9f5a9aa35f Factor out checks for duplicable objects. Closes #9333. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7908 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-15 07:13:40 +00:00
Jeremy Kemper
fb0673f5ad Add a time to duplicable tests 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7907 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-15 07:12:40 +00:00
Jeremy Kemper
bb4ebaa858 object.duplicable? returns true if object.dup is safe. False for nil, true, false, symbols, and numbers; true otherwise. References #9333. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7906 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-15 07:11:25 +00:00