TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
20,757 Commits 2 Branches 0 Tags 294 MiB
4083e0ea2a
Commit Graph

470 Commits

Author SHA1 Message Date
Aaron Patterson
4083e0ea2a removing text-format in favor of a more simple solution 2011-02-09 10:11:29 -08:00
Mikel Lindsaar
6854358964 Removing unused method argument 2011-01-18 12:06:21 +11:00
Mikel Lindsaar
b141fa6280 Cleaning up style, concat inside method calls is ugly 2011-01-18 12:06:21 +11:00
Mikel Lindsaar
3b584aee95 Fixing redundant escape in regex 2011-01-18 12:06:21 +11:00
Mikel Lindsaar
ad8dc5ab89 Should use standard ruby signature for respond_to 2011-01-18 12:06:20 +11:00
Mikel Lindsaar
b72cd29e53 Fixing spelling 2011-01-18 12:06:20 +11:00
wycats
7c568fda6b A bunch of cleanup on the inherited template patch 2010-12-26 23:44:51 -08:00
José Valim
8e6d27641c Clean up asset_host and asset_path. 2010-12-09 13:40:45 +01:00
Aditya Sanghi
f07ff29ea9 Merge branch 'master' of https://github.com/peterb/docrails into peterb-master 2010-11-29 21:41:48 +05:30
Ryan Bigg
8d1c56148f Merge branch 'master' of github.com:lifo/docrails 
* 'master' of github.com:lifo/docrails:
  Fix missing word in ActionMailer::Base documentation.
 2010-11-26 14:26:29 +11:00
Ryan Bigg
e968acc21c Update ActionMailer documentation to not use deprecated template_root method as documentation, but rather raise_delivery_errors method 2010-11-26 14:25:46 +11:00
Cheah Chu Yeow
ad8e1ba452 Fix missing word in ActionMailer::Base documentation. 2010-11-25 16:11:26 +08:00
Josh Kalderimis
d7db6a8873 class inheritable attributes is used no more! all internal use of class inheritable has been changed to class_attribute. class inheritable attributes has been deprecated. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-11-20 19:40:29 +01:00
Carl Lerche
ccd2f3ede5 Update the version.rb files to include a PRE part 2010-11-16 17:19:46 -08:00
Neeraj Singh
ea14396c45 replace if ! with unless 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-10-17 12:26:32 -02:00
Peter Baker
5a898e106a Explain actionamailer authentication types 2010-10-14 11:24:25 -05:00
José Valim
d649bf158b Provide a cleaner syntax for paths configuration that does not rely on method_missing. 2010-10-06 17:20:15 +02:00
Santiago Pastorino
4920312643 PERF: Don't create unnecessary objects 2010-10-03 14:58:23 -02:00
Santiago Pastorino
10249d7b77 PERF: change inject({}) with Hash + map 2010-10-03 14:52:46 -02:00
Aaron Patterson
e8c9cac1c3 self is implied, so remove self 2010-09-29 15:16:44 -07:00
Aaron Patterson
4d7b2ee524 dry up method missing 2010-09-29 15:07:33 -07:00
José Valim
6067d16200 Call it compile_methods! and do the same on AM. 2010-09-27 20:43:56 +02:00
Piotr Sarnacki
18aee33335 Do not require passing :app to mounted helpers, it's actually useless and not DRY 2010-09-08 19:27:59 +02:00
Piotr Sarnacki
98ab4ded37 Set only helpers_path on inherited hook in action_controller/railtie.rb and use helper(:all) just after that 2010-09-03 22:59:13 +02:00
Piotr Sarnacki
e5af8b7d85 Moved ActionMailer and ActionController railties options to inherited hook 
This change is needed, because we must take namespace into account and if
controller's/mailer's class is namespaced, engine's paths should be set
instead of application's ones.

The nice side effect of this is removing unneeded logic in
ActionController::Base.inherited - now the helpers_path should be set
correctly even for engine's controllers, so helper(:all) will always
include correct helpers.
 2010-09-03 22:59:12 +02:00
Piotr Sarnacki
d812677277 We don't need to clear action_methods on inherited hook as they are cleaned on method_added hook 2010-09-03 22:59:12 +02:00
Piotr Sarnacki
56ef192374 ActionMailer should not depend on ActionDispatch 2010-09-03 22:59:12 +02:00
Piotr Sarnacki
79bd92b783 Refactor ActionMailer to not use hide_actions 2010-09-03 22:59:11 +02:00
Piotr Sarnacki
4131a2d804 Move ActionController::Railties::RoutesHelpers and ActionMailer::Railties::RoutesHelper to AbstractController::Railties::RoutesHelpers 2010-09-03 22:59:11 +02:00
Piotr Sarnacki
32baa27892 Include routes helpers only for inherited classes in ActionMailer 2010-09-03 22:59:10 +02:00
Piotr Sarnacki
c7664d112f Include application's helpers and router helpers by default, but include engine's ones for controllers inside isolated namespace 2010-09-03 22:59:10 +02:00
Piotr Sarnacki
8fdeff0fa5 mounted helpers should be included in ActionMailer 2010-09-03 22:59:10 +02:00
José Valim
972efa11fd Deprecate the old mailer API that was not deprecated yet. 2010-08-29 20:42:13 -03:00
José Valim
f5a43138d4 Remove the deprecated API from ActionMailer. 2010-08-29 19:57:51 -03:00
David Heinemeier Hansson
21b1f29720 Master is now targeting 3.1.0.beta 2010-08-23 21:44:57 -05:00
Santiago Pastorino
b451de0d6d Deletes trailing whitespaces (over text files only find * -type f -exec sed 's/[ \t]*$//' -i {} \;) 2010-08-14 04:12:33 -03:00
Xavier Noria
4f7565c4de adds missing requires for Object#try 2010-08-09 15:25:21 +02:00
Xavier Noria
ccd45618ed Merge remote branch 'rails/master' 2010-07-30 02:35:24 +02:00
Xavier Noria
755af49755 edit pass to apply API guideline wrt the use of "# =>" in example code 2010-07-30 02:30:04 +02:00
Neeraj Singh
daad4454eb itsy bitsy changes to ActionMailer documentation 2010-07-28 22:22:50 -04:00
David Heinemeier Hansson
856fc4bbc3 Prep for RC 2010-07-26 12:53:25 -05:00
Santiago Pastorino
e1d4e78b15 Removes unused vars 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-24 01:19:44 +02:00
José Valim
76b6136b00 Clean up AM and AC railties. 2010-07-24 00:48:12 +02:00
Jeroen van Dijk
ab62aa1c43 Mention that ActionMailer::Base.default_url_options is now deprecated 2010-07-22 01:28:31 +02:00
Benjamin Quorning
7e075e6247 Fixed many references to the old config/environment.rb and Rails::Initializer 2010-07-13 13:00:21 +02:00
Wincent Colaiuta
75b32a69a1 Fixes for "router" and "routes" terminology 
Commit f7ba614c2db improved the internal consistency of the different
means of accessing routes, but it introduced some problems at the level
of code comments and user-visible strings.

This commit applies fixes on three levels:

Firstly, we remove or replace grammatically invalid constructs such as
"a routes" or "a particular routes".

Secondly, we make sure that we always use "the router DSL" or "the
router syntax", because this has always been the official terminology.

Finally, we make sure that we only use "routes" when referring to the
application-specific set of routes that are defined in the
"config/routes.rb" file, we use "router" when referring on a more
abstract level to "the code in Rails used to handle routing", and we use
"routing" when we need an adjective to apply to nouns such as
"url_helpers. Again this is consistent with historical practice and
other places in the documentation.

Note that this is not a sweep over the entire codebase to ensure
consistent usage of language; it is just a revision of the changes
introduced in commit f7ba614c2db.

Signed-off-by: Wincent Colaiuta <win@wincent.com>
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-03 22:42:31 +02:00
Piotr Sarnacki
f7ba614c2d Unify routes naming by renaming router to routes 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-02 01:51:03 +02:00
Wincent Colaiuta
52c56f9f7e docs: note that mail() accepts arbitrary headers 
The documentation makes it sound like mail() only accepts a limited
set of headers in the headers hash, but it in fact accepts any
arbitrary headers, and there is a test ("can pass random headers in
as a hash to mail") for it in the test suite.

Signed-off-by: Wincent Colaiuta <win@wincent.com>
 2010-06-30 17:07:19 +02:00
José Valim
6788db824a Move Rails::LogSubscriber to ActiveSupport::LogSubscriber, allowing frameworks like ActiveRecord and ActiveResource to log outsude Rails::Application [#4816 state:resolved] 2010-06-24 13:23:43 +02:00
Rizwan Reza
de65c82bfa Changes call backs to callbacks. 2010-06-15 22:48:10 +04:30