TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
4,316 Commits 2 Branches 0 Tags 294 MiB
45fd631e5e
Commit Graph

4316 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Rick Olson
c98b471ca4 Reverted old select_limited_ids_list postgresql fix that caused issues in mysql. Closes #5851 [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5265 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 03:12:32 +00:00
Rick Olson
8e3bf70bcd Removes the ability for eager loaded conditions to be interpolated, since there is no model instance to use as a context for interpolation. #5553 [turnip@turnipspatch.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5264 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 02:46:57 +00:00
David Heinemeier Hansson
ccd32adeca Fixed test:uncommitted on Windows (backslash issue) (closes #4999) [paul@paulbutcher.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5263 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 02:23:03 +00:00
David Heinemeier Hansson
0d8b8056be Docfix (closes #6234) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5262 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 02:20:43 +00:00
David Heinemeier Hansson
a21e86f023 Fixed migration creation to work with namespaced models, so script/generate model Gallery::Image will use create_table :gallery_images #6327 [BobSilva] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5261 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 02:19:58 +00:00
David Heinemeier Hansson
fe4d5ea786 Fixed rename_table on SQLite tables with indexes defined (closes #5942) [brandon@opensoul.org] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5260 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 02:14:36 +00:00
David Heinemeier Hansson
fc7fd4c5ce Docfix (closes #6040) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5259 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 02:05:50 +00:00
David Heinemeier Hansson
943be923f0 Added timeout option to SQLite3 configurations to deal more gracefully with SQLite3::BusyException, now the connection can instead retry for x seconds to see if the db clears up before throwing that exception (closes #6126) [wreese@gmail.com] Added default timeout setting of 5 seconds to SQLite3 database.yml configurations [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5258 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 02:02:27 +00:00
David Heinemeier Hansson
8f93516168 Docfix (closes #5143) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5257 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 01:53:51 +00:00
David Heinemeier Hansson
55aab5b8ac Added update_attributes! which uses save! to raise an exception if a validation error prevents saving (closes #6192) [jonathan] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5256 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 01:52:24 +00:00
David Heinemeier Hansson
9fd88d7939 Deprecated add_on_boundary_breaking (use validates_length_of instead) (closes #6292) [BobSilva] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5255 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 01:42:09 +00:00
David Heinemeier Hansson
cb0837a2b7 Doc fixes (closes #6325) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5254 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 01:32:11 +00:00
Jeremy Kemper
a307b8c7dc render_text may optionally append to the response body. render_javascript appends by default. This allows you to chain multiple render :update calls by setting @performed_render = false between them (awaiting a better public API). 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5253 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 01:26:35 +00:00
Nicholas Seckar
bc85e6ac4c Rename test assertion to prevent shadowing. Closes #6306. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5252 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 01:20:36 +00:00
Jeremy Kemper
5d1edc55a8 one render per test 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5251 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 01:14:38 +00:00
David Heinemeier Hansson
a49e7d5c0c Fixed that NumberHelper#number_to_delimiter should respect precision of higher than two digits (closes #6231) [phallstrom] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5249 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:59:19 +00:00
David Heinemeier Hansson
f9650a23f0 Fixed that caches_action breaks with file extensions (closes #6257) [Catfish] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5248 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:56:13 +00:00
David Heinemeier Hansson
211ffd3f79 Fixed that FormHelper#radio_button didn't respect an :id being passed in (closes #6266) [evansj] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5247 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:53:59 +00:00
David Heinemeier Hansson
8ff92e2435 Added an html_options hash parameter to javascript_tag() and update_page_tag() helpers #6311 [tzaharia] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5245 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:50:11 +00:00
David Heinemeier Hansson
ca35e264a4 Also update escaping for prototype rescues [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5244 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:45:41 +00:00
David Heinemeier Hansson
31d3048706 Fixed that rescue template path shouldn't be hardcoded, then it's easier to hook in your own (closes #6295) [mnaberez] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5243 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:40:05 +00:00
David Heinemeier Hansson
4b3e964a1a Fixed escaping of backslashes in JavaScriptHelper#escape_javascript (closes #6302) [sven@c3d2.de] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5242 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:34:43 +00:00
David Heinemeier Hansson
2e766b159f Fixed that some 500 rescues would cause 500's themselves because the response had not yet been generated #6329 [cmselmer] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5241 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:21:47 +00:00
David Heinemeier Hansson
3c6b7a2191 Fixed that assert_select selects the wrong tag by its contents (closes #6332) [jgarber] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5240 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:20:31 +00:00
David Heinemeier Hansson
717e26dd0e Deprecation cleanup for rescues (closes #6339) [adam] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5239 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:17:11 +00:00
David Heinemeier Hansson
3ba5e39b54 Docfix (closes #6356) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5238 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:15:28 +00:00
David Heinemeier Hansson
f1a2dee976 Include field:type option for models 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5237 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:11:46 +00:00
David Heinemeier Hansson
c16a4379ca Added script/generate resource which works just like scaffold_resource, but creates empty placeholders instead of predefined [DHH] Added generated attribute options to script/generate model, like the one found in scaffold_resource and resource [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5236 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:08:13 +00:00
David Heinemeier Hansson
5728b82c01 Added proper USAGE to the scaffold_resource generator [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5235 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-08 23:35:00 +00:00
David Heinemeier Hansson
c447d443dd Added proper USAGE to the scaffold_resource generator [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5234 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-08 23:32:07 +00:00
Jeremy Kemper
7ea86773a9 r5515@ks: jeremy | 2006-10-08 13:24:42 -0700 
#6281
 r5516@ks:  jeremy | 2006-10-08 13:29:49 -0700
 respond_to :html doesn't assume .rhtml. Closes #6281.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5232 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-08 20:30:24 +00:00
David Heinemeier Hansson
8ba8c7c560 cleanup of local_assigns handling and documentation update (closes #6358) [skaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5231 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-08 07:46:23 +00:00
Jeremy Kemper
0c3c131f3b The has_many create method works with polymorphic associations. Closes #6361. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5230 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-08 06:45:32 +00:00
Jamis Buck
6c0609fafb Add Base.delete for deleting resources without having to instantiate them first 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5229 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-06 17:25:10 +00:00
Jeremy Kemper
54e86cccd5 Update RUNNING_UNIT_TESTS for current Rake tasks. Closes #6349. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5228 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-05 18:19:24 +00:00
Jamis Buck
b8ff69fcdd callbacks that return false should cause save to return false 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5226 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-04 15:43:31 +00:00
Jamis Buck
53737eadd6 add a failing test so we can make it happy again 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5225 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-04 15:38:59 +00:00
Michael Koziarski
e899190826 Pull in latest multibyte patch. Closes #6346 [Manfred Stienstra] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5224 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-04 09:03:57 +00:00
Michael Koziarski
f238d495b7 Add ActiveSupport::Multibyte. Provides String#chars which lets you deal with strings as a sequence of chars, not of bytes. Closes #6242 [Julian Tarkhanov, Manfred Stienstra & Jan Behrens] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5223 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-03 23:45:32 +00:00
Jeremy Kemper
8cb0079fea add response to list of deprecated instance variables 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5221 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-02 22:36:02 +00:00
Jamis Buck
628838ed93 Make #save behavior mimic AR::Base#save (true on success, false on failure) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5220 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-02 22:14:15 +00:00
Jeremy Kemper
48d4d43f92 MySQL: introduce Mysql::Result#all_hashes to support further optimization. Closes #5581. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5219 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-02 20:43:13 +00:00
Rick Olson
928c84b65b Fix issue with #class_inheritable_accessor saving updates to the parent class when initialized with an Array or Hash [mojombo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5218 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-02 19:12:57 +00:00
Jeremy Kemper
297ac55b29 use instance vars in rescue templates since controller may not be instantiated yet 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5217 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-02 16:32:51 +00:00
Rick Olson
163a7123e5 assume the passed headers to the ActiveResource HttpMock Request/Response are hashes [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5216 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-02 14:20:18 +00:00
Jeremy Kemper
ef4fb3dee2 save! shouldn't validate twice. Closes #6324. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5215 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-02 03:21:32 +00:00
Jeremy Kemper
0092d0ac6d Association collections have an _ids reader method to match the existing writer for collection_select convenience (e.g. employee.task_ids). The writer method skips blank ids so you can safely do @employee.task_ids = params[:tasks] without checking every time for an empty list or blank values. References #1887, Closes #5780. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5214 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-01 19:15:51 +00:00
Kent Sibilev
f1d1f01b6d Removed deprecated @request and @response usages. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5213 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-01 15:46:00 +00:00
Rick Olson
3010e30f0e Fixed some deprecation warnings in ActionPack [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5212 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-30 01:38:22 +00:00
Rick Olson
52547f5331 Add an attribute reader method for ActiveRecord::Base.observers [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5211 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-30 01:37:07 +00:00