TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
1,845 Commits 2 Branches 0 Tags 294 MiB
46110aa689
Commit Graph

714 Commits

Author SHA1 Message Date
Jeremy Kemper
e7b142aef7 r2789@asus: jeremy | 2005-07-04 16:17:35 -0700 
require active_record_store only if ActiveRecord is already defined. define DEFAULT_SESSION_OPTIONS only if it is undefined.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1670 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-04 18:30:22 +00:00
Jamis Buck
fcdcd9b9fa Hashes sent via multipart post should be converted to strings #1032 [me@julik.nl] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1664 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-04 15:31:37 +00:00
Jamis Buck
930f33657c Updated html-scanner so that assert_tag(:tag => "p", :content => "foo") behaves as expected 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1661 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-04 15:05:40 +00:00
David Heinemeier Hansson
a62485a089 Added documentation about Manipulating the request collections 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1659 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-04 09:47:52 +00:00
Sam Stephenson
555072e8e9 Fix failure container logic in Ajax.Updater 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1652 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-04 05:36:12 +00:00
Sam Stephenson
5bbc24a508 Update Prototype; hopefully the last change before 0.13 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1651 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-04 05:23:28 +00:00
David Heinemeier Hansson
bf3a0c5391 Improved update_element_function #1597 [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1650 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-04 04:57:15 +00:00
David Heinemeier Hansson
cb4bd89741 Fixed assert_template nil will be true when no template was rendered #1565 [maceywj@telus.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1648 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 12:48:24 +00:00
David Heinemeier Hansson
c52edf2319 Added :prompt option to FormOptions#select (and the users of it, like FormOptions#select_country etc) to create "Please select" style descriptors #1181 [Michael Schuerig] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1646 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 12:23:16 +00:00
David Heinemeier Hansson
5524dedc06 Fixed routing bug #1592 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1645 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 12:01:06 +00:00
David Heinemeier Hansson
208291391c Added JavascriptHelper#update_element_function, which returns a Javascript function (or expression) that'll update a DOM element according to the options passed #933 [mortonda@dgrmm.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1644 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 11:01:43 +00:00
David Heinemeier Hansson
703d18ea52 Added note about render_partial_collection #1557 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1618 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:05:05 +00:00
David Heinemeier Hansson
481cac9658 AJAX error handling fix, Prototype event handling #1589 [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1617 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:00:38 +00:00
David Heinemeier Hansson
b7f37d3ef9 Fixed a bug with alternate layout #1468 [sam] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1614 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-02 18:49:17 +00:00
David Heinemeier Hansson
c6ab8f5706 Added :field_name option to DateHelper#select_(year|month|day) to deviate from the year/month/day defaults #1266 [Marcel Molina] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1613 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-02 18:38:22 +00:00
David Heinemeier Hansson
668a0817f7 Auto completer should hide update element by when initializing #1579 [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1610 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-02 18:18:55 +00:00
David Heinemeier Hansson
177ed3e681 Added more tests on assert_redirected_to #1581 [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1609 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-02 18:16:38 +00:00
David Heinemeier Hansson
eb2b86d795 Added ActionController::Base.enable_upload_progress for people who want to play with the experimental upload progress 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1607 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-02 11:29:41 +00:00
David Heinemeier Hansson
50f0a73624 Added JavascriptHelper#draggable_element and JavascriptHelper#drop_receiving_element to facilitate easy dragging and dropping through the script.aculo.us libraries #1578 [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1606 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-02 11:25:21 +00:00
David Heinemeier Hansson
c2060719d3 Added a DOCTYPE of HTML transitional to the HTML files generated by Rails #1124 [Michael Koziarski] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1605 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-02 11:21:25 +00:00
David Heinemeier Hansson
a53372c273 Added that UrlHelper#mail_to will now also encode the default link title #749 [f.svehla@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1601 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-02 06:46:41 +00:00
David Heinemeier Hansson
3553b59d3c Removed the default option of wrap=virtual on FormHelper#text_area to ensure XHTML compatibility #1300 [thomas@columbus.rr.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1600 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-02 06:39:43 +00:00
David Heinemeier Hansson
bf9b90a908 Adds the ability to include XML CDATA tags using Builder #1563 [Josh Knowles] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1598 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-02 06:21:13 +00:00
David Heinemeier Hansson
2f61c431fa Added evaluation of <SCRIPT> blocks in content returned to Ajax calls #1577 [Thomas Fuchs/court3nay] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1597 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-02 06:20:05 +00:00
David Heinemeier Hansson
f0e9fd74ae Make render(:inline) use locals #1556 [Michael Shuerig] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1584 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-01 18:21:29 +00:00
David Heinemeier Hansson
5651a69130 Load models and frequency typo on upoad progress #1555 [Sean Treadway] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1580 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-01 08:31:30 +00:00
David Heinemeier Hansson
cadcd9e714 Fix IE 30-sec timeout bug, make auto_complete_for even more delicious #1572 [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1579 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-01 07:25:44 +00:00
David Heinemeier Hansson
2455f96a6e Fixed mr recycle! 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1574 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-30 16:16:12 +00:00
David Heinemeier Hansson
524d1b5e04 Uncommented request.recycle! as it breaks more than it fixes, left test case in, xal? 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1572 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-30 14:49:36 +00:00
David Heinemeier Hansson
4cd5b05377 Dont include the upload progress automatically before it works better 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1571 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-30 08:29:14 +00:00
David Heinemeier Hansson
bab674c681 File upload progress seems to have problems on a variety of servers, marking as experimental for now and not including it in the docs 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1570 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-30 08:16:57 +00:00
David Heinemeier Hansson
a90598b458 Wrong variable name used in observe_field #1551 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1568 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-30 05:58:40 +00:00
David Heinemeier Hansson
8a145b251a Give auto_complete_for parameters, fix browser-autocompletion #1550 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1566 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-29 17:08:14 +00:00
David Heinemeier Hansson
8335fc610c A bit more routes refactoring and test 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1564 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-29 10:40:26 +00:00
David Heinemeier Hansson
94cae0d0a2 Got back to functional testing harmony 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1563 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-29 09:44:55 +00:00
David Heinemeier Hansson
571abe8d5e Rolled back changed to test_process as it broke havok this morning 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1562 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-29 09:05:46 +00:00
David Heinemeier Hansson
2d8679993c Fix JavaScriptHelper capitalization and make it compatible with Prototype #1545 [Sam Stephenson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1561 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-29 08:09:00 +00:00
David Heinemeier Hansson
0ffcceffac Script.aculo.us: autocompletion focus fix, setContentZoom fix #1546 [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1560 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-29 08:07:55 +00:00
Sam Stephenson
a551ba2c01 Sync Prototype; closes #1539 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1558 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-29 05:20:51 +00:00
Jeremy Kemper
31e48939b1 r1475@iwill: jeremy | 2005-06-28 23:19:51 -0700 
Ticket 1543 - Fix test_process
 r1476@iwill:  jeremy | 2005-06-29 00:20:53 -0700
 Correct expected, actual order for assert_equal.  Use new render method in TestController.
 r1477@iwill:  jeremy | 2005-06-29 00:23:45 -0700
 Generate route and assign parameters without modifying the user's params.
 r1480@iwill:  jeremy | 2005-06-29 00:28:52 -0700
 Update changelog.
 r1481@iwill:  jeremy | 2005-06-29 00:34:02 -0700
 Directly generate paths with a leading slash instead of tacking it on later.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1557 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-29 02:41:00 +00:00
Jamis Buck
453ed15395 Routes fail with leading slash #1540 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1555 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-28 21:18:04 +00:00
David Heinemeier Hansson
5136c2a16b Badly applied patch fix 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1554 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-28 17:54:19 +00:00
David Heinemeier Hansson
beffb77e05 Added support for upload progress indicators in Apache and lighttpd 1.4.x (won't work in WEBrick or lighttpd 1.3.x) #1475 [Sean Treadway] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1553 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-28 17:44:16 +00:00
David Heinemeier Hansson
62ed6950c9 Added support for upload progress indicators in Apache and lighttpd 1.4.x (won't work in WEBrick or lighttpd 1.3.x) #1475 [Sean Treadway] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1552 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-28 17:42:51 +00:00
David Heinemeier Hansson
96e590ca3c This patch modifies RouteSet#write_generation and RouteSet#write_recognition so that they return the source code used to recognize or generate URLs. #1531 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1551 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-28 17:17:39 +00:00
David Heinemeier Hansson
d763f08ba8 Fix the Event.findElement prototype function. Needed to get autocomplete working with Safari #1528 [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1547 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-28 09:47:56 +00:00
David Heinemeier Hansson
938a8fea27 Added support for graceful error handling of Ajax calls #1217 [Jamis Buck/Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1545 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-27 17:40:00 +00:00
Sam Stephenson
05ef7898bd Make Object.prototype.extend work correctly 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1544 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-27 17:10:52 +00:00
Sam Stephenson
9965993e8b Work around existing Element and Event objects in Prototype 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1543 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-27 16:05:10 +00:00
David Heinemeier Hansson
b8689c77a4 Don't ignore :controller for urls made inside a controller module #1526 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1542 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-27 15:17:59 +00:00
David Heinemeier Hansson
a7116b6534 Make named routes work without hashes #1523 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1541 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-27 14:32:19 +00:00
David Heinemeier Hansson
ef8bd07f5e Fixed routing bug 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1539 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-27 10:38:51 +00:00
Jamis Buck
d23d3bc360 Attempt to explicitly flush the output at the end of CgiProcess#out 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1537 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-27 09:35:09 +00:00
David Heinemeier Hansson
9b0bb24fe0 Update script.aculo.us scripts for Prototype 1.3.0 #1522 [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1536 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-27 09:24:18 +00:00
Sam Stephenson
0dd2981d2b Fix a potential bug in Prototype's Ajax.Request involving Mozilla and null POST bodies 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1534 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-27 06:33:09 +00:00
David Heinemeier Hansson
2269c23699 Fixed assert_redirected_to to handle absolute controller paths properly #1472 [Rick Olson/Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1533 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-27 05:36:03 +00:00
David Heinemeier Hansson
de1f231c32 Added event-based observations when frequency is not set on observe_field/form #1474 [flash@vanklinkenbergsoftware.nl] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1532 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-27 05:29:47 +00:00
David Heinemeier Hansson
c19b74d9a6 Dont use evals in backtraces #1513 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1531 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-27 05:27:35 +00:00
Sam Stephenson
264a7e7c46 Update to Prototype 1.3.0; closes #1441, #1348 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1530 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-27 05:07:48 +00:00
David Heinemeier Hansson
c9f2389c01 Update script.aculo.us scripts to fix some bugs #1515 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1528 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-26 17:23:38 +00:00
David Heinemeier Hansson
930b59eb39 Fixed that Functional tests do not set request.path_parameters properly #1512 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1527 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-26 14:36:13 +00:00
David Heinemeier Hansson
b17e178981 Renamed remote_sortable to sortable_element 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1526 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-26 14:34:13 +00:00
David Heinemeier Hansson
521d5fdc72 Added auto_complete_for to controller and text_field_with_auto_complete to view to make it really, really easy to do Google Suggest style interfaces 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1525 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-26 14:23:36 +00:00
David Heinemeier Hansson
7da736f929 Added script.aculo.us Javascripts (controls.js, dragdrop.js, effects.js) (NEEDS MORE DESCRIPTION) #1509 [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1522 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-26 12:03:43 +00:00
David Heinemeier Hansson
ee4c834ed2 Added testing of named routes #1506 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1517 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-26 05:23:41 +00:00
Jamis Buck
c6ea1d360c RoutingError should show 404.html when in public #1503 [Ulysses] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1513 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-25 19:05:44 +00:00
David Heinemeier Hansson
6f6c6b8bcb Updated assert_generates/routing to the new Routes code #1498 [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1505 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-25 10:58:44 +00:00
David Heinemeier Hansson
e4ccbf28c8 Fixed prototype to consider all fields it doesn't know as text (such as Safari's search) just like the browser in its serialization #1497 [Sean Treadway] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1503 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-25 10:48:28 +00:00
Jamis Buck
17928b7347 Eliminate a "string literal in condition" warning from some routes 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1502 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-25 09:20:38 +00:00
Jamis Buck
af33a6a6b1 Fix problem with symbol/string mismatch on some routes 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1500 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-24 22:15:45 +00:00
Jeremy Kemper
28012e68fe Fix routes generation for unit tests. #1434 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1497 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-24 17:48:14 +00:00
David Heinemeier Hansson
8e56f5ea3e Improved performance of Routes generation by a factor of 5 #1434 [Nicholas Seckar] Added named routes (NEEDS BETTER DESCRIPTION) #1434 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1496 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-24 16:40:01 +00:00
Jeremy Kemper
540d005ca5 Improved AbstractRequest documentation. Closes #1483. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1494 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-24 14:43:15 +00:00
David Heinemeier Hansson
0c3298f2f2 Added ActionController::Base.allow_concurrency to control whether the application is thread-safe, so multi-threaded servers like WEBrick knows whether to apply a mutex around the performance of each action. Action Pack and Active Record are by default thread-safe, but many applications may not be. Turned off by default. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1487 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-23 06:56:12 +00:00
David Heinemeier Hansson
4e0ffab8b0 Removed the mutex from the WEBrick adapter under the production environment so concurrent requests can be served 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1482 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-22 12:59:36 +00:00
David Heinemeier Hansson
8e56e09018 Updated documentation for partials #1171 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1474 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-21 16:59:04 +00:00
David Heinemeier Hansson
c608ebeade Added TextHelper#word_wrap(text, line_length = 80) #1449 [tuxie@dekadance.se] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1465 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-21 07:16:11 +00:00
David Heinemeier Hansson
e59bfc8519 Added a fall-through action for form_remote_tag that'll be used in case Javascript is unavailable #1459 [Scott Barron] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1464 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-21 07:08:13 +00:00
David Heinemeier Hansson
1e0d9a642f Added :xhr => true/false option to verify so you can ensure that a request is coming from an Ajax call or not #1464 [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1463 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-21 07:02:30 +00:00
David Heinemeier Hansson
bc6570dfcb Added tag_options as a third parameter to AssetHelper#auto_discovery_link_tag to control options like the title of the link #1430 [kevin.clark@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1460 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-21 06:52:05 +00:00
David Heinemeier Hansson
f2a021dc06 Added option to pass in parameters to CaptureHelper#capture, so you can create more advanced view helper methods #1466 [duane.johnson@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1459 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-21 06:43:14 +00:00
David Heinemeier Hansson
5ba31b3d1d Changed the default name of the input tag generated by FormTagHelper#submit_tag from "submit" to "commit" so it doesnt clash with form.submit() calls in Javascript #1271 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1456 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-21 05:26:40 +00:00
David Heinemeier Hansson
92473b8f96 Fixed relative urls support for lighttpd #1048 [Nicholas Seckar/maznawak@nerim.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1450 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-18 05:17:18 +00:00
Jeremy Kemper
959707bfb6 r1335@iwill: jeremy | 2005-06-17 11:41:50 -0700 
Ticket 1458 - distance_of_time_in_words
 r1336@iwill:  jeremy | 2005-06-17 11:44:50 -0700
 Update changelog
 r1337@iwill:  jeremy | 2005-06-17 11:45:44 -0700
 Applied patch.
 r1361@iwill:  jeremy | 2005-06-17 11:48:02 -0700
 Merge changelog


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1449 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-17 13:42:23 +00:00
David Heinemeier Hansson
a895be0259 Fixed query parser to deal gracefully with equal signs inside keys and values #1345 [gorou] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1441 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 06:42:49 +00:00
David Heinemeier Hansson
a7a1c4e2cd Added cuba to country list #1351 [todd] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1440 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 06:36:09 +00:00
David Heinemeier Hansson
ec6f0a1f51 Fixed radio_button to work with numeric values #1352 [demetrius] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1439 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 06:34:08 +00:00
David Heinemeier Hansson
665ab93761 Added :extension option to NumberHelper#number_to_phone #1361 [delynnb] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1438 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 06:33:10 +00:00
David Heinemeier Hansson
43c470fae4 Added button_to as a form-based solution to deal with harmful actions that should be hidden behind POSTs. This makes it just as easy as link_to to create a safe trigger for actions like destroy, although it's limited by being a block element, the fixed look, and a no-no inside other forms. #1371 [tom@moertel.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1437 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 06:17:51 +00:00
David Heinemeier Hansson
89e06ed4c6 Fixed image_tag so an exception is not thrown just because the image is missing and alt value can't be generated #1395 [Marcel] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1434 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 06:04:23 +00:00
David Heinemeier Hansson
5b3bc3139a Added a third parameter to TextHelper#auto_link called href_options for specifying additional tag options on the links generated #1401 [tyler.kovacs@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1432 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 06:00:18 +00:00
David Heinemeier Hansson
691562746f Fixed TextHelper#highlight to return the text, not nil, if the phrase is blank #1409 [patrick@lenz.sh] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1429 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 05:42:47 +00:00
David Heinemeier Hansson
7b47f150fd Its Iraq, not Irak #1443 [ivan] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1427 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 05:05:43 +00:00
David Heinemeier Hansson
cc6c48f0a8 Fixed TagHelper such that :name and 'name' keys in the options doesn't result in two attributes #1455 [take_tk] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1426 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 05:04:17 +00:00
Jeremy Kemper
7bb486055e r1318@iwill: jeremy | 2005-06-15 01:08:22 -0700 
Ticket 1394 - Helper isolation
 r1319@iwill:  jeremy | 2005-06-15 01:10:00 -0700
 Formulate a test case for helper isolation.
 r1331@iwill:  jeremy | 2005-06-15 15:21:07 -0700
 Update changelog
 r1332@iwill:  jeremy | 2005-06-15 15:21:30 -0700
 Remove superfluous, broken layout_test
 r1333@iwill:  jeremy | 2005-06-15 15:24:10 -0700
 Use an anonymous Module to store helpers per-class instead of tossing them all in template_class.  Create a new helper module for subclasses which includes its superclass' helper module.  Remove unnecessary ActionView::Base.controller_delegate.  Update helper tests.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1425 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-15 17:17:58 +00:00
Jamis Buck
14c378cc7f render(:template) applies a layout by default. render("foo/bar") works with a layout again. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1424 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-15 13:20:17 +00:00
David Heinemeier Hansson
280c224b43 Reverted changeset #1326 coming off ticket #1230 since it caused stale caches to be shared.. nasty 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1423 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-15 09:16:23 +00:00
David Heinemeier Hansson
cb79118111 Fixed double-singularization on scaffolded pagination call (Address would be turned into Addres) #1216, #1404 [nilsga] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1422 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-15 04:17:45 +00:00
Jamis Buck
ac1fa98bb9 Removed the require hack used in functional tests that worked around an earlier bug in rake. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1421 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-14 16:17:56 +00:00
Jamis Buck
ed7bfc9662 Allow distance_of_time_in_words to work with any value that responds to #to_time (like dates) #969 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1420 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-14 15:19:03 +00:00
Jamis Buck
3cb869eab6 Resync with html-scanner (fix parser bug) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1419 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-14 13:56:46 +00:00
Jamis Buck
75fb0a32a8 Support :render option to :verify #1440 [TobiasLuetke] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1418 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-14 13:23:55 +00:00
Jamis Buck
c23b2a4ad3 Updated vendor copy of html-scanner lib, for bug fixes and optimizations 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1416 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-14 10:30:36 +00:00
David Heinemeier Hansson
bca13f727e Changed test requests to come from 0.0.0.0 instead of 127.0.0.1 such that they don't trigger debugging screens on exceptions, but instead call rescue_action_in_public 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1415 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-14 08:04:49 +00:00
Jeremy Kemper
3cb26e9cb3 r2495@sedna: jeremy | 2005-05-27 22:07:18 -0700 
Branch to have scaffold use new render methods
 r2496@sedna:  jeremy | 2005-05-28 10:50:51 -0700
 axe unused process_request method
 r2497@sedna:  jeremy | 2005-05-28 10:51:58 -0700
 sanity assertions in process method check that @controller, @request, @response are set
 r2498@sedna:  jeremy | 2005-05-28 10:53:42 -0700
 clean up escaping.  use instance_variable_get instead of instance_eval.  put id in form action instead of hidden input (like the generated scaffolding)
 r2499@sedna:  jeremy | 2005-05-28 10:54:46 -0700
 clean up interpolation, remove tabs from stylesheet
 r2500@sedna:  jeremy | 2005-05-28 10:56:40 -0700
 modernize dynamic scaffolding.  use params[:id] instead of @params[id].  use consolidated render method instead of render_action, render_file, etc.  use builtin inflections rather than module methods.
 r2501@sedna:  jeremy | 2005-05-28 11:00:26 -0700
 modernize generated scaffolding.  use new-style assertions; use params[:id] instead of @params[id]; use consolidated render method instead of render_*
 r2542@sedna:  jeremy | 2005-06-12 02:24:06 -0700
 use :id => model instead of :id => model.id.  clean up the form helper method.  use flash[:notice] instead of flash['notice'].
 r2543@sedna:  jeremy | 2005-06-12 02:33:22 -0700
 whitespace
 r2544@sedna:  jeremy | 2005-06-12 02:56:57 -0700
 update changelogs
 r2545@sedna:  jeremy | 2005-06-12 03:26:23 -0700
 test dynamic form help when @post is not a new record
 r2546@sedna:  jeremy | 2005-06-12 03:44:14 -0700
 touch up TestCase#process sanity assertions


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1404 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-12 05:33:23 +00:00
Jamis Buck
f6ec9e3d66 Arrays sent via multipart posts are converted to strings #1032 [dj@omelia.org] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1397 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-10 12:21:25 +00:00
David Heinemeier Hansson
5add31eda4 CSS needs "red" not #red 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1388 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-06 09:48:48 +00:00
David Heinemeier Hansson
32c0e895bf Fixed scaffolding to use the latest style 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1380 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-02 20:13:02 +00:00
David Heinemeier Hansson
3162f386dc Made Action View work with the new render :file/:partial style from the controller 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1379 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-02 20:12:34 +00:00
Jamis Buck
e4c047e489 render(:action) and render() are the only two render calls to use a layout by default. All others default to :layout => false. Also, allow :layout => true to be a synonym for :layout => nil. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1378 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-01 13:39:58 +00:00
Jamis Buck
6ce58318f5 render(:inline) defaults to :layout => false 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1372 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-30 09:12:12 +00:00
Jamis Buck
f8542a64b3 Make sure the benchmarking render method always returns the result of the render, regardless of whether logging is enabled or not. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1371 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-30 09:00:46 +00:00
Jamis Buck
f57ee365e1 render(:text), render(:partial), and render(:nothing) always default to :layout => false. This also fixes send_file, which was applying a layout if one existed for the current action. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1369 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-30 07:51:02 +00:00
Jamis Buck
613260606b verify with :redirect_to won't redirect if a redirect or render has already been performed #1350 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1367 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-30 07:24:46 +00:00
Jamis Buck
00db6f0faa render(:partial => "...") uses an empty hash for the local assigns #1365. render(:partial => true) is identical to the older render_partial() 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1366 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-30 07:20:37 +00:00
Jamis Buck
b6c13f2d70 Don't die when an attempt to delete a cache fails 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1365 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-30 07:05:52 +00:00
David Heinemeier Hansson
bdd16a75e6 render :nothing shouldnt cause layouts 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1353 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-22 16:57:51 +00:00
David Heinemeier Hansson
060ecf1a24 Set redirected_to proper 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1352 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-22 16:52:54 +00:00
David Heinemeier Hansson
2f7c5f84e4 Cure some ills discovered with the refactoring 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1351 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-22 11:07:09 +00:00
David Heinemeier Hansson
da0c4c5c96 Deprecated all render_* methods in favor of consolidating all rendering behavior in Base#render(options). This enables more natural use of combining options, such as layouts 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1350 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-22 08:58:43 +00:00
David Heinemeier Hansson
0367317dd6 Deprecated redirect_to_path and redirect_to_url in favor of letting redirect_to do the right thing when passed either a path or url. Introduced r as a unified method for render (still under construction) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1349 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-22 07:43:05 +00:00
David Heinemeier Hansson
dab360e181 Added DoubleRenderError exception that'll be raised if render* is called twice #518 [Nicholas Seckar]. Fixed exceptions occuring after render has been called #1096 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1348 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-21 18:51:08 +00:00
David Heinemeier Hansson
7159402c6d Fixed use of an integer as return code for renders, so render_text "hello world", 404 now works #1327 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1345 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-21 17:50:57 +00:00
David Heinemeier Hansson
997eb90c90 Made the post_format work with content-type 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1337 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-20 18:39:40 +00:00
David Heinemeier Hansson
24b13acd42 Made the post_format work with content-type 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1336 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-20 18:32:04 +00:00
David Heinemeier Hansson
9bf38dec69 Include flash in the list of attributes with accessors in the view 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1334 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-20 07:04:51 +00:00
David Heinemeier Hansson
d3704f888b Fixed assert_redirect_to to work with redirect_to_path #869 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1332 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 19:19:58 +00:00
David Heinemeier Hansson
7160ab1c18 Fixed escaping of :method option in remote_form_tag #1218 [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1328 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 19:08:16 +00:00
David Heinemeier Hansson
977671c226 Optimize ActionCacheFilter by using url_for less #1230 [skaen] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1326 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 18:59:43 +00:00
David Heinemeier Hansson
caf6ff6a2f Cache relative_url_root and optimize path #1232 [skaen] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1325 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 18:55:50 +00:00
David Heinemeier Hansson
3a057ea4ac Faster action_exempted? #1231 [skaen] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1324 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 18:54:16 +00:00
David Heinemeier Hansson
45ee71af3c Added Serbia and Montenegro to the country_select #1239 [todd@robotcoop.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1323 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 18:30:53 +00:00
David Heinemeier Hansson
dd8c92ea5b Fixed Request#remote_ip in testing #1251 [bitsweat] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1322 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 18:24:52 +00:00
David Heinemeier Hansson
473e5bde74 Fixed that compute_public_path should recognize external URLs, so image_tag("http://www.example.com/images/icon.gif") is not prefixed with the relative url path #1254 [victor-ronr-trac@carotena.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1321 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 18:06:12 +00:00
David Heinemeier Hansson
202d5c0751 Added support for descending year values in DateHelper#select_year, like select_year(Date.today, :start_year => 2005, :end_year => 1900), which would count down from 2005 to 1900 instead of the other way #1274 [nwoods@mail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1320 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 17:40:02 +00:00
David Heinemeier Hansson
26022d8d2a Ajax docing #1282 [Dee.Zsombor@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1318 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 17:29:20 +00:00
David Heinemeier Hansson
496ee0cd1b Fixed that FormHelper#checkbox should return a checked checkbox if the value is the same as checked_value #1286 [Florian Weber] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1317 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 17:27:08 +00:00
David Heinemeier Hansson
9b1fefbf54 Fixed doc #1291 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1315 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 17:14:35 +00:00
David Heinemeier Hansson
7ec91d4651 Fixed Form.disable in Prototype #1317 [Wintermute] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1311 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 16:45:53 +00:00
David Heinemeier Hansson
aa20834222 Added accessors to logger, params, response, session, and headers from the view, so you can write <% logger.info "stuff" %> instead of <% @logger.info "others" %> -- more consistent with the preferred way of accessing these attributes and collections from the controller 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1307 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 16:00:04 +00:00
David Heinemeier Hansson
cada2c71d3 Use X-POST_DATA_FORMAT instead of just POST_DATA_FORMAT 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1305 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-14 09:31:35 +00:00
David Heinemeier Hansson
86d2b2792a Added support for POST data in form of YAML or XML, which is controller through the POST_DATA_MARSHAL header 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1304 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-14 08:38:37 +00:00
David Heinemeier Hansson
db11abbfba Added support for POST data in form of YAML or XML, which is controller through the POST_DATA_MARSHAL header 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1303 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-14 08:36:19 +00:00
David Heinemeier Hansson
51f9c931ea Fixed that render_partial_collection should always return a string (and not sometimes an array, despite <%= %> not caring) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1302 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-13 16:27:36 +00:00
David Heinemeier Hansson
8983a09752 Go straight to the class for asset_host 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1299 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-09 11:27:39 +00:00
David Heinemeier Hansson
45780be2a7 Added TextHelper#sanitize that can will remove any Javascript handlers, blocks, and forms from an input of HTML. This allows for use of HTML on public sites, but still be free of XSS issues. #1277 [Jamis Buck] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1298 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-09 11:24:18 +00:00
David Heinemeier Hansson
b167248b21 Fixed the HTML scanner used by assert_tag where a infinite loop could be caused by a stray less-than sign in the input #1270 [Jamis Buck] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1297 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-09 11:20:19 +00:00
David Heinemeier Hansson
8a41ea4588 Only gsub on a string 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1292 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-06 18:10:13 +00:00
David Heinemeier Hansson
409bc0970a Added functionality to assert_tag, so you can now do tests on the siblings of a node, to assert that some element comes before or after the element in question, or just to assert that some element exists as a sibling #1226 [Jamis Buck] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1291 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-06 16:42:01 +00:00
David Heinemeier Hansson
c971c24839 Changed RAILS_ASSET_HOST to become ActionController::Base.asset_host 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1289 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-06 05:10:36 +00:00
David Heinemeier Hansson
358a669390 Added better error handling for regexp caching expiration 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1288 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-06 05:09:01 +00:00
David Heinemeier Hansson
ac44be3494 Treat all request types as upper-case so the switch will work 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1283 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-04 10:46:33 +00:00
David Heinemeier Hansson
8b2598bb64 Made it default to assuming a GET request and reading from command-line only in case of the new CMD method 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1282 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-04 09:39:41 +00:00
David Heinemeier Hansson
dacb61c8ca Added that both AssetHelper#stylesheet_link_tag and AssetHelper#javascript_include_tag now accept an option hash as the last parameter, so you can do stuff like: stylesheet_link_tag "style", :media => "all" 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1281 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-03 14:39:57 +00:00
David Heinemeier Hansson
d2fb072563 Added FormTagHelper#image_submit_tag for making submit buttons that uses images 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1280 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-03 14:30:53 +00:00
David Heinemeier Hansson
2eebd11e0b Added the option of specifying a RAILS_ASSET_HOST that will then be used by all the asset helpers. This enables you to easily offload static content like javascripts and images to a separate server tuned just for that. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1279 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-03 10:25:01 +00:00
David Heinemeier Hansson
1edb807aff Dont expire or read fragments if caching is turned off 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1270 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-02 07:49:55 +00:00
David Heinemeier Hansson
577a22c47e Dont benchmark if the logger has been turned off 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1269 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-02 07:05:15 +00:00
David Heinemeier Hansson
e6f3e5d900 Fixed action/fragment caching using the filestore when a directory and a file wanted to to use the same name. Now there's a .cache prefix that sidesteps the conflict #1188 [imbcmdth@hotmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1260 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-30 15:29:27 +00:00
David Heinemeier Hansson
537efa36d0 Doc fix #1200 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1257 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-30 13:36:40 +00:00
David Heinemeier Hansson
90b08c5b92 Fixed documentation #1214 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1254 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-30 08:50:10 +00:00
David Heinemeier Hansson
98306bed05 Fixed missing id uniqueness in FormTag#radio_button #1207 [Jarkko] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1253 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-30 08:46:22 +00:00
David Heinemeier Hansson
b4fe4daa84 Fixed assert_redirected_to to work with :only_path => false #1204 [Alisdair McDiarmid] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1251 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-30 08:34:02 +00:00
David Heinemeier Hansson
c29cfe389e Check definition on constant not string 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1250 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-30 08:33:25 +00:00
David Heinemeier Hansson
6d0ddd818a Fixed render_partial_collection to output an empty string instead of nil when handed an empty array #1202 [Ryan Carver] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1249 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-30 08:29:50 +00:00
David Heinemeier Hansson
5640f76970 Improved the speed of regular expression expirations for caching by a factor of 10 #1221 [Jamis Buck] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1248 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-30 08:23:42 +00:00
David Heinemeier Hansson
fe00c275cd Removed dumping of template assigns on the rescue page as it would very easily include a ton of data making page loads take seconds (and the information was rarely helpful) #1222 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1246 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-30 08:19:14 +00:00
David Heinemeier Hansson
61cafca6ea Disregard expire methods when the controller hasnt been set, which essentially makes it such that the record observer callbacks are ignored when the sweeper shouldnt be active 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1242 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-27 17:40:51 +00:00
David Heinemeier Hansson
fbd86c2017 Added BenchmarkHelper that can measure the execution time of a block in a template and reports the result to the log 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1240 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-27 08:17:25 +00:00
David Heinemeier Hansson
a2ef9778ce Added ActionController::Caching::Sweeper as an improved an easier to use sweeper. Added that Fragments#expire_fragment now accepts as a regular expression as the name thereby deprecating expire_matched_fragments. Fixed that fragments shouldn't use the current host and the path as part of the key like pages does 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1239 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-27 08:14:53 +00:00
David Heinemeier Hansson
734c69f241 Added conditions to around_filters just like before_filter and after_filter 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1238 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-27 06:42:12 +00:00
David Heinemeier Hansson
77af61be40 Added xml_http_request/xhr method for simulating XMLHttpRequest in functional tests #1151 [Sam Stephenson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1230 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-19 16:34:44 +00:00
Sam Stephenson
71a616890b Update to Prototype 1.2.1 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1228 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-19 11:16:50 +00:00
David Heinemeier Hansson
5462358cd3 Fixed that :get, :post, and the others should take a flash array as the third argument just like process #1144 [rails@cogentdude.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1227 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-19 11:04:38 +00:00
David Heinemeier Hansson
0dd497853a More documentation #1148 [Alisdair McDiarmid] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1226 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-19 10:59:55 +00:00
David Heinemeier Hansson
865874ab6a Fixed stringification on all assigned hashes. The sacrifice is that assigns[:person] wont work in testing. Instead assigns["person"] or assigns(:person) must be used. In other words, the keys of assigns stay strings but weve added a method-based accessor to appease the need for symbols. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1223 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-19 10:26:03 +00:00
David Heinemeier Hansson
aa236c4425 Fixed that rendering a template would require a connection to the database #1146 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1222 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-19 09:57:15 +00:00
David Heinemeier Hansson
420b830b00 Fixed that rendering a template would require a connection to the database #1146 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1221 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-19 09:54:10 +00:00
David Heinemeier Hansson
7d01005514 Fixed documentation and prepared for release of 0.12 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1216 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-18 20:10:11 +00:00
David Heinemeier Hansson
3b9bf64130 Added support for web servers that use PATH_INFO instead of REQUEST_URI like IIS #1014 [BradG/Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1211 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-18 15:43:07 +00:00
David Heinemeier Hansson
e9681eb9c5 Added graceful handling of PUT, DELETE, and OPTIONS requests for a complete coverage of REST functionality #1136 [joshknowles@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1208 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-18 14:15:26 +00:00
David Heinemeier Hansson
bceb88ef9c Fixed that you can now pass an alternative :href option to link_to_function/remote in order to point to somewhere other than # if the javascript fails or is turned off. You can do the same with form_remote_tag by passing in :action. #1113 [Sam Stephenson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1200 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-18 05:15:17 +00:00
Sam Stephenson
d547c3f5ec Update to Prototype 1.2.0 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1198 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-18 02:16:13 +00:00
David Heinemeier Hansson
806cf6d76a Added assert_tag and assert_no_tag as a much improved alternative to the deprecated assert_template_xpath_match #1126 [Jamis Buck] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1195 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 16:43:48 +00:00
David Heinemeier Hansson
95e6c03de7 Added Request#xml_http_request? (and an alias xhr?) to that'll return true when the request came from one of the Javascript helper methods (Ajax). This can be used to give one behavior for modern browsers supporting Ajax, another to old browsers #1127 [Sam Stephenson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1194 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 16:40:53 +00:00
David Heinemeier Hansson
7cda49248b Fixed page caching for non-vhost applications living underneath the root #1004 [Ben Schumacher] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1193 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 14:10:24 +00:00
David Heinemeier Hansson
72c51356c5 Hide the deprecated methods from the docs 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1190 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 11:47:54 +00:00
David Heinemeier Hansson
dca7efa67e Deprecated the majority of all the testing assertions and replaced them with a much smaller core and access to all the collections the old assertions relied on. That way the regular test/unit assertions can be used against these. Added documentation about how to use it all. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1189 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 11:38:01 +00:00
David Heinemeier Hansson
8e8bf37aa9 Fixed DateHelper to return values on the option tags such that they'll work properly in IE with form_remote_tag #1024 [rscottmace@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1184 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 09:44:28 +00:00
David Heinemeier Hansson
ba96827b3d Fixed FormTagHelper#check_box to respect checked #1049 [DelynnB] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1183 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 09:39:01 +00:00
David Heinemeier Hansson
e5b3d08a0a Added that render_partial called from a controller will use the action name as default #828 [Dan Peterson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1182 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 09:25:54 +00:00
David Heinemeier Hansson
c3ca5ab7a8 Added Element.toggle, Element.show, and Element.hide to the prototype javascript library. Toggle.display has been deprecated, but will still work #992 [Lucas Carlson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1181 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 07:52:50 +00:00
David Heinemeier Hansson
6acda705dc Added that deleting a cookie should not just set it to an empty string but also instantly expire it #1118 [todd@robotcoop.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1180 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 07:18:39 +00:00
David Heinemeier Hansson
ffdd4bc251 Added AssetTagHelper#image_path, AssetTagHelper#javascript_path, and AssetTagHelper#stylesheet_path #1110 [Larry Halff] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1176 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 06:23:27 +00:00
David Heinemeier Hansson
5e3b8b36fa Fixed url_for(nil) in functional tests #1116 [Alisdair McDiarmid] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1175 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 06:18:33 +00:00
David Heinemeier Hansson
db16349bc1 Fixed error handling of broken layouts #1115 [Michael Schubert] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1173 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 06:11:58 +00:00
David Heinemeier Hansson
6ee06ebec6 Changed render_partial to take local assigns as the second parameter instead of an explicit object and then the assigns 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1170 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-16 16:08:29 +00:00
David Heinemeier Hansson
82456d9392 Fixed partials handling 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1169 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-16 16:06:29 +00:00
David Heinemeier Hansson
f3e5e07982 Added submit_to_remote that allows you to trigger an Ajax form submition at the click of the submission button, which allows for multiple targets in a single form through the use of multiple submit buttons #930 [yrashk@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1160 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-13 05:44:43 +00:00
David Heinemeier Hansson
ad24c6d756 Fixed pagination to work with joins #1034 [scott@sigkill.org] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1159 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-13 05:40:22 +00:00