TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
43,790 Commits 2 Branches 0 Tags 294 MiB
46fc89faba
Commit Graph

2407 Commits

Author SHA1 Message Date
Jon Atack
5b56db5808 Fix run-on sentences and improve grammar [skip ci] 2014-04-22 09:40:32 +02:00
Gaurish Sharma
28bd442034 Running AR tests on postgres, mysql & sqlite 
[ci skip]
 2014-04-21 18:09:22 +05:30
Richard Schneeman
86b02826a6 Merge pull request #14820 from akshay-vishnoi/doc_changes 
[ci skip] builtin -> built-in
 2014-04-20 12:46:03 -05:00
Akshay Vishnoi
0c2854fa03 [ci skip] builtin -> built-in 2014-04-20 21:03:09 +05:30
Jon Atack
1365af1836 Fix code indentation and improve formatting 
in the Getting Started Guide.

This PR regroups #14817, #14818 and #14819 into one commit.

[skip ci]
 2014-04-20 17:26:51 +02:00
Jon Atack
cd86201ec6 Grammar fix in Getting Started Guide 2014-04-20 12:21:28 +02:00
Gaurish Sharma
0fd301aaf7 Remove reference to outdated section 
[ci skip]
 2014-04-20 01:39:52 +05:30
Nick Quaranto
66e5844b9a Remove statement assuming coffee shop/public space wifi is inherently insecure 2014-04-19 15:19:09 -04:00
Robin Dupret
fd6d78356f Don't rely on Arel master in bug report template [ci skip] 
We should rely instead on the version supported by Active Record

Closes #14809
 2014-04-19 18:25:11 +02:00
Arthur Nogueira Neves
d39a0d8b82 Merge pull request #14804 from akshay-vishnoi/doc_changes 
"subhash" --> "sub-hash"
 2014-04-19 09:46:08 -05:00
Anton Kalyaev
5facaca7d8 wrap methods in backticks [ci skip] 2014-04-19 14:19:53 +04:00
Akshay Vishnoi
fe8a6ba3a1 "subhash" --> "sub-hash" 2014-04-19 04:03:43 +05:30
Vijay Dev
c2fa85f481 Merge branch 'master' of github.com:rails/docrails 2014-04-18 21:59:44 +05:30
Brad Dunbar
d5acf61abc :uglify -> :uglifier 
The name of the gem is `uglifier` and all other references
use `uglifier`, not `uglify`.
 2014-04-18 10:35:56 -04:00
Steven Harman
e50719332e Fix spelling and proper nouns 
[ci skip]
 2014-04-17 23:24:41 -04:00
PaulL1
d3152750b7 Include default rails protect_from_forgery with: :exception 
Extend previous changes, include the default line from the application controller that new rails applications are created with: 
  protect_from_forgery with: :exception

Minor wording changes to align.
 2014-04-17 21:20:17 +02:00
PaulL1
92fd44b35d CSRF protection should rescue exception not extend 
I think the changes to the default behaviour mean that rails will throw an exception when an invalid authenticity token is found.  The previous proposed code of calling super then sign_out meant that sign_out was never reached - the exception handler never returned.

I think the best approach now is to catch the exception, although I'm not 100% certain on that.
 2014-04-17 14:04:40 +02:00
Kyle Heironimus
2c99e58208 [skip ci] Reorder i18n guide 
Currently, the section called "How to store your custom translations"
has several subheadings that make no sense, such as "Translations for
ActiveRecord models." These make more sense under the "Overview of the
I18n API Features" section. I moved the "How to store..." section down
to the more appropriate sub-headings "Using Different Backends" and
"Using Different Exception Handlers" and removed the "Customize your
i18n setup" header.
 2014-04-16 14:26:47 -05:00
Arthur Nogueira Neves
fa83601996 Merge pull request #11836 from mcfiredrill/engines-testing-doc 
additional note about routes in functional tests for engines [ci skip]
 2014-04-16 10:49:26 -04:00
Mike MacDonald
19b2bcc76d [ci skip] Avoid suggesting dangerous code in i18n guide 
Calling `to_sym` on user input opens apps up to Denial of Service attacks, via the symbol table being expanded to consume vast swathes of memory.

It is a fairly common configuration to have DNS configured such that all subdomains route to your Rails app, in which case an attacker visits `www1.foo.com`, `www2.foo.com`, and so on until something gives.

It is far less likely to have this problem with TLDs, so that change was only for consistency.
 2014-04-15 21:19:00 -04:00
schneems
c5e083af3d [ci skip] document statement_limit 
Per discussion at https://github.com/rails/rails/issues/14645#issuecomment-40499409
 2014-04-15 13:06:26 -05:00
schneems
b415390ad6 [ci skip] PP does not generate pass by default 
This was changed in https://github.com/rails/rails/pull/13415/files
 2014-04-15 13:06:26 -05:00
Juanito Fatas
2e57d518d8 [ci skip] Add missing end in one of the examples in Migrations.md. 2014-04-15 15:57:09 +08:00
Richard Schneeman
c52a84f766 Merge pull request #14729 from akshay-vishnoi/doc_changes 
[ci skip] Improve doc, fix grammatical issue
 2014-04-14 14:14:46 -05:00
ZENATI YASSINE
1497529d05 [ci skip] Added link to ruby-lang.org installation. 2014-04-14 17:07:05 +02:00
Christopher Owen
0e9fab5ff5 - Fix lingering reference to :text instead of the newer :plain 
- Section references `form_tag` instead of the `form_for` used in the example
 2014-04-14 12:06:59 +10:00
Nick Borromeo
0debba8899 Disable assest cache store in docs [ci skip] 2014-04-13 12:01:45 -07:00
Juanito Fatas
982a19edc9 [ci skip] Use plain underscore instead of "\_". 2014-04-13 23:56:59 +08:00
Akshay Vishnoi
e75314803e [ci skip] Improve doc, fix grammatical issue 2014-04-13 21:20:31 +05:30
Steven Harman
c4d2e8eef2 Fix spelling errors and grammar issues 
Including replacing a few "smart quotes" with regular quotes (' and "),
for consistency.
[ci skip]
 2014-04-13 10:15:55 -04:00
Marcel Morgan
2ddbe87e7a Update documentation to use Rails.application instead 
References to ``AppName::Application` removed in favour of ``Rails.application``
as generated with a new rails 4.1 app.

[ci skip]
 2014-04-13 05:52:04 -05:00
Afshin Mokhtari
7782fdcf2b Missing 'are' in note - [ci skip] 
This is in the note at the end of Section 2: Controller Naming Convention.  [ci skip]
 2014-04-12 17:43:23 -07:00
Robin Dupret
80d0dd53ca Fix a few typos [ci skip] 
This is a follow up to 545afc15.
 2014-04-12 20:12:47 +02:00
Vipul A M
73bfb51011 Change links to 37signals and svn blog to point to new destinations. [ci skip] 2014-04-12 12:46:04 +05:30
Steven Harman
21bb6e0010 Fix a few grammar issues. [ci skip] 2014-04-11 16:14:08 -04:00
Steven Harman
9efab213d2 Use path where extensions are defined, not used 
For consistency with all other documentation, point to where these core
extensions are defined, not where the example code comes from.

[ci skip]
 2014-04-11 15:49:43 -04:00
Rafael Mendonça França
7bb8fd2f64 Merge pull request #14646 from deivid-rodriguez/provide_byebug_by_default 
Improve debugging support
 2014-04-11 13:55:10 -03:00
Rafael Mendonça França
4e9c0b7874 Fix version indicator on guides and link to Rails 4.0 [ci skip] 2014-04-11 13:39:37 -03:00
Rafael Mendonça França
f166f1da46 Merge pull request #14689 from matthewd/asset_initializer 
Move assets precompile (and version) to an initializer
 2014-04-11 12:56:03 -03:00
Rafael Mendonça França
08775e347f Merge pull request #14707 from minio-sk/fix-issue-14702 
Be explicit about allowed constraint values, fixes #14702
 2014-04-11 11:10:59 -03:00
Jano Suchal
aca64fed43 Be explicit about allowed constraint values, fixes #14702 2014-04-11 15:19:37 +02:00
Matthew Draper
f612c2b052 Move assets precompile (and version) to an initializer 
sprockets-rails 2.1 needs the precompile list to be available in all
environments.
 2014-04-11 22:47:54 +09:30
Rafael Mendonça França
d0b5484b5d Merge pull request #14705 from akshay-vishnoi/doc_changes 
Add more test case for #demodulize, Improve documentation
 2014-04-11 09:46:22 -03:00
Akshay Vishnoi
075a1e21fa Add more test case for #demodulize, Improve documentation 2014-04-11 17:57:16 +05:30
David Rodríguez de Dios
545afc150e Re-review the debugging guide. 
Tested on a brand new app to exactly match current byebug's behaviour.
 2014-04-11 13:55:42 +02:00
David Rodríguez de Dios
8834847a37 Minor fixes in the rails debugging guide 2014-04-11 11:00:19 +02:00
Rafael Mendonça França
632d9d2237 Merge pull request #14694 from heironimus/callback_guide 
Add after_commit/after_rollback to callback list
 2014-04-10 17:13:17 -03:00
Akshay Vishnoi
8c1406cf25 [ci skip] Remove false documentation 2014-04-11 01:28:47 +05:30
Kyle Heironimus
16f481b28b Add after_commit/after_rollback to callback list 
Adding after_commit/after_rollback to list of callbacks in order helps
explain the callback order as well as making it consistent with the API
docs at http://api.rubyonrails.org/classes/ActiveRecord/Callbacks.html
 2014-04-10 14:58:36 -05:00
Rafael Mendonça França
85b48d2bcb Merge pull request #14677 from JuanitoFatas/update-initialization-code-snippets 
[ci skip] Update code snippets to latest master (initialization.md).
 2014-04-10 14:10:10 -03:00
Juanito Fatas
3664e3a430 [ci skip] Update code snippets to latest master (initialization.md). 
Also update the `server.run` example (Replace Mongrel with Puma).
 2014-04-10 22:44:47 +08:00
Parth Bharadiya
3fe7b5f4a1 Correct factual error for page not found 2014-04-10 15:41:09 +05:30
Rafael Mendonça França
b053a47b3e depend_on_asset is not required anymore on sprockets-rails 2.1.2 2014-04-09 14:07:31 -03:00
Rafael Mendonça França
040a1dbb11 Merge pull request #14654 from Alamoz/secret_key 
Expand explanation of how to set secrets.yml.
 2014-04-09 13:05:44 -03:00
Yves Senn
7cf46ad889 upgrading section for 4.1 is no longer WIP. [ci skip] 2014-04-09 11:23:33 +02:00
Adrien Lamothe
a4e5587236 Expand explanation of how to set secrets.yml. [ci skip] 2014-04-08 21:18:26 -07:00
Vadim Golub
fec69b9b8d Guides: minor typo fixed [ci skip] 2014-04-09 02:54:42 +03:00
Gaurish Sharma
5d5b7c56ac Instead boat load of libraries, simply say StdLib 2014-04-09 04:34:33 +05:30
Rafael Mendonça França
30a41e76f6 new CHANGELOGs entries are in the top [ci skip] 2014-04-08 17:34:34 -03:00
Matias Korhonen
f0125a19b9 Updates the maintenance policy with new Rails versions 2014-04-08 23:18:49 +03:00
David Rodríguez de Dios
eb2d555f5c Update debugging guide to use byebug 2014-04-08 20:59:28 +02:00
Jarmo Isotalo
2bc0271e3d Added OS X specific commands to installation guide [ci skip] 
Recommended using homebrew for installing MySQL and PostgreSQL
 2014-04-07 00:07:46 +03:00
Gaurish Sharma
38ad5438cc Improve Contributing to Rails Guide 
Logically group the content, so it makes more sense if someone tries to read from start of page to end of page. [ci skip]
 2014-04-06 02:26:43 +05:30
Andy Callaghan
3779c1d45e W3C CSP document moved to gihub.io URL [ci skip] 
The old link https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html is now being soft redirected to this new URL
 2014-04-05 17:01:59 +01:00
Łukasz Adamczak
251840f20a Improve error message for guides:generate:kindle 
With `kindlegen` missing from the PATH, the task
keeps suggesting to `gem install kindlerb`.
This change provides a more meaningful error
message for guides:generate:kindle.
 2014-04-03 21:31:27 +02:00
Rafael Mendonça França
7e6630329e Merge pull request #14569 from matthewd/sqlite_relative_deprecated 
Revise 'sqlite3:' URL handling for smoother upgrades

Conflicts:
	activerecord/CHANGELOG.md
 2014-04-03 11:12:54 -03:00
ariabov
34a3d425ea In Active Record Querying guide, currently Merging of scopes section uses a concept of default scope in its example before it is introduced in the following section titled Applying a default scope. 
It makes more sense to switch the ordering to introduce default scopes (`Applying a default scope`) first and then go into `Merging of scopes` section where it is used.
 2014-04-02 23:39:22 -07:00
Rafael Mendonça França
79f06a9134 Merge pull request #14564 from killthekitten/patch-2 
Fix default_url_options example in i18n guide
 2014-04-02 20:53:12 -05:00
Nikolay Shebanov
3f70c69437 Fix default_url_options example in i18n guide [ci skip] 2014-04-03 05:46:44 +04:00
Carlos Antonio da Silva
5aa4157ae4 Fix cookie serializer docs 
The option actually needs to be set on action_dispatch. [ci skip]
 2014-04-02 13:19:13 -03:00
Matthew Draper
f846828dae Revise 'sqlite3:' URL handling for smoother upgrades 
Restore the 4.0 behaviour for 'sqlite3:///', but deprecate it. We'll
change to the absolute-path interpretation in 4.2.

The current "correct" spellings for in-memory, relative, and absolute
URLs, respectively, are:

    sqlite3::memory:
    sqlite3:relative/path
    sqlite3:/full/path

Substantially reverses/defers fbb79b517f3127ba620fedd01849f9628b78d6ce.
Uncovered by @guilleiguaran while investigating #14495, though that
sounds like a different issue.
 2014-04-03 01:30:27 +10:30
Alessandro Tagliapietra
8ae3f24eb7 Fixed small documentation typo 
Using `Rails.application.config.cookies_serializer :hybrid` throws an exception, fixed to `=`.
 2014-04-02 16:02:13 +02:00
Vijay Dev
3ae33961e0 Merge branch 'master' of github.com:rails/docrails 2014-03-29 17:08:40 +05:30
Vijay Dev
f8872d658e copy edit [ci skip] 2014-03-29 17:08:07 +05:30
Gaurish Sharma
15a18c18e4 Clarify environment_name for logs 
[ci skip]
 2014-03-27 16:37:47 +05:30
Juanito Fatas
c7ab4fc4e2 [ci skip] Fix Pull Request URL in 4.1 release note. 2014-03-27 01:39:58 +08:00
Yves Senn
dcda6e32b4 link to "Schema migration" Wikipedia page. Closes #14479. [ci skip] 2014-03-26 09:06:31 +01:00
Yves Senn
10b68955dc synchronize changelogs and 4.1 release notes. [ci skip] 
Conflicts:
	actionpack/CHANGELOG.md
	activerecord/CHANGELOG.md
	activesupport/CHANGELOG.md
	railties/CHANGELOG.md
 2014-03-25 10:06:01 +01:00
Iain D Broadfoot
3bbc96048d fix log_tags request object grammar 2014-03-21 14:59:42 +00:00
Godfrey Chan
3dad856a1a Added a warning about serializing data with JSON cookie jars [skip ci] 
Closes #14409
 2014-03-19 15:39:22 -07:00
chriskohlbrenner
2ec51d03ac Fix a typo to make clause plural [ci skip] 2014-03-19 16:39:45 -04:00
Guillermo Iguaran
4a69c933cf Merge pull request #14379 from robertomiranda/rake-notes.config 
Add Public Api for Register New Extensions for Rake Notes
 2014-03-17 17:47:24 -05:00
robertomiranda
6b4793b1d2 Update command line guide 2014-03-17 17:03:41 -05:00
Robin Dupret
af98176468 Remove extra white-spaces [ci skip] 
Follow up to 024e5e31
 2014-03-16 10:08:00 +01:00
Afshin Mokhtari
024e5e3104 Reword 5.6 strong parameters and private method stuff [ci skip] 2014-03-15 23:28:34 +00:00
Afshin Mokhtari
4d1bc027e1 Fix probs in sections 5.6 and 5.9; [ci skip] 2014-03-13 20:28:02 +00:00
sukolsak
69ba49dd85 Fix a grammatical error in the i18n guide [ci skip] 2014-03-12 15:03:04 -07:00
Gary S. Weaver
2c634f01fa minor fix to 4.1 rel notes for begin_transaction joinable option [CI skip] 2014-03-10 12:42:06 -04:00
Rafael Mendonça França
a1ad848469 The 4.1 release notes is already a thing so lets show in the guides 
links
 2014-03-10 10:32:16 -03:00
Rashmi Yadav
7ea0a50126 Updating select helper doc [ci skip] 2014-03-08 20:23:15 +01:00
Yves Senn
dc8bfc8ab6 docs, shorten CsrfHelper description and refer to security guide. [ci skip] 2014-03-08 15:46:43 +01:00
Yves Senn
2883cb9766 added CSRF helper to rails guide documentation. Closes #11615. [ci skip] 2014-03-08 13:41:38 +01:00
Patrick Perey
91156b6f0c Add preventDefault() on click event 2014-03-07 10:46:27 -08:00
Vijay Dev
70ff31d69f Merge branch 'master' of github.com:rails/docrails 
Conflicts:
	guides/source/4_1_release_notes.md
 2014-03-07 20:58:11 +05:30
Vijay Dev
507ee79a6c Merge pull request #14257 from killthekitten/patch-1 
Add "Low-Level Caching" part to "Caching With Rails" guide
 2014-03-06 22:53:08 +05:30
Aaron Patterson
b7192143ed Merge pull request #14285 from sikachu/master-revert-render-body-remove-content-type 
Do note remove `Content-Type` when `render :body`
 2014-03-06 08:22:43 -08:00
joker1007
64816dacc5 Fix guide about config.active_record.default_timezone [ci skip] 
Now the initial value of ActiveRecord.default_timezone is always :utc
 2014-03-06 18:59:11 +09:00
Nikolay Shebanov
d361d9303b [ci skip] Add "Low-Level Caching" part to "Caching With Rails" 2014-03-06 00:05:39 +04:00
Prem Sichanugrist
ed88a601f7
Do note remove Content-Type when render :body 
`render :body` should just not set the `Content-Type` header. By
removing the header, it breaks the compatibility with other parts.

After this commit, `render :body` will returns `text/html` content type,
sets by default from `ActionDispatch::Response`, and it will preserve
the overridden content type if you override it.

Fixes #14197, #14238

This partially reverts commit 3047376870d4a7adc7ff15c3cb4852e073c8f1da.
 2014-03-05 10:33:52 -05:00
Yves Senn
8d486c63d6 docs, flash message keys are normalized to strings. [ci skip] 
This is a follow up to a668beffd64106a1e1fedb71cc25eaaa11baf0c1
 2014-03-05 09:53:39 +01:00