TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
38,631 Commits 2 Branches 0 Tags 294 MiB
484253515c
Commit Graph

38631 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Neer Friedman
484253515c Fix microsecond precision of Time#at_with_coercion 
When Time.at_with_coercion (wraps Time.at) is called with a single
argument that "acts_like?(:time)" it is coerced to integer thus losing
it's microsecond percision.

This commits changes this to use `#to_f` to prevent the problem
 2013-07-09 13:43:56 +01:00
Rafael Mendonça França
1a6eb1e560 Merge pull request #11372 from wangjohn/fixing_rails_commands_class 
Using the instance variable for argv.
 2013-07-09 05:25:34 -07:00
wangjohn
0c5d8f813c Using the instance variable for argv. 
Instead of using the global constant ARGV, we're changing to using the
instance variable because it is more testable.
 2013-07-09 08:21:54 -04:00
Rafael Mendonça França
1ccbf7d76a Merge pull request #11375 from namusyaka/fix_attribute_for_inspect 
Fix: attribute_for_inspect truncate upto (51 => 50) characters.
 2013-07-09 04:44:43 -07:00
namusyaka
a8bd220768 Fix: attribute_for_inspect truncate upto (51 => 50) characters. 2013-07-09 20:01:48 +09:00
Rafael Mendonça França
f9fec4f46b Merge pull request #11174 from vipulnsward/remove_column_passing 
Stop sending column info to `substitute_at` as it doesn't get utilized.
 2013-07-09 02:58:15 -07:00
Rafael Mendonça França
6f014b346f Merge pull request #11073 from tricknotes/improve-guides-js 
Improve guides js
 2013-07-09 02:47:04 -07:00
Rafael Mendonça França
76e95c0ce8 Merge pull request #11143 from robin850/upgrading-rails 
Add few information about missing steps [ci skip]
 2013-07-09 02:40:57 -07:00
Rafael Mendonça França
90d1a3f723 Merge pull request #11354 from jadeatucker/cache_exists_should_return_boolean 
cache.exists? should return true/false
 2013-07-09 01:56:45 -07:00
Rafael Mendonça França
ae85a4aa98 Merge pull request #11351 from jetthoughts/cleanup_request 
Use content_length method instead of ENV['CONTENT_LENGTH'].to_i
 2013-07-09 01:47:43 -07:00
Rafael Mendonça França
590c9d418a Merge pull request #11353 from jetthoughts/revert_to_raw_post 
Use Request#raw_post instead Request#body in ParamsParser#parse_formatted_parameters
 2013-07-09 01:35:33 -07:00
Rafael Mendonça França
74da4d1ad2 Merge pull request #11361 from jetthoughts/add_cursor_pointer_for_menu 
Added cursor pointer for 'More Ruby on Rails' dropdown menu on guides page (which appear on small windows)
 2013-07-09 01:07:23 -07:00
Rafael Mendonça França
449b5f3ed8 Merge pull request #11368 from Amit-Thawait/master 
Fixed Travis CI link for rails
 2013-07-09 01:00:25 -07:00
Rafael Mendonça França
6e53bcfe99 Merge pull request #11373 from vipulnsward/remove_deprecated_test 
Remove redundant test about `push_with_attributes` removal.
 2013-07-09 00:57:57 -07:00
Amit Thawait
d92d28dde1 link break added after the Travis CI link 
link break added after the Travis CI link
 2013-07-09 11:35:12 +05:30
Vipul A M
fd2ddb3eb8 Remove redundant test about push_with_attributes removal. 2013-07-09 11:02:13 +05:30
Aaron Patterson
16e4d013d8 close our connection when we are done 2013-07-08 16:36:46 -07:00
Aaron Patterson
2e0b0c1dab remove dead code 2013-07-08 16:30:10 -07:00
Aaron Patterson
b0c0e9f38b if we remove the connection from the pool, we should close it 2013-07-08 16:21:47 -07:00
Aaron Patterson
e5f0c0c548 use latches rather than mucking with the scheduler 2013-07-08 16:10:57 -07:00
Rafael Mendonça França
dfb017274f Merge pull request #11371 from arunagw/actionview-changes 
Actionview changes
 2013-07-08 15:13:37 -07:00
Arun Agrawal
d6da0dc3f2 Removed unused require from actionview rakefile. 2013-07-09 00:10:24 +02:00
Arun Agrawal
0d534b8aae Fixed broken rake task for update_version [ci skip] 
Also added actionview to update version rake task
 2013-07-09 00:10:15 +02:00
Arun Agrawal
e80844505a actionview should be able to install using install.rb [ci skip] 2013-07-09 00:10:07 +02:00
Rafael Mendonça França
070cff713e Merge pull request #11370 from dpdawson/master 
Fix a grammatical error/typo in Active Record Migrations guide. [ci skip]
 2013-07-08 15:04:36 -07:00
Daniel Dawson
e863410b58 Fix a grammatical error/typo in Active Record Migrations guide. [ci skip] 2013-07-08 22:56:09 +01:00
Aaron Patterson
24c4195bab refactor to_sql so it does not depend on the to_sql implementation of 
the connection
 2013-07-08 14:31:10 -07:00
Amit Thawait
d78f8c8c7f Fixed broken link of Travis CI for rails and added full path 2013-07-08 12:49:36 -07:00
Rafael Mendonça França
b025fca0c5 Merge pull request #11355 from wangjohn/class_for_rails_commands 
Creating a class for carrying out rails commands.
 2013-07-08 08:39:34 -07:00
Rafael Mendonça França
61f5fba722 Merge pull request #11367 from artemeff/sass_in_notes 
handle notes in *.sass files
 2013-07-08 08:34:50 -07:00
Yuri Artemev
dd996ad394 handle notes in *.sass files 2013-07-08 19:13:01 +04:00
Carlos Antonio da Silva
daf4387f42 Merge pull request #11363 from dpdawson/master 
Fix 2 grammatical errors/typos in Active Record Basics guide. [ci skip]
 2013-07-08 06:20:16 -07:00
Daniel Dawson
a8b1eca2d8 Fix 2 grammatical errors/typos in Active Record Basics guide. [ci skip] 2013-07-08 12:25:10 +01:00
Paul Nikitochkin
448ed61b8d Added cursor pointer for 'More Ruby on Rails' 
dropdown menu on guides page (which appear on small windows)
[ci skip]
 2013-07-08 11:52:52 +03:00
Yves Senn
4be2003778 Merge pull request #11359 from willnet/patch-1 
Update 'Active Record Migrations' guide [ci skip]
 2013-07-08 01:46:59 -07:00
Akira Matsuda
f573df32d4 Fix SyntaxError in guides sample code 
[ci skip]
 2013-07-08 17:21:45 +09:00
Akira Matsuda
874fbdaad6 1.9 Hash Syntax 2013-07-08 17:21:25 +09:00
Akira Matsuda
19df76f75e params keys are Strings 2013-07-08 17:21:25 +09:00
Shinichi Maeshima
f6b75ff377 Update 'Active Record Migrations' guide [ci skip] 
Delete an unneeded line.
 2013-07-08 16:44:42 +09:00
wangjohn
f1f249d836 Creating a class for carrying out rails commands. 
This class encapsulates a lot of logic that wasn't very object oriented.
Helper methods have been created to try to make things more logical and
easy to read.
 2013-07-07 23:15:55 -07:00
Jade Tucker
8471fc0363 Explicitly test for true and false. 2013-07-07 18:59:32 -07:00
Jade Tucker
cad2c8f579 cache.exists? should return true/false 2013-07-07 15:50:22 -07:00
Paul Nikitochkin
f6746c0245 Use Request#raw_post instead Request#body 
In order to get raw_post to be not empty after
ParamsParser#parse_formatted_parameters,
added rewinding of body stream input on parsing json params.

Closes #11345
 2013-07-08 01:48:35 +03:00
Paul Nikitochkin
c61b3ce0f5 Use helper method to get ENV['CONTENT_LENGTH'] 2013-07-08 00:11:57 +03:00
Rafael Mendonça França
b18a27375a Add CHANGELOG entry for #11348 2013-07-07 14:26:20 -03:00
Rafael Mendonça França
9eeb3cc040 Merge pull request #11348 from sanemat/fix/link-to-block 
Fix actionview link_to with block and url_hash
 2013-07-07 10:02:39 -07:00
Rafael Mendonça França
09f6fe1cd4 Fix "Stack Level Too Deep" error when rendering recursive partials 
When rendering recursive partial Action View is trying to generate the
view digest infinitly causing a stack level error.

Fixes #11340
 2013-07-07 13:44:16 -03:00
sanemat
bcc30d8f2f Include block in a argument shift 2013-07-08 00:35:14 +09:00
Rafael Mendonça França
a67cc28311 Merge pull request #11347 from ankit8898/refactoring-sp 
Refactored strong parameters usage and updated Gemfile.lock with Rails 4
 2013-07-07 08:26:11 -07:00
Rafael Mendonça França
3e953d48a2 Merge pull request #11317 from ma2gedev/enforcer_tag_option 
Added an `enforce_utf8` hash option for `form_tag` method
 2013-07-07 08:20:25 -07:00