TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
3,950 Commits 2 Branches 0 Tags 294 MiB
5048aa9831
Commit Graph

367 Commits

Author SHA1 Message Date
David Heinemeier Hansson
5048aa9831 Deprecated old render parameter calls 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4947 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-03 23:02:56 +00:00
David Heinemeier Hansson
268c1dee8f Require action mailer more gracefully 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4944 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-03 22:43:24 +00:00
David Heinemeier Hansson
4bd444c1fe More deprecation fun 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4943 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-03 22:35:31 +00:00
David Heinemeier Hansson
f12fdc50a6 Better compartmentalizing of assertions 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4931 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-03 20:18:06 +00:00
David Heinemeier Hansson
3142502964 Added assert_select* for CSS selector-based testing (deprecates assert_tag) #5936 [assaf.arkin@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4929 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-03 19:54:21 +00:00
Jeremy Kemper
db9be58719 Cleanup assert_tag :children counting. Closes #2181. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4915 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-03 16:40:01 +00:00
Rick Olson
2b45e2d370 Add routing tests to assert that RoutingError is raised when conditions aren't met. Closes #6016 [Nathan Witmer] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4907 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-02 20:41:40 +00:00
Nicholas Seckar
d34a346d9d Switch to using FormEncodedPairParser for parsing request parameters. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4866 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-30 05:50:02 +00:00
Tobias Lütke
ff063d700d respond_to .html now always renders #{action_name}.rhtml so that registered custom template handlers do not override it in priority. 
Custom mime types require a block and throw proper error now.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4860 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-30 00:34:36 +00:00
David Heinemeier Hansson
d164d09649 FormEncodedStringParser needs a tad more work before it can handle POST data (like file handling), so were backing out for a bit 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4833 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-28 14:05:05 +00:00
Jeremy Kemper
96c6ca369a Deprecation: test deprecated instance vars in partials. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4824 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-26 05:58:16 +00:00
David Heinemeier Hansson
7b34d0f8c5 Actually, indifferent access mattered in the bowels (hashes hidden in arrays) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4823 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-26 03:09:32 +00:00
David Heinemeier Hansson
a78519071c Result is made indifferent on the way out 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4822 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-26 02:58:55 +00:00
David Heinemeier Hansson
04fda65306 Changed the POST parameter processing to use the new QueryStringParser and make the result a indifferent hash [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4821 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-26 02:49:09 +00:00
David Heinemeier Hansson
9e054fdf41 More tests for array/hashing in parameters, one failing 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4820 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-26 01:57:44 +00:00
Nicholas Seckar
3b1972a896 Add UrlWriter to allow writing urls from Mailers and scripts. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4814 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-24 06:15:01 +00:00
Nicholas Seckar
caf546b675 Add test case from ticket #4090 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4805 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-22 07:18:24 +00:00
Nicholas Seckar
7678d123a7 Relax Routing's anchor pattern warning; it was preventing use of [^/] inside restrictions. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4763 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-15 02:04:11 +00:00
Nicholas Seckar
5baf7462c7 Add controller_paths variable to Routing; Assign Routing.controller_paths from initializer; fix script/about and rails info controller. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4762 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-15 01:28:06 +00:00
Rick Olson
8c4b599b7c Fix assert_redirected_to issue with named routes for module controllers. [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4757 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-13 18:31:58 +00:00
Nicholas Seckar
84bacf99d6 Invoke method_missing directly for hidden actions. Closes #3030. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4755 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-13 04:15:22 +00:00
Jeremy Kemper
c3cdd3b659 Deprecation: check whether instance variables have been monkeyed with before assigning them to deprecation proxies. Raises a RuntimeError if so. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4717 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-07 21:58:31 +00:00
Jeremy Kemper
c40b1a4a67 Deprecate direct usage of @params. Update ActionView::Base for instance var deprecation. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4715 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-07 12:40:14 +00:00
Jeremy Kemper
2399a223c3 Deprecation! @session and @flash will be removed after 1.2. Use the session and flash methods instead. You'll get printed warnings during tests and logged warnings in dev mode when you access either instance variable directly. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4699 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-07 06:11:56 +00:00
Nicholas Seckar
127ee8c8f8 Make Routing noisy when an anchor regexp is assigned to a segment. Closes #5674 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4677 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-05 22:12:50 +00:00
David Heinemeier Hansson
5130fc84c6 Remove duplicate routes from mapped resources (closes #5712) [eigentone@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4669 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-05 20:46:49 +00:00
Jeremy Kemper
12ab93b72b Make controller_path available as an instance method. Closes #5724. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4664 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-05 01:56:58 +00:00
David Heinemeier Hansson
2d6ca64c45 Make us pass to ease RESTful children posts 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4659 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-04 00:45:09 +00:00
David Heinemeier Hansson
6e842f216c Make us pass to ease RESTful children posts 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4658 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-04 00:15:09 +00:00
Marcel Molina
d17bd6a043 Make action caching aware of different formats for the same action so that, e.g. foo.xml is cached separately from foo.html. Implicitly set content type when reading in cached content with mime revealing extensions so the entire onous isn't on the webserver. PDI MORE CACHING TESTS [Marcel Molina Jr.] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4656 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-03 23:59:38 +00:00
Rick Olson
58b996f9b0 Restrict Request Method hacking with ?_method to POST requests. [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4644 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-01 03:02:31 +00:00
Jeremy Kemper
c9417dcef3 Nested resource testing. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4643 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-01 01:23:06 +00:00
Jeremy Kemper
a247d72139 Nesting map.resources 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4642 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-01 00:29:02 +00:00
Rick Olson
78e37f45c6 Fix bug when passing multiple options to SimplyRestful, like :new => { :preview => :get, :draft => :get }. [Rick Olson, Josh Susser, Lars Pind] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4641 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-07-31 21:57:59 +00:00
Rick Olson
d2eafa8b73 Dup the options passed to map.resources so that multiple resources get the same options. [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4639 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-07-31 20:32:48 +00:00
Rick Olson
ed4c295c47 Fixed the new_#{resource}_url route and added named route tests for Simply Restful. [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4638 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-07-31 20:00:18 +00:00
David Heinemeier Hansson
865b175765 Added map.resources from the Simply Restful plugin (backwards incompatible with the plugin!) [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4637 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-07-31 18:59:58 +00:00
Rick Olson
04d9e94e88 Fixed that you can still access the flash after the flash has been reset in reset_session. Closes #5584 [lmarlow@yahoo.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4617 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-07-22 02:31:21 +00:00
Jeremy Kemper
71234daef1 r4487@asus: jeremy | 2006-04-29 12:21:39 -0700 
Check whether @flash is defined? for warnings-safety.
 r4488@asus:  jeremy | 2006-04-29 12:23:15 -0700
 Check whether @flash is defined? for warnings-safety. Obviates nil? check.
 r4489@asus:  jeremy | 2006-04-29 12:45:18 -0700
 Check whether @session is defined? for warnings-safety.
 r4490@asus:  jeremy | 2006-04-29 12:50:41 -0700
 Check whether @rendering_runtime is defined? for warnings-safety.
 r4491@asus:  jeremy | 2006-04-29 12:55:01 -0700
 Check whether @_cycles is defined? for warnings-safety.
 r4492@asus:  jeremy | 2006-04-29 12:59:19 -0700
 Check whether instance variables are defined? for warnings-safety.
 r4493@asus:  jeremy | 2006-04-29 13:14:09 -0700
 Add nil @template to PrototypeHelperTest to suppress unitialized instance variable warning.
 r4494@asus:  jeremy | 2006-04-29 13:31:34 -0700
 Check whether @auto_index defined? for warnings-safety.
 r4495@asus:  jeremy | 2006-04-29 13:32:24 -0700
 Wrap content_columns redefinitions with silence_warnings.
 r4496@asus:  jeremy | 2006-04-29 13:35:28 -0700
 Wrap more redefinitions with silence_warnings.
 r4829@asus:  jeremy | 2006-07-08 10:59:20 -0700
 abstract unit, fix warnings
 r4830@asus:  jeremy | 2006-07-08 11:06:12 -0700
 Use parens to silence warning.
 r4831@asus:  jeremy | 2006-07-08 11:06:48 -0700
 Use parens to silence warning.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4595 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-07-08 18:14:49 +00:00
David Heinemeier Hansson
11c715a53f Added exception handling of missing layouts (closes #5373) [chris@ozmm.org] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4550 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-07-05 02:38:55 +00:00
Jeremy Kemper
d0526ede40 r4748@asus: jeremy | 2006-06-29 22:40:35 -0700 
Loosen urlencoded content type check.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4524 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-30 05:41:03 +00:00
Nicholas Seckar
e494b0a441 Add route_name_path method to generate only the path for a named routes. For example, map.person will add person_path. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4518 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-30 02:36:17 +00:00
Jeremy Kemper
bbc1351344 Determine the correct template_root for deeply nested components. Closes #2841. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4474 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-21 00:31:43 +00:00
Rick Olson
2bbcff8cf4 Fix that routes with *path segments in the recall can generate URLs. [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4454 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-17 00:25:24 +00:00
David Heinemeier Hansson
36dc94a6a1 Added Hash.create_from_xml(string) which will create a hash from a XML string and even typecast if possible [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4453 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-16 10:07:13 +00:00
Rick Olson
2f58a467e3 add passing test to make sure unhandled requests don't load unnecessary classes. Closed #5408. [nkriege@hotmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4451 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-16 03:22:09 +00:00
Jamis Buck
816d67b104 Make sure passed routing options are not mutated by routing code. (closes #5314) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4444 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-07 16:27:14 +00:00
Jamis Buck
ae7029ddd1 Do some path normalization to prevent the possible_controllers list from containing invalid entries 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4443 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-07 16:16:37 +00:00
Jamis Buck
4e3543b467 Make sure named routes are never generated relative to some containing module 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4442 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-06 19:09:56 +00:00
Jamis Buck
e768dc694d Improve parameter expiry handling to fix sticky-id issue. Add a more informative Route#to_s method. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4441 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-06 17:59:54 +00:00