Commit Graph

18119 Commits

Author SHA1 Message Date
Xavier Noria
b7e7e56eb7 Merge remote branch 'docrails/master' 2010-08-14 13:22:41 +02:00
Subba Rao Pasupuleti
e516378410 Adding missing required statement
[#5056 state:resolved]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-08-14 13:17:32 +02:00
Santiago Pastorino
9dc88aba47 Fixes some ActionMailer tests 2010-08-14 13:17:32 +02:00
Santiago Pastorino
b95d6e84b0 Deletes trailing whitespaces (over text files only find * -type f -exec sed 's/[ \t]*$//' -i {} \;) 2010-08-14 13:17:32 +02:00
Santiago Pastorino
36a84a4f15 Makes AR use AMo to_key implementation
[#5249]
2010-08-14 13:17:31 +02:00
Santiago Pastorino
48c7ad17b0 This method is actually not used, it's implemented on the concrete adapters
[#5331 state:committed]
2010-08-14 13:17:31 +02:00
Aaron Patterson
22b9bbc828 converting to a symbol is not necessary 2010-08-14 13:17:31 +02:00
Prem Sichanugrist
6a14eee918 Removing most of the symbol to proc usage in Active Record
This will hopefully make Active Record run a bit more faster.
2010-08-14 13:17:31 +02:00
Aaron Patterson
cfbfb86730 removing a lolinject 2010-08-14 13:17:31 +02:00
Santiago Pastorino
4c2bbe9a1a Moves local_request? to require.local?
[#5361 state:committed]
2010-08-14 13:17:31 +02:00
Aaron Patterson
e8ffe7d6b6 avoid direct use of arel constants 2010-08-14 13:17:30 +02:00
Aaron Patterson
c8d5ee3e9e removing references to arel constants 2010-08-14 13:17:30 +02:00
Aaron Patterson
d6c84845b3 avoiding symbol to proc again 2010-08-14 13:17:30 +02:00
Aaron Patterson
6c50ad0234 do not use arel constants directly 2010-08-14 13:17:30 +02:00
Aaron Patterson
5baf75b650 symbol to proc is slow, we should avoid it 2010-08-14 13:17:30 +02:00
Jeremy Kemper
17a6dfb745 It's snowing! 2010-08-14 13:17:30 +02:00
Subba Rao Pasupuleti
f8f437191f no callbacks should be created for empty array [#5289 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-14 13:17:30 +02:00
Subba Rao Pasupuleti
b61ff257e9 tidy up validations length code [#5297 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-14 13:17:29 +02:00
Greg Campbell
1577eafe77 Add missing ActiveModel::Validations require
[#5311 state: resolved]

ActiveModel::Validations uses Hash#except, but does not require it from
ActiveSupport.  (This wasn't showing up in the tests, because it was
required in the helper, and was also required in
ActiveModel::Serialization).

Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-14 13:17:29 +02:00
Neeraj Singh
8fdecaaef2 Ensure we can nest include calls [#5285 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-14 13:17:29 +02:00
Subba Rao Pasupuleti
b7fdc937fa Adding missing required statement
[#5056 state:resolved]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-08-14 06:27:15 -03:00
Santiago Pastorino
0a22576970 Fixes some ActionMailer tests 2010-08-14 05:58:34 -03:00
Santiago Pastorino
b451de0d6d Deletes trailing whitespaces (over text files only find * -type f -exec sed 's/[ \t]*$//' -i {} \;) 2010-08-14 04:12:33 -03:00
Santiago Pastorino
535082fe3e deprected -> deprecated 2010-08-14 03:55:14 -03:00
Santiago Pastorino
1590377886 Makes AR use AMo to_key implementation
[#5249]
2010-08-13 22:26:44 -03:00
Santiago Pastorino
27fb88aa22 This method is actually not used, it's implemented on the concrete adapters
[#5331 state:committed]
2010-08-13 21:19:47 -03:00
Aaron Patterson
be5d1608cb converting to a symbol is not necessary 2010-08-13 16:50:31 -07:00
Prem Sichanugrist
a7eb8d97a4 Removing most of the symbol to proc usage in Active Record
This will hopefully make Active Record run a bit more faster.
2010-08-13 16:24:49 -07:00
Aaron Patterson
1f250415fe removing a lolinject 2010-08-13 14:45:57 -07:00
Santiago Pastorino
919888503d Moves local_request? to require.local?
[#5361 state:committed]
2010-08-13 17:35:52 -03:00
Aaron Patterson
b9eec677c4 avoid direct use of arel constants 2010-08-13 13:33:08 -07:00
Aaron Patterson
af3e39358c removing references to arel constants 2010-08-13 12:37:18 -07:00
Aaron Patterson
e18bd86314 avoiding symbol to proc again 2010-08-13 12:37:07 -07:00
Aaron Patterson
4439e57ee0 do not use arel constants directly 2010-08-13 12:37:03 -07:00
Aaron Patterson
5651e4c835 symbol to proc is slow, we should avoid it 2010-08-13 12:36:59 -07:00
Jeremy Kemper
c49144b2f7 It's snowing! 2010-08-12 13:32:00 -07:00
Mark Hayes
b680d153d2 in Rendering objects with RecordIdentifier example, locals should reference @account not @buyer 2010-08-12 12:52:17 -07:00
Xavier Noria
fddcd21bd1 be more precise re :validate and :autosave 2010-08-12 19:31:47 +02:00
Xavier Noria
08c37ebf6f be more precise re :validate and :autosave 2010-08-12 19:30:51 +02:00
Subba Rao Pasupuleti
ef0da581e9 no callbacks should be created for empty array [#5289 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-12 13:12:26 -03:00
Subba Rao Pasupuleti
e82b38cd57 tidy up validations length code [#5297 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-12 13:12:03 -03:00
Greg Campbell
90a7915ab2 Add missing ActiveModel::Validations require
[#5311 state: resolved]

ActiveModel::Validations uses Hash#except, but does not require it from
ActiveSupport.  (This wasn't showing up in the tests, because it was
required in the helper, and was also required in
ActiveModel::Serialization).

Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-12 13:11:48 -03:00
Neeraj Singh
6ed1ba472e Ensure we can nest include calls [#5285 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-12 13:10:58 -03:00
Xavier Noria
4134d7db34 Merge remote branch 'docrails/master' 2010-08-12 17:36:09 +02:00
Xavier Noria
8af2186d26 revises some autosave docs, style and content 2010-08-12 17:31:04 +02:00
Paco Guzman
8a2b69b727 applied guidelines to "# =>" 2010-08-12 17:09:58 +02:00
José Valim
e4943e93c2 Make update_attribute behave as in Rails 2.3 and document the behavior intrinsic to its implementation. 2010-08-12 12:04:16 -03:00
Xavier Noria
599c505837 commit review: applies guidelines to "# =>" 2010-08-12 16:41:34 +02:00
Neeraj Singh
cfad74cfef updating documentation for named_scope and default_scope 2010-08-12 10:23:20 -04:00
Mark Turner
1049bae132 fixed indentation in test cases
Signed-off-by: wycats <wycats@gmail.com>
2010-08-11 23:55:53 -07:00