Commit Graph

2535 Commits

Author SHA1 Message Date
Santiago Pastorino
5132081975 AS gem doesn't depend on nokogiri so shows a nicer error if users haven't installed 2010-07-30 16:05:51 -03:00
Santiago Pastorino
95e9ced581 Make options an attr_reader 2010-07-30 12:09:47 -03:00
Carl Lerche
d277b823d0 Add another missing require in 'active_support/inflector/inflections' 2010-07-29 22:53:21 -07:00
Xavier Noria
ccd45618ed Merge remote branch 'rails/master' 2010-07-30 02:35:24 +02:00
Xavier Noria
755af49755 edit pass to apply API guideline wrt the use of "# =>" in example code 2010-07-30 02:30:04 +02:00
Neeraj Singh
3c3ff1377d Adding documentation regarding lazy_load_hooks 2010-07-29 13:05:54 -04:00
Carl Lerche
d04c6f2ff6 Add a missing require in 'active_support/core_ext/string/inflections' 2010-07-29 08:51:23 -07:00
Neeraj Singh
627d870c92 itsy bitsy changes to documentation 2010-07-28 22:44:32 -04:00
José Valim
7c3d479c4b More documentation to class_attribute. 2010-07-28 08:49:54 -07:00
Neeraj Singh
dea8bf5dc4 editing the documentation regarding :race_condition_ttl and :expires_in option in AS cache 2010-07-28 11:22:35 -04:00
Neeraj Singh
2d601e4ea3 editing a sentence 2010-07-28 10:56:10 -04:00
Neeraj Singh
5b10e47593 adding comment specifying that cattr_accessor also supports instance_write and instance_rader option 2010-07-28 10:13:11 -04:00
Neeraj Singh
eb902d6c00 clarifying the instance_write option with an example 2010-07-28 10:08:00 -04:00
Neeraj Singh
ff7e17d33e adding some comments to cattr_accessor method 2010-07-28 10:05:10 -04:00
Neeraj Singh
f3b50b11c7 updating description of how class_attribute works 2010-07-28 09:53:38 -04:00
Neeraj Singh
4952a80200 adding test for respond_to cache_key and cleaning up the ENV settings 2010-07-28 21:02:45 +08:00
Neeraj Singh
7d29627be9 test cases for rails_app_version in AS cache.rb 2010-07-28 21:02:45 +08:00
Neeraj Singh
3265af5c8b adding more test cases for expand_cache_key 2010-07-28 21:02:44 +08:00
Neeraj Singh
194ec3d165 removing unused variable 2010-07-28 21:02:44 +08:00
Xavier Noria
e17e08efef adds test coverage for edge-cases of Array.wrap, and better documentation for how it differs from Kernel#Array 2010-07-28 03:49:04 +02:00
Neeraj Singh
e7920a3bde clarifying description for class_attribute method 2010-07-27 16:30:56 -04:00
Neeraj Singh
f3409dc0a0 polishing comments 2010-07-26 23:35:15 -04:00
Neeraj Singh
d214925625 making comments meaningful by correcting, adding and pruning 2010-07-26 23:03:46 -04:00
Neeraj Singh
b357aedbf6 making comments have a consistent theme of narrative 2010-07-26 22:41:13 -04:00
Santiago Pastorino
a2ca9cb78d This is a hash in 1.9.2 2010-07-26 20:09:34 -03:00
David Heinemeier Hansson
856fc4bbc3 Prep for RC 2010-07-26 12:53:25 -05:00
Aaron Patterson
32844cbc02 fixing space errors 2010-07-26 09:58:35 -07:00
Leigh Caplan
37d82f2ca0 Test to ensure that falsy objects aren't wrapped by deprecation proxies 2010-07-26 09:53:42 -07:00
Leigh Caplan
e56c9ef08d Override new on proxy objects so that they never wrap nil or false. 2010-07-26 09:53:42 -07:00
Bernerd Schaefer
e87e3db200 XmlMini.rename_key emits valid xml with dasherize
This resolves issues for libraries which use '_' prefixed keys in their
attributes hash, such as Mongoid. A key like "_id" or "_type" will no
longer be converted to "<-id>" and "<-type>".

Signed-off-by: wycats <wycats@gmail.com>
2010-07-26 09:48:22 -07:00
Santiago Pastorino
4ea1753fc2 This is for making sure const_missing is triggered without warnings 2010-07-26 12:51:52 -03:00
Neeraj Singh
78c8242d2f strengthening the test suite for rescue_from
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-07-26 16:48:50 +02:00
Neeraj Singh
a5bb1f511f strengthening the rescue_from test suites
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-07-26 16:48:45 +02:00
wycats
1b97701e51 Fix a bug where requires inside of autoloads were being added to the autoloaded_constants list, causing mayhem. [#5165 state:resolved] 2010-07-26 00:59:54 -07:00
Aaron Patterson
53fbbf4b83 fisting warning 2010-07-25 16:28:21 -07:00
Xavier Noria
6aa1253588 Merge remote branch 'docrails/master' 2010-07-26 00:23:57 +02:00
Xavier Noria
dcb7832ed5 APIs for individual components are no longer published 2010-07-26 00:05:14 +02:00
Santiago Pastorino
9a32af96d1 CHANGELOG updated Object#returning removed
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-07-25 23:30:36 +02:00
Santiago Pastorino
b0b9bf3204 Object#returning removed
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-07-25 23:30:27 +02:00
José Valim
ff0d842454 Revert the previous three commits.
* AS::Notifications#instrument should not measure anything, it is not its responsibility;

* Adding another argument to AS::Notifications#instrument API needs to be properly discussed;
2010-07-25 20:46:42 +02:00
Aaron Patterson
b7e0408ca9 use a hash to collect optional statistics about the instrumentation 2010-07-25 11:11:23 -07:00
Santiago Pastorino
b1cfcedc8f Change returning with tap
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-07-25 16:33:04 +02:00
Santiago Pastorino
749948a264 Removing one AS/lib ruby and rake adds to $LOAD_PATH 2010-07-25 08:27:00 +08:00
José Valim
834bd23a07 Get rid of instrumenter.elapsed. 2010-07-24 10:22:22 +02:00
Santiago Pastorino
85980852a0 make a throwaway value equals to _ to avoid warnings
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-07-24 01:19:55 +02:00
Santiago Pastorino
8289661903 Make this test, test again
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-07-24 01:19:47 +02:00
Santiago Pastorino
e1d4e78b15 Removes unused vars
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-07-24 01:19:44 +02:00
Santiago Pastorino
80cf6559ed Makes restore previosly saved warnings_on_first_load value and avoid warning
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-07-24 01:19:43 +02:00
Neeraj Singh
8429e7b45b making comments sentence more concise 2010-07-23 16:22:17 -04:00
Neeraj Singh
46c7a991a2 fixing typo 2010-07-23 16:14:16 -04:00