TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
40,802 Commits 2 Branches 0 Tags 294 MiB
5487f62741
Commit Graph

200 Commits

Author SHA1 Message Date
Rafael Mendonça França
5487f62741 Use the right indentation 2013-11-19 22:53:32 -02:00
Rafael Mendonça França
ed7e4932f4 Renderer#_render_template should be private 
Closes #12831
 2013-11-19 22:52:06 -02:00
Mac Martine
6251eb992f Improve readability of sentence in partial-renderer docs [ci skip] 2013-11-19 15:46:00 -08:00
Shimpei Makimoto
1e848906c5 Use set_backtrace instead of @backtrace in ActionView error 2013-11-16 04:41:28 +09:00
Rafael Mendonça França
f6f4bed34d Merge pull request #12853 from joshjordan/master 
Allocate one less object using html_safe during content_tag construction
 2013-11-15 09:45:14 -08:00
Andrey Ognevsky
d04c4fac3b Take Hash with options inside Array in #url_for 2013-11-15 15:50:42 +04:00
Josh Jordan
ea6640d05d Allocate one less object using html_safe during content_tag construction 2013-11-14 23:51:40 -05:00
David Heinemeier Hansson
07996ebc50 Revert "Used Yield instead of block.call" -- this causes all of atom_feed_helper_test.rb to fail with "SystemStackError: stack level too deep". 
This reverts commit d3a1ce1cdc60d593de1682c5f4e3230c8db9a0fd.
 2013-11-14 15:31:27 -08:00
Rafael Mendonça França
84961dc5df Merge pull request #12889 from kuldeepaggarwal/speed_ups 
Used Yield instead of block.call
 2013-11-14 11:29:28 -08:00
Kuldeep Aggarwal
d3a1ce1cdc Used Yield instead of block.call 2013-11-15 00:53:57 +05:30
Saulius Grigaliunas
07d99335b3 Fix syntax error in atom_feed example [ci skip] 
Builder's #tag! takes either String or Symbol as the first parameter
 2013-11-13 13:56:13 +02:00
Rafael Mendonça França
452d746006 Make the method name the first argument 
This is the only argument that changes over the method calls so it is
better to it be the first one
 2013-11-09 18:28:32 -02:00
Rafael Mendonça França
87d0bde03f Drop one more string allocation 2013-11-09 18:28:32 -02:00
Carlos Antonio da Silva
5deec016fe Improve changelogs formatting [ci skip] 2013-11-09 16:44:58 -02:00
Yves Senn
675304b478 Merge pull request #12760 from pseidemann/master 
fix simple_format escapes own output when sanitize is set to true
 2013-11-09 04:07:50 -08:00
Vipul A M
5c0b9026ef Extract common code from number helpers to new delegator method. 2013-11-09 07:38:30 +05:30
pseidemann
881a2cc907 fix simple_format escapes own output when sanitize is set to true 2013-11-08 17:13:59 +01:00
Arun Agrawal
daf226abc8 sub! can return nil 
Revert "drop one more string allocation"

This reverts commit 4d15661d6c46c86a62ee1fc358f4b3ef9dd9f2ea.
 2013-11-07 20:08:32 +01:00
Aaron Patterson
4d15661d6c drop one more string allocation 2013-11-06 14:46:14 -08:00
Aaron Patterson
68b7e381f1 drop string allocations in the log subscriber 2013-11-06 14:37:30 -08:00
Rafael Mendonça França
256ae7dec5 Merge pull request #12788 from kylefritz/patch-1 
rdoc: favicon source shouldn't begin with a slash to reference asset pipeline resource [ci skip]
Conflicts:
	actionview/lib/action_view/helpers/asset_tag_helper.rb
 2013-11-06 17:38:34 -02:00
Alex Johnson
01ef2c1943 Refactor File.expand_path usage to remove additional File.join 2013-11-05 10:50:03 +05:30
David Heinemeier Hansson
2b66f556ed Line up the comments for aesthetics 2013-11-03 12:53:48 -08:00
Arun Agrawal
816126862e Warnings removed for ruby trunk 
Same as 4d4ff531b8807ee88a3fc46875c7e76f613956fb
 2013-11-01 09:49:57 +01:00
Jérémy Lecour
cdf74eb5a0 Fix typo in the CHANGELOG 2013-10-31 15:29:16 +01:00
Carsten Zimmermann
805a6cc564 Convert CDATA input to string before gsub'ing 
Rails 3.2 API allowed arbitrary input for cdata_section;
this change re-introduces the old behaviour.
 2013-10-29 18:17:57 +01:00
Rafael Mendonça França
86f287e6cf Remove warning of shadowing outer local variable 2013-10-27 20:18:08 -02:00
Rafael Mendonça França
a53f716706 Merge pull request #12636 from kongregate/dont_rescue_Exceptions 
Avoid unnecessary catching of Exception instead of StandardError (conver...
 2013-10-24 16:48:32 -07:00
stopdropandrew
54f485248c Avoid unnecessary catching of Exception instead of StandardError (converting Exceptions into StandardErrors) 2013-10-24 16:43:27 -07:00
Rafael Mendonça França
6c570648ad Merge pull request #10471 from andyw8/button_to_params 
Add params option for button_to

Conflicts:
	actionpack/CHANGELOG.md
 2013-10-24 18:02:19 -02:00
Rafael Mendonça França
b2ea0ff572 Ensure the state is clean after one failure 2013-10-16 19:43:10 -03:00
Rafael Mendonça França
c44f8d255b Merge pull request #12540 from wyaeld/bug/fix-recursive-digest 
Ensure ActionView::Digestor.cache is correctly cleaned up
 2013-10-16 19:41:16 -03:00
Adam Jahnke
065d3e061d Fix typo in form_helper.rb 2013-10-16 16:09:09 -05:00
Brad Murray
0cdce7f910 add a new local variable to track if digests are being stored, to ensure the cleanup works correctly 2013-10-17 09:00:37 +13:00
Brad Murray
af1dc7f08a update digestor code based on review 2013-10-15 21:08:47 +13:00
Brad Murray
6c04cb2261 update changelog 2013-10-15 11:23:37 +13:00
Brad Murray
2b3a349123 Ensure ActionView::Digest.cache is correctly cleaned up when 
ActionView::Resolver.caching = false.
 2013-10-15 11:17:11 +13:00
Brad Murray
89969dd711 Add 2 tests, 1 of which fails, to isolate the digest_caching behaviour causing #12521 
If config.action_view.cache_template_loading = false, most likely in a development
configuration if config.cache_classes = false &
config.action_controller.perform_caching = true.

config.action_view.cache_template_loading defaults to the value of config.cache_classes
 2013-10-15 11:06:50 +13:00
Rafael Mendonça França
aa9101eb7e Merge pull request #12491 from shamanime/patch-1 
Fix wrong variable name used in the select_day method documentation
 2013-10-13 10:13:03 -07:00
Vipul A M
78c176e2fa Change map to map! to save extra array creation on new array 2013-10-13 20:58:50 +05:30
Jefferson Queiroz Venerando
97943f19b7 Fix wrong variable name used in the select_day method documentation 
The variable name created in the example is `my_date`, the methods  were using `my_time` instead.
 2013-10-10 10:34:14 -03:00
Arun Agrawal
64eb39a5b9 Moved viewpathstest into actionview/test/actionpack/controller 
These test were not running at all,
Now it will run as a tests part.
 2013-10-09 20:09:33 +02:00
Arun Agrawal
32b42e2620 FakeController is not required in AV 2013-10-09 19:30:44 +02:00
Rafael Mendonça França
874ca68f3d Merge pull request #12437 from websiteswithclass/master 
Fixed typo in documentation
 2013-10-04 06:40:01 -07:00
Arun Agrawal
e9bce34ddf Directory name in RUNNING_UNIT_TESTS.rdoc [ci skip] 2013-10-04 08:31:29 +02:00
Joseph Zidell
bf495069cb Fixed return strings in documentation 2013-10-03 18:30:42 -04:00
Joseph Zidell
58d64ddc46 Fixed typo in documentation 2013-10-03 16:57:18 -04:00
Arun Agrawal
9a16872aee Running all isolated test for actionview 
1. fix name for activerecord directory
2. Added actionpack directory to run tests
 2013-10-03 00:00:50 +02:00
Thomas von Deyen
1825f6fb60 Adds template dependencies rake task from cache_digests gem. 
This adds the rake tasks `cache_digests:dependencies` and `cache_digests:nested_dependencies` from `cache_digests` gem.
 2013-09-26 21:19:19 +02:00
Rafael Mendonça França
0cc4ff77cc Add CHANGELOG entry for #12344 
[ci skip]
 2013-09-24 21:07:24 -03:00