Commit Graph

93 Commits

Author SHA1 Message Date
Zachary Scott
b0cb4cad1e Merge pull request #19779 from jonatack/improve-contributing-to-ruby-on-rails-guide
Improve the Contributing to Rails Guide [skip ci]
2015-04-21 14:39:16 -04:00
Xavier Noria
e539866d80 capitalize title
According to the guidelines:

    http://guides.rubyonrails.org/ruby_on_rails_guides_guidelines.html#headings

References #19821.
2015-04-20 11:30:46 +02:00
yuuji.yaginuma
986753f73a correct link to Generic template [ci skip] 2015-04-20 14:13:47 +09:00
Godfrey Chan
0cfc34ae9a Consistency: Rails master -> edge Rails [ci skip] 2015-04-20 00:08:20 -04:00
Godfrey Chan
60cb61dba6 Fix typos in contributing guide [ci skip]
* includes -> include
* "on your computer" is implied
2015-04-19 23:43:18 -04:00
Godfrey Chan
b37845cc25 Better explain the bug report templates [ci skip] 2015-04-19 23:03:50 -04:00
Jon Atack
5c7b8d9f40 Improve the Contributing to Rails Guide [skip ci]
First commit:

This PR improves the "4.12 Commit Your Changes" section of the
Contributing to Ruby on Rails Guide:

- Fix formatting of the commit message example

- Improve readability and clarity

- Fix grammar

- Wrap lines

See the before and after images below in this PR.

-----

Second commit:

- Rewrite to remove the word "buffer" [skip ci]
2015-04-16 18:53:24 +05:30
Jon Atack
6345f31fbf Fix typos and improve the documentation
This is a squash of the following commits, from first to last:

-

Fix minor, random things I’ve come across lately that individually
did not seem worth making a PR for, so I saved them for one commit.

One common error is using “it’s” (which is an abbreviation of “it is”)
when the possessive “its” should be used for indicating possession.

-

Changes include the name of a test, so remove the `[skip ci]` (thanks @senny).

-

Line wrap the changes at 80 chars and add one more doc fix.

-

Add a missing line wrap in the Contributing to Ruby on Rails Guide.

-

Line wrap the `TIP` section in the Contributing to Ruby on Rails Guide as well.

Rendering the guide locally with `bundle exec rake guides:generate` did
not show any change in on-screen formatting after adding the line wrap.

The HTML generated is (extra line added to illustrate where the line
wrap takes place):

    <div class="info"><p>Please squash your commits into a single commit
when appropriate. This

    simplifies future cherry picks and also keeps the git log
clean.</p></div>

-

Squash commits.
2015-04-15 16:25:24 +05:30
Islam Wazery
2e1d69ea97 [ci skip] Update contributing guide 2015-04-12 16:23:42 +02:00
Joel Brewer
2730a22d31 [ci skip] Subject-verb agreement 2015-03-14 12:32:01 -05:00
Piotr Szotkowski
d69c7e66b3 Remove line wrapping from the benchmark/ips output
[ci skip]
2015-03-03 21:29:26 +01:00
Rafael Mendonça França
ef4afb65b2 Talk about Gemfile.lock in the contributing guide
[ci skip]
2015-02-18 16:37:43 -02:00
Brian Morearty
552e9e2299 Doc: run bundle update after cloning Rails. 2015-01-29 13:34:44 -08:00
Prathamesh Sonpatki
bd13ff68ef Changed "in GitHub" to "on GitHub" [ci skip]
- Followup of https://github.com/rails/rails/pull/18503.
2015-01-14 16:37:36 +05:30
Vipul A M
5cfaf5a46e - Changed IN to ON in markdown renderer condition
- Changed `IN` to `ON` in all note sentences in guides.
2015-01-14 11:52:13 +05:30
Robin Dupret
73fe108d70 Minor documentation edits [ci skip] 2014-12-28 22:55:09 +01:00
Xavier Noria
7702974281 warn about reading guides in GitHub
References #18148.
2014-12-23 23:32:50 +01:00
Sammy Larbi
f5489f9ab4 Clarify ActiveRecord testing guidelines [ci skip]
1. Specify that you need to create the test databases, and that no special
   Rails command needs to be run to do that.
2. Although the underscore style of `rake test_mysql` works, make the
   documentation of running the tests in RUNNING_UNIT_TESTS.rdoc
   consistent with the "Contributing..." guide.
3. Promote "Testing Active Record" to not be a subsection of
   "Running a Single Test," since it doesn't make sense as a subsection
   of that.
2014-12-21 10:18:46 -06:00
Brooks Reese
1a0e8e06b8 Fix sentence structure [ci skip] 2014-12-05 10:00:42 -06:00
Sergey Alekseev
872b6cc986 remove misleading class [ci skip] 2014-12-04 13:59:02 +03:00
Godfrey Chan
7bcffb5799 Oops, missed a closing bracket [ci skip] 2014-10-21 00:36:31 -07:00
Tu Hoang
8aa51b5def [ci skip] Provide more reasoning to not accept cosmetic changes 2014-10-21 14:24:10 +07:00
Guo Xiang Tan
c7bce61a22 [CI SKIP] Improve force push note. 2014-09-23 22:38:13 +08:00
Prathamesh Sonpatki
6aa11fbb1a Added note about updating pull requests by force push
- Added note about force pushing same branch to update a existing pull
  request instead of opening new one in contributing guide.
- [ci skip]
2014-09-23 18:15:30 +09:00
José Valim
57f5b00ba4 Remove more references to respond_with 2014-08-17 13:20:23 -04:00
Yves Senn
ce14ebe6b4 docs, add example for running a single test against core adapters.
[ci skip]
2014-07-22 08:41:25 +02:00
Nishant Modak
da5ac71885 correct markdown usage [ci skip] 2014-07-09 01:32:44 +05:30
Juanito Fatas
8b39eca5b7 [ci skip] Add benchmark your code section to contributing to ruby on rails guide.
I have seen many times that maintainers want people to use this gem to give
a benchmark report. It would be nice to add it and refer to it later.
2014-05-27 05:14:12 +08:00
John Kelly Ferguson
d02c810e29 Rename Posts to Articles in Guides, continuation of 2d446e77 / #13774 [ci skip] 2014-05-21 23:01:45 -04:00
Arun Agrawal
da4d841e16 Reorganize ActiveRecord tasks [Arun Agrawal & Abd ar-Rahman Hamidi] 2014-05-16 23:09:05 +02:00
Ivan Tse
04051df419 Branch name should match in text and code example.
[ci skip]
2014-05-08 00:29:45 -04:00
Yves Senn
b231825f3e Revert "Merge pull request #14940 from arunagw/hbakhtiyor-test-db-namespaces-ar"
This reverts commit fe9859600824268ff614cb3eb48b62c7165a1fbd, reversing
changes made to add9560643ef79830febf47fa1228752d1df3502.
2014-05-03 20:08:15 +02:00
Arun Agrawal
2de846852a Reorganize ActiveRecord tasks [Arun Agrawal & Abd ar-Rahman Hamidi] 2014-05-03 19:34:18 +02:00
Robin Dupret
4142a3019c Follow up to 38ad5438 [ci skip]
This commit adds new lines between titles, paragraphs and code blocks
for an easier reading.

Moreover, in order to be consistent with the other guides, let's remove
the sharps on the right side of the different titles.

The "Running a Single Test" part was also explained after the "Testing
Active Record" one which shows how to run a single test under the scope
of a specific adapter.

Finally, let's explain the `-n` option to run a specific test method.
2014-05-02 12:10:19 +02:00
Vijay Dev
668d8420dc Merge branch 'master' of github.com:rails/docrails 2014-04-27 21:35:38 +05:30
Vijay Dev
9ace0a7ba1 Revert "Running AR tests on postgres, mysql & sqlite"
This reverts commit 28bd442034e0974d0a4d664076dafb8e9555816d.

Reason: Existing text was clearer imo.

[ci skip]
2014-04-27 21:29:15 +05:30
Guo Xiang Tan
1c2484d4eb Improve readability of contributing to rails guide. [ci skip] 2014-04-23 12:36:06 -07:00
Gaurish Sharma
28bd442034 Running AR tests on postgres, mysql & sqlite
[ci skip]
2014-04-21 18:09:22 +05:30
Gaurish Sharma
0fd301aaf7 Remove reference to outdated section
[ci skip]
2014-04-20 01:39:52 +05:30
Steven Harman
c4d2e8eef2 Fix spelling errors and grammar issues
Including replacing a few "smart quotes" with regular quotes (' and "),
for consistency.
[ci skip]
2014-04-13 10:15:55 -04:00
Steven Harman
21bb6e0010 Fix a few grammar issues. [ci skip] 2014-04-11 16:14:08 -04:00
Gaurish Sharma
38ad5438cc Improve Contributing to Rails Guide
Logically group the content, so it makes more sense if someone tries to read from start of page to end of page. [ci skip]
2014-04-06 02:26:43 +05:30
Vijay Dev
92fdd65162 Merge branch 'master' of github.com:rails/docrails
Conflicts:
	guides/source/active_record_validations.md
	guides/source/api_documentation_guidelines.md
	guides/source/configuring.md
2014-02-09 23:33:55 +05:30
dpmehta02
b9ead0feb0 update contribution doc grammar. [ci skip]
- Manually applied from #13951.
- Discussion at #13947.
- Removed trailing whitespace from 18044e86af

/cc @dpmehta02
2014-02-06 09:39:09 +01:00
Vipul A M
9cc4dadb0b Remove old comments about suppressing warnings. 2014-01-25 14:04:09 +05:30
Akshay Vishnoi
ef0f633c66 Typo and grammatical fixes [ci skip] 2013-12-02 19:35:02 +05:30
Alex Johnson
178c4f74f9 Update pull request instructions as per the new Github UI
[ci skip]
2013-10-30 13:25:28 +05:30
Vipul A M
9da59af114 Be assertive about adding [ci skip] message 2013-09-03 01:02:45 +05:30
Steve Klabnik
55870cd8dd Add note about features vs. bugs.
Sometimes people ask what makes a feature and what makes a bug, so
let's clarify that so we can show it to people later.
2013-08-26 13:57:03 -07:00
Steve Klabnik
a57416cc49 Flesh out feedback portion of contributing guide.
I don't know of anyone that hangs out in #rails-contrib, and we should
also let people know that feedback can take some time.
2013-08-26 13:52:28 -07:00