Commit Graph

463 Commits

Author SHA1 Message Date
David Heinemeier Hansson
577a22c47e Dont benchmark if the logger has been turned off
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1269 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-02 07:05:15 +00:00
David Heinemeier Hansson
e6f3e5d900 Fixed action/fragment caching using the filestore when a directory and a file wanted to to use the same name. Now there's a .cache prefix that sidesteps the conflict #1188 [imbcmdth@hotmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1260 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-30 15:29:27 +00:00
David Heinemeier Hansson
537efa36d0 Doc fix #1200
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1257 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-30 13:36:40 +00:00
David Heinemeier Hansson
90b08c5b92 Fixed documentation #1214
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1254 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-30 08:50:10 +00:00
David Heinemeier Hansson
98306bed05 Fixed missing id uniqueness in FormTag#radio_button #1207 [Jarkko]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1253 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-30 08:46:22 +00:00
David Heinemeier Hansson
b4fe4daa84 Fixed assert_redirected_to to work with :only_path => false #1204 [Alisdair McDiarmid]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1251 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-30 08:34:02 +00:00
David Heinemeier Hansson
c29cfe389e Check definition on constant not string
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1250 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-30 08:33:25 +00:00
David Heinemeier Hansson
6d0ddd818a Fixed render_partial_collection to output an empty string instead of nil when handed an empty array #1202 [Ryan Carver]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1249 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-30 08:29:50 +00:00
David Heinemeier Hansson
5640f76970 Improved the speed of regular expression expirations for caching by a factor of 10 #1221 [Jamis Buck]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1248 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-30 08:23:42 +00:00
David Heinemeier Hansson
fe00c275cd Removed dumping of template assigns on the rescue page as it would very easily include a ton of data making page loads take seconds (and the information was rarely helpful) #1222
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1246 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-30 08:19:14 +00:00
David Heinemeier Hansson
61cafca6ea Disregard expire methods when the controller hasnt been set, which essentially makes it such that the record observer callbacks are ignored when the sweeper shouldnt be active
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1242 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-27 17:40:51 +00:00
David Heinemeier Hansson
f871f33994 Added descriptions for new caching features
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1241 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-27 08:18:42 +00:00
David Heinemeier Hansson
fbd86c2017 Added BenchmarkHelper that can measure the execution time of a block in a template and reports the result to the log
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1240 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-27 08:17:25 +00:00
David Heinemeier Hansson
a2ef9778ce Added ActionController::Caching::Sweeper as an improved an easier to use sweeper. Added that Fragments#expire_fragment now accepts as a regular expression as the name thereby deprecating expire_matched_fragments. Fixed that fragments shouldn't use the current host and the path as part of the key like pages does
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1239 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-27 08:14:53 +00:00
David Heinemeier Hansson
734c69f241 Added conditions to around_filters just like before_filter and after_filter
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1238 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-27 06:42:12 +00:00
David Heinemeier Hansson
77af61be40 Added xml_http_request/xhr method for simulating XMLHttpRequest in functional tests #1151 [Sam Stephenson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1230 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-19 16:34:44 +00:00
Sam Stephenson
71a616890b Update to Prototype 1.2.1
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1228 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-19 11:16:50 +00:00
David Heinemeier Hansson
5462358cd3 Fixed that :get, :post, and the others should take a flash array as the third argument just like process #1144 [rails@cogentdude.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1227 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-19 11:04:38 +00:00
David Heinemeier Hansson
0dd497853a More documentation #1148 [Alisdair McDiarmid]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1226 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-19 10:59:55 +00:00
David Heinemeier Hansson
865874ab6a Fixed stringification on all assigned hashes. The sacrifice is that assigns[:person] wont work in testing. Instead assigns["person"] or assigns(:person) must be used. In other words, the keys of assigns stay strings but weve added a method-based accessor to appease the need for symbols.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1223 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-19 10:26:03 +00:00
David Heinemeier Hansson
aa236c4425 Fixed that rendering a template would require a connection to the database #1146
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1222 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-19 09:57:15 +00:00
David Heinemeier Hansson
420b830b00 Fixed that rendering a template would require a connection to the database #1146
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1221 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-19 09:54:10 +00:00
David Heinemeier Hansson
7d01005514 Fixed documentation and prepared for release of 0.12
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1216 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-18 20:10:11 +00:00
David Heinemeier Hansson
3b9bf64130 Added support for web servers that use PATH_INFO instead of REQUEST_URI like IIS #1014 [BradG/Nicholas Seckar]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1211 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-18 15:43:07 +00:00
David Heinemeier Hansson
e9681eb9c5 Added graceful handling of PUT, DELETE, and OPTIONS requests for a complete coverage of REST functionality #1136 [joshknowles@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1208 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-18 14:15:26 +00:00
David Heinemeier Hansson
bceb88ef9c Fixed that you can now pass an alternative :href option to link_to_function/remote in order to point to somewhere other than # if the javascript fails or is turned off. You can do the same with form_remote_tag by passing in :action. #1113 [Sam Stephenson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1200 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-18 05:15:17 +00:00
Sam Stephenson
d547c3f5ec Update to Prototype 1.2.0
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1198 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-18 02:16:13 +00:00
David Heinemeier Hansson
806cf6d76a Added assert_tag and assert_no_tag as a much improved alternative to the deprecated assert_template_xpath_match #1126 [Jamis Buck]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1195 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 16:43:48 +00:00
David Heinemeier Hansson
95e6c03de7 Added Request#xml_http_request? (and an alias xhr?) to that'll return true when the request came from one of the Javascript helper methods (Ajax). This can be used to give one behavior for modern browsers supporting Ajax, another to old browsers #1127 [Sam Stephenson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1194 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 16:40:53 +00:00
David Heinemeier Hansson
7cda49248b Fixed page caching for non-vhost applications living underneath the root #1004 [Ben Schumacher]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1193 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 14:10:24 +00:00
David Heinemeier Hansson
72c51356c5 Hide the deprecated methods from the docs
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1190 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 11:47:54 +00:00
David Heinemeier Hansson
dca7efa67e Deprecated the majority of all the testing assertions and replaced them with a much smaller core and access to all the collections the old assertions relied on. That way the regular test/unit assertions can be used against these. Added documentation about how to use it all.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1189 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 11:38:01 +00:00
David Heinemeier Hansson
8e8bf37aa9 Fixed DateHelper to return values on the option tags such that they'll work properly in IE with form_remote_tag #1024 [rscottmace@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1184 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 09:44:28 +00:00
David Heinemeier Hansson
ba96827b3d Fixed FormTagHelper#check_box to respect checked #1049 [DelynnB]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1183 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 09:39:01 +00:00
David Heinemeier Hansson
e5b3d08a0a Added that render_partial called from a controller will use the action name as default #828 [Dan Peterson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1182 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 09:25:54 +00:00
David Heinemeier Hansson
c3ca5ab7a8 Added Element.toggle, Element.show, and Element.hide to the prototype javascript library. Toggle.display has been deprecated, but will still work #992 [Lucas Carlson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1181 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 07:52:50 +00:00
David Heinemeier Hansson
6acda705dc Added that deleting a cookie should not just set it to an empty string but also instantly expire it #1118 [todd@robotcoop.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1180 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 07:18:39 +00:00
David Heinemeier Hansson
ffdd4bc251 Added AssetTagHelper#image_path, AssetTagHelper#javascript_path, and AssetTagHelper#stylesheet_path #1110 [Larry Halff]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1176 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 06:23:27 +00:00
David Heinemeier Hansson
5e3b8b36fa Fixed url_for(nil) in functional tests #1116 [Alisdair McDiarmid]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1175 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 06:18:33 +00:00
David Heinemeier Hansson
68dfe3e046 Clean up load paths to avoid unit test interaction #1113 [alles@atomicobject.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1174 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 06:16:00 +00:00
David Heinemeier Hansson
db16349bc1 Fixed error handling of broken layouts #1115 [Michael Schubert]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1173 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 06:11:58 +00:00
David Heinemeier Hansson
6ee06ebec6 Changed render_partial to take local assigns as the second parameter instead of an explicit object and then the assigns
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1170 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-16 16:08:29 +00:00
David Heinemeier Hansson
82456d9392 Fixed partials handling
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1169 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-16 16:06:29 +00:00
David Heinemeier Hansson
f3e5e07982 Added submit_to_remote that allows you to trigger an Ajax form submition at the click of the submission button, which allows for multiple targets in a single form through the use of multiple submit buttons #930 [yrashk@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1160 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 05:44:43 +00:00
David Heinemeier Hansson
ad24c6d756 Fixed pagination to work with joins #1034 [scott@sigkill.org]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1159 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 05:40:22 +00:00
David Heinemeier Hansson
7f558cbd05 Fixed that *rest parameter in map.connect couldn't accept an empty list #1037 [Dee.Zsombor@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1158 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 05:35:51 +00:00
David Heinemeier Hansson
2ad8dc6a1f Added :confirm option to link_to_remote just like link_to has #1082 [yrashk@fp.org.ua]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1156 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 05:21:37 +00:00
David Heinemeier Hansson
c29db9f210 Added minute_step as an option to select_minute (and the helpers that use it) to jump in larger increments than just 1 minute. At 15, it would return 0, 15, 30, 45 options #1085 [ordwaye@evergreen.edu]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1154 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 05:15:41 +00:00
David Heinemeier Hansson
e0a2dab816 Added KLOC counter for AR and AP. Combined theyre at ~9KLOC
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1153 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 05:06:40 +00:00
David Heinemeier Hansson
bf1bcff2bd Fixed that an exception would be thrown when an empty form was submitted #1090 [jan@ulbrich-boerwang.de]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1152 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 04:50:54 +00:00