Pratik Naik
5a03645762
Allow Module#depends_on to accept multiple modules
2009-05-21 03:04:17 +02:00
Pratik Naik
e21d1614bb
Made ActionController::Verification work with new_base
2009-05-21 02:55:25 +02:00
Yehuda Katz + Carl Lerche
7f7fdc407a
Make controller/content_type_test.rb pass on new base
2009-05-20 17:42:04 -07:00
Yehuda Katz + Carl Lerche
c8eda9ade4
Fixed new_base tests on ruby 1.9
2009-05-20 17:22:29 -07:00
Pratik Naik
8e7a87d299
Make ActionController::Flash work with new_base
2009-05-21 01:41:35 +02:00
Yehuda Katz + Carl Lerche
01f032f256
Added responds_to to new base.
2009-05-20 15:34:26 -07:00
Joshua Peek
6761759a90
Temporarily bundle rack-test while MockSession is baking
2009-05-19 22:43:22 -05:00
Bryan Helmkamp
df0faea378
Refactor ActionController instantiation capture
2009-05-19 22:43:21 -05:00
Bryan Helmkamp
0029d5e594
Integrating Rack::MockSession (from Rack::Test)
2009-05-19 22:43:21 -05:00
Yehuda Katz + Carl Lerche
321168b17b
Make old caching tests pass on new base.
2009-05-19 18:11:45 -07:00
Yehuda Katz + Carl Lerche
67cc021d01
Modified caching implementation to work with NewBase
2009-05-19 18:11:45 -07:00
Yehuda Katz + Carl Lerche
0e7da0e4a0
Include caching module into new base
2009-05-19 18:11:44 -07:00
Yehuda Katz + Carl Lerche
26f2be01c2
Modify caching to use new included helper
2009-05-19 18:11:44 -07:00
Pratik Naik
4a6f4b92ad
Change integration test helpers to accept Rack environment instead of just HTTP Headers.
...
Before : get '/path', {}, 'Accept' => 'text/javascript'
After : get '/path', {}, 'HTTP_ACCEPT' => 'text/javascript'
2009-05-19 23:50:03 +02:00
Yehuda Katz + Carl Lerche
07f733c631
Ported simple benchmarking in new base
2009-05-18 17:33:45 -07:00
Pratik Naik
195fadbfd3
Ensure HTTP Digest auth uses appropriate HTTP method [ #2490 state:resolved] [Steve Madsen]
2009-05-18 16:59:37 +02:00
Joshua Peek
092089015b
Extract generic callbacks middleware from dispatcher
2009-05-17 13:39:55 -05:00
Joshua Peek
8118fca9be
Merge Failsafe middleware into ShowExceptions
2009-05-17 12:24:59 -05:00
Joshua Peek
c3319504f0
Rescue hack was supposed to be removed. Some how it crept back in.
2009-05-17 12:24:59 -05:00
Thomas E. Glasgow
e41984c5f7
Simplify filter_chain method implementation [ #2327 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
2009-05-17 18:56:07 +02:00
Jeffrey Chupp
842dab0c29
Ensure WhiteListSanitizer allows dl tag [ #2393 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
2009-05-17 14:29:47 +02:00
Yehuda Katz + Carl Lerche
5a45446cff
Ported Rescuable to new base
2009-05-15 17:49:11 -07:00
Yehuda Katz + Carl Lerche
7e10504bde
Refactored AbstractController to provide better hook points for overriding aspects of action dispatching
2009-05-15 15:57:12 -07:00
Yehuda Katz + Carl Lerche
b6bac73b28
Merge commit 'origin/master'
...
Conflicts:
actionpack/lib/action_controller/abstract/base.rb
actionpack/lib/action_controller/routing.rb
2009-05-14 17:38:30 -07:00
Yehuda Katz + Carl Lerche
da65320433
Got new base to pass controller/base_test.rb, implemented method_missing action semantics in compatibility mode, and fixed a few action_missing bugs.
2009-05-14 17:25:10 -07:00
Yehuda Katz + Carl Lerche
8fac2c88ca
Cleaning up more render tests
2009-05-14 15:30:35 -07:00
Jeremy Kemper
c286952050
Minimal base/new_base comparison
2009-05-14 02:01:08 -07:00
Jeremy Kemper
e8550ee032
Cherry-pick core extensions
2009-05-13 12:00:15 -07:00
Yehuda Katz + Carl Lerche
216309c165
Implemented redirects and partial rendering in new base.
2009-05-12 16:21:34 -07:00
Yehuda Katz + Carl Lerche
72ca7c591c
Fixed new callbacks to not call the action when a callback sets the response body
2009-05-12 10:53:00 -07:00
Yehuda Katz + Carl Lerche
00a9d4b91c
Merge branch 'master' into wip_abstract_controller
...
Conflicts:
actionpack/lib/action_controller/abstract/callbacks.rb
actionpack/lib/action_controller/abstract/renderer.rb
actionpack/lib/action_controller/base/base.rb
actionpack/lib/action_controller/dispatch/dispatcher.rb
actionpack/lib/action_controller/routing/route_set.rb
actionpack/lib/action_controller/testing/process.rb
actionpack/test/abstract_controller/layouts_test.rb
actionpack/test/controller/filters_test.rb
actionpack/test/controller/helper_test.rb
actionpack/test/controller/render_test.rb
actionpack/test/new_base/test_helper.rb
2009-05-11 17:07:05 -07:00
Yehuda Katz + Carl Lerche
0cac68d3be
Revert "Whitespace!"
...
This reverts commit a747ab5b20b9d543e9d311070e3b720c761ae716.
2009-05-11 15:03:24 -07:00
Yehuda Katz + Carl Lerche
0f6e764e40
Fixed a bug with handling render options
2009-05-11 14:48:58 -07:00
Yehuda Katz + Carl Lerche
6694bd46f5
Aliased AbstractController::ActionNotFound to ActionController::UnknownAction
2009-05-11 12:45:26 -07:00
Yehuda Katz + Carl Lerche
94ee9d2452
Ported ConditionalGet to new Base
2009-05-11 12:04:43 -07:00
Yehuda Katz + Carl Lerche
c1d120a71e
Don't run the action if callbacks are halted.
...
In AbstractController, this means that response_body is not empty
2009-05-11 11:48:38 -07:00
Yehuda Katz + Carl Lerche
a2f3684cec
Ported fresh_when into a ConditionalGet module
2009-05-11 10:57:59 -07:00
Yehuda Katz
030dfe3f83
More community code review :)
2009-05-11 10:22:07 -07:00
Joshua Peek
a747ab5b20
Whitespace!
2009-05-07 10:45:29 -05:00
Joshua Peek
af40fa6d03
Prefer "included" language over "setup"
2009-05-07 10:38:57 -05:00
Joshua Peek
2854535b02
Make module dependency DSL opt in
2009-05-07 10:29:22 -05:00
Joshua Peek
bcc4537f2a
Wrap dispatcher callbacks around the whole middleware chain. Kill unnecessary Reloader middleware.
2009-05-03 09:41:40 -05:00
Joshua Peek
11af089cee
Extract ActionController rescue templates into Rescue and ShowExceptions middleware.
...
This commit breaks all exception catching plugins like ExceptionNotifier. These plugins should be rewritten as middleware instead overriding Controller#rescue_action_in_public.
2009-05-02 23:02:22 -05:00
Joshua Peek
24affdc88c
Deprecate Controller.process interface
2009-05-02 15:37:29 -05:00
Joshua Peek
f32cf44870
Switch functional tests to run through the rack interface instead of process
2009-05-02 15:29:18 -05:00
Joshua Peek
a8b75c480f
Functional test runner finalizes response just like the integration test runner. In both runners, the @response object will now behave the same.
...
Some functional tests will need to be updated if they are relying on preprocessed data on the response.
2009-05-02 14:57:40 -05:00
Joshua Peek
3900f4007e
Deprecate assert_redirect_to's partial hash matching
2009-05-02 14:23:44 -05:00
Yehuda Katz
72160d9f89
Implement FooController.action(:name)
...
* Rails actions are now Rack endpoints, and can be retrieved
via FooController.action(name) and called with an env
* Updated some tests that relied on the old internal
#process/#call implementation
2009-05-02 02:15:09 -07:00
Yehuda Katz + Carl Lerche
ad2a1b5cb1
Get render :inline working
2009-05-01 18:17:08 -07:00
Yehuda Katz + Carl Lerche
7dd072d333
A few more tweaks to get new Base running old render tests again
2009-05-01 17:53:20 -07:00