Add more information about passing variables to translation definitions
and also merge this part with the "Interpolation" one as the latter
didn't bring any new information. Moreover, each one was referring to
the other for further information.
[ci skip]
The has_and_belongs_to_many default join_table behavior changed
between Rails 3.2 and Rails 4.0 and should be noted in the
appropriate section of the upgrade guide.
commit:
46492949b8
This reverts commit 00aa1afae3821dd858dec7111bcdf230b12040d7, reversing
changes made to b584cc68fc28492147ed3ed127ad8a7441ca8161.
Reason:
As far as we can tell, this should not be the case. Both localhost, 127.0.0.1
and ::1 is "supposed to work", so this is probably a bug somewhere.
Reopening #19815 instead.
Rewording in accordance with the documentation guidelines (‘Prefer
wordings that avoid "you"s and "your”s.’) and to remove in particular
“if you'd call”.
Added note about non-GET links getting converted to GET links in mailer Added note about non-GET links getting converted to GET links in mailer templates [ci skip]
Explain config.active_support.test_order defaults
to :random in newly-generated applications thanks
to generated config/environments/test.rb, otherwise
default is :sorted (until Rails 5.0).
Rails has different naming conventions for the inverse assertion
methods. While minitest uses `refute` we use `_not`. We should have a
table listing the common assertions that you want to use in the Rails
context.
Refs #18305.
First commit:
This PR improves the "4.12 Commit Your Changes" section of the
Contributing to Ruby on Rails Guide:
- Fix formatting of the commit message example
- Improve readability and clarity
- Fix grammar
- Wrap lines
See the before and after images below in this PR.
-----
Second commit:
- Rewrite to remove the word "buffer" [skip ci]
This is a squash of the following commits, from first to last:
-
Fix minor, random things I’ve come across lately that individually
did not seem worth making a PR for, so I saved them for one commit.
One common error is using “it’s” (which is an abbreviation of “it is”)
when the possessive “its” should be used for indicating possession.
-
Changes include the name of a test, so remove the `[skip ci]` (thanks @senny).
-
Line wrap the changes at 80 chars and add one more doc fix.
-
Add a missing line wrap in the Contributing to Ruby on Rails Guide.
-
Line wrap the `TIP` section in the Contributing to Ruby on Rails Guide as well.
Rendering the guide locally with `bundle exec rake guides:generate` did
not show any change in on-screen formatting after adding the line wrap.
The HTML generated is (extra line added to illustrate where the line
wrap takes place):
<div class="info"><p>Please squash your commits into a single commit
when appropriate. This
simplifies future cherry picks and also keeps the git log
clean.</p></div>
-
Squash commits.
