José Valim
5c1354901e
Improve docs for AbsC::Rendering
2013-02-27 08:30:46 -07:00
Yves Senn
4d7f53379a
cleanup, remove trailing whitespace within actionpack
2012-10-27 16:03:18 +02:00
Nick Sutterer
1b01ab4959
remove AV.prepare and move all helper-related logic into the controller. this decouples the view since it no longer knows about routes internals.
...
this is a result of an ongoing discussion at https://github.com/rails/rails/pull/6826 .
2012-06-29 11:33:37 +02:00
José Valim
39514af7e7
Merge pull request #5480 from drogus/rendering-issues
...
Fix for #5440
2012-03-17 11:24:19 -03:00
Sergey Nartimov
5215eed5a3
Symbol#[] method presents in Ruby 1.9
2012-01-07 15:30:36 +03:00
Sergey Nartimov
7d862359d0
get rid of using instance_variable_names method from AS
...
- instance_variables return symbols in 1.9
- there is instance_variable_defined? method
2012-01-07 14:44:47 +03:00
José Valim
e6bfcc21a8
Remove unecessary config_accessors.
2011-12-24 09:59:28 +01:00
José Valim
efc28a7f70
Some small optimizations and improvements to benchmark code.
2011-12-08 16:39:06 +01:00
José Valim
6e8fe1bf02
TestCase should respect the view_assigns API instead of pulling variables on its own.
2011-10-02 11:29:13 +02:00
José Valim
d42bb68430
More updates to ivars list.
2011-05-06 14:57:25 +02:00
José Valim
894bdbd53d
Move variables to underscore format, update protected instance variables list.
2011-05-06 14:57:25 +02:00
José Valim
1632a3a49f
More AV::Base cleanup.
2011-05-04 12:07:37 +02:00
José Valim
6afc900191
Move prefixes to view paths as they are now a lookup context dependency.
2011-05-04 11:28:37 +02:00
Nick Sutterer
eb327c1bab
no @controller dependency in Renderers.
2011-05-04 00:12:11 +02:00
José Valim
f9849070ac
Add a shared entry point for AV and AC render which can be used as extension in the future.
2011-05-03 16:51:47 +02:00
José Valim
b735761385
Introduce view renderer.
2011-05-01 13:40:13 +02:00
José Valim
a66c917235
Do not inherit from Rack::Response, remove a shit-ton of unused code.
2011-04-19 11:54:12 +02:00
José Valim
4f044528c0
Slightly reorganize rendering stack.
2011-04-18 08:12:51 +02:00
José Valim
d6bd606bdd
render :once, YAGNI.
2011-04-15 21:11:54 +02:00
Prem Sichanugrist
0f8a6ebba3
Fix missing requires in Action Mailer
...
This made the isolated test failed on CI server.
Signed-off-by: Xavier Noria <fxn@hashref.com>
2011-04-13 19:52:19 +02:00
Neeraj Singh
806e6f80dc
render_to_string must ensure that response_body
...
is nil
[ #5875 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2011-01-25 20:14:03 +01:00
José Valim
262b2ea8cd
Solve SystemStackError when changing locale inside ActionMailer [ #5329 state:resolved]
2011-01-19 23:42:10 +01:00
wycats
e03e1fdbc8
Speed up template inheritance and remove template inheritance option
2010-12-26 23:56:09 -08:00
artemave
ce21ea7832
#948 make template inheritance optional
2010-12-26 22:32:15 -08:00
artemave
ddd85ef9c6
#948 template_inheritance
2010-12-26 22:32:15 -08:00
Santiago Pastorino
d3f8765482
Avoid range object creation
2010-11-20 02:29:57 -02:00
Santiago Pastorino
bb7b705b0c
Fix indentation
2010-11-19 14:26:44 -02:00
Santiago Pastorino
555b7cd04a
Don't merge just directly add to the action to the :partial key
2010-11-19 14:26:42 -02:00
Santiago Pastorino
b1ffd65b8f
Useless assignation
2010-11-19 14:26:39 -02:00
Andrew White
4ba24ba043
Allow generated url helpers to be overriden [ #5243 state:resolved]
2010-10-26 14:27:18 +01:00
José Valim
940b57789f
Add support to render :once.
...
This will be used internally by sprockets to ensure requires are executed just once.
2010-10-10 12:43:26 +02:00
José Valim
c563f10f3e
render :template => 'foo/bar.json' now works as it should.
2010-10-07 21:31:31 +02:00
José Valim
8f9e9118e4
Make collection rendering faster.
2010-10-07 21:31:31 +02:00
José Valim
14f9904e0f
Avoid (@_var ||= nil) pattern by using initialize methods and ensuring everyone calls super as expected.
2010-09-29 11:18:31 +02:00
Emilio Tagua
059d609a1a
Avoid more uninitialized variable warnings.
2010-09-28 15:46:30 -03:00
Piotr Sarnacki
6c95e0f879
Add mounted_helpers to routes
...
mounted_helpers are a bit similar to url_helpers. They're automatically
included in controllers for Rails.application and each of mounted
Engines. Mounted helper allows to call url_for and named helpers for
given application.
Given Blog::Engine mounted as blog_engine, there are 2 helpers defined:
app and blog_engine. You can call routes for app and engine using those
helpers:
app.root_url
app.url_for(:controller => "foo")
blog_engine.posts_path
blog_engine.url_for(@post)
2010-09-03 22:59:07 +02:00
Piotr Sarnacki
f7ba614c2d
Unify routes naming by renaming router to routes
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-07-02 01:51:03 +02:00
wycats
ffe001f19d
Changes made while working on upgrading cells to Rails 3
2010-06-02 22:56:41 +02:00
José Valim
3fc609ee41
Fix ActionMailer test broken in 99d54599215c2a8cea7e57f609e8e578043d71b2
2010-04-12 10:50:27 +02:00
wycats
209fb5190b
render_to_string should have the identical signature as render
2010-04-04 19:58:15 -07:00
wycats
0aa0c37b59
Well that was a bust
2010-03-18 22:55:44 -07:00
wycats
995f57033f
We seem to have removed the URL helpers from ActionView subclasses...
2010-03-18 22:21:25 -07:00
Carlhuda
a5d80f84d2
Each controller class has it's own view context subclass. This removes the need for ActionView::Base.for_controller
2010-03-18 18:14:54 -07:00
Carlhuda
1dacc19702
Return a valid Rack response from bare ActionController::Metal
2010-03-18 17:32:53 -07:00
Carlhuda
71c9337f45
All tests pass without memoizing view_context
2010-03-18 15:52:43 -07:00
José Valim
21dcbb17de
Ensure json is loaded before using responders.
2010-03-17 23:09:28 +01:00
Carlhuda
6416a35f4b
Remove unneeded AV::Base and AV::Template monkey-patches
2010-03-17 14:29:18 -07:00
José Valim
f2c0a353ae
Finish cleaning up rendering stack from views and move assigns evaluation to controller (so plugins and/or controllers can overwrite just one method).
2010-03-12 20:39:53 +01:00
José Valim
07cf49aadf
Optimize and clean up how details key get expired.
2010-03-10 22:13:29 +01:00
José Valim
00d6271d2b
Clean up the API required from ActionView::Template.
2010-03-09 13:12:11 +01:00