Thomas Fuchs
a5df861852
Fix loop_on_multiple_args to work, again (not my day), fixes #6078
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5063 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-07 14:16:58 +00:00
Thomas Fuchs
cb6309bcc9
Ahem, now for real
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5062 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-07 12:57:39 +00:00
Thomas Fuchs
984312cf85
Fix a warning in prototype_helper_test, fixes #6077
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5061 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-07 12:56:48 +00:00
Thomas Fuchs
8734da9bca
Update JavaScriptGenerator#show/hide/toggle/remove to new Prototype syntax for multiple ids, fixes #6068 [petermichaux@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5057 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-07 09:19:35 +00:00
Nicholas Seckar
00685ad8fd
Update UrlWriter to support :only_path.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5054 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-06 22:21:36 +00:00
David Heinemeier Hansson
5a5f85d5be
Get symbol definitions of methods converted to strings [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5045 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-06 04:00:37 +00:00
Rick Olson
5360e47431
added passing test for using partials with an xml builder
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5044 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-06 03:51:45 +00:00
David Heinemeier Hansson
83313fccc0
Backed out of locals hash as it caused trouble with Builder, see ticket for more
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5043 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-06 03:38:11 +00:00
David Heinemeier Hansson
8c9ce617c9
Fixed JavaScriptHelper#link_to_function and JavaScriptHelper#button_to_function to have the script argument be optional [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5039 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-06 01:31:04 +00:00
David Heinemeier Hansson
951b4d2799
Still need the regular assertions
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5028 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-05 23:04:14 +00:00
David Heinemeier Hansson
bd09d9aafb
caller is necessary for proper trace in deprecation
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5021 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-05 22:08:33 +00:00
David Heinemeier Hansson
9598176390
Better bundling of new assertions and make integration tests work again
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5020 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-05 21:28:22 +00:00
Thomas Fuchs
4f68dcb035
Update to script.aculo.us 1.6.3 [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5015 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-05 10:42:41 +00:00
Sam Stephenson
899c1b0157
Update to Prototype 1.5.0_rc1
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5012 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-05 04:17:06 +00:00
David Heinemeier Hansson
1d4d037b0d
Added access to nested attributes in RJS ( closes #4548 ) [richcollins@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5004 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 20:54:10 +00:00
David Heinemeier Hansson
bf8b101dd6
Fixed that AssetTagHelper#image_tag and others using compute_public_path should not modify the incoming source argument ( closes #5102 ) [eule@space.ch]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5003 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 20:43:38 +00:00
David Heinemeier Hansson
4fdddc331e
Expose more options of inplace_editor (but its still going plugin with v2.0) ( closes #5103 )
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5002 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 20:41:38 +00:00
David Heinemeier Hansson
c2054c4289
Superseeded by action_caching_test ( closes #5173 )
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5001 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 20:39:50 +00:00
David Heinemeier Hansson
40c86a7bda
Documentation for routes ( closes #5165 ) [rramdas@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5000 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 20:34:19 +00:00
David Heinemeier Hansson
9514e4e6ad
Deprecated the auto-appending of .png to AssetTagHelper#image_tag calls that doesn't have an extension [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4999 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 20:25:43 +00:00
David Heinemeier Hansson
40762a4873
Fixed default routing NoMethodError downcase for nil when default controller provided ( closes #5400 ) [kajism@yahoo.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4998 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 20:09:15 +00:00
David Heinemeier Hansson
df70e28e03
Added locals hash to partials, which makes for convenient access of some times available/some times not variables ( closes #5491 ) [wbruce@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4997 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 20:01:52 +00:00
David Heinemeier Hansson
939017487d
Update usage notes to verify
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4996 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 19:42:10 +00:00
David Heinemeier Hansson
4c966a07a1
Fixed FormOptionsHelper#select to respect :selected value ( closes #5813 )
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4995 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 19:35:18 +00:00
David Heinemeier Hansson
d4bb22b220
Fixed TextHelper#simple_format to deal with multiple single returns within a single paragraph ( closes #5835 ) [moriq@moriq.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4994 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 19:26:32 +00:00
David Heinemeier Hansson
a693b3beca
Fixed TextHelper#pluralize to handle 1 as a string ( closes #5905 ) [rails@bencurtis.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4993 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 19:23:07 +00:00
David Heinemeier Hansson
17f7eaa141
Improved resolution of DateHelper#distance_of_time_in_words for better precision ( closes #5994 ) [Bob Silva]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4989 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 17:00:37 +00:00
David Heinemeier Hansson
fc901e6f5d
Doc fix ( closes #6023 )
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4988 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 16:47:48 +00:00
Jeremy Kemper
da8d7a7011
deprecated render assertions
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4977 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 05:51:48 +00:00
Jeremy Kemper
e04a6e8155
deprecated assertions tests
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4976 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 05:47:51 +00:00
David Heinemeier Hansson
653bfe9600
Dont raise deprecation warning on render :action => "stuff"
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4975 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 05:24:08 +00:00
Jeremy Kemper
ea831469a9
new render deprecations test
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4974 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 05:09:18 +00:00
Jeremy Kemper
96c45a8118
Don't use deprecated render API. Cosmetics.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4973 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 05:07:26 +00:00
Jeremy Kemper
7cbb4ac44f
deprecated keep_flash test
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4972 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 05:06:10 +00:00
Jeremy Kemper
3158730411
redirect deprecation tests
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4971 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 05:05:11 +00:00
Jeremy Kemper
d4a3eff89d
no more render_to_string deprecation warnings
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4970 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 04:59:05 +00:00
Jeremy Kemper
2dd5820280
silence deprecation warnings. cosmetics.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4969 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 04:58:08 +00:00
Jeremy Kemper
7818cf1123
deprecated render tests
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4968 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 04:05:38 +00:00
Jeremy Kemper
9b424f04ca
test_test deprecation and cosmetics
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4967 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 04:03:57 +00:00
Jeremy Kemper
be54075956
set ActiveSupport::Deprecation.debug = true to see backtraces for deprecation callers. off by default. on for Rails tests.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4966 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 03:38:13 +00:00
Jeremy Kemper
29f04510e9
pass caller to deprecation warning
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4965 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 03:36:13 +00:00
Jeremy Kemper
25ea18aa15
Fix deprecation warnings in verification tests.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4963 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 03:17:32 +00:00
Jeremy Kemper
c3a52523ce
Active Record integration deprecation tests
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4962 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 03:07:17 +00:00
David Heinemeier Hansson
3558322b9d
Changed that uncaught exceptions raised any where in the application will cause RAILS_ROOT/public/500.html to be read and shown instead of just the static "Application error (Rails)" [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4955 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 23:51:34 +00:00
Jeremy Kemper
71dbef6d27
Integration tests: thoroughly test ActionController::Integration::Session. Closes #6022 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4954 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 23:34:57 +00:00
David Heinemeier Hansson
8ca3f34db1
Docs and deprecation
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4953 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 23:28:54 +00:00
David Heinemeier Hansson
6d88a992b5
Added deprecation language for in_place_editor and auto_complete_field that both pieces will become plugins by Rails 2.0 [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4952 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 23:22:24 +00:00
Jeremy Kemper
af61b9cdae
action
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4949 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 23:17:13 +00:00
David Heinemeier Hansson
0f956d1d6d
Deprecated all of ActionController::Dependencies. All dependency loading is now handled from Active Support [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4948 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 23:08:43 +00:00
David Heinemeier Hansson
5048aa9831
Deprecated old render parameter calls
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4947 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 23:02:56 +00:00
David Heinemeier Hansson
315603e2be
Backout of blowup fix
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4945 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 22:46:16 +00:00
David Heinemeier Hansson
268c1dee8f
Require action mailer more gracefully
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4944 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 22:43:24 +00:00
David Heinemeier Hansson
4bd444c1fe
More deprecation fun
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4943 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 22:35:31 +00:00
David Heinemeier Hansson
761f1f1f3a
Deprecate deprecated assertions
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4938 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 20:36:51 +00:00
David Heinemeier Hansson
d52b4a6645
Moved in deprecated assertions and remove duplicated requires
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4935 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 20:27:48 +00:00
David Heinemeier Hansson
a4bef314fe
Follow proper naming conventions
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4934 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 20:22:47 +00:00
David Heinemeier Hansson
f12fdc50a6
Better compartmentalizing of assertions
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4931 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 20:18:06 +00:00
David Heinemeier Hansson
3142502964
Added assert_select* for CSS selector-based testing (deprecates assert_tag) #5936 [assaf.arkin@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4929 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 19:54:21 +00:00
Jeremy Kemper
4fc6c872ef
radio_button_tag generates unique id attributes. Closes #3353 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4925 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 19:32:31 +00:00
David Heinemeier Hansson
fef2d880a5
Update copyright times
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4922 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 18:53:05 +00:00
David Heinemeier Hansson
b6afb2837c
Nitpick updates
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4919 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 18:34:28 +00:00
Jeremy Kemper
6d17ece9f2
strip_tags returns nil for a blank arg such as nil or "". Closes #2229 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4916 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 16:47:05 +00:00
Jeremy Kemper
db9be58719
Cleanup assert_tag :children counting. Closes #2181 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4915 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 16:40:01 +00:00
Jeremy Kemper
a769b88819
button_to accepts :method so you can PUT and DELETE with it. Closes #6005 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4914 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 15:59:18 +00:00
Rick Olson
0c999f4125
Update sanitize text helper to strip plaintext tags, and <img src=javascript:bang>. [Rick Olson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4911 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 00:02:14 +00:00
Rick Olson
ad63005cdd
Update routing documentation. Closes #6017 [Nathan Witmer]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4908 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-02 20:43:29 +00:00
Rick Olson
2b45e2d370
Add routing tests to assert that RoutingError is raised when conditions aren't met. Closes #6016 [Nathan Witmer]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4907 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-02 20:41:40 +00:00
David Heinemeier Hansson
c1c659a2de
Doc fixes ( closes #6012 )
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4906 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-02 19:45:03 +00:00
David Heinemeier Hansson
6e08dab186
Docs for js linkers ( closes #5948 )
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4904 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-02 19:41:04 +00:00
Jeremy Kemper
7aa9eed88f
Deprecation: update docs. Closes #5998 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4898 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-01 23:37:10 +00:00
Jamis Buck
bdf91d6748
Make auto_link parse a greater subset of valid url formats.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4896 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-02 01:47:32 +00:00
Jeremy Kemper
9c99be88b2
Integration tests: headers beginning with X aren't excluded from the HTTP_ prefix, so X-Requested-With becomes HTTP_X_REQUESTED_WITH as expected.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4892 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-01 02:25:29 +00:00
David Heinemeier Hansson
e278b72bf3
Fixed a few find_alls
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4888 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-31 23:38:03 +00:00
Jeremy Kemper
12ff554cd4
Tighten rescue clauses. Closes #5985 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4885 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-31 03:16:28 +00:00
Jeremy Kemper
785e1fa599
Fix send_data documentation typo. Closes #5982 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4884 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-31 03:07:38 +00:00
Nicholas Seckar
d34a346d9d
Switch to using FormEncodedPairParser for parsing request parameters.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4866 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-30 05:50:02 +00:00
Nicholas Seckar
9ece976a99
Add desc for test task so that completion can detect it
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4865 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-30 04:51:11 +00:00
Tobias Lütke
ff063d700d
respond_to .html now always renders #{action_name}.rhtml so that registered custom template handlers do not override it in priority.
...
Custom mime types require a block and throw proper error now.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4860 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-30 00:34:36 +00:00
David Heinemeier Hansson
06a731e365
Keep onsubmit around for form_remote_for
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4838 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-29 07:48:55 +00:00
David Heinemeier Hansson
eb1d78189e
Reload should take options for the replace
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4836 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-29 00:20:18 +00:00
David Heinemeier Hansson
d164d09649
FormEncodedStringParser needs a tad more work before it can handle POST data (like file handling), so were backing out for a bit
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4833 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-28 14:05:05 +00:00
Jeremy Kemper
9f8b8f5ca8
Typo in integration app session. Closes #5864 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4825 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-26 06:54:26 +00:00
Jeremy Kemper
96c6ca369a
Deprecation: test deprecated instance vars in partials.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4824 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-26 05:58:16 +00:00
David Heinemeier Hansson
7b34d0f8c5
Actually, indifferent access mattered in the bowels (hashes hidden in arrays)
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4823 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-26 03:09:32 +00:00
David Heinemeier Hansson
a78519071c
Result is made indifferent on the way out
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4822 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-26 02:58:55 +00:00
David Heinemeier Hansson
04fda65306
Changed the POST parameter processing to use the new QueryStringParser and make the result a indifferent hash [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4821 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-26 02:49:09 +00:00
David Heinemeier Hansson
9e054fdf41
More tests for array/hashing in parameters, one failing
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4820 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-26 01:57:44 +00:00
Nicholas Seckar
3b1972a896
Add UrlWriter to allow writing urls from Mailers and scripts.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4814 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-24 06:15:01 +00:00
Jeremy Kemper
d65a8f6e9e
map.resources docs typo closes #5895
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4812 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-24 01:52:23 +00:00
Jeremy Kemper
767eaa9df1
Clean up and run the Active Record integration tests by default. Closes #5854 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4807 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-22 09:19:55 +00:00
Nicholas Seckar
caf546b675
Add test case from ticket #4090
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4805 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-22 07:18:24 +00:00
Jeremy Kemper
070f3fdc8c
Clean up and run the Active Record integration tests by default.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4804 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-22 04:38:03 +00:00
Jeremy Kemper
04d2d5f288
Correct example in cookies docs. Closes #5832 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4793 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-20 05:28:47 +00:00
Thomas Fuchs
6457b365a1
Updated trunk to script.aculo.us 1.6.2
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4766 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-15 14:20:55 +00:00
Nicholas Seckar
5f3486c0b4
cleanup
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4764 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-15 02:04:25 +00:00
Nicholas Seckar
7678d123a7
Relax Routing's anchor pattern warning; it was preventing use of [^/] inside restrictions.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4763 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-15 02:04:11 +00:00
Nicholas Seckar
5baf7462c7
Add controller_paths variable to Routing; Assign Routing.controller_paths from initializer; fix script/about and rails info controller.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4762 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-15 01:28:06 +00:00
Marcel Molina
2ac4839050
Update respond_to docs to follow established naming convention
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4759 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-14 14:33:40 +00:00
Rick Olson
8c4b599b7c
Fix assert_redirected_to issue with named routes for module controllers. [Rick Olson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4757 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-13 18:31:58 +00:00
Rick Olson
c963f8e955
Tweak RoutingError message to show option diffs, not just missing named route significant keys. [Rick Olson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4756 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-13 18:00:08 +00:00
Nicholas Seckar
84bacf99d6
Invoke method_missing directly for hidden actions. Closes #3030 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4755 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-13 04:15:22 +00:00
Marcel Molina
9b204641c0
Fix typo in caching docs.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4740 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-09 15:30:43 +00:00
Rick Olson
f06cae3652
Require Tempfile explicitly for TestUploadedFile due to changes in class auto loading. [Rick Olson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4734 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-09 00:11:28 +00:00
Rick Olson
4679e1bf7f
Add RoutingError exception when RouteSet fails to generate a path from a Named Route. [Rick Olson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4733 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-09 00:02:08 +00:00
Nicholas Seckar
74165eb6ac
New dependencies implementation
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4728 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-08 21:21:04 +00:00
Jeremy Kemper
c3cdd3b659
Deprecation: check whether instance variables have been monkeyed with before assigning them to deprecation proxies. Raises a RuntimeError if so.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4717 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-07 21:58:31 +00:00
Jeremy Kemper
c40b1a4a67
Deprecate direct usage of @params. Update ActionView::Base for instance var deprecation.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4715 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-07 12:40:14 +00:00
Thomas Fuchs
a3b045a73e
Add support for the param_name parameter to the auto_complete_field helper. Fixes #5026 [david.a.williams@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4713 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-07 11:08:32 +00:00
Nicholas Seckar
c469e4653d
it's me, john wayne
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4700 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-07 06:13:01 +00:00
Jeremy Kemper
2399a223c3
Deprecation! @session and @flash will be removed after 1.2. Use the session and flash methods instead. You'll get printed warnings during tests and logged warnings in dev mode when you access either instance variable directly.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4699 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-07 06:11:56 +00:00
Rick Olson
a27ccf1765
add Rdocs to map.resources
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4689 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-06 16:33:22 +00:00
Nicholas Seckar
822527102f
I know we all love > but we can't all have them
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4678 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-05 22:13:11 +00:00
Nicholas Seckar
127ee8c8f8
Make Routing noisy when an anchor regexp is assigned to a segment. Closes #5674
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4677 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-05 22:12:50 +00:00
David Heinemeier Hansson
4699c336f7
Make test_tag_options pass ( closes #5600 ) [shugo]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4675 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-05 21:38:03 +00:00
David Heinemeier Hansson
8eaf479156
Added months and years to the resolution of DateHelper#distance_of_time_in_words, such that "60 days ago" becomes "2 months ago" ( closes #5611 ) [pjhyett@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4674 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-05 21:34:18 +00:00
David Heinemeier Hansson
5130fc84c6
Remove duplicate routes from mapped resources ( closes #5712 ) [eigentone@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4669 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-05 20:46:49 +00:00
Michael Koziarski
6c50597489
Short documentation to mention use of Mime::Type.register. Closes #5710 [choonkeat@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4665 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-05 02:00:04 +00:00
Jeremy Kemper
12ab93b72b
Make controller_path available as an instance method. Closes #5724 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4664 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-05 01:56:58 +00:00
David Heinemeier Hansson
6b5ef885d9
The white space inquisition is coming for you!
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4661 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-04 16:47:48 +00:00
Nicholas Seckar
f39180eded
Fix broken query parameter tests
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4660 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-04 16:03:21 +00:00
David Heinemeier Hansson
2d6ca64c45
Make us pass to ease RESTful children posts
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4659 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-04 00:45:09 +00:00
David Heinemeier Hansson
6e842f216c
Make us pass to ease RESTful children posts
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4658 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-04 00:15:09 +00:00
Marcel Molina
08f40a5e06
Fix typo in caching docs. [Marcel Molina Jr.]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4657 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-04 00:02:44 +00:00
Marcel Molina
d17bd6a043
Make action caching aware of different formats for the same action so that, e.g. foo.xml is cached separately from foo.html. Implicitly set content type when reading in cached content with mime revealing extensions so the entire onous isn't on the webserver. PDI MORE CACHING TESTS [Marcel Molina Jr.]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4656 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-03 23:59:38 +00:00
Jamis Buck
49f44daf17
More tweaks to make sure assert_redirected_to works with symbols
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4649 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-01 21:34:58 +00:00
Jamis Buck
0cfde5f8c0
Make sure assert_respond_to works with symbol parameters
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4648 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-01 20:56:26 +00:00
Rick Olson
58b996f9b0
Restrict Request Method hacking with ?_method to POST requests. [Rick Olson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4644 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-01 03:02:31 +00:00
Jeremy Kemper
c9417dcef3
Nested resource testing.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4643 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-01 01:23:06 +00:00
Jeremy Kemper
a247d72139
Nesting map.resources
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4642 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-01 00:29:02 +00:00
Rick Olson
78e37f45c6
Fix bug when passing multiple options to SimplyRestful, like :new => { :preview => :get, :draft => :get }. [Rick Olson, Josh Susser, Lars Pind]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4641 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-31 21:57:59 +00:00
Rick Olson
d2eafa8b73
Dup the options passed to map.resources so that multiple resources get the same options. [Rick Olson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4639 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-31 20:32:48 +00:00
Rick Olson
ed4c295c47
Fixed the new_#{resource}_url route and added named route tests for Simply Restful. [Rick Olson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4638 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-31 20:00:18 +00:00
David Heinemeier Hansson
865b175765
Added map.resources from the Simply Restful plugin (backwards incompatible with the plugin!) [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4637 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-31 18:59:58 +00:00
Jeremy Kemper
ffaecb792e
r4886@ks: jeremy | 2006-07-31 00:01:55 -0700
...
comma
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4636 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-31 07:02:08 +00:00
David Heinemeier Hansson
63ad8b4d19
Fixed that integration simulation of XHRs should set Accept header as well [Edward Frederick]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4634 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-31 06:18:34 +00:00
David Heinemeier Hansson
df7efd7e21
Fixed that integration simulation of XHRs should set Accept header as well [Edward Frederick]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4633 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-31 06:18:20 +00:00
Rick Olson
efff453148
show missing file path on failed fixture_file_upload
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4631 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-30 16:16:46 +00:00
Michael Koziarski
d02c07dbb9
Ensure TestRequest#session always returns a TestSession [Koz]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4630 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-28 23:15:12 +00:00
Jamis Buck
d70d521955
Don't search a load-path of '.' for controller files, since it may include symlinks to all kinds of things and result in far too many irrelevant files being considered
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4625 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-27 15:31:07 +00:00
Nicholas Seckar
9d17f882ee
Update integration.rb to require test_process explicitly instead of via Dependencies
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4624 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-27 14:30:23 +00:00
David Heinemeier Hansson
45e319d0f8
Added ICS to extension lookup recognition [Lars Pind]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4622 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-26 16:34:49 +00:00
Rick Olson
04d9e94e88
Fixed that you can still access the flash after the flash has been reset in reset_session. Closes #5584 [lmarlow@yahoo.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4617 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-22 02:31:21 +00:00
Rick Olson
101ebc996a
Allow form_for and fields_for to work with indexed form inputs. [Jeremy Kemper, Matt Lyon]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4613 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-18 15:42:22 +00:00
Nicholas Seckar
378a935430
Remove leak in development mode
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4611 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-17 17:03:47 +00:00
Marcel Molina
2482e17e57
Get rid of constant redefinition warnings when running AP tests
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4610 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-13 03:32:38 +00:00
Marcel Molina
c80c6364d9
Provide support for decimal columns to form helpers. Closes #5672 . [dave@pragprog.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4609 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-13 03:25:17 +00:00
Jeremy Kemper
1dc4cc030f
Update documentation for erb trim syntax. Closes #5651 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4598 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-09 05:17:41 +00:00
Jeremy Kemper
71234daef1
r4487@asus: jeremy | 2006-04-29 12:21:39 -0700
...
Check whether @flash is defined? for warnings-safety.
r4488@asus: jeremy | 2006-04-29 12:23:15 -0700
Check whether @flash is defined? for warnings-safety. Obviates nil? check.
r4489@asus: jeremy | 2006-04-29 12:45:18 -0700
Check whether @session is defined? for warnings-safety.
r4490@asus: jeremy | 2006-04-29 12:50:41 -0700
Check whether @rendering_runtime is defined? for warnings-safety.
r4491@asus: jeremy | 2006-04-29 12:55:01 -0700
Check whether @_cycles is defined? for warnings-safety.
r4492@asus: jeremy | 2006-04-29 12:59:19 -0700
Check whether instance variables are defined? for warnings-safety.
r4493@asus: jeremy | 2006-04-29 13:14:09 -0700
Add nil @template to PrototypeHelperTest to suppress unitialized instance variable warning.
r4494@asus: jeremy | 2006-04-29 13:31:34 -0700
Check whether @auto_index defined? for warnings-safety.
r4495@asus: jeremy | 2006-04-29 13:32:24 -0700
Wrap content_columns redefinitions with silence_warnings.
r4496@asus: jeremy | 2006-04-29 13:35:28 -0700
Wrap more redefinitions with silence_warnings.
r4829@asus: jeremy | 2006-07-08 10:59:20 -0700
abstract unit, fix warnings
r4830@asus: jeremy | 2006-07-08 11:06:12 -0700
Use parens to silence warning.
r4831@asus: jeremy | 2006-07-08 11:06:48 -0700
Use parens to silence warning.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4595 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-08 18:14:49 +00:00
Jeremy Kemper
f801cd7959
Pass :id => nil or :class => nil to error_messages_for to supress that html attribute. Closes #3586 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4592 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-08 05:35:08 +00:00
Jeremy Kemper
eede40bcf0
Reset @html_document between requests so assert_tag works. Closes #4810 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4591 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-08 04:58:55 +00:00