Manfred Stienstra
5da9a74bd3
Add a failing test case for an implicit action with a before filter.
...
Signed-off-by: Andrew White <andyw@pixeltrix.co.uk>
2011-03-23 23:32:44 +00:00
Xavier Noria
3b91b3726d
Merge branch 'master' of git://github.com/lifo/docrails
2011-03-23 21:52:33 +01:00
Prem Sichanugrist
2ddfdba9a0
Do not show optional (.:format) block for wildcard route [ #6605 state:resolved]
...
This will make the output of `rake routes` to be correctly match to the behavior of the application, as the regular expression used to match the path is greedy and won't capture the format part by default
2011-03-22 09:19:40 -07:00
Aaron Patterson
55bf087da1
SJIS is an alias to Windows-31J in ruby trunk. Use SHIFT_JIS for this test
2011-03-21 10:00:30 -07:00
José Valim
1413c9b1d5
Improved resolver docs a bit
2011-03-19 16:06:50 -07:00
Chris Kowalik
d76fadbd7d
[action_view] docs for FileSystemResolver
2011-03-20 07:01:47 +08:00
Chris Kowalik
de1fe5e8a7
[action_view] added custom patterns to template resolver
2011-03-20 07:01:46 +08:00
Josh Kalderimis
0eae625256
fixes an issue with number_to_human when converting values which are less than 1 but greater than -1 [ #6576 state:resolved]
...
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2011-03-16 15:11:00 -03:00
Gabriel Horner
61781d84c1
doc :anchor option for #match in routes
2011-03-15 09:23:17 -04:00
Aaron Patterson
9f2706d770
use a list to represent the supported verbs for a route object
2011-03-14 18:26:30 -07:00
Aaron Patterson
9ba2d422f5
stop splatting arguments so that we can understand wtf is going on
2011-03-14 16:17:05 -07:00
Aaron Patterson
833a90594e
RegexpWithNamedGroups is only used for path_info, so only apply to path info
2011-03-14 15:17:29 -07:00
Xavier Noria
21b12d89a6
Merge branch 'master' of git://github.com/lifo/docrails
2011-03-14 22:09:52 +01:00
Manuel Meurer
deae670e9a
Change ActionView::ViewPathSet to ActionView::PathSet
2011-03-13 15:14:51 +07:00
Mike Gehard
58de03f077
Add additional text to NotImplementedErrors [ #6328 state:resolved]
...
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2011-03-12 13:43:23 -02:00
Aaron Patterson
acd4bfb537
Just define methods directly on the class rather than use the module
...
indirection.
clever--
2011-03-11 18:16:47 -08:00
Aaron Patterson
89c5b9aee7
do not automatically add format to routes that end in a slash
2011-03-11 18:06:22 -08:00
Prem Sichanugrist & Xavier Noria
68802d0fbe
Filter sensitive query string parameters in the log [ #6244 state:committed]
...
This provides more safety to applications that put secret information in the query string, such as API keys or SSO tokens.
Signed-off-by: Xavier Noria <fxn@hashref.com>
2011-03-11 00:16:18 +01:00
Andrew White
03cbd9672c
Filter params that return nil for to_param and allow through false values
2011-03-09 14:44:25 +00:00
Aaron Patterson
0c777bace2
stop being clever and just call methods on the Route object
2011-03-08 16:18:27 -08:00
Aaron Patterson
f975626dc1
test/unit in ruby trunk adds a new instance variable. YAY!
2011-03-08 14:09:44 -08:00
Akira Matsuda
071ddb8281
more "SSL everywhere" for GitHub URLs
...
see: https://github.com/blog/738-sidejack-prevention-phase-2-ssl-everywhere
2011-03-07 06:18:32 +09:00
Akira Matsuda
5bed37779a
"SSL everywhere" for GitHub URLs
...
see: https://github.com/blog/738-sidejack-prevention-phase-2-ssl-everywhere
2011-03-07 05:56:02 +09:00
Akira Matsuda
d91be36598
fix typos
2011-03-07 05:21:25 +09:00
Andrew White
31f09f9dbc
Improve testing of cookies in functional tests:
...
- cookies can be set using string or symbol keys
- cookies are preserved across calls to get, post, etc.
- cookie names and values are escaped
- cookies can be cleared using @request.cookies.clear
[#6272 state:resolved]
2011-03-06 12:49:44 +00:00
Andrew White
e00867bc43
Raise ArgumentError if route name is invalid [ #6517 state:resolved]
2011-03-06 07:08:50 +00:00
Alexander Uvarov
0509bf35f1
Allow model to be inherited from Hash [ #6487 state:resolved]
...
Signed-off-by: Andrew White <andyw@pixeltrix.co.uk>
2011-03-06 05:28:35 +00:00
Diego Carrion
dff73dec22
added failing test for fields_for with a record object that inherits from Hash
...
Signed-off-by: Andrew White <andyw@pixeltrix.co.uk>
2011-03-06 05:18:56 +00:00
R.T. Lechow
87e9e3f9af
Action Pack typos.
2011-03-05 11:56:35 +01:00
Alexander Uvarov
0db915efd1
Add an option to FormBuilder to omit hidden field with id
...
[#4551 state:committed]
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2011-03-04 16:38:08 -02:00
Aaron Patterson
1f2e7214aa
make sure string keys are always looked up from the class cache
2011-03-02 10:11:28 -08:00
Aaron Patterson
9198372421
Ruby 1.8: Y U NO FUN?
2011-03-02 09:43:27 -08:00
Aaron Patterson
dd41387f34
use newer class cache api
2011-03-02 09:35:10 -08:00
Cheah Chu Yeow
2ee5555744
Fix Action caching bug where an action that has a non-cacheable response always renders a nil response body. It now correctly renders the response body.
...
Note that only GET and HTTP 200 responses can be cached.
[#6480 state:committed]
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2011-03-02 13:11:07 -02:00
Aaron Patterson
f345e2380c
yo dawg, directly use the class cache rather than the cache of the cache
2011-03-01 17:43:45 -08:00
Aaron Patterson
7b6bfe84f3
refactor Reference to a ClassCache object, fix lazy lookup in Middleware so that anonymous classes are supported
2011-03-01 17:20:35 -08:00
Aaron Patterson
50ed1a25a4
initialize ivars
2011-03-01 17:20:35 -08:00
Aaron Patterson
fd26afc93b
Enumerable gives us include?, so remove include?
2011-03-01 10:21:44 -08:00
Aaron Patterson
648fd60ecf
prefer composition over inheritance with AD::MS
2011-03-01 10:14:09 -08:00
Aaron Patterson
46bb424287
Revert "compute ext in initialize, and use an attr_reader"
...
This reverts commit 2dbb73bdda3b81947fd112486ac4285fb1a6e3a9.
Conflicts:
actionpack/lib/action_dispatch/middleware/static.rb
2011-02-28 19:47:09 -08:00
Aaron Patterson
f279422e33
no need to pass a regex to Regexp.compile
2011-02-28 18:03:06 -08:00
Aaron Patterson
2dbb73bdda
compute ext in initialize, and use an attr_reader
2011-02-28 17:54:00 -08:00
Aaron Patterson
54fdd33f33
use a subclass of AS::TZ for testing html output
2011-02-28 16:30:14 -08:00
Josh Kalderimis
0f8d2794f2
updated Time, Date and DateTime current methods in AS to use Time.zone and not Time.zone_default.
...
[#6410 state:committed]
2011-02-28 14:05:49 -08:00
Santiago Pastorino
53b17e9ad0
javascript_include_tag shouldn't raise if you register an expansion key with nil value
2011-02-28 11:52:00 -02:00
Santiago Pastorino
801e314006
Add tests for register expansion methods with key = []
2011-02-28 11:30:12 -02:00
Prem Sichanugrist
839d06f5f2
We're in 2011, let's update our license
...
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2011-02-22 18:24:20 -02:00
Michael Koziarski
3d907a68d9
Prepend the CSRF filter to make it much more difficult to execute application code before it fires.
2011-02-23 09:00:41 +13:00
Xavier Noria
f41bf6938f
merges docrails
2011-02-18 23:22:15 +01:00
Nicholas Rowe
9a9d895481
Fix Typos: remove several occurences of the the
2011-02-17 20:46:52 -05:00