Ryuta Kamizono
c81af6ae72
Enable Layout/EmptyLinesAroundAccessModifier
cop
...
We sometimes say "✂️ newline after `private`" in a code review (e.g.
https://github.com/rails/rails/pull/18546#discussion_r23188776 ,
https://github.com/rails/rails/pull/34832#discussion_r244847195 ).
Now `Layout/EmptyLinesAroundAccessModifier` cop have new enforced style
`EnforcedStyle: only_before` (https://github.com/rubocop-hq/rubocop/pull/7059 ).
That cop and enforced style will reduce the our code review cost.
2019-06-13 12:00:45 +09:00
Aaron Patterson
a3a98606f3
pass format to the digestor
2019-02-16 10:57:51 -08:00
Daniel Colson
a1ac18671a
Replace assert !
with assert_not
...
This autocorrects the violations after adding a custom cop in
3305c78dcd.
2018-04-19 08:11:33 -04:00
Daniel Colson
82c39e1a0b
Use assert_empty and assert_not_empty
2018-01-25 23:32:59 -05:00
Daniel Colson
94333a4c31
Use assert_predicate and assert_not_predicate
2018-01-25 23:32:59 -05:00
Rafael França
a8ebd48559
Merge pull request #31004 from shuheiktgw/remove_unnecessary_returns
...
Remove redundant return statements
2017-10-31 01:47:35 -04:00
Shuhei Kitagawa
03dd47ff21
removed unnecessary semicolons
2017-10-28 17:39:58 +09:00
Shuhei Kitagawa
c40b4428e6
removed unnecessary returns
2017-10-28 17:20:38 +09:00
Kir Shatrov
82df8c2ca5
Use frozen string literal in actionmailer/
2017-07-23 18:17:19 +03:00
Matthew Draper
87b3e226d6
Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"
...
This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing
changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
2017-07-02 02:15:17 +09:30
Kir Shatrov
cfade1ec7e
Enforce frozen string in Rubocop
2017-07-01 02:11:03 +03:00
bogdanvlviv
40bdbce191
Define path with __dir__
...
".. with __dir__ we can restore order in the Universe." - by @fxn
Related to 5b8738c2df003a96f0e490c43559747618d10f5f
2017-05-23 00:53:51 +03:00
David Heinemeier Hansson
75fa8dd309
Use recyclable cache keys ( #29092 )
2017-05-18 18:12:32 +02:00
Rafael Mendonça França
55f9b8129a
Add three new rubocop rules
...
Style/SpaceBeforeBlockBraces
Style/SpaceInsideBlockBraces
Style/SpaceInsideHashLiteralBraces
Fix all violations in the repository.
2016-08-16 04:30:11 -03:00
Stan Lo
ab2af4dfcb
Modify LogSubscriber for single partial's cache message.
...
Implement naive partial caching mechanism.
Add test for LogSubscriber
Use ActionView::Base#log_payload to store log_subscriber's payload, so we can pass cache result into it.
Fixed tests
Remove useless settings
Check if #log_payload exists before calling it. Because other classes also includes CacheHelper but don't have is attribute
Use @log_payload_for_partial_reder instead of #log_payload to carry ActionView's payload.
Update test's hash syntax
Add configuration to enable/disable fragment caching logging
Remove unless test and add new test to ensure cache info won't effect next rendering's log
Move :enable_fragment_cache_logging config from ActionView to ActionPack
Apply new config to tests
Update actionview's changelog
Update configuration guide
Improve actionview's changelog
Refactor PartialRenderer#render and log tests
Mute subscriber's log instead of disabling instrumentation.
Fix typo, remove useless comment and use new hash syntax
Improve actionpack's log_subscriber test
Fix rebase mistake
Apply new config to all caching intstrument actions
2016-08-08 00:24:39 +08:00
Xavier Noria
b326e82dc0
applies remaining conventions across the project
2016-08-06 20:20:22 +02:00
Xavier Noria
b91ff557ef
applies new string literal convention in actionmailer/test
...
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
2016-08-06 19:03:39 +02:00
Vipul A M
cbb25c4b1c
Expand on Action Mailer Fragment caching tests
2016-04-17 23:16:09 +05:30
Stan Lo
98fe07a946
Move ActionMailer::Caching's content into ActionMailer::Base instead of including it
...
Remove useless helper in ActionDispatch::Caching and fix indentation
2016-02-23 21:06:41 -03:00
Stan Lo
3e824d3f5b
Move most caching methods to ActionDispatch::Caching, and let ActionMailer and ActionController to include it
2016-02-23 21:06:40 -03:00
Stan Lo
049b6e670f
Porting ActionController::Caching to ActionMailer::Caching
2016-02-23 21:04:16 -03:00