TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
31,383 Commits 2 Branches 0 Tags 294 MiB
629bc03bf8
Commit Graph

31383 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Vijay Dev
0a83e89222 moar copy edits [ci skip] 2012-06-14 22:45:42 +05:30
Vijay Dev
6efc5bf404 copy editing [ci skip] 2012-06-14 22:37:17 +05:30
Steve Klabnik
a7f4b0a123 Remove update_attribute. 
Historically, update_attribute and update_attributes are similar, but
with one big difference: update_attribute does not run validations.
These two methods are really easy to confuse given their similar
names. Therefore, update_attribute is being removed in favor of
update_column.

See the thread on rails-core here:
https://groups.google.com/forum/?fromgroups#!topic/rubyonrails-core/BWPUTK7WvYA
 2012-06-14 18:54:24 +02:00
Vijay Dev
3b55b7fe7c Revert "Add a note about JavaScript runtime" 
This reverts commit d63b69ba7f2b9111aeb04b50884949c2a4b6e584.
 2012-06-14 22:15:55 +05:30
Aaron Patterson
f5e7cb84cd AV::TestCase does not need to be loaded when eagerly loading the 
framework
 2012-06-14 09:42:24 -07:00
Aaron Patterson
b9b9e39bab i suck, fixing error message 2012-06-14 09:37:58 -07:00
José Valim
68021d3602 Merge pull request #6671 from mrbrdo/master 
Bad Regexp exploits "fix" master branch
 2012-06-14 09:35:36 -07:00
MrBrdo
bc7c0b5c10 prevent users from unknowingly using bad regexps that can compromise security (http://homakov.blogspot.co.uk/2012/05/saferweb-injects-in-various-ruby.html) 2012-06-14 18:10:49 +02:00
Oscar Del Ben
32664e7463 Add server.run example 
This is the last chapter before I go back and make sure the guide is
complete/review
 2012-06-14 09:05:10 -07:00
Aaron Patterson
99c9d18601 Wrap up missing helper exceptions 
The `path` method on missing helper errors is inconsistent with the
implementation on LoadError in Ruby 2.0.  Wrap up the missing helper
exceptions so that the inconsistent behavior is mirrored in Ruby 2.0
(until we can figure out *why* it's inconsistent).
 2012-06-14 09:01:58 -07:00
Konstantin Shabanov
12e9a75f22 Add uuid type support to PostgreSQL adapter 2012-06-14 17:44:51 +04:00
Xavier Noria
f278b06789 removes item in the Active Record CHANGELOG 
That change to update_attribute was considered
to be too subtle and was reverted in 30ea923
just before Rails 3 shipped. Later we introduced
update_column (Rails 3.1).
 2012-06-14 11:50:10 +02:00
Aaron Patterson
5d50befa2e using hax to fix tests on Ruby 2.0 2012-06-13 18:01:16 -07:00
Santiago Pastorino
6d7e374c5b Fix build 2012-06-13 20:21:35 -03:00
Santiago Pastorino
b5d5f96ed9 Merge pull request #6721 from homakov/patch-2 
These lines don't help to mitigate CVE. They only turn [nil] into nil, w...
 2012-06-13 14:40:53 -07:00
Nathan Long
f48c576fc8 Show how to add attributes to options 2012-06-13 15:49:31 -04:00
Santiago Pastorino
459de6fac3 ActionController::Caching depends on RackDelegation and AbstractController::Callbacks 2012-06-13 16:18:03 -03:00
Oscar Del Ben
18faa5b337 Show when Rack middlewares are executed 2012-06-13 08:59:14 -07:00
Oscar Del Ben
1f07ff97ab Add initialize! explanation 2012-06-13 08:48:45 -07:00
Oscar Del Ben
81fd371f13 Close explanation of config/environment 2012-06-13 08:34:48 -07:00
Egor Homakov
e995734e7f These lines don't help to mitigate CVE. They only turn [nil] into nil, w/o them [nil] turns into [] and that is quite innocent. 
generated  SQL - `IN (NULL)`
compact! did all the job.
 2012-06-13 17:49:29 +04:00
Aaron Patterson
56a1bb2f10 raise the same exception in order to keep path info 
Ruby 2.0.0 implements LoadError#path, but newly raised load errors will
not contain the path information.  Replace the error message, copy
blame, and rereaise the same exception object
 2012-06-12 16:19:51 -07:00
Aaron Patterson
00d8ee8e30 fixing security email address 2012-06-12 14:34:44 -07:00
Aaron Patterson
2be40a873e Merge branch 'master-sec' 
* master-sec:
  Array parameters should not contain nil values.
 2012-06-12 14:25:45 -07:00
Aaron Patterson
24894fc130 Array parameters should not contain nil values. 2012-06-12 14:07:29 -07:00
Rafael Mendonça França
6ff78a188a Merge pull request #6715 from arunagw/add_asserts 
Need a assert here in tests
 2012-06-12 11:43:12 -07:00
Arun Agrawal
ddf58fa9aa Need a assert here in tests 2012-06-12 14:39:40 -04:00
Rafael Mendonça França
a268d2dc97 Merge pull request #6676 from aurelian/master 
Don't assign the attributes if the list is empty
 2012-06-12 10:45:19 -07:00
Andrew Hooker
5dd4358f1d Adding note about cosmetic changes not being accepted 2012-06-12 13:55:00 -03:00
Santiago Pastorino
fa4b0295b6 content_type is already a Mime::Type object 2012-06-12 13:42:10 -03:00
Santiago Pastorino
0e06e8a692 This consider_all_requests_local doesn't make sense 
This middleware is only for Public Exceptions.
This follows bd8c0b8a
 2012-06-12 13:25:11 -03:00
Rafael Mendonça França
14ccb0d8be Merge pull request #6444 from kennyj/create_extenstion_hstore 
Create hstore extension when building PostgreSQL databases (for rails contributor).
 2012-06-12 06:36:01 -07:00
Jakub Kuźma
595b8bc8f8 fixed http token authentication formatting 2012-06-12 13:00:17 +02:00
kennyj
34492af710 Create hstore extension when building PostgreSQL databases. 2012-06-12 19:34:24 +09:00
José Valim
122f6de2e0 Merge pull request #6711 from takkanm/fix-warning-LoadError-path-method 
fix method redefined warning in Ruby2.0
 2012-06-12 02:34:07 -07:00
Mitsutaka Mimura
a599c034fd fix method redefined warning in Ruby2.0 
Ruby2.0 already has LoadError#path.
 2012-06-12 17:41:53 +09:00
José Valim
5ea2b11ad7 Stop relying on mutable structures in the FileUpdateChecker 2012-06-12 10:36:13 +02:00
Rafael Mendonça França
e6ea3fec30 Remove warnings and unused code 2012-06-11 22:07:37 -03:00
Sam Oliver
07d346646f Fix cache_store configuration example 2012-06-11 23:29:59 +01:00
Rafael Mendonça França
65d584c35b No need to cache table metadata in advance now that #6683 was merged. 2012-06-11 18:13:14 -03:00
Santiago Pastorino
bd8c0b8a7a Return proper format on exceptions 2012-06-11 18:07:30 -03:00
Rafael Mendonça França
174f36a077 Merge pull request #6492 from pmahoney/fair-connection-pool2 
Fair connection pool2

Conflicts:
	activerecord/test/cases/associations/eager_test.rb
 2012-06-11 17:26:33 -03:00
Rafael Mendonça França
2d1ca38774 Merge pull request #6709 from amatsuda/sqlite3_version_is_always_gt_125 
current AR::ConnectionAdapters::SQLite3Adapter supports only SQLite3 ~> 1.3.6
 2012-06-11 13:04:43 -07:00
Akira Matsuda
998ef50ef1 current AR::ConnectionAdapters::SQLite3Adapter supports only SQLite3 ~> 1.3.6 2012-06-12 04:54:48 +09:00
José Valim
c53ff3317d Merge pull request #6708 from amatsuda/ignore_git_ignored_files_in_rake_test_uncommitted 
ignore .gitignore'd files in rake test:uncomitted
 2012-06-11 12:37:05 -07:00
Akira Matsuda
2d3e488bb3 ignore .gitignore'd files in rake test:uncomitted 2012-06-12 03:29:48 +09:00
Rafael Mendonça França
0d1f98ce65 Merge pull request #6706 from amatsuda/ar_timezone_format_test_tiny_fix 
TimeZone format is always /[+-]\d{2}:\d{2}/ in Ruby 1.9
 2012-06-11 10:52:25 -07:00
Akira Matsuda
73d1046646 TimeZone format is always /[+-]\d{2}:\d{2}/ in Ruby 1.9 2012-06-12 02:41:58 +09:00
Rafael Mendonça França
0e97aa2e51 Merge pull request #6705 from ganeshkumar/string_method_changes 
both string and symbol will be interpolated as string no need to convert to_s
 2012-06-11 10:37:02 -07:00
Akira Matsuda
588bb6b987 Range#cover? is not implemented in AS now 2012-06-12 02:29:21 +09:00