TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
28,648 Commits 2 Branches 0 Tags 294 MiB
640f6c201d
Commit Graph

7299 Commits

Author SHA1 Message Date
kennyj
640f6c201d Fix GH #4674. Reset column information and sequence name when setting table_name. 2012-03-04 22:22:27 +09:00
Jon Leighton
223549f420 Fix rake test_sqlite3_mem 2012-03-04 12:15:11 +00:00
Jon Leighton
7ba0fe2172 Remove unusused variables 2012-03-04 11:23:39 +00:00
Piotr Sarnacki
4443b3647d Merge pull request #5255 from carlosantoniodasilva/active-record-review 
Refactor and cleanup in some ActiveRecord modules
 2012-03-03 11:10:17 -08:00
Vishnu Atrai
d8996d3cab remove usages of AS::OrderedHash 2012-03-03 23:48:29 +05:30
Vijay Dev
2aec357b7e Merge pull request #4984 from raghunadhd/change_orderhash 
Refactored code
 2012-03-03 09:05:23 -08:00
Vijay Dev
f9e26940b3 Merge branch 'master' of github.com:lifo/docrails 2012-03-03 22:08:24 +05:30
Carlos Antonio da Silva
50725cec39 Refactor and cleanup in some ActiveRecord modules 
* Avoid double hash lookups in AR::Reflection when reflecting associations/aggregations
* Minor cleanups: use elsif, do..end, if..else instead of unless..else
* Simplify DynamicMatchers#respond_to?
* Use "where" instead of scoped with conditions hash
* Extract `scoped_by` method pattern regexp to constant
* Extract noisy class_eval from method_missing in dynamic matchers
* Extract readonly check, avoid calling column#to_s twice in persistence
* Refactor predicate builder, remove some variables
 2012-03-03 04:09:50 -03:00
Aaron Patterson
b5c939dcb3 only log an error if there is a logger. fixes #5226 2012-03-02 10:25:09 -08:00
Xavier Noria
fcef72890b revert setting NOT NULL constraints in add_timestamps 
Commit 3dbedd2 added NOT NULL constraints both to table
creation and modification. For creation the new default
makes sense, but the generic situation for changing a
table is that there exist records. Those records have
no creation or modification timestamps, and in the
general case you don't even know them, so when updating
a table these constraints are not going to work. See
a bug report for this use case in #3334.
 2012-03-01 16:15:00 -08:00
Waseem Ahmad
92887ca315 Add documentation for IndexDefinition. 2012-03-02 01:28:30 +05:30
claudiob
05c6caf48c Add release dates to documentation 
Set "March 1, 2012" as the release date for 3.2.2, 3.1.4, 3.0.12
 2012-03-01 11:20:03 -08:00
kennyj
adf3cb5adb Fix warning: assigned but unused variable 2012-03-01 03:09:33 +09:00
Xavier Noria
7d29d7afd5 Merge pull request #5212 from MarkMT/master 
update_only documentation for accepts_nested_attributes_for
 2012-02-28 14:33:19 -08:00
Mark
27da612eec Modified comments explaining what the update_only option does. 2012-02-28 14:28:44 -06:00
José Valim
5bbd2d3aa8 Merge pull request #5196 from lest/patch-3 
force datetime attributes to be changed, fix GH #3965
 2012-02-28 10:09:40 -08:00
José Valim
d17e44edde Merge pull request #5197 from lest/patch-4 
remove unnecessary code
 2012-02-27 22:50:24 -08:00
Aaron Patterson
acf7e86024 Revert "only mutate the scope object in the bind method" 
This reverts commit 1b9e19cd22f2b5d5e7b82e042f92340822c0f966.
 2012-02-27 16:48:34 -08:00
Sergey Nartimov
cb400b0c65 remove unnecessary code 
it was added in 36129f21b86db4bd69e932e586129e246c2a5ca8
but isn't useful anymore as corresponding tests pass without it
 2012-02-28 01:26:39 +03:00
Sergey Nartimov
ddb5d2f756 force datetime attributes to be changed, fix GH #3965 2012-02-28 00:33:50 +03:00
Aaron Patterson
1b9e19cd22 only mutate the scope object in the bind method 2012-02-27 11:34:41 -08:00
Aaron Patterson
4f82553e54 bind value creation refactoring 2012-02-27 11:29:16 -08:00
Aaron Patterson
2adf78d335 removing dead code 2012-02-27 11:13:56 -08:00
Aaron Patterson
4bc2ae0da1 use bind values for join columns 2012-02-27 11:13:56 -08:00
Aaron Patterson
699e460be2 Merge pull request #5168 from kennyj/fix_5152 
[PostgreSQL] Remove NULLS FIRST/LAST. Closes #5152
 2012-02-27 10:27:08 -08:00
Aaron Patterson
a19dd29e55 Merge pull request #5173 from kennyj/fix_3931-2 
Fix type_to_sql with text and limit on mysql/mysql2. Fix GH #3931 (Try again).
 2012-02-27 10:21:18 -08:00
Vijay Dev
1e25d6217c Merge branch 'master' of github.com:lifo/docrails 
Conflicts:
	actionmailer/CHANGELOG.md
 2012-02-25 21:52:59 +05:30
kennyj
fe7cacb510 Fix type_to_sql with text and limit on mysql/mysql2. Fix GH #3931. 2012-02-26 00:35:58 +09:00
kennyj
404b73bce1 Remove NULLS FIRST/LAST. closes #5152 2012-02-25 23:01:43 +09:00
Paco Guzman
152a393d4f Update changelogs with rails 3.0-stable branch info 2012-02-25 13:50:08 +01:00
Aaron Patterson
9ef701d659 use regular ruby for fewer method calls. we do not need 🎁s! 2012-02-24 16:55:22 -08:00
Noah Hendrix
0519567e3d Fixed typo in composed_of example with Money#<=>, was comparing amount itself instead of other_money.amount 2012-02-24 13:55:24 -06:00
Xavier Noria
9d1f1b1ea9 removes verify_active_connections! 
The method verify_active_connections! was used in
the old days (up to 2.1 I think) by the dispatcher
to verify the connections, but nowadays we do that
in a different way and this method is obsolete.
 2012-02-24 09:11:59 -08:00
Michael Guterl
6c384a6d9f Update with new task names for building mysql and postgresql databases 2012-02-23 09:49:48 -05:00
Marcelo Silveira
846a9bcae8 Remove unused implementation of next_migration_number 2012-02-23 09:56:34 -02:00
Dimitar Dimitrov
7ee7f14e11 Revert "Remove meaningless code from the examples" of AutosaveAssociation 
Reverts a part of 91148936f770dc8bbbb33d46a09528f1a32d8a71. Should probably be squashed with it when merging back in rails/rails.
 2012-02-22 22:25:44 +02:00
Dimitar Dimitrov
91148936f7 Minor fixes to ActiveRecord::AutosaveAssociation's docs 
* Fix typos
* Remove meaningless code from the examples
 2012-02-22 22:19:42 +02:00
Aaron Patterson
66b7eb1927 bumping up arel 2012-02-21 16:15:12 -08:00
Aaron Patterson
fd398475af prepared statements can be disabled 2012-02-21 16:15:12 -08:00
Aaron Patterson
19c7124c4f more ruby 2.0 respond_to? changes 2012-02-21 11:37:00 -08:00
Aaron Patterson
f48a33be7d tag bind params with a bind param object 2012-02-20 18:16:56 -08:00
William Lawson
1649a860f2 removed commented line. 3434 tests, 10531 assertions, 0 failures, 0 errors, 31 skips 2012-02-20 07:14:51 -05:00
William Lawson
977f4bdee6 Restored ability to identify ID and Sequence from tables relying on a nonmatching sequence default value for PK. 2012-02-20 07:10:46 -05:00
Josef Šimánek
b4b2f5d8e4 Update activerecord/CHANGELOG.md 2012-02-18 18:29:48 +01:00
Peter Mitchell
910c59fffe Correctly print names of non-timestamped migrations with db:migrate:status 2012-02-17 16:58:11 +01:00
Aaron Patterson
decafdd57a use Process.pid rather than $$ 2012-02-16 14:49:21 -08:00
Aaron Patterson
aaff1a4101 database connections are automatically established after forking. 
Connection pools are 1:1 with pids.
 2012-02-16 14:33:38 -08:00
Jeremy Kemper
079e2f4ec1 Merge pull request #5064 from lest/patch-1 
move id_before_type_cast to PrimaryKey module
 2012-02-16 10:24:05 -08:00
Sergey Nartimov
ec4759d205 move id_before_type_cast to PrimaryKey module 2012-02-16 19:49:38 +03:00
Waseem Ahmad
9aad20f184 Autoload various constants effectively in abstract connection adapter. 2012-02-16 17:35:20 +05:30