Carlos Antonio da Silva
|
aa7fdfb859
|
Remove short circuit return in favor of simple conditional
|
2013-11-15 01:11:57 -02:00 |
|
Carlos Antonio da Silva
|
374d465f28
|
Invert conditional to avoid double checking for Regexp
|
2013-11-15 01:04:57 -02:00 |
|
Carlos Antonio da Silva
|
9014a79436
|
Only check that the option exists once instead of doing on each conditional
|
2013-11-15 01:01:59 -02:00 |
|
Carlos Antonio da Silva
|
61fef76106
|
Remove argument that is accessible as attribute
|
2013-11-15 01:00:53 -02:00 |
|
Carlos Antonio da Silva
|
b8c6c08452
|
Cache regexp source on format validation to avoid allocating new objects
Example:
>> r = /some-regexp/
=> /some-regexp/
>> r.source.object_id == r.source.object_id
=> false
|
2013-11-15 00:38:55 -02:00 |
|
Carlos Antonio da Silva
|
70161ae3b8
|
Make code simpler to read by using a case statement
|
2013-11-15 00:24:54 -02:00 |
|
Carlos Antonio da Silva
|
12815e0d44
|
Avoid a new hash allocation
|
2013-11-15 00:24:54 -02:00 |
|
Carlos Antonio da Silva
|
4c7e3a3087
|
Use a simple conditional rather than short circuit with next
|
2013-11-15 00:19:03 -02:00 |
|
Carlos Antonio da Silva
|
d2992818e0
|
Simplify number parsing logic in numericality validation
|
2013-11-15 00:07:22 -02:00 |
|
Carlos Antonio da Silva
|
f70e30ec6d
|
Avoid creation of extra hash with merge just to set a value
|
2013-11-15 00:07:22 -02:00 |
|
Carlos Antonio da Silva
|
deaf285824
|
Merge pull request #12686 from kryzhovnik/master
Minor doc fix of ActiveModel::Naming. [ci skip]
Conflicts:
activemodel/lib/active_model/naming.rb
|
2013-11-02 14:46:56 -02:00 |
|
Andrey Samsonov
|
fb6f02c521
|
Minor doc fix of ActiveModel::Naming.
- qoute example line's result when it kind of String
- right ("singular_route_key") method in example
|
2013-10-29 15:23:03 +04:00 |
|
Guillermo Iguaran
|
c31b900221
|
Merge pull request #12635 from mperham/4-0-stable
Allow any version of BCrypt
|
2013-10-24 19:31:13 -02:00 |
|
Akira Matsuda
|
68db6bc431
|
Let validates_inclusion_of accept Time and DateTime ranges
fixes 4.0.0 regression introduced in 0317b93c17a46d7663a8c36edc26ad0ba3d75f85
|
2013-10-23 22:10:15 +09:00 |
|
T.J. Schuck
|
5d7b413d84
|
Use bcrypt's public cost attr, not internal constant
See:
- https://github.com/codahale/bcrypt-ruby/pull/63
- https://github.com/codahale/bcrypt-ruby/pull/64
- https://github.com/codahale/bcrypt-ruby/pull/65
|
2013-10-10 11:46:59 -04:00 |
|
Arun Agrawal
|
31488dba85
|
observers are not part of ActiveModel [ci skip]
|
2013-10-09 14:25:16 +02:00 |
|
Vijay Ubuntu
|
27576df810
|
adding load_path to include active_model in the load path of example
similar to activerecord/examples/simple.rb
|
2013-10-09 01:52:55 +05:30 |
|
Rafael Mendonça França
|
c48c111bb2
|
Merge pull request #8791 from griffinmyers/master
Updated DirtyModel's @changed_attributes hash to be symbol/string agnostic
Conflicts:
activemodel/CHANGELOG.md
|
2013-10-03 11:37:10 -03:00 |
|
T.J. Schuck
|
4a99e10199
|
bcrypt-ruby v3.1.2 supports Ruby 2.0 on Windows
|
2013-09-23 14:28:26 -04:00 |
|
Rafael Mendonça França
|
ed0b080cb3
|
Fix the documentation method.
It is reload! in the class definition.
[ci skip]
|
2013-09-23 11:25:43 -03:00 |
|
Rafael Mendonça França
|
7ef29140eb
|
No need to abbreviate ActiveModel
[ci skip]
|
2013-09-23 11:01:43 -03:00 |
|
Rafael Mendonça França
|
089e1b6426
|
Document reset_changes since it is part of public API
[ci skip]
|
2013-09-23 11:00:56 -03:00 |
|
Rafael Mendonça França
|
9aa1a3d853
|
Merge pull request #10816 from bogdan/less-dirty-dirty
Make AM::Dirty less dirty to plugin into AR or other library
|
2013-09-23 10:59:05 -03:00 |
|
Rajarshi Das
|
782d794c20
|
use assert_empty in activemodel conditional validation test cases
|
2013-09-10 17:26:39 +05:30 |
|
Rajarshi Das
|
e21a18bed0
|
fix actionview and activemodel test cases typos
|
2013-09-05 14:21:57 +05:30 |
|
Gaurish Sharma
|
65f1766a08
|
Add :nodoc: to ActiveModel::SecurePassword.min_cost
[ci skip]
|
2013-08-29 01:27:18 +05:30 |
|
Rajarshi Das
|
9f478deaab
|
remove unused instance variable
|
2013-08-23 16:04:08 +05:30 |
|
Guillermo Iguaran
|
99e33c03b7
|
Dont' check for any order in hash since we aren't sorting it and this is determinated only by the used interpreter
|
2013-08-18 16:40:21 -05:00 |
|
Guillermo Iguaran
|
c40111c346
|
Refactor serialization test for hash order
|
2013-08-18 09:04:09 -05:00 |
|
Gaurish Sharma
|
90c450f6cd
|
Avoid Skip in test, have a unified test for order
|
2013-08-09 15:27:21 +05:30 |
|
Gaurish Sharma
|
9f8116fb77
|
Add tests for ActiveModel::Serializers::JSON#as_json ordering
|
2013-08-09 04:32:00 +05:30 |
|
Ryoji Yoshioka
|
23ef1dfd70
|
Fix: documentation for ActiveModel::Errors
|
2013-08-05 18:58:22 +09:00 |
|
Max Shytikov
|
af1e3b7c48
|
fix tests
|
2013-07-30 20:03:57 +03:00 |
|
Arun Agrawal
|
f52832de2a
|
grab executable from rubygems
As done here d7fc97d3f90c0e30865d32ce202658f03248cacc
|
2013-07-26 11:07:25 +02:00 |
|
Vladimir Kiselev
|
3be0cdfa55
|
Fix secure_password password_confirmation validations
|
2013-07-24 03:14:15 +04:00 |
|
Burkhard Vogel-Kreykenbohm
|
ad62cf68f8
|
bcrypt-ruby stable is 3.1
|
2013-07-17 16:39:07 +02:00 |
|
John Gesimondo
|
0e945f8909
|
it's xml, not json
change docs for xml serializer to talk about xml
|
2013-07-13 16:25:04 -07:00 |
|
Ankit Gupta-FIR
|
6a71d09ad2
|
Replaced older rocket sign to new :
|
2013-07-04 17:25:50 +01:00 |
|
Aaron Patterson
|
09b31f08d4
|
eagerly initialize the attributes module to avoid check-then-set race conditions
|
2013-07-02 14:34:40 -07:00 |
|
Aaron Patterson
|
4c88f4ce16
|
remove wrong documentation from a :nodoc:'d method
|
2013-07-02 14:04:40 -07:00 |
|
Aaron Patterson
|
d094aaad19
|
the data structure used to store attribute aliases should not be exposed
|
2013-07-01 16:23:08 -07:00 |
|
Vipul A M
|
404a61e19c
|
Remove redundant escapes from xml serialization test
|
2013-07-01 10:17:33 +05:30 |
|
Steven Yang
|
6e583cdac3
|
fix typo in ActiveModel::Error docs [ci skip]
|
2013-06-30 18:38:29 -03:00 |
|
Steven Yang
|
5fe43ffcfb
|
remove evals from AM::Validations::Callbacks
follow the same refactor at a63a964a5d1ed02cf0df1b1a33a96ed2a9fa987b
|
2013-06-30 18:47:55 +08:00 |
|
Steven Yang
|
e8fe6660d2
|
provide a more sementicthe local variables name for ActiveModel::Validations::Clusivity#include? method
the original name `exclusion` is a bit confusing when using with the method `inclusion_method`
rename it to a more logic neutral name.
|
2013-06-29 18:36:40 +08:00 |
|
Paul Nikitochkin
|
e63ba910ae
|
Remove deprecation warning from AttributeMethodsMatcher
|
2013-06-28 00:16:42 +03:00 |
|
Łukasz Strzałkowski
|
468939297d
|
Remove deprecated attr_protected/accessible
Rails 4.0 has removed attr_protected and attr_accessible feature in favor of Strong Parameters.
|
2013-06-27 20:38:30 +02:00 |
|
Carlos Antonio da Silva
|
48ab2c06e0
|
Merge pull request #11054 from senny/11048_make_default_value_explicit
make default value for `:message` on `AM::Errors` explicit.
|
2013-06-27 05:16:38 -07:00 |
|
Carlos Antonio da Silva
|
61346d1b42
|
Merge pull request #10774 from chuckbergeron/validates-inclusion-of-accuracy-for-non-numeric-ranges
Greater accuracy for validates_inclusion_of on non-numeric ranges
Closes #10774, fixes #10593
|
2013-06-25 21:48:41 -03:00 |
|
Akshay Khole
|
444d3412b9
|
Fixing Issue #11083
Removing other occurrences of `the` appearing twice
|
2013-06-25 16:47:29 +05:30 |
|