TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
2,196 Commits 2 Branches 0 Tags 294 MiB
6a8b9484a7
Commit Graph

799 Commits

Author SHA1 Message Date
Tobias Lütke
6a8b9484a7 action pack asserts don't spam you with unnecissary backtraces anymore 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2611 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 13:58:22 +00:00
Thomas Fuchs
09aae0a275 Updated and clarified documentation for JavaScriptHelper to be more concise about the various options for including the JavaScript libs 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2608 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 05:08:59 +00:00
Scott Barron
f8f4eccd9a If a component redirects when called with render_component_as_string, render the 
redirected to action.

Fixes #2327


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2604 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 02:53:21 +00:00
David Heinemeier Hansson
04f4ae255f Take retry with breakpoint out until we fix it 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2597 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 01:09:34 +00:00
Nicholas Seckar
e0e8f0a302 Fix Request#host_with_port to use the standard port when Rails is behind a proxy. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2596 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 01:00:25 +00:00
Michael Koziarski
59709d9188 Ensure radio_button works as expected with values other than strings. 
Thanks to:
*  grant.mcinnes@utoronto.ca
*  rails@jeffcole.net



git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2573 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-14 02:07:51 +00:00
Jeremy Kemper
acb80e3d0e Escape query strings in the href attribute of URLs created by url_helper. #2333 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2572 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-13 22:44:45 +00:00
Nicholas Seckar
2cad95d851 Improved line number reporting for template errors 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2571 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-13 21:58:20 +00:00
David Heinemeier Hansson
43b6a74fb1 Added :locals support for render :inline #2463 [mdabney@cavoksolutions.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2567 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-13 20:26:39 +00:00
Sam Stephenson
4b72a4b12f Unset the X-Requested-With header when using the xhr wrapper in functional tests. Closes #2352. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2551 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-13 18:09:27 +00:00
Marcel Molina
d4576673c0 Unescape paths before writing cache to file system. Closes #1877. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2544 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-12 22:57:04 +00:00
Sam Stephenson
f49dc37e71 Wrap javascript_tag contents in a CDATA section and add a cdata_section method to TagHelper. Closes #1691. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2543 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-12 22:47:39 +00:00
Marcel Molina
7aa1ba7ff0 Misc doc fixes (typos/grammar/etc). Closes #2445. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2537 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-12 03:43:28 +00:00
Jamis Buck
8946804b8a Make xyz_tag(..., :id => "foo") work again 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2535 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-12 01:05:29 +00:00
Jamis Buck
0efeeba780 Speed improvement for session_options. #2287. [skaes@web.de] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2527 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-11 01:53:31 +00:00
Marcel Molina
9025e5d47f Make cacheing binary files friendly with Windows. Closes #1975. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2524 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-11 01:06:05 +00:00
Marcel Molina
064842f516 Convert boolean form options form the tag_helper. Recloses #809. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2523 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-10 21:34:51 +00:00
Sam Stephenson
0886bb391d Fixed that an instance variable with the same name as a partial should be implicitly passed as the partial :object. Closes #2269. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2522 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-10 20:35:13 +00:00
Sam Stephenson
e3655ef733 Fix Element.toggle logic 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2521 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-10 19:09:40 +00:00
Jamis Buck
df000fca26 Move lib/version.rb to lib/action_pack/version.rb 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2514 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-10 14:33:44 +00:00
Marcel Molina
68a322005d Add versioning convention from SwitchTower to all Rails components. Add --version, -v option to the 'rails' command. Closes #1840. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2508 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-09 21:15:45 +00:00
Thomas Fuchs
7d101d5840 Update Prototype to V1.4.0_pre11, script.aculo.us to [2502] and fix the rails generator to include the new .js files [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2503 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-09 16:56:23 +00:00
Marcel Molina
a9de9c48c2 Make assert_tag :children count appropriately. Closes #2181. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2500 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-09 01:45:21 +00:00
David Heinemeier Hansson
f510b09c28 Made the documentation about render template/file sane 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2446 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-03 21:20:52 +00:00
David Heinemeier Hansson
f13534e65f Forced newer versions of RedCloth to use hard breaks [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2437 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-02 20:24:53 +00:00
David Heinemeier Hansson
810ebf7c6a Forced newer versions of RedCloth to use hard breaks [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2436 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-02 20:21:43 +00:00
David Heinemeier Hansson
c6d8a1f975 Use a nicer date format 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2433 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-01 19:00:28 +00:00
David Heinemeier Hansson
c69160a90d Better logging about partials when logger to to debug 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2432 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-01 19:00:06 +00:00
Thomas Fuchs
e7afaf62bd Added new scriptaculous options for auto_complete_field #2343 [m.stienstra@fngtps.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2431 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-01 05:43:53 +00:00
Jamis Buck
1e08d11579 Don't prepend the asset host if the string is already a fully-qualified URL 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2430 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-30 19:10:20 +00:00
David Heinemeier Hansson
562b69829d Not the avenue we want to go down 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2424 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-30 08:13:46 +00:00
David Heinemeier Hansson
438db964ad Testing should also use a default REQUEST_METHOD 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2408 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-29 08:43:17 +00:00
David Heinemeier Hansson
ba91f9feaf Dont log size of request, doesnt work well with procs, not that interesting 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2401 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 20:03:31 +00:00
Thomas Fuchs
4d6ad9c48b Updated rdoc for javascript_include_tag 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2395 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 10:55:57 +00:00
David Heinemeier Hansson
981763e53e My life for white space 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2393 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 09:06:34 +00:00
David Heinemeier Hansson
d87618d20d Log request method and response size / status code 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2391 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 08:43:17 +00:00
Thomas Fuchs
516dc2c0f1 Update script.aculo.us to 1.5_rc2, and Prototype to 1.4.0_pre7 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2386 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 08:20:47 +00:00
Nicholas Seckar
0b1abc3360 Undo condition change made in [2345] to prevent normal parameters arriving as StringIO. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2379 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 23:39:56 +00:00
Jeremy Kemper
17d2732b1c Ticket #2295 - Tolerate consecutive delimiters in query parameters 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2375 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 22:23:37 +00:00
Nicholas Seckar
564077373d Streamline render process, code cleaning. Closes #2294. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2368 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 16:45:39 +00:00
Scott Barron
a111e1a271 Keep flash after component is rendered. Closes #2291. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2363 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 11:02:11 +00:00
Marcel Molina
b54560600b Have text helpers use built in Regexp.escape rather than home grown alternative 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2350 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-26 20:49:52 +00:00
Jeremy Kemper
9852197f83 r3573@asus: jeremy | 2005-09-26 11:38:44 -0700 
Ticket 1507 - IE file uploads give the filename as a full Windows path, but Ruby on UNIX doesn't know how to File.basename('C:\\blah\blah.foo').
 r3574@asus:  jeremy | 2005-09-26 14:32:11 -0700
 Get rid of constant redefine warning.
 r3575@asus:  jeremy | 2005-09-26 14:33:07 -0700
 Override the file upload's original_filename singleton method in CGIMethods.get_typed_value.
 r3576@asus:  jeremy | 2005-09-26 14:33:49 -0700
 Unit test overridden original_filename against normal filenames and full Windows paths.
 r3577@asus:  jeremy | 2005-09-26 14:33:57 -0700
 Update change log.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2345 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-26 17:59:46 +00:00
Thomas Fuchs
2346f5716f Fix open/save dialog in IE not opening files send with send_file/send_data, #2279 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2325 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-25 06:53:42 +00:00
David Heinemeier Hansson
2a31691ee2 Fixed that auto_discovery_link_tag couldn't take a string as the URL 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2296 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-22 11:37:16 +00:00
David Heinemeier Hansson
d616b86025 Asserts now need html/document so it should require it 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2284 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-21 09:04:05 +00:00
David Heinemeier Hansson
8a35865b74 Added small note about how longtext might be needed for large session data 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2275 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-20 10:54:11 +00:00
David Heinemeier Hansson
3754822f43 Fixed problem with send_file and WEBrick using stdout #1812 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2274 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-20 10:53:33 +00:00
David Heinemeier Hansson
7f26415d3c Optimized tag_options to not sort keys, which is no longer necessary when assert_dom_equal and friend is available #1995 [skae]. Added assert_dom_equal and assert_dom_not_equal to compare tags generated by the helpers in an order-indifferent manner #1995 [skae] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2271 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-20 07:54:55 +00:00
David Heinemeier Hansson
47292cdef7 Fixed that Request#domain caused an exception if the domain header wasn't set in the original http request #1795 [Michael Koziarski] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2270 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-20 06:44:53 +00:00