TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
15,810 Commits 2 Branches 0 Tags 294 MiB
6be0fa6a06
Commit Graph

3660 Commits

Author SHA1 Message Date
Pratik Naik
181c414baa Fix scope loading issue when the table doesn't exist 2010-03-10 11:28:04 +00:00
Carlos Antonio da Silva
47d252f992 Fix associations to call :destroy or :delete based on the right :dependent option 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-03-09 00:11:34 +01:00
wycats
39d6f9e112 Make many parts of Rails lazy. In order to facilitate this, 
add lazy_load_hooks.rb, which allows us to declare code that
should be run at some later time. For instance, this allows
us to defer requiring ActiveRecord::Base at boot time purely
to apply configuration. Instead, we register a hook that should
apply configuration once ActiveRecord::Base is loaded.

With these changes, brings down total boot time of a
new app to 300ms in production and 400ms in dev.

TODO: rename base_hook
 2010-03-07 06:24:30 -08:00
Aaron Patterson
a424f199a9 drying up more code in associations.rb 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-06 21:41:13 -08:00
Aaron Patterson
939291e8f2 deleting repeated code 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-06 21:33:29 -08:00
Stefan Penner
4bc2cbc3cf Load RAILS_VERSION relative to the gemspec file. 2010-03-06 21:33:28 -08:00
Aaron Patterson
3789539916 converting inject to each and map 
[#4119 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-06 20:31:50 -08:00
Aaron Patterson
45c36ea096 refactoring build_where 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-06 13:25:12 -08:00
Bryan Helmkamp
deb00bcb8c Read Rails version from a file instead of modifying the load path and doing requires 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-04 21:25:52 -08:00
Carl Lerche
0de3b9ec93 Somehow this fixes the AR tests when ran with rake. I should probably figure out why. 2010-03-04 02:20:01 -08:00
Carl Lerche
07b5146442 Fix active_records' log tests 2010-03-02 23:01:31 -08:00
Jeremy Kemper
56ea20605a Wordsmith gem descriptions 2010-03-02 10:43:41 -08:00
Bryan Helmkamp
f221a6f19f Leverage VERSION constants from gemspecs to avoid tedious updates when releasing 2010-03-02 00:32:53 -05:00
Bryan Helmkamp
a4111bbca0 Update versions of all components to normalize them to new format 2010-03-02 00:32:48 -05:00
Bryan Helmkamp
11db694e0b Remove cruft in the gem packaging and release code 2010-03-01 19:00:19 -08:00
Joshua Peek
5cc17da894 activerecord test load paths 2010-02-28 18:28:25 -06:00
José Valim
f3839b2b99 ActiveRecord should raise an error on invalid migration types. 2010-02-28 11:53:48 +01:00
S. Christoffer Eliesen
09cb0977d4 Print database.rake errors to stderr. 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-02-27 16:53:40 -08:00
Santiago Pastorino
b25c41e6d8 no more warning interpreted as argument prefix on association_preload.rb 2010-02-26 14:54:10 -08:00
Tobias Bielohlawek
4db72b702f fixed a 'RecordNotFound' bug when calling 'reload' on a object which doesn't met the default_scope conditions, added test [#3166 status:resolved] 
The reload method didn't made use of 'with_exclusive_scope' when reloading the object. This lead to a RecordNotFound exception, in case the object doesn't met the default_scope condition (anymore) - which is obviously a bug. This quick fix makes use of with_exclusive_scope in the reload method as well. See test for full example.

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-02-26 11:14:16 +01:00
Henry Hsu
bf9a0ae12b Fix a bug where default_scope was overriding attributes given on model initialization [#3218 status:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-02-26 11:09:43 +01:00
Jeremy Kemper
f7b0a857e9 Use Object#singleton_class instead of #metaclass. Prefer Ruby's choice. 2010-02-25 09:32:29 -08:00
Carlhuda
24ab5665b2 Revert "Fix test load paths for those not using bundler" 
This reverts commit eec2d301d4ce9df9c71c1a5aa63053eb970b6818.

This commit broke tests. You cannot have a file called "bundler" on the load path.
 2010-02-23 17:31:17 -08:00
Santiago Pastorino
ee541049fd avoid @lock_value not initialized warning 2010-02-22 14:08:07 -08:00
Santiago Pastorino
2b43021499 avoid @transaction_joinable not initialized warning 2010-02-22 14:07:53 -08:00
Santiago Pastorino
ca92e92ba1 avoid active not initialized warning 2010-02-22 14:07:44 -08:00
José Valim
250c809246 Require persisted? in ActiveModel::Lint and remove new_record? and destroyed? methods. ActionPack does not care if the resource is new or if it was destroyed, it cares only if it's persisted somewhere or not. 2010-02-21 11:12:14 +01:00
José Valim
9dd67fce25 Add to_key and to_param methods to ActiveModel::Conversion. 2010-02-21 09:08:59 +01:00
snusnu
f81c6bc040 AMo #key is now #to_key and CI is probably happy 
Obviously #key is a too common name to be included
in the AMo interface, #to_key fits better and also
relates nicely to #to_param. Thx wycats, koz and
josevalim for the suggestion.

AR's #to_key implementation now takes customized
primary keys into account and there's a testcase
for that too.

The #to_param AMo lint makes no assumptions on how
the method behaves in the presence of composite
primary keys. It leaves the decision wether to
provide a default, or to raise and thus signal to
the user that implementing this method will need
his special attention, up to the implementers. All
AMo cares about is that #to_param is implemented
and returns nil in case of a new_record?.

The default CompliantObject used in lint_test
provides a naive default implementation that just
joins all key attributes with '-'.

The #to_key default implementation in lint_test's
CompliantObject now returns [id] instead of [1].
This was previously causing the (wrong) tests I
added for AR's #to_key implementation to pass. The
#to_key tests added with this patch should be
better.

The CI failure was caused by my lack of knowledge
about the test:isolated task. The tests for the
record_identifier code in action_controller are
using fake non AR models and I forgot to stub the
#to_key method over there. This issue didn't come
up when running the test task, only test:isolated
revealed it. This patch fixes that.

All tests pass isolated or not, well, apart from
one previously unpended test in action_controller
that is unrelated to my patch.
 2010-02-20 20:17:29 -08:00
snusnu
9acd686753 Adds #key and #to_param to the AMo interface 
This commit introduces two new methods that every
AMo compliant object must implement. Below are the
default implementations along with the implied
interface contract.

  # Returns an Enumerable of all (primary) key
  # attributes or nil if new_record? is true
  def key
    new_record? ? nil : [1]
  end

  # Returns a string representing the object's key
  # suitable for use in URLs, or nil if new_record?
  # is true
  def to_param
    key ? key.first.to_s : nil
  end

1) The #key method

Previously rails' record_identifier code, which is
used in the #dom_id helper, relied on calling #id
on the record to provide a reasonable DOM id. Now
with rails3 being all ORM agnostic, it's not safe
anymore to assume that every record ever will have
an #id as its primary key attribute.

Having a #key method available on every AMo object
means that #dom_id can be implemented using

  record.to_model.key # instead of
  record.id

Using this we're able to take composite primary
keys into account (e.g. available in datamapper)
by implementing #dom_id using a newly added

  record_key_for_dom_id(record)

method. The user can overwrite this method to
provide customized versions of the object's key
used in #dom_id.

Also, dealing with more complex keys that can
contain arbitrary strings, means that we need to
make sure that we only provide DOM ids that are
valid according to the spec. For this reason, this
patch sends the key provided through a newly added

  sanitize_dom_id(candidate_id)

method, that makes sure we only produce valid HTML

The reason to not just add #dom_id to the AMo
interface was that it feels like providing a DOM
id should not be a model concern. Adding #dom_id
to the AMo interface would force these concern on
the model, while it's better left to be implemented
in a helper.

Now one could say the same is true for #to_param,
and actually I think that it doesn't really fit
into the model either, but it's used in AR and it's
a main part of integrating into the rails router.

This is different from #dom_id which is only used
in view helpers and can be implemented on top of a
semantically more meaningful method like #key.

2) The #to_param method

Since the rails router relies on #to_param to be
present, AR::Base implements it and returns the
id by default, allowing the user to overwrite the
method if desired.

Now with different ORMs integrating into rails,
every ORM railtie needs to implement it's own
#to_param implementation while already providing
code to be AMo compliant. Since the whole point of
AMo compliance seems to be to integrate any ORM
seamlessly into rails, it seems fair that all we
really need to do as another ORM, is to be AMo
compliant. By including #to_param into the official
interface, we can make sure that this code can be
centralized in the various AMo compliance layers,
and not be added separately by every ORM railtie.

3) All specs pass
 2010-02-19 23:31:25 -08:00
José Valim
3f948a0e29 Merge master. 2010-02-17 00:48:04 +01:00
Prem Sichanugrist
f0523f72b4 Rename Rails::Subscriber to Rails::LogSubscriber 2010-02-16 22:36:15 +01:00
Joshua Peek
eec2d301d4 Fix test load paths for those not using bundler 2010-02-15 10:20:11 -06:00
Pratik Naik
dc3cc6c608 Move batch finders to Relation 2010-02-12 22:31:03 +00:00
Mikel Lindsaar
5fe3dc4bf5 Adding ruby version spec to all gemspec files to at least 1.8.7 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-02-08 09:42:12 +01:00
David Heinemeier Hansson
28fe0c330a Silenced "SHOW FIELDS" and "SET SQL_AUTO_IS_NULL=0" statements from the MySQL driver to improve log signal to noise ration in development [DHH] 2010-02-06 13:20:47 -08:00
RomD
f44a0b1d52 fix usage examples and more to use new invocations 
Signed-off-by: Carl Lerche <carllerche@mac.com>
 2010-02-06 09:51:53 -08:00
Prem Sichanugrist
1d9d9d2d89 Fix tiny version number from '3.0.0beta' to '3.0.0.beta1', so 'rake install' will be run correctly [#3879 status:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-02-06 15:51:44 +01:00
Santiago Pastorino
44c46558a4 test_validates_acceptance_of_as_database_column fixed 
[#3826 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-02-05 16:08:08 -08:00
Jeremy Kemper
c548e21365 Bump git versions to 3.0.0.beta1 since we've released 2010-02-05 09:24:12 -08:00
Jeremy Kemper
a81a2a29ab Bump arel dep 2010-02-05 09:21:45 -08:00
Jeremy Kemper
459ecaf95d Submarine the rake-gemcutter dep in Rakefiles 2010-02-05 00:03:03 -08:00
Jeremy Kemper
7b81f5981f Fix task defines 2010-02-04 18:44:32 -08:00
Jeremy Kemper
c1785f3282 Release using gemcutter gem:push tasks 2010-02-04 18:28:45 -08:00
Jeremy Kemper
23ad1eff0d Rationalize railtie dependencies: AC uses AV; AR uses AMo; and Rails always uses AS. 2010-02-04 10:08:06 -08:00
David Heinemeier Hansson
031139bb71 Homogenize gemspecs and remove the deprecated autorequire 2010-02-03 17:59:49 -08:00
David Heinemeier Hansson
dd13874ff6 Merge 2010-02-03 17:31:35 -08:00
David Heinemeier Hansson
79817aa9e7 Move to 3.0.0.beta 2010-02-03 17:29:51 -08:00
Jeremy Kemper
9b033d14b2 Merge remote branch 'mikel/master' 2010-02-03 17:03:21 -08:00
SubbaRao Pasupuleti
639e044298 removing , from ,= statement in WrappedDatabaseException constructor 
[#3830 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-02-03 17:02:40 -08:00
Mikel Lindsaar
02ef8d20a1 Adding guard to make sure test database declarations exist before trying to auto create 2010-02-04 11:57:13 +11:00
Mikel Lindsaar
9d65390805 Added encoding qery support for SQLite3 to make rake db:charset work on all databases shipping with Rails 3 2010-02-03 18:06:38 +11:00
Mikel Lindsaar
fbdef7aafe Made rake db:create also create the test database if you are in development mode 2010-02-03 16:39:04 +11:00
Szymon Nowak
17bee0dd2f Change Rails::Generators::Migration protected instance methods to class methods. [#3820 status:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-02-02 10:18:48 +01:00
Prem Sichanugrist
ea2cbc86f7 Add test case for unable to run migration if ActiveRecord::Base.logger is nil (#3434) 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-02-02 10:14:51 +01:00
Corey Johnson
f4e5303bcf fixed migration logger bug [#3434 status:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-02-02 10:12:07 +01:00
Mikel Lindsaar
d1eed079e1 Merge branch 'master' of git://github.com/rails/rails 2010-02-02 10:51:19 +11:00
Jeremy Kemper
e5ab4b0d07 Convert to class_attribute 2010-02-01 02:02:42 -08:00
Carl Lerche
9f01dff9c2 Get rails tests running on bundler 0.9 2010-01-31 19:13:43 -08:00
Jeremy Kemper
9bd0422dd7 Bump arel dependency to 0.2.0 from 0.2.pre 2010-01-31 18:42:41 -08:00
Mikel Lindsaar
65ad16568c Updating copyright dates on all licenses 2010-02-01 10:10:53 +11:00
Joshua Peek
db49c706b6 Axe AM state machine 
We're going do it eventually, get it done before 3.0 is final.
 2010-01-30 18:38:01 -06:00
Pratik Naik
ec057ada07 Rely on arel to generate the correct sql when an empty array is supplied to IN predicate 2010-01-30 19:34:05 +00:00
José Valim
d6e2f5013c Drop AR I18n deprecation and simple use errors.messages as fallback. 2010-01-30 13:12:12 +01:00
Paul Rosania
766e857bea tsort-based dependency resolution for initializers 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-01-29 19:25:58 -08:00
Carl Lerche
f15bbcf97e Move the ActiveRecord generator settings into the Railtie 2010-01-28 10:45:25 -08:00
Jeremy Kemper
fd0eb3d904 Clear up some ivar warnings 2010-01-27 19:33:03 -08:00
Aaron Patterson
beda2d43d6 future proofing the sqlite3 adapter code 
Signed-off-by: Yehuda Katz <wycats@Yehuda-Katz.local>
 2010-01-26 15:09:11 -08:00
Jack Christensen
c5b652f3d2 PostgreSQLAdapter: set time_zone to UTC when Base.default_timezone == :utc so that Postgres doesn't incorrectly offset-adjust values inserted into TIMESTAMP WITH TIME ZONE columns [#3777 state:resolved] 2010-01-25 20:57:07 -06:00
Carlhuda
64f8c87b1d Fix AR's rake tasks to work with the Rails::Application refactor 2010-01-25 17:55:54 -08:00
José Valim
02908e1142 As first step setup the load path and lazy compare middlewares. 2010-01-25 22:59:08 +01:00
José Valim
3b6f659fb6 Add active_model/railtie back to generated boot.rb, add models back to paths, load active_support/railtie since we need it and ensure default logger is set before config. 2010-01-25 01:12:22 +01:00
José Valim
e548f96b1d Rename plugin_name to railtie_name and engine_name. 2010-01-24 12:23:21 +01:00
José Valim
f915f9e339 Merge branch 'master' into app 
Conflicts:
	railties/lib/rails/application.rb
 2010-01-23 22:53:26 +01:00
Pratik Naik
8ff2fb6f3a Make default_scope work with Relations 2010-01-23 13:41:09 +05:30
José Valim
c8cc8a9872 Moved more configuration away from bootstrap. 2010-01-22 20:44:38 +01:00
Pratik Naik
4afd9702fe Relation should respond to class methods 2010-01-22 20:14:37 +05:30
Pratik Naik
ee8c006dac Allow calling class methods on a Relation 2010-01-22 20:10:41 +05:30
Pratik Naik
6d30002a52 Revert "Refactoring attributes/types" [#3348 state:open] 
This reverts commit f936a1f100e75082081e782e5cceb272885c2df7.

Conflicts:

	activerecord/lib/active_record.rb
	activerecord/lib/active_record/base.rb

Revert "Fixed: #without_typecast should only disable typecasting on the duplicated attributes" [#3387 state:open]

This reverts commit 2831996483c6a045f1f38d8030256eb58d9771c3.

Reason :

  It's not generating attribute methods properly, making object.column 5x slower.
 2010-01-22 02:37:07 +05:30
Pratik Naik
a68a3e9af6 Simplify finder method definitions 2010-01-21 22:29:21 +05:30
Pratik Naik
da142cd865 Supplying Arel::SqlLiteral is much faster 2010-01-21 17:52:09 +05:30
José Valim
378464a2e4 Default to sync instrumentation. 2010-01-21 13:09:12 +01:00
Pratik Naik
fa9f000246 Use quoted_table_name with arel.from() if no from values explicitly supplied. Arel seems to be spending a lot of time figuring out the FROM value otherwise. 2010-01-21 01:37:02 +05:30
Pratik Naik
798d2828dc Cache quoted_table_name 2010-01-21 01:28:50 +05:30
Pratik Naik
24cc9e5b4f Relation#spawn is basically clone + reset 2010-01-21 00:41:15 +05:30
Pratik Naik
8bdcb6f072 Always use table.* in the finder query unless specified 2010-01-21 00:40:38 +05:30
Pratik Naik
459e9b29d4 Use @limit_value and @offset_value instead of calling arel 2010-01-20 22:20:56 +05:30
Pratik Naik
8d31c9f3a0 Move update and update_all to Relation 2010-01-20 22:20:56 +05:30
Pratik Naik
f7d94cdc6d Fix AP's AR integration tests warning 2010-01-20 20:40:20 +05:30
Pratik Naik
1fb78e3ed8 Base.merge_conditions is no longer needed 2010-01-20 20:37:17 +05:30
Pratik Naik
8b9bfbe225 Dont delegate Relation#update to arel 2010-01-20 19:01:26 +05:30
Pratik Naik
f216fadc0e Delegate delete_all to Relation 2010-01-20 18:33:14 +05:30
Pratik Naik
9756805676 Move destroy to Relation 2010-01-20 18:28:45 +05:30
Pratik Naik
223e2a2709 Remove Base.delete as it's same as Relation#delete 2010-01-20 18:24:36 +05:30
Pratik Naik
2493229674 Delegate exists? to Relation 2010-01-20 18:17:37 +05:30
Pratik Naik
8f0f02a166 Make Relation#destroy_all handle all the cases 2010-01-20 18:12:50 +05:30
Pratik Naik
8a1be22849 Use unscoped instead of with_exclusive_scope for preloading 2010-01-20 16:11:14 +05:30
Pratik Naik
5502780c69 Move array_of_strings? to Relation 2010-01-20 14:01:42 +05:30
Pratik Naik
394c05ed82 Remove stale methods constructing joins 2010-01-20 13:24:53 +05:30
Pratik Naik
565b4cd3e0 Scope#find is no longer needed now that Relation#find handles all the cases 2010-01-20 03:40:37 +05:30
Pratik Naik
52ec4311f5 Delegate all finders to Relation 2010-01-20 03:35:25 +05:30
Pratik Naik
74e3539cda Ignore order for simple calculations to make postgresql happy 2010-01-20 02:17:49 +05:30
Pratik Naik
d8c30723aa Named scopes dont need count() now that Relation#count handles all the cases 2010-01-20 01:35:20 +05:30
Pratik Naik
1b78a3f8d5 with_scope no longer needs :reverse_merge 2010-01-20 01:29:18 +05:30
Pratik Naik
42553a98ea Remove find_with_associations and related code from associations now that Relation handles that stuff 2010-01-20 01:20:20 +05:30
Pratik Naik
9acf0af544 Remove Relation#where_clause 2010-01-19 23:11:54 +05:30
Pratik Naik
dbce07b81d Give preference to to_a over arel from Relation#method_missing 2010-01-19 22:52:08 +05:30
Pratik Naik
9465b84b54 Rename CalculationMethods to Calculations and get rid of the old Calculations module 2010-01-19 22:17:33 +05:30
Pratik Naik
8f63dcb648 Move the only remaining calculation method calculate() to Relation 2010-01-19 22:17:33 +05:30
Pratik Naik
ec63fdcff3 Get rid of construct_count_options_from_args 2010-01-19 20:43:03 +05:30
Pratik Naik
73b179eb68 Delegate count to Relation 2010-01-19 20:37:12 +05:30
Pratik Naik
9c7c7104f6 Fix the named scope equality check 2010-01-19 17:45:48 +05:30
Pratik Naik
4148c686ec Delegate :average, :minimum, :maximum, :sum to Relation 2010-01-19 15:50:47 +05:30
Pratik Naik
b9599502c9 Add Relation#construct_relation_for_association_calculations for calculations with includes 2010-01-19 15:22:09 +05:30
Pratik Naik
e6a68a5cc3 Add Relation#find_with_associations to load relation with eager loaded associations 2010-01-19 04:42:19 +05:30
Pratik Naik
9e7ec2a9f1 Simplify calculation scope building. Remove :order from associations as it is troublesome w/ calculation methods using postgresql. 2010-01-18 23:40:42 +05:30
Pratik Naik
3c4186b366 Remove construct_calculation_arel_with_included_associations because it's same as construct_finder_arel_with_included_associations 2010-01-18 23:40:42 +05:30
Pratik Naik
893524382a No need to pass current_scoped_methods to construct_calculation_arel everytime 2010-01-18 23:40:42 +05:30
José Valim
728db5a932 Rake tasks should load generators from new paths. 2010-01-18 18:22:55 +01:00
Joshua Peek
68b76a38eb Cleanup deprecation notices. 2010-01-18 09:49:38 -06:00
Paco Guzman
e27bfad6a5 Forgot to change named_scope to scope in an ArgumentError raise exception for duplication scopes related to commit d60bb0a9e4be [#3736 status:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-01-18 16:36:08 +01:00
José Valim
9fffdc5cdb Generators load path now will be Ruby load path. If you want to use rspec:install generator, you need generators/rspec/install_generator in your load path. 2010-01-18 16:21:11 +01:00
Pratik Naik
4c00c65c58 Simplify construct_finder_arel_* methods 2010-01-18 19:40:23 +05:30
Pratik Naik
2a2bc8e84a Handle invalid query IN() generated when a blank array is supplied in hash conditions 2010-01-18 18:56:55 +05:30
Pratik Naik
8bb5274648 Get rid of Relation#order_clauses 2010-01-18 18:56:55 +05:30
Pratik Naik
8ba2902dd4 Fix the named_scope deprecation notice 2010-01-18 18:56:55 +05:30
José Valim
40c4a0036a Ensure deprecated validate methods are invoked when they are private [#3214 status:resolved] 2010-01-18 09:56:36 +01:00
Pratik Naik
6ce538d485 Add missing CHANGELOG entry about relations as scopes 2010-01-18 04:42:04 +05:30
Pratik Naik
d60bb0a9e4 Rename named_scope to scope 2010-01-18 04:38:19 +05:30
Pratik Naik
e1d507c7fb Dont check for class equaity when merging relations 2010-01-18 04:28:21 +05:30
Pratik Naik
88de6b2de2 Inherit named scope class Scope from Relation 2010-01-18 04:24:24 +05:30
Pratik Naik
c6850d8361 Ensure that Scope#proxy_scope is always klass. Rename proxy_scope to klass too. 2010-01-18 00:03:18 +05:30
Pratik Naik
dca3de3bc7 Make relations work as scopes 2010-01-17 23:22:11 +05:30
Pratik Naik
f0cde5be54 Make sure named_scope names are not used as method names already 2010-01-17 21:34:41 +05:30
José Valim
c0d31ca41b save(false) is gone, use save(:validate => false) instead. 2010-01-17 14:22:34 +01:00
José Valim
27d9836ad3 Add ActionDispatch::Railties::Subscriber and finish tidying up the logging. 2010-01-17 12:43:17 +01:00
Pratik Naik
54a043895f Make merging of order values consistent 2010-01-17 14:19:41 +05:30
Pratik Naik
8d87c80c19 Make Relation#reload force load the records immediately 2010-01-17 04:25:59 +05:30
Pratik Naik
7921a73acd Use relations to build scope for named scopes 2010-01-17 04:20:11 +05:30
Pratik Naik
b8b6621acb Simplify Model.scoped definition 2010-01-17 03:54:52 +05:30
Pratik Naik
dba196cb7f Merge docrails 2010-01-17 03:26:20 +05:30
Pratik Naik
6e3bee6cf1 Cache Model.arel_table 2010-01-17 03:14:17 +05:30
Pratik Naik
6806483b91 Use arel_table[] instead of unscoped[] to get arel attribute 2010-01-17 03:10:07 +05:30
Pratik Naik
0ab30637dd Revert "Fix #microseconds conversion and #fast_string_to_time" 
This reverts commit 717a2941e15b32d07cc456bb0d81742ecfc5b4a3. Bunch of failures when running postgresql tests.
 2010-01-17 03:04:11 +05:30
Pratik Naik
cd90dcb1bd Rename Model.active_relation to Model.unscoped 2010-01-17 03:00:56 +05:30
Pratik Naik
468cfcedd3 Improve the error message for class mismatch on Relation#merge 2010-01-17 02:08:42 +05:30
Pratik Naik
7f8d4d3c4e Get rid of Base#merge_includes 2010-01-16 23:59:57 +05:30
Pratik Naik
07e41a8361 No need to set @arel_engine to nil twice. Committed by mistake in 3968825f 2010-01-16 23:17:14 +05:30
Pratik Naik
3968825f5f Make sure Model#active_relation always adds STI conditions if needed 2010-01-16 23:11:35 +05:30
Pratik Naik
cfdfd89926 Use new finder methods for association preloading 2010-01-16 22:14:10 +05:30