Joshua Peek
c08547d226
Namespace Inflector, Dependencies, OrderedOptions, and TimeZone under ActiveSupport [ #238 state:resolved]
2008-06-03 13:32:53 -05:00
Jeremy Kemper
f55ad960d2
Stack @output_buffer for nested rendering
2008-06-03 01:10:00 -07:00
Jeremy Kemper
0bdb7d353b
Work with @output_buffer instead of _erbout
2008-06-02 21:32:50 -07:00
Joshua Peek
92050f6c6f
Ensure Rack processor reads CGI output_cookies for the session cookie.
2008-06-02 21:02:51 -05:00
Ezra Zygmuntowicz
06cb20708b
Added Rack processor
...
Signed-off-by: Joshua Peek <josh@joshpeek.com>
2008-06-01 11:25:11 -07:00
Jeremy Kemper
b43309328a
Ruby 1.9 compat: ensure binary encoding for post body parsing
2008-05-19 16:24:26 -07:00
Jeremy Kemper
b5c8433a6f
Ruby 1.9 compat: qualify module name within module_evaled block
2008-05-19 12:57:42 -07:00
Chris Hapgood
e6f5079a48
Test for assert_response for failure response without an exception. [ #141 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
2008-05-19 11:20:36 +01:00
José Valim
99860b72ae
Add fragment_exist? and exist? methods to cache stores. [ #203 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
2008-05-19 10:38:59 +01:00
Sven Fuchs
345f030c5b
Ensure routing generator works with non-string keys. [ #172 state:resolved]
...
Make sure that (with recent correction to globbed parameter escaping) non-string
values can still be passed route generation helpers for globbed route segments.
For example, foo_path([1, 2, 3]) should still work for a route like map.foo "*globbed"
by implicitely calling to_s on the Fixnums.
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
2008-05-16 17:36:09 +01:00
Joshua Peek
bc3cc91a3f
One last fix to test_filter_parameters_is_protected.
2008-05-14 14:14:23 -05:00
Joshua Peek
f32b974338
Clean up previously commited test.
2008-05-14 13:55:14 -05:00
Joshua Peek
1066b16237
Improve test coverage for filter_parameters [José Valim]
2008-05-14 13:38:02 -05:00
Joshua Peek
8d37bd08ee
Protect #filter_parameters created by filter_parameter_logging [José Valim] [ #196 state:resolved]
2008-05-14 13:00:09 -05:00
Joshua Peek
7708650f73
Added conditional support to caches_action [José Valim] [ #166 state:resolved]
2008-05-14 12:33:54 -05:00
Rich Cavanaugh
d8bcec6ce6
make CGI::Cookie handle deleting a cookie properly
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2008-05-13 10:51:55 -07:00
rick
74fd17346f
Merge branch 'master' of git@github.com:rails/rails
2008-05-13 09:41:10 -07:00
Rich Cavanaugh
a425cd1473
Don't double-escape cookie store data. Don't split cookie values with newlines into an array. [ #130 state:resolved]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2008-05-12 15:26:19 -07:00
Peter Jones
2a986200b9
Bug: Earlier Check for Session in Forgery Protection
...
The session is used by the form_authenticity_token method before it is
tested to be valid. This patch moves a few lines around so that the
session is validated first.
Without this patch, if you try to use forgery protection with sessions
turned off, you get this exception message:
undefined method `session_id' for {}:Hash
The patch includes a test that can be used to see this behavior before
the request_forgery_protection.rb file is patched to fix it.
2008-05-11 13:27:34 -05:00
David Heinemeier Hansson
c43623c48b
Added session(:on) to turn session management back on in a controller subclass if the superclass turned it off (Peter Jones) [ #136 state:resolved]
2008-05-11 13:18:49 -05:00
Andreas Neuhaus
74eed6290e
Fixed flash.now not being accessible in tests. Flash sweeping is now done before action processing instead after
...
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#10 state:resolved]
2008-05-11 18:30:10 +12:00
rick
d09a8446d5
fix merge conflict with actionpack changelog
2008-05-10 17:46:55 -07:00
Jacek Becela
a7ea06b4eb
Make render shorthands work with namespaced controllers
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
2008-05-10 11:28:19 +01:00
Chris Roos
6776edccf6
Escape globbed parameters in routes correctly.
...
:controller => 'glob', :action=> 'show', :additional => ['foo/bar', 'baz']
Should generate /glob/show/foo%2Fbar/baz not /glob/show/foo/bar/baz
2008-05-10 14:55:41 +12:00
Pratik Naik
e520fd5db7
Delegate action_name to controller inside views.
2008-05-06 12:02:24 +01:00
rick
c8451aeeea
change ActionController::RequestForgeryProtection to use Mime::Type#verify_request? [ #73 ]
2008-05-06 02:58:32 -07:00
Marcos Arias
2c39836dc3
Refactored and fixed Resources.map_member_actions to make use of custom ActionController::Base.resources_path_names when the option :path_names is not directly specified. Added a specific test for this functionality and fixed assert_restful_routes_for test helper to make use of ActionController::Base.resources_path_names instead of just "new" or "edit".
...
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#111 state:resolved]
2008-05-06 21:48:07 +12:00
rick
0697d17d12
Change the request forgery protection to go by Content-Type instead of request.format so that you can't bypass it by POSTing to "#{request.uri}.xml" [ #73 state:resolved]
2008-05-06 00:42:24 -07:00
rick
37599d16f2
regression test for bug introduced in [6a6b4392c16c665eb713705f2b38e959a658eeef] [Ian White] [ #22 state:resolved]
2008-05-05 23:42:52 -07:00
Cheah Chu Yeow
ee1d508a6b
Allow ActionController::Base#default_url_options to have a default options argument of nil.
...
This fixes a bug introduced in [6a6b4392c16c665eb713705f2b38e959a658eeef] which was breaking routing in ActionController::UrlWriter.
2008-05-05 23:41:33 -07:00
Cheah Chu Yeow
6a6b4392c1
Ensure that default_url_options, if defined, are used in named routes.
...
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#22 state:resolved]
2008-05-04 12:49:44 +12:00
David Heinemeier Hansson
12288a0341
Merge branch 'master' of git@github.com:rails/rails
2008-05-01 17:26:46 -05:00
David Heinemeier Hansson
926f4648f0
Made the location of the routes file configurable with config.routes_configuration_file (Scott Fleckenstein) [ #88 state:resolved]
2008-05-01 17:26:31 -05:00
Tobias Lütke
f48e89931f
Accept header mime parser can now deal with empty fields
2008-05-01 17:45:14 -04:00
Pratik Naik
74436d2203
Fixed render :template for templates in top level of view path. [ #54 state:resolved]
2008-05-01 10:21:46 +01:00
Tobias Lütke
fef82759ff
Implement increment/decrement on cache storage engines, using read/write by default and using atomic command on memcache
2008-04-29 15:12:47 -04:00
Jeremy Kemper
642bcd2d01
Ruby 1.9 compat: force assert_select text encoding to the encoding of the regexp it's matching against.
2008-04-28 10:52:23 -07:00
Eugene Pimenov
e6a3ce3392
Make sure member names aren't mistakenly set to nil when providing :path_names
...
[#19 state:resolved]
Signed-off-by: Michael Koziarski <michael@koziarski.com>
2008-04-23 20:19:22 +12:00
Pratik Naik
a04f022877
Delegate ivars to controller instead of copying
...
Reduce number of instance variables being copied from controller to
view. Instead, delegate them to controller instance.
2008-04-21 11:53:14 +01:00
Pratik Naik
2b69840e5e
Remove ActionController::Base#view_controller_internals
...
Get rid of ActionController::Base#view_controller_internals flag and
use @@protected_view_variables for storing the list of controller
specific instance variables which should be inaccessible inside views.
2008-04-21 03:45:38 +01:00
Paul Horsfall
14a40804a2
Add conditional options to caches_page method [ #25 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com>
2008-04-19 16:21:34 -05:00
Pratik Naik
ef4c65088f
Move missing template logic to ActionView
2008-04-19 18:59:13 +01:00
Pratik Naik
534c6b2444
Introduce ActionView::InlineTemplate class
2008-04-19 16:21:18 +01:00
Pratik Naik
986aec5dbb
Refactor Dispatcher callbacks to remove unnecessary Dependencies checks in production environment.
2008-04-18 13:05:43 +01:00
Joshua Peek
745359a494
Stub out Dispatcher#log_failsafe_exception method to please the test gods.
2008-04-15 18:04:12 -05:00
David Heinemeier Hansson
420c4b3d88
Added Rails.public_path to control where HTML and assets are expected to be loaded from (defaults to Rails.root + "/public") #11581 [nicksieger]
2008-04-13 17:33:27 -05:00
Michael Koziarski
60be4b09f5
Merge branch 'master' into custom_paths_for_resource_names
2008-04-12 12:40:51 +12:00
Michael Koziarski
063c393bf0
Allow alternative values for the 'new' and 'edit' actions in resourceful routes.
...
map.resource :schools, :as => 'escuelas', :path_names => { :new => 'nueva' }
Closes #11181 . [ivanvr]
2008-04-12 12:40:40 +12:00
Jeremy Kemper
9a7ab8b05b
stub the instance method, there is no class method
2008-04-11 16:46:46 -07:00
David Heinemeier Hansson
e89093aeb4
Fixed that formatted_polymorphic_route should be able to take the :format as part of a single hash or as the option hash (references #8741 )
2008-04-11 12:34:44 -05:00
Rick Olson
4d594cffcf
Automatically parse posted JSON content for Mime::JSON requests. [rick]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9242 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-04-08 05:05:54 +00:00
Josh Peek
917423d664
Provide a helper proxy to access helper methods from outside views. Closes #10839 [Josh Peek]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9234 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-04-06 18:42:34 +00:00
Pratik Naik
1e087fd3fd
Ensure RJS redirect_to doesn't html-escapes string argument. Closes #8546
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9212 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-04-02 12:48:59 +00:00
Jeremy Kemper
30fa377f33
Ruby 1.9 compat: encoding and multibyte test fixes
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9194 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-04-01 07:39:04 +00:00
Jeremy Kemper
ecdddc4de5
Ruby 1.9 compat: proc arity
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9190 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-04-01 06:11:56 +00:00
Jeremy Kemper
a2ad945627
style & whitespace
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9189 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-04-01 06:11:48 +00:00
Jeremy Kemper
b79f7d127a
Ruby 1.9: no args is 0 arity, not -1 as in 1.8
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9187 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-04-01 06:11:31 +00:00
Jeremy Kemper
9cc478a254
Support render :partial => collection of heterogeneous elements. Closes #11491 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9177 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-04-01 00:50:09 +00:00
Jeremy Kemper
a61b63d420
Avoid remote_ip spoofing
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9124 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-28 21:38:01 +00:00
Jeremy Kemper
5c0656c9ee
Fix layouts in symlinked paths. Closes #9136 [court3nay, caio]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9120 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-28 20:54:26 +00:00
David Heinemeier Hansson
db3a60eb92
Added support for regexp flags like ignoring case in the :requirements part of routes declarations ( closes #11421 ) [NeilW]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9115 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-28 20:01:21 +00:00
David Heinemeier Hansson
388e5d3fac
Fixed that ActionController::Base#read_multipart would fail if boundary was exactly 10240 bytes ( closes #10886 ) [ariejan]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9113 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-28 19:55:31 +00:00
David Heinemeier Hansson
c57254d449
Fixed HTML::Tokenizer (used in sanitize helper) didnt handle unclosed CDATA tags ( closes #10071 ) [esad, packagethief]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9111 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-28 19:45:32 +00:00
Rick Olson
0381398708
Fix regression from filter refactoring where re-adding a skipped filter resulted in it being called twice. [rick]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9080 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-23 01:48:17 +00:00
Jeremy Kemper
f2840f508d
Fix an edge case with extra periods in Routing.normalize_paths. Closes #11337 [cavalle, veejar]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9069 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-21 22:44:04 +00:00
Jeremy Kemper
856a4dcf12
Refactor filters to use Active Support callbacks. Closes #11235 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9055 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-18 17:56:05 +00:00
David Heinemeier Hansson
db08329946
Fixed that polymorphic routes would modify the input array ( closes #11363 ) [thomas.lee]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9053 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-17 23:45:42 +00:00
Rick Olson
1e0ac3a673
Fix more obscure nested parameter hash parsing bug. Closes #10797 [thomas.lee]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9020 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-13 03:22:25 +00:00
Rick Olson
3a17ea9031
Fix nested parameter hash parsing bug. #10797 [thomas.lee]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9010 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-11 07:46:39 +00:00
Pratik Naik
cff3ecc2ae
Allow using named routes in ActionController::TestCase before any request has been made. Closes #11273 [alloy]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8992 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-08 12:56:41 +00:00
Pratik Naik
011e469410
Make MimeResponds::Responder#any work without explicit types. Closes #11140 [jaw6]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8987 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-07 11:17:05 +00:00
Pratik Naik
d7627361d3
Remove unused ActionController::Base.template_class. Closes #10787
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8985 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-05 12:12:17 +00:00
Pratik Naik
a96272a0c5
Moved template handlers related code from ActionView::Base to ActionView::Template
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8981 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-05 02:03:24 +00:00
Michael Koziarski
cc5a957d2b
Allow file uploads in Integration Tests. Closes #11091 [RubyRedRick]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8978 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-03 06:42:24 +00:00
Michael Koziarski
51b6619d4e
Refactor partial rendering into a PartialTemplate class. [Pratik]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8976 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-03 04:01:35 +00:00
David Heinemeier Hansson
7dcd0d7d96
Added that requests with JavaScript as the priority mime type in the accept header and no format extension in the parameters will be treated as though their format was :js when it comes to determining which template to render. This makes it possible for JS requests to automatically render action.js.rjs files without an explicit respond_to block [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8956 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-02-29 18:09:23 +00:00
Jeremy Kemper
5e83612766
Fix Hash#from_xml with Type records. Closes #9242 [Juanjo Bazan, Isaac Feliu]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8937 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-02-27 23:11:08 +00:00
Michael Koziarski
1537aec184
use stubbing instead of monkeypatching to stop tests from interfering with one another. Closes #11163 [RubyRedRick]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8899 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-02-19 21:43:13 +00:00
Michael Koziarski
db4f421b0b
Add :trailing_slash option to UrlWriter. Closes #9117 [juanjo.bazan]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8892 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-02-18 00:42:06 +00:00
Michael Koziarski
1d5ea1857f
Sort files to test to make load order platform independent. Fix the clash this exposes. Closees #11081 [tpope]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8880 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-02-16 03:08:05 +00:00
Michael Koziarski
46356100d1
Make sure render :update support the options hash. Closes #11088 [ernesto.jimenez]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8862 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-02-12 22:42:36 +00:00
Jamis Buck
11787b802a
remove support for ampersand-delimited cookie values
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8861 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-02-12 21:45:39 +00:00
Marcel Molina
c848c4c621
Fix problem with render :partial collections, records, and locals. #11057 [lotswholetime]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8822 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-02-08 22:04:06 +00:00
Rick Olson
8e6638afa4
Fix bug with setting Request#format= after the getter has cached the value. Closes #10889 [cch1]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8811 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-02-07 16:46:50 +00:00
Michael Koziarski
692dbbf793
Introduce a Template class to ActionView. Closes #11024 [lifofifo]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8805 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-02-06 04:26:40 +00:00
Jeremy Kemper
0da2aa6d11
Introduce the :index option for form_for and fields_for to simplify multi-model forms (see http://railscasts.com/episodes/75 ). Closes #9883 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8786 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-02-02 06:16:04 +00:00
Jeremy Kemper
fadaba679a
Introduce map.resources :cards, :as => 'tarjetas' to use a custom resource name in the URL: cards_path == '/tarjetas'. Closes #10578 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8785 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-02-02 05:57:16 +00:00
Jeremy Kemper
9e1d91c24b
TestSession supports indifferent access. Closes #7372 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8782 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-02-02 05:32:44 +00:00
Jeremy Kemper
b84a33ddd1
Don't split cookies on comma also. References r8505.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8773 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-02-02 02:55:44 +00:00
Michael Koziarski
900d6d7bd2
Make assert_routing aware of the HTTP method used. Closes #8039 [mpalmer]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8748 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-30 01:25:44 +00:00
Michael Koziarski
aecb7fbefc
Correct line numbers from template errors. Closes #10937 [Aleksey Kondratenko]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8744 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-27 20:48:13 +00:00
Michael Koziarski
f11904ad6d
Add documentation for polymorphic URL helpers, make API consistent for polymorphic_path and polymorphic_url.
...
Closes #10883 [mislav] Closes #8782 [gbuesing] Closes #8720 [gbuesing]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8741 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-27 01:18:47 +00:00
Michael Koziarski
6e165b8940
Make it simpler to make the root route an alias for another route. Closes #10818 [bscofield]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8738 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-26 08:41:19 +00:00
Michael Koziarski
61c90a4ad6
Reapply the TemplateFinder first applied in [8669] then reverted in [8676]. Closes #10800 [lifofifo]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8683 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-21 20:45:04 +00:00
Michael Koziarski
250a1194b9
Ensure mime types can be compared with symbols. Closes #10796 [bscofield]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8677 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-20 22:55:25 +00:00
Jeremy Kemper
88bc014acc
Revert r8669 for now, breaks Action Mailer. Reopens #10800 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8676 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-19 06:01:57 +00:00
Jeremy Kemper
630c643f5b
Add timing test for large restful route recognition. References #10835 [oleganza]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8673 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-19 05:24:44 +00:00
Jeremy Kemper
84b0f9c739
Introduce TemplateFinder to handle view paths and lookups. Closes #10800 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8669 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-19 03:20:39 +00:00
Jeremy Kemper
aae37bb4f7
Extract ActiveSupport::Callbacks from Active Record, test case setup and teardown, and ActionController::Dispatcher. Closes #10727 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8664 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-19 02:44:45 +00:00
Michael Koziarski
b812b23687
Make render :partial recognise form builders and use the _form partial. Closes #10814 [djanowski]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8646 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-16 02:01:57 +00:00
Michael Koziarski
8a71f87009
Ensure that the tests use the instance-level view-paths correctly. Closes #10820 [lifofifo]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8645 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-16 01:41:31 +00:00
Michael Koziarski
7501451d7f
don't misbehave when redirecting to nil. Closes #10272 [farleyknight]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8633 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-12 03:09:39 +00:00
David Heinemeier Hansson
eff27ab119
Fix a few caching errors, expose a case thats still not working (ref #107330 [catfish]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8630 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-12 01:19:46 +00:00
Jeremy Kemper
9889d86a6c
Introduce send_file :x_sendfile => true to send an X-Sendfile response header.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8628 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-11 22:07:04 +00:00
Michael Koziarski
104f31af1d
Provide a nicer way to access headers. request.headers["Content-Type"] instead of request.headers["HTTP_CONTENT_TYPE"] [Koz]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8625 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-11 06:39:56 +00:00
Michael Koziarski
e6de95889d
* Pass around handler instances, not their classes [Koz]
...
* Move compilation, rendering and 'compilable?' checks into the Handlers [Koz]
* Remove delegate_* methods as the handler is now an instance [Koz]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8624 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-11 04:45:06 +00:00
Jeremy Kemper
a8eb90fcee
Move fragment caching from special helper methods to TemplateHandler. Closes #10754 [Josh Peek]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8619 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-10 03:17:20 +00:00
Jeremy Kemper
59f222dbf7
UrlWriter respects relative_url_root. Closes #10748 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8616 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-10 02:51:09 +00:00
Michael Koziarski
5ef8a81b84
Don't append the forgery token to an ajax request if it's serializing a form, prevents duplicate tokens. Closes #10684 [macournoyer]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8598 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-08 21:17:08 +00:00
Jeremy Kemper
07fcac508a
Ruby 1.9 compat: don't rely on Array#to_s to flatten and join as string
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8590 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-07 08:12:34 +00:00
Jeremy Kemper
7324444344
Ruby 1.9 compat: cookie store delete sets nil value instead of empty string
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8589 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-07 08:12:03 +00:00
Jeremy Kemper
3a62e0e868
Ruby 1.9 compat: check dom equality
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8587 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-07 08:09:06 +00:00
Jeremy Kemper
3b13a09e89
Filter procs must take 1 or 2 arguments. Raise ArgumentError otherwise.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8583 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-07 00:12:43 +00:00
Jeremy Kemper
ca4c7ab362
Support render :text => nil. Closes #6684 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8577 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-06 20:52:57 +00:00
Jeremy Kemper
139b92495f
* Continue evolution toward ActiveSupport::TestCase and friends. #10679 [Josh Peek]
...
* TestCase: introduce declared setup and teardown callbacks. Pass a list of methods and an optional block to call before setup or after teardown. Setup callbacks are run in the order declared; teardown callbacks are run in reverse. [Jeremy Kemper]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8570 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-05 13:34:15 +00:00
Jeremy Kemper
9d755f1983
require abstract_unit directly since test is in load path
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8564 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-05 13:32:06 +00:00
Jeremy Kemper
3464a7e79c
assert_response failures include the exception message. Closes #10688 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8559 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-05 02:19:48 +00:00
David Heinemeier Hansson
2a9ad9ccbc
Moved the caching stores from ActionController::Caching::Fragments::* to ActiveSupport::Cache::*. If you're explicitly referring to a store, like ActionController::Caching::Fragments::MemoryStore, you need to update that reference with ActiveSupport::Cache::MemoryStore [DHH] Deprecated ActionController::Base.fragment_cache_store for ActionController::Base.cache_store [DHH] All fragment cache keys are now by default prefixed with the 'views/' namespace [DHH] Added ActiveRecord::Base.cache_key to make it easier to cache Active Records in combination with the new ActiveSupport::Cache::* libraries [DHH] Added ActiveSupport::Gzip.decompress/compress(source) as an easy wrapper for Zlib [Tobias Luetke] Included MemCache-Client to make the improved ActiveSupport::Cache::MemCacheStore work out of the box [Bob Cottrell, Eric Hodel] Added config.cache_store to environment options to control the default cache store (default is FileStore if tmp/cache is present, otherwise MemoryStore is used) [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8546 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-03 21:05:12 +00:00
David Heinemeier Hansson
e2e98ef0b8
Made fragment caching in views work for rjs and builder as well ( closes #6642 ) [zsombor]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8542 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-03 15:35:10 +00:00
David Heinemeier Hansson
d5645fd4a0
Fixed rendering of partials with layout when done from site layout ( closes #9209 ) [antramm]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8541 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-03 15:28:36 +00:00
Rick Olson
14f6440ed6
Correct indentation in a couple spots. Closes #10671 [l.guidi, rick]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8527 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-01-02 19:24:44 +00:00
Jeremy Kemper
1bb208d7e5
Fixup mocha tests for 0.5.6. Closes #10602 [murphy, mikong]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8508 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-29 05:16:03 +00:00
Jeremy Kemper
7555073803
Ruby 1.9 compat: introduce instance_variable_names. Closes #10630 [Frederick Cheung]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8499 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-28 05:42:12 +00:00
Jeremy Kemper
16558f6dd8
Ensure that test case setup is run even if overridden. Closes #10382 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8497 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-28 05:21:24 +00:00
Jeremy Kemper
41c82e66c1
Ruby 1.9 compat: file uploads. References #1689 [Frederick Cheung]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8492 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-27 11:17:53 +00:00
Rick Olson
e781faddca
Fix HTML Sanitizer to allow trailing spaces in CSS style attributes. Closes #10566 [wesley.moxam]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8485 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-23 21:07:20 +00:00
Jeremy Kemper
fa906778ff
Integration tests use ActionController::Dispatcher rather than the old Dispatcher. Closes #10596 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8483 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-22 19:03:01 +00:00
Jeremy Kemper
f91acf0258
Ruby 1.9 compat: move from the deprecated Base64 module to ActiveSupport::Base64. Closes #10554 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8433 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-18 21:14:07 +00:00
David Heinemeier Hansson
0f6c86ff40
Added delete_via_redirect and put_via_redirect to integration testing ( closes #10497 ) [philodespotos]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8429 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-17 00:39:19 +00:00
David Heinemeier Hansson
436da684dc
Allow headers[Accept] to be set by hand when calling xml_http_request ( closes #10461 ) [BMorearty]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8426 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-17 00:10:18 +00:00
David Heinemeier Hansson
26e10218bc
Added OPTIONS to list of default accepted HTTP methods ( closes #10449 ) [holoway]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8425 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-17 00:06:24 +00:00
Jeremy Kemper
2f61985540
Mark that render tests crash Ruby 1.9
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8410 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-15 02:29:45 +00:00
Jeremy Kemper
ee0ea35d91
Ruby 1.9 compat: helpers
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8409 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-15 02:29:36 +00:00
Jeremy Kemper
525cac7f82
Note that filters test crashes Ruby 1.9
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8408 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-15 02:29:24 +00:00
Jeremy Kemper
a3143eaa98
Ruby 1.9 compat: account for new, non-flattening Array#to_s
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8407 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-15 02:29:15 +00:00
Jeremy Kemper
f85089aabb
Fixes for standalone tests
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8406 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-15 02:29:04 +00:00
Jeremy Kemper
11dde5ca2f
Ruby 1.9 compat: cookies
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8405 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-15 02:28:53 +00:00
Jeremy Kemper
93ec552e9b
Fix up template handler tests. Closes #10437 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8372 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-10 20:41:59 +00:00
Jeremy Kemper
bafd698acb
render :xml and :json preserve custom content types. Closes #10388 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8342 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-09 22:11:37 +00:00
Jeremy Kemper
db885e81b9
Ignore illegal seeks on body rewind. Catches CGI errors depending on your httpd. Closes #10404 [Curtis Hawthorne]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8327 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-07 04:20:20 +00:00
David Heinemeier Hansson
8f24701ae1
Fixed send_file/binary_content for testing ( closes #8044 ) [tolsen]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8318 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-05 23:23:04 +00:00
David Heinemeier Hansson
2af36bbbd4
Fix typos ( closes #10378 )
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8301 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-05 18:54:41 +00:00
David Heinemeier Hansson
3a622d0045
Fix broken test ( closes #10364 ) [chuyeow]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8271 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-05 02:34:36 +00:00
David Heinemeier Hansson
9663f9952a
Make sure that setting the format with a symbol works too
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8261 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-03 19:49:22 +00:00
David Heinemeier Hansson
e03f13c553
Fixed that verification violations with no specified action didn't halt the chain (now they do with a 400 Bad Request) [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8245 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-30 21:04:57 +00:00
Rick Olson
0a9bc591e7
Raise UnknownHttpMethod exception for unknown HTTP methods. Closes #10303 [tarmo]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8235 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-29 02:08:51 +00:00
Michael Koziarski
6a611e1e95
Make sure the optimisation code for routes doesn't get used if :host, :anchor or :port are provided in the hash arguments. [pager, Koz] Closes #10292
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8227 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-28 04:11:37 +00:00
David Heinemeier Hansson
45d679bcb8
Added protection from trailing slashes on page caching ( closes #10229 ) [devrieda]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8226 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-28 00:29:43 +00:00
David Heinemeier Hansson
5e94f053cb
Fixed to_s bug with namespace routes ( closes #10283 ) [johnb]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8216 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-26 22:41:28 +00:00
Rick Olson
87e506da53
Add #prepend_view_path and #append_view_path instance methods on ActionController::Base for consistency with the class methods. [rick]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8214 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-26 03:59:23 +00:00
Rick Olson
1af084ecda
Refactor sanitizer helpers into HTML classes and make it easy to swap them out with custom implementations. Closes #10129 . [rick]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8213 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-26 03:45:54 +00:00
David Heinemeier Hansson
9e76b59c85
Fixed that named routes living under resources shouldn't have double slashes ( closes #10198 ) [isaacfeliu]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8206 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-25 22:24:23 +00:00
Michael Koziarski
ec93d61fb9
Make sure that cookie sessions use a secret that is at least 30 chars in length. [Koz]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8184 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-21 21:31:45 +00:00
Michael Koziarski
41fb4904e2
Refactor cookie_only option to survive multiple requests and add regression tests. References #10048 . [theflow]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8176 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-21 04:28:59 +00:00
Michael Koziarski
0c12d6c6dc
Ensure that the routing optimisation code isn't used when additional arguments are passed to the named route. Closes #10209 [bscofield, Koz]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8169 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-20 21:25:25 +00:00
Michael Koziarski
6d0e5eaf06
memoize host with port and refactor the tests which depend on it changing
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8164 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-17 05:41:47 +00:00
Michael Koziarski
5ce6d74531
Fix Tests broken in [8134]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8135 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-14 09:36:35 +00:00
David Heinemeier Hansson
31e2a2d9bb
Fixed handling of non-domain hosts ( closes #9479 ) [purp]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8108 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-07 14:57:51 +00:00
David Heinemeier Hansson
9a8d583a91
Fixed that ActionController::CgiRequest#host_with_port() should handle standard port ( closes #10082 ) [moro]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8088 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-06 16:36:10 +00:00
Michael Koziarski
788ece4799
Make rescue_from behave like rescue when dealing with subclasses. Closes #10079 [fxn]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8081 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-06 06:02:24 +00:00
Jeremy Kemper
82314608b5
Factor Integration::Runner behavior out of IntegrationTest. Introduce Session#request_count which counts processed requests.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8064 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-01 07:59:24 +00:00
Jeremy Kemper
d44ce1cb73
Integration tests: get_ and post_via_redirect take a headers hash. Closes #9130 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8047 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-27 20:38:08 +00:00
Rick Olson
742694e0eb
Simplfy #view_paths implementation. ActionView templates get the exact object, not a dup. [Rick]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8035 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-26 05:45:41 +00:00
Michael Koziarski
2cc0cac3ef
Introduce TestCase subclasses for testing rails applications allowing tests to be DRY'd up a bit and to provide a path toward tidying up our monkeypatching of test/unit.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8022 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-26 02:21:21 +00:00
Jeremy Kemper
4d2ae8a699
Partials also set 'object' to the default partial variable. Closes #8823 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8018 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-25 21:32:01 +00:00
Michael Koziarski
12d8d48b71
Refactor the default rendering out to a method called default_render to provide a hook for plugin authors. Closes #9953 [cjheath]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8011 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-25 06:38:01 +00:00
Jeremy Kemper
4c2920e89c
Remove unnecessary returns from builtin filters since render/return is now sufficient. Closes #9952 [Josh Peek]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8009 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-24 04:47:40 +00:00
Jeremy Kemper
79670fb975
request.parameters doesn't overwrite request.request_parameters. Closes #9949 [nullstyle]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7992 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-22 21:10:56 +00:00
David Heinemeier Hansson
f777ff72f9
Changed before_filter halting to happen automatically on render or redirect but no longer on simply returning false [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7984 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-21 18:58:17 +00:00
Rick Olson
c9fecf20ff
Ensure that cookies handle array values correctly. Closes #9937 [queso]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7978 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-20 17:30:01 +00:00
Jeremy Kemper
a2172e75f5
Dispatcher: fix that to_prepare should only run once in production. Closes #9889 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7944 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-16 16:36:52 +00:00
Jeremy Kemper
5cb6a9aabd
Improve the error message for assert_redirected_to. Closes #7337 [mikong, sandofsky]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7934 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-16 05:07:23 +00:00
Jeremy Kemper
ae8179f05c
Expand Routes::DynamicSegment test coverage. Closes #7122 [Kevin Clark]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7898 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-15 04:27:31 +00:00
Jeremy Kemper
86a9c212c0
Skip memcache tests unless it's installed
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7893 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-15 01:47:35 +00:00
Jeremy Kemper
6e56cc013f
Wrap test with uses_mocha
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7888 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-14 22:54:28 +00:00
Jeremy Kemper
d0df7f2b12
Memcached sessions: add session data on initialization; don't silently discard exceptions; add unit tests. Closes #9823 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7885 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-14 20:46:06 +00:00
Michael Koziarski
bd03bf9f5e
Make sure that custom inflections are picked up by map.resources by triggering a routing reload when new inflections are defined. Closes #9815 [mislav, kampers]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7849 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-13 03:28:35 +00:00
Jeremy Kemper
4db4661a67
rescue_from accepts :with => lambda { |exception| ... } or a normal block. Closes #9827 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7822 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-10 02:34:42 +00:00
Michael Koziarski
4aabe46341
Add :status to redirect_to allowing users to choose their own response code without manually setting headers. Closes #8297 [codahale, chasgrundy]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7820 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-09 23:07:36 +00:00
Jeremy Kemper
8a2fa23cd1
Add tests for [7727]. Closes #6090 [dkubb, mpalmer, tarmo]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7793 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-08 03:33:30 +00:00
Jeremy Kemper
d9f3c435f9
Fix url_for, redirect_to, etc. with :controller => :symbol instead of 'string'. Closes #8562 , #9525 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7776 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-07 19:12:02 +00:00
Jeremy Kemper
52ca5dad1e
Use StringIO and Tempfile subclasses instead of defining singleton methods on each multipart field.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7759 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-06 11:40:13 +00:00
Jeremy Kemper
3405fb3dea
Rewind stdin if possible after multipart parsing.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7758 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-06 09:39:31 +00:00
Rick Olson
904df818d6
Move ActionController::Routing.optimise_named_routes to ActionController::Base.optimise_named_routes. Now you can set it in the config.
...
ActionController::Routing::DynamicSegment#interpolation_chunk should call #to_s on all values before calling URI.escape. [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7724 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-03 05:47:41 +00:00
Jeremy Kemper
0ee1cb2cd3
Ruby 1.9 compat, consistent load paths
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7719 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-02 05:32:14 +00:00
David Heinemeier Hansson
860cf2d44e
Fixed that render template did not honor exempt_from_layout ( closes #9698 ) [pezra]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7701 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-30 22:59:24 +00:00
David Heinemeier Hansson
7275d2749c
Fixed JSON encoding to use quoted keys according to the JSON standard ( closes #8762 ) [choonkat/chuyeow]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7697 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-30 20:57:50 +00:00
Michael Koziarski
9660360d6b
Re-enable Routing optimisation code for _url methods, add defined?(request) to the guard conditions
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7673 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-28 20:57:39 +00:00
Rick Olson
82ff27766d
Better error messages if you leave out the :secret option for request forgery protection. Closes #9670 [rick]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7671 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-28 16:50:48 +00:00
Michael Koziarski
c1bdf027d8
Add missing require
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7670 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-28 16:48:59 +00:00
Rick Olson
5edc81dcc2
Allow ability to disable request forgery protection, disable it in test mode by default. Closes #9693 [lifofifo]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7668 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-28 15:55:45 +00:00
David Heinemeier Hansson
e3b49c052b
Fixed spelling errors ( closes #9706 ) [tarmo/rmm5t]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7666 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-28 14:18:47 +00:00
David Heinemeier Hansson
3c695356ae
Fixed the layout defaults ( closes #9564 ) [lifo]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7661 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-28 01:23:20 +00:00
Jeremy Kemper
f08da31a4f
Move Railties' Dispatcher to ActionController::Dispatcher, introduce before_ and after_dispatch callbacks, and warm up to non-CGI requests.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7640 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-26 01:24:07 +00:00
David Heinemeier Hansson
82c1fed89f
Protect button_to behind protect_from_forgery ( closes #9675 ) [lifo]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7636 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-25 16:50:35 +00:00
David Heinemeier Hansson
7ca53e1d31
Added another failing test
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7632 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-25 16:37:43 +00:00
David Heinemeier Hansson
06dd4b3166
Better failing tests
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7630 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-25 15:09:21 +00:00
David Heinemeier Hansson
55a9c86e62
Added failing tests for iphone
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7629 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-25 14:57:15 +00:00
David Heinemeier Hansson
501244fee4
Updated iphone_with_html_response_type to fail as it uses the new register_alias approach
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7625 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-24 23:44:36 +00:00
David Heinemeier Hansson
bdf5672077
Change from InvalidToken to InvalidAuthenticityToken to be more specific
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7623 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-24 23:12:25 +00:00
Jeremy Kemper
cb5b8a7f05
Optimized named routes respect AbstractRequest.relative_url_root. Closes #9612 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7605 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-23 22:52:57 +00:00
Jeremy Kemper
6580b3ab00
Remove , and ; (comma and semicolon) from routing separators again. References #8558 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7599 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-23 21:58:02 +00:00
David Heinemeier Hansson
7d9fe04b1d
Fixed cache_page to use the request url instead of the routing options when picking a save path ( closes #8614 ) [josh]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7598 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-23 21:56:52 +00:00
Jeremy Kemper
a6f49d9b78
Introduce ActionController::Base.rescue_from to declare exception-handling methods. Cleaner style than the case-heavy rescue_action_in_public. Closes #9449 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7597 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-23 21:56:22 +00:00
Rick Olson
c619003854
Rename some RequestForgeryProtection methods. The class method is now #protect_from_forgery, and the default parameter is now 'authenticity_token'. [Rick]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7596 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-23 18:14:44 +00:00
Rick Olson
4e3ed5bc44
Merge csrf_killer plugin into rails. Adds RequestForgeryProtection model that verifies session-specific _tokens for non-GET requests. [Rick]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7592 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-23 02:32:55 +00:00
Michael Koziarski
7573791284
Disable the routing optimisation code when dealing with foo_url helpers. Add test to actionmailer to expose the problem they introduced. References #9450 [Koz]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7572 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-22 19:20:06 +00:00
Jeremy Kemper
28f7de07cb
Test CGI::Cookie#to_s. Closes #9624 [tarmo]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7535 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-22 09:01:33 +00:00
Michael Koziarski
9b468f4cd7
[html-scanner] Fix parsing of empty tags. Closes #7641 . [anthony.bailey]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7528 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-21 20:45:49 +00:00
David Heinemeier Hansson
eede82ccb9
Added support for HTTP Only cookies (works in IE6+ and FF 2.0.5+) as an improvement for XSS attacks ( closes #8895 ) [lifo/Spakman]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7525 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-21 15:05:49 +00:00
David Heinemeier Hansson
4156497602
Fixed CaptureHelper#content_for to work with the optional content parameter instead of just the block #9434 [sandofsky/wildchild]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7522 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-21 03:40:25 +00:00
David Heinemeier Hansson
0d99423727
Fixed that default layouts did not take the format into account #9564 [lifofifo]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7514 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-18 23:10:34 +00:00
Michael Koziarski
7cb26b5d2d
Disable optimisation code for UrlWriter as request.host doesn't make sense there.
...
Don't try to use the .to_query method when the route has no dynamic segments.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7501 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-17 09:30:18 +00:00
Jeremy Kemper
148202d401
Fixed optimized route segment escaping. Closes #9562 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7487 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-15 22:10:20 +00:00
Jeremy Kemper
494d2c631b
root_path returns '/' not ''. Closes #9563 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7482 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-15 20:38:39 +00:00
David Heinemeier Hansson
d48039cefb
Fixed that setting request.format would also affect respond_to blocks [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7479 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-15 04:18:32 +00:00
Jeremy Kemper
c87206cc57
Add option to force binary mode on tempfile used for fixture_file_upload. Closes #6380 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7478 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-14 07:34:45 +00:00
David Heinemeier Hansson
b611c685d9
Fixed that resource namespaces wouldnt stick to all nested resources ( closes #9399 ) [pixeltrix]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7447 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-10 14:31:44 +00:00
David Heinemeier Hansson
46f217b298
Removed deprecated form of calling xml_http_request/xhr without the first argument being the http verb [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7436 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-09 23:00:17 +00:00
David Heinemeier Hansson
f7b0bc9ea3
Removed deprecated ActionController::Base.cookie (use ActionController#Base.cookies[]= instead)
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7435 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-09 22:56:15 +00:00
David Heinemeier Hansson
4cfc60a6c8
Removed deprecated ActionController::Base.cookie (use ActionController#Base.cookies[]= instead)
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7434 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-09 22:55:16 +00:00
David Heinemeier Hansson
6b0a647236
Removed ActionController::Base#keep_flash (use flash.keep instead)
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7428 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-09 21:54:59 +00:00
David Heinemeier Hansson
89b7630627
Removed the deprecated ActionController#Base.template_root/= methods (use ActionController#Base.view_paths/= instead) [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7426 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-09 18:00:55 +00:00
Michael Koziarski
80ff0b9f1c
Optimise named route generation when using positional arguments. Closes #9450 [Koz]
...
This change delivers significant performance benefits for the most
common usage scenarios for modern rails applications by avoiding the
costly trip through url_for. Initial benchmarks indicate this is
between 6 and 20 times as fast.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7421 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-09 00:18:55 +00:00
Jeremy Kemper
f1b12b62f4
Fix layout overriding response status. Closes #9476 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7418 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-08 03:12:03 +00:00
Michael Koziarski
32553a2d76
Fix assert_select for XML documents. Closes #8173 . [dasil003]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7417 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-08 01:32:16 +00:00
Michael Koziarski
fe31f0e066
Add a user_agent to TestRequest
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7416 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-07 03:45:54 +00:00
Tobias Lütke
68d685056a
Remove deprecated named routes [pixeltrix]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7415 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-06 14:28:32 +00:00
Michael Koziarski
a75d273ece
Allow additional parameters to be passed to named route helpers when using positional arguments. Closes #8930 [ian.w.white@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7411 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-05 23:37:17 +00:00
Michael Koziarski
f81dae3fca
Remove deprecated functionality from actionpack. Closes #8958 [lifofifo]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7403 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-03 00:18:30 +00:00
Jeremy Kemper
33e5e41dda
request.host works with IPv6 addresses. Closes #9458 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7382 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-08-31 19:03:42 +00:00
Rick Olson
0fc77b3928
correct the ActionCacheTest from [7346]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7348 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-08-20 13:48:13 +00:00
Rick Olson
1a459e8e7d
Fix bug where action caching sets the content type to the ActionCachePath object. Closes #9282 [mindforge]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7346 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-08-20 01:12:43 +00:00
Rick Olson
0127e586d0
Find layouts even if they're not in the first view_paths directory. Closes #9258 [caio]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7321 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-08-15 18:59:37 +00:00
Michael Koziarski
55f444e694
Send freshness information when sending Etags. Without this internet explorer will not send conditional gets for a resource, but instead hold on to the responses for the current browser session.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7309 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-08-12 22:32:19 +00:00
David Heinemeier Hansson
bbbc45156b
Added partial layouts (see example in action_view/lib/partials.rb) [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7261 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-08-02 20:10:03 +00:00
Rick Olson
bdcbfa9944
Allow you to set custom :conditions on resource routes. [Rick]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7234 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-07-25 02:47:21 +00:00
David Heinemeier Hansson
937a7abe45
Fixed that file.content_type for uploaded files would include a trailing \r #9053 [bgreenlee]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7212 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-07-24 01:20:18 +00:00
Tobias Lütke
9014bf3f26
* url_for now accepts a series of symbols representing the namespace of the record [Josh Knowles]. Closes #8640
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7197 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-07-19 13:42:11 +00:00
Michael Koziarski
b549366216
Introduce fake_models.rb to avoid platform-specific code. [mpalmer] Closes #8714
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7190 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-07-17 09:44:03 +00:00
Michael Koziarski
5476a6a6c7
Make :trailing_slash work with query parameters for url_for. Closes #4004 [nov]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7186 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-07-14 09:28:56 +00:00
Michael Koziarski
d4d4a08f6b
Make sure missing template exceptions actually say which template they were looking for. Closes #8683 [dasil003]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7181 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-07-11 23:32:02 +00:00
Michael Koziarski
e80fabbbf4
Fix errors with around_filters which do not yield, restore 1.1 behaviour with after filters. Closes #8891 [skaes]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7177 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-07-11 02:29:25 +00:00
Michael Koziarski
fd65d89e07
Allow you to delete cookies with options. Closes #3685 [josh, Chris Wanstrath]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7160 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-07-01 23:27:59 +00:00
Rick Olson
a450e769f1
Allow you to render views with periods in the name. Closes #8076 [norbert]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7158 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-07-01 00:04:03 +00:00
David Heinemeier Hansson
20045df260
Temporary fix for formatted_polymorphic_urls and other polys that have additional options (need better testing!)
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7152 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-28 22:27:59 +00:00
Jeremy Kemper
557e19346a
Prefix nested resource named routes with their action name, e.g. new_group_user_path(@group) instead of group_new_user_path(@group). The old nested action named route is deprecated in Rails 1.2.4. Closes #8558 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7138 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-27 08:38:55 +00:00
Jeremy Kemper
a72fe4ea45
Give the legacy X-POST_DATA_FORMAT header greater precedence during params parsing for backward compatibility.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7126 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-26 01:19:18 +00:00
David Heinemeier Hansson
73fba4faf1
Fixed that HTTP authentication should work if the header is called REDIRECT_X_HTTP_AUTHORIZATION as well ( closes #6754 ) [mislaw]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7091 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-23 16:43:08 +00:00
Jeremy Kemper
9159489872
Don't mistakenly interpret the request uri as the query string. Closes #8731 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7084 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-23 00:13:40 +00:00