TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
37,831 Commits 2 Branches 0 Tags 294 MiB
6f3e01e8b7
Commit Graph

1943 Commits

Author SHA1 Message Date
kennyj
6f3e01e8b7 Remove active_support/json/variable was deprecated. 2013-06-01 21:23:19 +09:00
Arun Agrawal
5eaa30e47c Running isolated tests 
These stopped running don't know when. 
But these should be running now.
 2013-05-28 19:59:55 +02:00
Carlos Antonio da Silva
c3890d38cb Merge pull request #10763 from senny/10758_to_sentence_with_blank_elements 
test-case for `Array#to_sentence` with `blank?` items.
 2013-05-26 13:51:49 -07:00
Yves Senn
27b8a99263 add test-case for `Array#to_sentence with blank items. 2013-05-26 18:47:23 +02:00
Vipul A M
d745d62616 Fix some typo in method names, variables 2013-05-26 16:27:05 +05:30
Carl Lerche
e539228d08 Bug fix: Evented notification subscribers can handle published events 2013-05-17 16:27:23 -07:00
Rafael Mendonça França
8f2b1a12dc Merge pull request #10652 from md5/concern-multiple-included 
Raise an error when multiple included blocks are defined for a Concern
 2013-05-16 14:06:00 -07:00
Aaron Patterson
9fef7c8dc9 Merge pull request #10527 from zenspider/squishy_minitest5 
Squishy minitest5
 2013-05-16 13:41:54 -07:00
Mike Dillon
2d7a86e179 Raise when multiple included blocks are defined 2013-05-16 11:28:31 -07:00
Aaron Patterson
1012c3e969 remove deprecation notices 2013-05-15 09:40:58 -07:00
kennyj
f9c82f586c Fix HWIA#to_hash behavior with array of hashes. 2013-05-16 00:08:58 +09:00
Aaron Patterson
ba55276434 deprecating string based terminators 2013-05-14 16:03:09 -07:00
Rafael Mendonça França
c7182563e5 Merge pull request #10266 from vipulnsward/fix_HIA_to_hash 
fix HashWithIndifferentAccess#to_hash behaviour
 2013-05-14 12:39:48 -07:00
Aaron Patterson
9dcecbb080 Merge branch 'master' into normalizecb 
* master:
  private callback methods should work
  Update mail to minimum version 2.5.4
 2013-05-14 10:48:43 -07:00
Aaron Patterson
f93da579ce private callback methods should work 2013-05-14 10:48:34 -07:00
Aaron Patterson
edf116a91b Merge branch 'master' into normalizecb 
* master:
  adding more callback type coverage
 2013-05-13 15:42:01 -07:00
Aaron Patterson
099e827f57 adding more callback type coverage 2013-05-13 15:40:39 -07:00
Aaron Patterson
19b9f7ba33 pass the actual filter, not a string 2013-05-13 12:05:22 -07:00
Aaron Patterson
37ca5b0966 add tests for reset_calbacks 2013-05-13 11:44:15 -07:00
Erik Michaels-Ober
ce4456fde6 Replace multi_json with json 2013-05-11 21:43:48 -07:00
Rafael Mendonça França
4b57bc0c2a Merge pull request #10534 from cmaruz/master 
Escape of U+2028 and U+2029 in the JSON Encoder

Conflicts:
	activesupport/lib/active_support/json/encoding.rb
 2013-05-10 14:38:23 -03:00
Vipul A M
6944dfb5d0 remove redundant var 2013-05-09 18:23:27 +05:30
Mario Caropreso
582b44175b Added escaping of U+2028 and U+2029 inside the json encoder. 
U+2028 and U+2029 are allowed inside strings in JSON (as all literal
Unicode characters) but JavaScript defines them as newline
seperators. Because no literal newlines are allowed in a string, this
causes a ParseError in the browser. We work around this issue by
replacing them with the escaped version. The resulting JSON is still
valid and can be parsed in the browser.

This commit has been coauthored with Viktor Kelemen @yikulju
 2013-05-09 13:41:56 +01:00
Aaron Patterson
1d6ac22462 add test for object conditional with scope 2013-05-08 15:51:45 -07:00
Aaron Patterson
7d89a9f00a adding a class conditional test 2013-05-08 15:23:39 -07:00
Aaron Patterson
ece76f3840 adding tests for lambdas as conditions 2013-05-08 14:35:43 -07:00
Aaron Patterson
1ff1236b07 we need to indicate the type of callback 2013-05-08 11:37:26 -07:00
Aaron Patterson
5d2c3a14a3 adding more tests around callback inconsistencies 2013-05-08 10:31:02 -07:00
Aaron Patterson
d32b329b7e refactor tests for more points 2013-05-08 10:08:37 -07:00
Aaron Patterson
3df92d981b adding test to demonstrate inconsistencies in the AS::Callbacks api 2013-05-08 10:07:19 -07:00
Prathamesh Sonpatki
b5429eec60 Fix Typo existant -> existent [ci skip] 2013-05-08 09:50:46 +05:30
Sean Walbran
9003a422f2 fix issue #10502, do not recompute method name for already-stringified object filter 2013-05-07 13:22:52 -05:00
Rafael Mendonça França
33283c98ed Merge pull request #10234 from dasch/dasch/fetch-multi 
Allow fetching multiple values from the cache at once
 2013-05-06 18:52:57 -07:00
Ryan Davis
3073c53198 Updates to make rails 4 happy with minitest 5: 
+ Namespace changes, overhaul of runners.
+ Internal ivar name changes
- Removed a logger globally applied to tests that spew everywhere?!?
+ Override Minitest#__run to sort tests by name.
+ Reworked testing isolation to work with the new cleaner architecture.
- Removed a bunch of tests that just test minitest straight up. I think these changes were all merged to minitest 4 a long time ago.
- Minor report output differences.
 2013-05-06 17:38:45 -07:00
Daniel Schierbeck
36d41a15c3 Allow fetching multiple values from the cache at once 
Add a simple API for fetching a list of entries from the cache, where
any missing entries are computed by a supplied block.
 2013-05-06 11:38:51 +02:00
Anton Kalyaev
13c19c8de0 use nokogirisax as a backend 
Most likely someone just forgot to change it during copying and
pasting test cases from nokigiri engine test.
 2013-05-05 19:47:50 +04:00
Ryan Davis
adc049b06f Fixed bad tests to clean up after themselves. 2013-05-03 15:37:18 -07:00
Aaron Patterson
4c242e6d33 Squashed commit of the following: 
commit 2683de5da85135e8d9fe48593ff6167db9d64b18
Author: Aaron Patterson <aaron.patterson@gmail.com>
Date:   Fri May 3 11:29:20 2013 -0700

    cannot support infinite ranges right now

commit cebb6acef2c3957f975f6db4afd849e535126253
Author: Aaron Patterson <aaron.patterson@gmail.com>
Date:   Fri May 3 11:26:12 2013 -0700

    reverting infinity comparison

commit 385f7e6b4efd1bf9b89e8d607fcb13e5b03737ea
Author: Aaron Patterson <aaron.patterson@gmail.com>
Date:   Fri May 3 11:23:28 2013 -0700

    Revert "Added ability to compare date/time with infinity"

    This reverts commit 38f28dca3aa16efd6cc3af6453f2e6b9e9655ec1.

    Conflicts:
    	activesupport/CHANGELOG.md
    	activesupport/lib/active_support/core_ext/numeric/infinite_comparable.rb
    	activesupport/test/core_ext/date_ext_test.rb
    	activesupport/test/core_ext/date_time_ext_test.rb
    	activesupport/test/core_ext/numeric_ext_test.rb
    	activesupport/test/core_ext/time_ext_test.rb
    	activesupport/test/core_ext/time_with_zone_test.rb

commit 0d799a188dc12b18267fc8421675729917610047
Author: Aaron Patterson <aaron.patterson@gmail.com>
Date:   Fri May 3 11:18:53 2013 -0700

    Revert "Refactor infinite comparable definition a bit"

    This reverts commit dd3360e05e4909f2f0c74a624cccc2def688f828.

commit 42dec90e49745bbfae546f0560b8783f6b48b074
Author: Aaron Patterson <aaron.patterson@gmail.com>
Date:   Fri May 3 11:18:47 2013 -0700

    Revert "Require 'active_support/core_ext/module/aliasing' in the infinite_comparable module"

    This reverts commit 7003e71c13c53ec3d34250560fbf80b8381df693.
 2013-05-03 11:29:35 -07:00
Carlos Antonio da Silva
eee91eb77e Merge pull request #10412 from vipulnsward/fix_callback_test_typo 
Fix typo in test
 2013-05-02 05:55:26 -07:00
Vipul A M
469befa7ef Fix typo in test 2013-05-02 09:42:57 +05:30
Carlos Antonio da Silva
da47960893 Fix failures in AS with minitest 4.7.4 2013-05-01 23:21:08 -03:00
Brian Morearty
d7da403dde Revert "Object#in? also accepts multiple parameters" 
This reverts commit ebf69ab1636df74c76332c53bcd3d8494fb91b45.

`in?` must not take multiple parameters because its behavior would be
ambiguous:

    # Test if "B" is included in a list of names with `"B".in?(*names)`:
    names = ["BMorearty"]
    "B".in?(*names)   # => true

    names = ["BMorearty","rubyduo"]
    "B".in?(*names)   # => false

Conflicts:
	activesupport/lib/active_support/core_ext/object/inclusion.rb
	activesupport/test/core_ext/object/inclusion_test.rb
 2013-05-01 04:32:20 -07:00
Xavier Noria
65850baf98 Module#delegate checks nilness rather that falsehood if :allow_nil is true, and avoids multiple evaluation of the target method 
Notes:

1) I hope nilness is a word.

2) See rationale for avoiding multiple evaluation in a comment in the patch, credit goes to @jeremy for pointing out this gotcha in the existing implementation.

3) Embeds a little joke dedicated to @pixeltrix (it could be worse! :D).

References #10347.
 2013-04-26 19:58:54 +02:00
Xavier Noria
11e23b9561 Merge pull request #10351 from JonRowe/update_as_date_next_week_to_document_intent 
Propose better documentation for ActiveSupports `next_week` functionaility
 2013-04-26 01:49:06 -07:00
Li Ellis Gallardo
ccbe023439 Delegation method bug 
Add documentation and test to delegation method that make sure we're
aware that when a delegated object is not nil or false and doesn't
respond to the method it will still raise a NoMethodError exception.
 2013-04-25 21:36:22 -05:00
Jon Rowe
888f21492a better document next_week functionaility closes #9568 2013-04-26 09:09:53 +10:00
Andrew White
a56b150b64 Adjust for daylight savings in String#to_time 
The changes in b79adc4323 had a bug where if the time in the String
was in standard time but the current time was in daylight savings then
the calculated adjustment was off by an hour.

This commit fixes this and adds extra tests for the following:

* time in string is standard time, current time is standard time
* time in string is standard time, current time is daylight savings
* time in string is daylight savings, current time is standard time
* time in string is daylight savings, current time is daylight savings

Fixes #10306.
 2013-04-23 12:48:31 +01:00
Rafael Mendonça França
dab58bee2a Merge pull request #10096 from benofsky/fix_skipping_object_callback_filters 
Fixes skipping object callback filters
 2013-04-21 21:19:18 -07:00
Vipul A M
df24b8790f fix HashWithIndifferentAccess#to_hash behaviour 2013-04-19 21:20:32 +05:30
Hrvoje Šimić
4037fc83c1 more descriptive NameError's messages for class attributes 2013-04-17 16:12:21 +02:00