Commit Graph

1956 Commits

Author SHA1 Message Date
Rafael Mendonça França
78234fe605 Merge pull request #10740 from mrsimo/hash-with-indifferent-access-select
HashWithIndifferentAccess#select working as intended
2013-06-14 13:53:31 -07:00
Xavier Noria
85bb7d9af1 Merge pull request #10943 from killthekitten/10932_constantize_empty
Fix #10932. Treat "" and "::" as invalid on constantize
2013-06-14 02:19:25 -07:00
Nikolay Shebanov
7fd36f307a Fix #10932. Treat "" and "::" as invalid on constantize 2013-06-14 11:20:15 +04:00
Andrew White
a272d0cbe2 Add missing nsec test for 17f5d8e 2013-06-13 12:21:19 +01:00
Andrew White
17f5d8e062 Keep sub-second resolution when wrapping a DateTime value
Add `DateTime#usec` and `DateTime#nsec` so that `ActiveSupport::TimeWithZone`
keeps sub-second resolution when wrapping a `DateTime` value.

Fixes #10855
2013-06-13 12:01:12 +01:00
Vipul A M
48b6860b79 Drop extra variable from test 2013-06-12 11:18:35 +05:30
Andrew Kreiling
a548792aa0 Don't blindly call blame_file! on exceptions in ActiveSupport::Dependencies::Loadable
It is possible under some environments to receive an Exception that is
not extended with Blamable (e.g. JRuby).
ActiveSupport::Dependencies::Loadable#load_dependency blindly call
blame_file! on the exception which throws it's own NoMethodError
exception and hides the original Exception.

This commit fixes #9521
2013-06-09 18:20:10 -04:00
Andrew White
b7f9de27f0 Override Time.at to work with Time-like values
Time.at allows passing a single Time argument which is then converted
to an integer. The conversion code since 1.9.3r429 explicitly checks
for an instance of Time so we need to override it to allow DateTime
and ActiveSupport::TimeWithZone values.
2013-06-08 09:50:15 +01:00
Rafael Mendonça França
424fa92b35 Merge pull request #10784 from senny/10526_prevent_key_transformation
Prevent side effects in `Hash#with_indifferent_access`.
2013-06-03 16:46:59 -07:00
David Heinemeier Hansson
a6fe33d8a3 Allow Date to be compared with Time (like it was possible to compare Time with Date) 2013-06-03 16:47:48 +02:00
kennyj
6c2cbc6fff Remove active_support/testing/pending.rb was deprecated. 2013-06-01 21:23:19 +09:00
kennyj
6f3e01e8b7 Remove active_support/json/variable was deprecated. 2013-06-01 21:23:19 +09:00
Yves Senn
c44a929f49 Prevent side effects in Hash#with_indifferent_access. 2013-05-29 08:43:35 +02:00
Arun Agrawal
5eaa30e47c Running isolated tests
These stopped running don't know when. 
But these should be running now.
2013-05-28 19:59:55 +02:00
Carlos Antonio da Silva
c3890d38cb Merge pull request #10763 from senny/10758_to_sentence_with_blank_elements
test-case for `Array#to_sentence` with `blank?` items.
2013-05-26 13:51:49 -07:00
Yves Senn
27b8a99263 add test-case for `Array#to_sentence with blank items. 2013-05-26 18:47:23 +02:00
Vipul A M
d745d62616 Fix some typo in method names, variables 2013-05-26 16:27:05 +05:30
Albert Llop
921ec9b5c6 HashWithIndifferentAccess#select working as intended
Before this commit, #reject returned a HashWithIndifferentAccess,
whereas #select returned a Hash. Now #select also returns a
HashWithIndifferentAccess.
2013-05-23 15:26:00 +02:00
Carl Lerche
e539228d08 Bug fix: Evented notification subscribers can handle published events 2013-05-17 16:27:23 -07:00
Rafael Mendonça França
8f2b1a12dc Merge pull request #10652 from md5/concern-multiple-included
Raise an error when multiple included blocks are defined for a Concern
2013-05-16 14:06:00 -07:00
Aaron Patterson
9fef7c8dc9 Merge pull request #10527 from zenspider/squishy_minitest5
Squishy minitest5
2013-05-16 13:41:54 -07:00
Mike Dillon
2d7a86e179 Raise when multiple included blocks are defined 2013-05-16 11:28:31 -07:00
Aaron Patterson
1012c3e969 remove deprecation notices 2013-05-15 09:40:58 -07:00
kennyj
f9c82f586c Fix HWIA#to_hash behavior with array of hashes. 2013-05-16 00:08:58 +09:00
Aaron Patterson
ba55276434 deprecating string based terminators 2013-05-14 16:03:09 -07:00
Rafael Mendonça França
c7182563e5 Merge pull request #10266 from vipulnsward/fix_HIA_to_hash
fix HashWithIndifferentAccess#to_hash behaviour
2013-05-14 12:39:48 -07:00
Aaron Patterson
9dcecbb080 Merge branch 'master' into normalizecb
* master:
  private callback methods should work
  Update mail to minimum version 2.5.4
2013-05-14 10:48:43 -07:00
Aaron Patterson
f93da579ce private callback methods should work 2013-05-14 10:48:34 -07:00
Aaron Patterson
edf116a91b Merge branch 'master' into normalizecb
* master:
  adding more callback type coverage
2013-05-13 15:42:01 -07:00
Aaron Patterson
099e827f57 adding more callback type coverage 2013-05-13 15:40:39 -07:00
Aaron Patterson
19b9f7ba33 pass the actual filter, not a string 2013-05-13 12:05:22 -07:00
Aaron Patterson
37ca5b0966 add tests for reset_calbacks 2013-05-13 11:44:15 -07:00
Erik Michaels-Ober
ce4456fde6 Replace multi_json with json 2013-05-11 21:43:48 -07:00
Rafael Mendonça França
4b57bc0c2a Merge pull request #10534 from cmaruz/master
Escape of U+2028 and U+2029 in the JSON Encoder

Conflicts:
	activesupport/lib/active_support/json/encoding.rb
2013-05-10 14:38:23 -03:00
Vipul A M
6944dfb5d0 remove redundant var 2013-05-09 18:23:27 +05:30
Mario Caropreso
582b44175b Added escaping of U+2028 and U+2029 inside the json encoder.
U+2028 and U+2029 are allowed inside strings in JSON (as all literal
Unicode characters) but JavaScript defines them as newline
seperators. Because no literal newlines are allowed in a string, this
causes a ParseError in the browser. We work around this issue by
replacing them with the escaped version. The resulting JSON is still
valid and can be parsed in the browser.

This commit has been coauthored with Viktor Kelemen @yikulju
2013-05-09 13:41:56 +01:00
Aaron Patterson
1d6ac22462 add test for object conditional with scope 2013-05-08 15:51:45 -07:00
Aaron Patterson
7d89a9f00a adding a class conditional test 2013-05-08 15:23:39 -07:00
Aaron Patterson
ece76f3840 adding tests for lambdas as conditions 2013-05-08 14:35:43 -07:00
Aaron Patterson
1ff1236b07 we need to indicate the type of callback 2013-05-08 11:37:26 -07:00
Aaron Patterson
5d2c3a14a3 adding more tests around callback inconsistencies 2013-05-08 10:31:02 -07:00
Aaron Patterson
d32b329b7e refactor tests for more points 2013-05-08 10:08:37 -07:00
Aaron Patterson
3df92d981b adding test to demonstrate inconsistencies in the AS::Callbacks api 2013-05-08 10:07:19 -07:00
Prathamesh Sonpatki
b5429eec60 Fix Typo existant -> existent [ci skip] 2013-05-08 09:50:46 +05:30
Sean Walbran
9003a422f2 fix issue #10502, do not recompute method name for already-stringified object filter 2013-05-07 13:22:52 -05:00
Rafael Mendonça França
33283c98ed Merge pull request #10234 from dasch/dasch/fetch-multi
Allow fetching multiple values from the cache at once
2013-05-06 18:52:57 -07:00
Ryan Davis
3073c53198 Updates to make rails 4 happy with minitest 5:
+ Namespace changes, overhaul of runners.
+ Internal ivar name changes
- Removed a logger globally applied to tests that spew everywhere?!?
+ Override Minitest#__run to sort tests by name.
+ Reworked testing isolation to work with the new cleaner architecture.
- Removed a bunch of tests that just test minitest straight up. I think these changes were all merged to minitest 4 a long time ago.
- Minor report output differences.
2013-05-06 17:38:45 -07:00
Daniel Schierbeck
36d41a15c3 Allow fetching multiple values from the cache at once
Add a simple API for fetching a list of entries from the cache, where
any missing entries are computed by a supplied block.
2013-05-06 11:38:51 +02:00
Anton Kalyaev
13c19c8de0 use nokogirisax as a backend
Most likely someone just forgot to change it during copying and
pasting test cases from nokigiri engine test.
2013-05-05 19:47:50 +04:00
Ryan Davis
adc049b06f Fixed bad tests to clean up after themselves. 2013-05-03 15:37:18 -07:00