TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
89,475 Commits 2 Branches 0 Tags 294 MiB
796eb66445
Commit Graph

8886 Commits

Author SHA1 Message Date
Mathieu Le Tiec
796eb66445
Clarify ActiveModel::SecurePassword maximum password length 
Since 74264f4 improved the secure_password length validation to match bcrypt limit, this validation can be described more accurately in the ActiveModel basics guide.
 2023-10-24 10:24:38 +02:00
Rafael Mendonça França
7937092b3e
Merge pull request #49723 from mylesboone/activestorage_touch_config 
Add config option to not touch records
 2023-10-23 13:56:02 -04:00
Petrik de Heus
2a5666ae11
Merge pull request #49729 from joshuay03/add-discord-link-to-contributing-guide 
Add Discord invite link to contributing guide
 2023-10-21 14:03:05 +02:00
Xinqi Mu
6dd1f87e26
Fix factually incorrect SQL statements 2023-10-21 18:40:45 +08:00
Joshua Young
1fb96f0856 Add Discord invite link to contributing guide 2023-10-21 16:14:17 +10:00
Hartley McGuire
92fb75e46a
Add release note for alias_attribute deprecation 
Ref eae26caec3e38c21835f4afd8622aad20c16c713
 2023-10-20 18:49:09 -04:00
Di Wu
f48c3ad9e8
Update broken links in testing.md on Setting Header And CGI Variables (#49725) 
* Update broken links in testing.md

The HTTP headers and CGI variables section had broken links. Updated these to direct to the correct locations on datatracker.ietf.org.

* Update to Point to correct section 4.1
 2023-10-20 17:59:02 -04:00
Myles Boone
13d66b1632 Add config option to not touch records 
ActiveStorage::Attachment records are not directly maintained by
ActiveStorage and it may not be feasible or desired to update the record
when its attachment is saved.
 2023-10-20 14:41:57 -04:00
Aitor García Rey
4a3e51a840
Update classic_to_zeitwerk_howto.md 
Some typos were fixed on the Zeitwerk migration guide.
 2023-10-17 18:54:58 +02:00
Sean Doyle
8ecbdb3dbc Fix failing linter in guides/source 
Fix [Failing CI Lint][]

Adds a missing comma to make an example Ruby block syntactically valid.

[Failing CI Lint]: https://github.com/rails/rails/actions/runs/6539678344/job/17758241844?pr=49486#step:4:12
 2023-10-16 23:00:58 +01:00
eileencodes
0b1a6d76ac
[ci skip] Fix shard docs followup 
Oops, the ShardRecord needs to be an abstract class and
ApplicationRecord needs to be a primary_abstract_class
 2023-10-16 17:09:46 -04:00
eileencodes
35e0ae4337
[ci skip] Fix shard docs 
We never explained how migrations paths work for shards. This fixes that
and also adds the appropriate class setup. You no longer need to set a
`default` shard as of #48353. In addition, `ApplicationRecord` should be
used for the non-sharded db that also serves as the tenant/shard router.
Then shards should get their own connection class since the schema
differs.
 2023-10-16 17:02:11 -04:00
Rafael Mendonça França
2872d55a3b
Revert "Add psych to the bug report template" 
This reverts commit e4e242685efc74e4bacccd5c5878bc671fd63fb7.

This doesn't solve the problem.
 2023-10-16 15:26:13 +00:00
Rafael Mendonça França
e4e242685e
Add psych to the bug report template 
With release of psych 5.1.1.1 bundler doesn't know which version to
load.

https://buildkite.com/rails/rails/builds/100852
 2023-10-16 14:14:21 +00:00
Ryuta Kamizono
53438e9216
Merge pull request #49632 from zzak/bug_report_templates/unfreeze_rack 
Revert "Freeze rack in 2.0 for guides bug report templates"
 2023-10-15 12:40:51 +09:00
Dustin Brown
c11c5cb482 Fix code blocks that caused lint failures 2023-10-14 17:02:19 +00:00
Rafael Montas
dd8f6e5cbb Fix typo in configuring guide 2023-10-14 12:59:35 +00:00
zzak
a03200460e
Revert "Freeze rack in 2.0 for guides bug report templates" 
This reverts commit c5ace249e742eeb5f5aee4b4464b9c6f7a4af3eb.

Since this commit support for Rack 3 has stabilized.
 2023-10-14 09:23:28 +09:00
Rafael Mendonça França
653725ee7c
Merge pull request #49610 from ezekg/fix/note-on-rails-7-1-sha-1-bug 
Add note on active_record.encryption.support_sha1_for_non_deterministic_encryption
 2023-10-13 17:14:47 +02:00
Edward Tippett
2130d523b4 Use correct tense of cast for guides 
Switch to `cast` for describing the past tense actions.

`casted` is a common mistake, but not correct English.
 2023-10-13 13:07:07 +10:30
paulreece
f5668a0b18 Just clarifies a little the bun installation process and gives people instructions what to do if it did not install. 2023-10-12 18:01:38 -04:00
Zeke Gabrielse
88ed242498 Add note on support_sha1_for_non_deterministic_encryption 2023-10-12 14:37:30 -05:00
Carlos Antonio da Silva
bbf4fc9efb
Merge pull request #49603 from y0608/patch-1 
Fix broken link in AR validations guide [ci skip]
 2023-10-12 10:44:16 -03:00
Carlos Antonio da Silva
837b8d992c
Merge pull request #49602 from Earlopain/49600-followup 
Update filter_parameters default in configuring guide [ci skip]
 2023-10-12 10:40:59 -03:00
Y.I
bb638b4143
Typo: broken link 2023-10-12 16:30:14 +03:00
Earlopain
227aa4e8c0
Update filter_parameters default in configuring guide [ci skip] 2023-10-12 14:45:55 +02:00
Carlos Antonio da Silva
5103ab167e Fix numbered list and indentation of code blocks on upgrade guide 
Otherwise they are considered separate lists instead of a sequence
within the same list. This also renders the code block with extra
indent, as part of the item they belong to.

Also use `Active Record Encryption` with capital letters consistently.

[ci skip]
 2023-10-12 08:46:39 -03:00
Jonathan Hefner
d7aee014cb Fix monospace formatting [ci-skip] 2023-10-11 23:51:34 -05:00
Jonathan Hefner
5021b46396 Remove unnecessary monospace formatting [ci-skip] 2023-10-11 23:47:52 -05:00
John Bampton
6cd5254111 guides/source/asset_pipeline.md: fix spelling 2023-10-12 13:54:00 +10:00
Rafael Mendonça França
90a6f3663b
Merge pull request #49587 from jdelStrother/patch-2 
Advise upgraders to set active_record.encryption.hash_digest_class
 2023-10-12 01:12:36 +02:00
Jonathan del Strother
5f68493cda
Advise upgraders to set active_record.encryption.hash_digest_class 
This is currently documented in new_framework_defaults, but deserves highlighting more explicitly to help anyone upgrading from older versions.
 2023-10-11 22:51:59 +00:00
Rafael Mendonça França
7228da34b9
Merge pull request #49532 from akhilgkrishnan/base-template-for-7-2-release-note 
Added base template for rails 7.2 release note [skip ci]
 2023-10-11 23:03:13 +02:00
Rafael Mendonça França
2f853e6bed
Merge pull request #49585 from akhilgkrishnan/update-7-1-to-7-2 
Updated the rails version in 7.1 to 7.2 in guide [skip ci]
 2023-10-11 22:01:30 +02:00
Carlos Antonio da Silva
c8c95f424e
Merge pull request #49580 from p8/guides/format-html-attributes 
Recommend fixed-width fonts for HTML and CSS as well in documentation [ci-skip]
 2023-10-11 14:23:27 -03:00
Rafael Mendonça França
452c9f6c71
Merge pull request #49538 from akhilgkrishnan/capitalize-framework-names 
Capitalize framework names [skip ci]
 2023-10-11 17:04:27 +02:00
Akhil G Krishnan
41e86d4286 Updated the rails version in 7.1 to 7.2 in guide [skip ci] 2023-10-11 20:26:23 +05:30
Eileen M. Uchitelle
bfd981ebb4
Merge pull request #49539 from akhilgkrishnan/docs-update-7-0-to-7-1 
Updated the rails version in 7.0 to 7.1 in guide [skip ci]
 2023-10-11 10:17:44 -04:00
Akhil G Krishnan
72fae17f92 Updated the rails version in 7.0 to 7.1 in guide [skip ci] 2023-10-11 19:45:22 +05:30
Ryuta Kamizono
7514031eeb
Merge pull request #49582 from fatkodima/enable-RedundantDoubleSplatHashBraces-cop 
Enable `Style/RedundantDoubleSplatHashBraces` rubocop cop
 2023-10-11 22:39:55 +09:00
fatkodima
b8829cabec Enable Style/RedundantDoubleSplatHashBraces rubocop cop 2023-10-11 14:55:00 +03:00
hachi8833
0df2c25479 Update guide: NPM -> npm 2023-10-11 19:07:50 +09:00
Petrik
79f5588d33 Recommend fixed-width fonts for HTML and CSS as well in docs [ci-skip] 2023-10-11 11:20:11 +02:00
Sébastien Dubois
6eeb128e60 Explain how to configure collection cache key 2023-10-11 09:54:54 +02:00
Jonathan Hefner
8776e951f2
Merge pull request #49556 from mguan2020/my_new_branch 
Fixed formatting in Action Text documentation to make it more consistent. [ci skip]
 2023-10-10 23:06:26 -05:00
John Bampton
7ee9306bb7 guides/source/asset_pipeline.md: change Javascript to JavaScript 2023-10-11 09:18:36 +05:30
John Bampton
bc41113fc9 guides/source/configuring.md: fix grammar and spelling 2023-10-11 09:18:36 +05:30
Akhil G Krishnan
cf61804fd4 Update postgres naming to PostgreSQL 2023-10-11 09:18:36 +05:30
John Bampton
10bd1d8d23 guides/source/asset_pipeline.md: change Javascript to JavaScript 2023-10-11 08:13:16 +10:00
John Bampton
ecac7d6d4e guides/source/configuring.md: fix grammar and spelling 2023-10-11 07:04:34 +10:00