_N_I_X_O_N_
c06b614c12
Fix activestorage direct upload on firefox
...
Direct upload on firefox is not working because it can’t handle click
events on “input[type=submit]”.
After a successful upload we can see on console a xml parse error, it
happens because AWS S3 success body response is empty, so changing the
reponseType suppress this error.
2017-09-12 18:45:23 +00:00
George Claghorn
2cd8ac1b68
Have attachments touch their records
2017-08-31 20:10:56 -04:00
Yoshiyuki Hirano
e38900b845
Update Active Storage docs [ci skip]
2017-08-30 02:40:03 +09:00
George Claghorn
d3e7dc6f16
Synchronously destroy attachments
2017-08-29 00:02:59 -04:00
Yoshiyuki Hirano
0196ac6654
Enable links in Active Storage docs [ci skip]
2017-08-26 05:47:26 +09:00
Yoshiyuki Hirano
7ba922bb48
Fix link in doc for active storage [ci skip]
2017-08-25 22:44:46 +09:00
George Claghorn
446814c3b8
Add frozen string literal pragma
2017-08-21 18:25:21 -04:00
George Claghorn
63395aba5a
Encode Content-Disposition filenames according to RFC 2231
...
Closes #30134 .
2017-08-21 18:23:15 -04:00
George Claghorn
376dd5c001
DRY
2017-08-20 18:09:44 -04:00
George Claghorn
8bd14971b9
Rename ActiveStorage::Filename#extname to extension_with_delimiter
2017-08-20 16:30:15 -04:00
Xavier Noria
d8bf5d73c3
restores some double newlines deleted in ae87217
...
These were intentional, see
https://github.com/rails/rails/pull/30061#issuecomment-320068368
2017-08-15 22:01:24 +02:00
Xavier Noria
ae87217382
minor tweaks in Active Storage after a walkthrough
2017-08-15 18:50:46 +02:00
Koichi ITO
d02844f249
Use frozen string literal in Active Storage
2017-08-12 21:43:42 +09:00
Anton Khamets
e25466b142
Enable browser caching for blobs and variants ( #30196 )
2017-08-11 13:18:12 -04:00
Koichi ITO
d90f261562
Fix formatting of Active Storage docs [ci skip]
...
Follow up of #30188 .
2017-08-11 13:15:23 +09:00
qsona
7cfa80f812
Fix a typo
2017-08-10 12:11:28 +09:00
Ryuta Kamizono
6768390a42
Use content_type.start_with?("...") than content_type =~ /^.../
...
`start_with?` is a little faster than regexp for prefix matching by a
fixed string.
2017-08-05 08:10:13 +09:00
Rafael França
66e5bf9d07
Merge pull request #30061 from claudiob/ast-rubocop
...
Make Rubocop happy about ActiveStorage
2017-08-03 17:24:45 -04:00
Rafael Mendonça França
f601a01b2c
Do not eager load ActiveRecord::Base
...
Everything inside the app directory of a engine is autoload/eager loaded automatically so we don't need to require them.
2017-08-03 16:57:48 -04:00
Rafael Mendonça França
da44e858ca
There is no reason to single line methods here
...
I know those methods are unlikely to change but having one line method
is hard to read and also hard to modify.
2017-08-03 15:23:28 -04:00
claudiob
9d636c9e2f
Make Rubocop happier about ActiveStorage
...
Running `rubocop activestorage` before this commit resulted in 20 offenses.
This commit only fixes:
- Trailing whitespace detected
- Space inside } missing
- Put one space between the method name and the first argument.
The other offenses are left since they are intentional according to
@georgeclaghorn (https://github.com/rails/rails/pull/30061#issuecomment-319999190 )
2017-08-03 11:43:08 -07:00
David Heinemeier Hansson
13882d0067
Remove circular dependency
2017-08-01 17:12:57 -05:00
David Heinemeier Hansson
ba12811db2
Move the direct_upload: true convenience option from the activestorage helper into actionview
2017-07-31 16:23:37 -05:00
Rafael Mendonça França
9330d01ada
Add 'activestorage/' from commit '3f4a7218a4a4923a0e7ce1b2eb0d2888ce30da58'
...
git-subtree-dir: activestorage
git-subtree-mainline: 0d58e7e478e79c2d6b2a39a4444d2a17a903b2a6
git-subtree-split: 3f4a7218a4a4923a0e7ce1b2eb0d2888ce30da58
2017-07-31 15:21:22 -04:00
