TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
4,679 Commits 2 Branches 0 Tags 294 MiB
7ec0204ecd
Commit Graph

771 Commits

Author SHA1 Message Date
David Heinemeier Hansson
7ec0204ecd Move etagging down to response, so renders with layouts dont screw it up [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6165 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-19 00:27:19 +00:00
David Heinemeier Hansson
aad7fbde68 Added caching option to AssetTagHelper#stylesheet_link_tag and AssetTagHelper#javascript_include_tag [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6164 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-18 23:54:20 +00:00
David Heinemeier Hansson
109d4ac954 Allow people to set their own etags, if they want more control over the process (closes #7580) [] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6163 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-18 16:32:05 +00:00
Jeremy Kemper
c9260c556c Add request protocol to asset host if not given. Prefer setting asset host as hostname only, no request protocol. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6162 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-18 07:23:57 +00:00
Jeremy Kemper
90c1207c38 Work around the two connection per host browser limit: use asset%d.myapp.com to distribute asset requests among asset[0123].myapp.com. Use a DNS wildcard or CNAMEs to map these hosts to your asset server. See http://www.die.net/musings/page_load_time/ for background. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6161 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-18 06:44:20 +00:00
Jeremy Kemper
4fd84aae90 Etagging ignores appended and block responses. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6160 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-18 00:47:18 +00:00
David Heinemeier Hansson
2e55095f6f Added that rendering will automatically insert the etag header on 200 OK responses. The etag is calculated using MD5 of the response body. If a request comes in that has a matching etag, the response will be changed to a 304 Not Modified and the response body will be set to an empty string. [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6158 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-17 18:16:44 +00:00
Rick Olson
e312cc3215 remove Mime::PLAIN from tests so its not confused with the default Mime::TEXT mime type 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6153 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-15 16:40:38 +00:00
Rick Olson
5d54b8f07c Add Mime::Type convenience methods to check the current mime type. [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6152 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-15 16:25:46 +00:00
Jeremy Kemper
eb2dad2fe5 Revert [6086] and [6087] since they caused a major regression with functional tests in 1.2.2. References #7372. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6145 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-10 03:55:12 +00:00
Thomas Fuchs
c9108f3e39 Add a :url_based_filename => true option to ActionController::Streaming::send_file, which allows URL-based filenames. [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6142 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-09 11:25:37 +00:00
David Heinemeier Hansson
06b1198736 Fix that FormTagHelper#submit_tag using :disable_with should trigger the onsubmit handler of its form if available [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6134 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-06 17:48:38 +00:00
Rick Olson
92195e68a0 Fix issue with deprecation messing up #template_root= usage. Add #prepend_view_path and #append_view_path to allow modification of a copy of the 
superclass' view_paths.  [Rick]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6125 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-04 22:27:45 +00:00
Rick Olson
69b0e5c44a Allow Controllers to have multiple view_paths instead of a single template_root. Closes #2754 [John Long] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6120 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-04 20:47:05 +00:00
David Heinemeier Hansson
8f614a80e7 Fix gem deprecation warnings, which also means depending on RubyGems 0.9.0+ [Chad Fowler] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6119 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-04 20:44:45 +00:00
Rick Olson
19fbb31464 Add much-needed html-scanner tests. Fixed CDATA parsing bug. [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6117 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-04 20:04:40 +00:00
Rick Olson
7a49cb058f fix form_for example in ActionController::Resources documentation. Closes #7362 [gnarg], Added enhanced docs to routing assertions. Closes #7359 [Rob Sanheim], improve error message for Routing for named routes. Closes #7346 [Rob Sanheim] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6113 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-02-04 19:07:08 +00:00
David Heinemeier Hansson
6b5238aade Added FormBuilder#submit as a delegate for FormTagHelper#submit_tag [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6089 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-29 20:42:46 +00:00
Jeremy Kemper
09c708981c TestSession supports indifferent access so session['foo'] == session[:foo] in your tests. Closes #7372. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6086 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-28 18:24:46 +00:00
Nicholas Seckar
2cc9c8135c Allow Routes to generate all urls for a set of options by specifying :generate_all => true. References #1739. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6082 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-28 17:29:51 +00:00
Nicholas Seckar
17a9405b58 Change the query parser to map empty GET params to "" rather than nil. Closes #5694. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6081 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-28 17:00:17 +00:00
Jeremy Kemper
d6d94c7377 date_select and datetime_select take a :default option. Closes #7052. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6080 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-28 16:44:44 +00:00
Jeremy Kemper
ad29870c21 select :multiple => true suffixes the attribute name with [] unless already suffixed. Closes #6977. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6078 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-28 16:17:55 +00:00
Jeremy Kemper
dad60e7801 mail_to :encode => 'hex' also encodes the mailto: part of the href attribute as well as the linked email when no name is given. Closes #2061. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6070 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-28 14:16:25 +00:00
Jeremy Kemper
799f556fe1 Resource member routes require :id, eliminating the ambiguous overlap with collection routes. Closes #7229. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6062 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-28 08:20:04 +00:00
Jeremy Kemper
0eacdcf9a3 Use a consistent load path to avoid double requires. Fix some scattered Ruby warnings. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6057 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-28 07:16:55 +00:00
Jeremy Kemper
4ac332fa9a Fix Test::Unit::TestCase#clean_backtrace 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6056 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-28 07:10:35 +00:00
Jeremy Kemper
dde527440a Remove deprecated assertions. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6055 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-28 07:00:43 +00:00
Nicholas Seckar
35ec1c928f Fix doubly appearing parameters due to string and symbol mixups. Closes #2551. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6053 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-28 05:29:32 +00:00
Michael Koziarski
768b60e60d Add error_messages and error_message_on to the default FormBuilder. Closes #6939 [nik.wakelin] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6040 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-26 03:38:23 +00:00
Jeremy Kemper
ef1d0c1259 Autolinking recognizes trailing and embedded . , : ; Closes #7354. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6034 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-24 18:42:03 +00:00
Jeremy Kemper
7fce529b2a Mocha 0.4 mixes in more public instance methods, confusing controller identification of action methods. Closes #7347. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6030 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-24 12:04:08 +00:00
Jeremy Kemper
f08bd27398 Pass busy timeout for sqlite3 integration tests. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6029 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-24 12:02:40 +00:00
Thomas Fuchs
8e82e29010 Make TextHelper::auto_link recognize URLs with colons in path correctly, fixes #7268 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6005 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-21 21:41:44 +00:00
Rick Olson
fcd73821c2 Modernize cookie testing code, and increase coverage (Heckle++) #7101 [Kevin Clark] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5977 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-17 06:51:59 +00:00
Rick Olson
d2205ea5e9 Improve Test Coverage for ActionController::Routing::Route#matches_controller_and_action? (Heckle++) #7115 [Kevin Clark] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5976 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-17 06:49:43 +00:00
Rick Olson
582c028b14 Heckling ActionController::Resources::Resource revealed that set_prefixes didn't break when :name_prefix was munged. #7081 [Kevin Clark] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5974 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-17 06:46:02 +00:00
Rick Olson
4733182e56 Fix #distance_of_time_in_words to report accurately against the Duration class. #7114 [eventualbuddha] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5973 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-17 06:28:57 +00:00
Jeremy Kemper
d38417fc02 RecordInvalid, RecordNotSaved => 422 Unprocessable Entity, StaleObjectError => 409 Conflict. References #7097. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5966 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-17 00:43:53 +00:00
Jamis Buck
b0a1aa7e7e Allow fields_for to be nested in form_for 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5965 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-17 00:04:02 +00:00
Tobias Lütke
64a80ef756 Allow inGroupsOf and eachSlice to be called through rjs. Closes #7046 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5942 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-15 15:11:29 +00:00
Jeremy Kemper
55efae2720 Allow exempt_from_layout :rhtml. References #6742, closes #7026. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5927 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-14 13:57:44 +00:00
Jeremy Kemper
a6e12c0c21 Wrap and skip tests using mocha. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5926 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-14 12:49:55 +00:00
Jeremy Kemper
ba814a9033 Use mocha for rescue tests. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5916 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-13 07:14:46 +00:00
Rick Olson
dd6826eba3 Recognize the .txt extension as Mime::TEXT [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5912 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-12 20:54:04 +00:00
Jeremy Kemper
88e02f6e56 Failing test for exempt_from_layout :rhtml. References #6742. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5909 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-12 10:31:24 +00:00
Jeremy Kemper
41198ad3ad Fix parsing of array[] CGI parameters so extra empty values aren't included. Closes #6252. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5904 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-12 09:10:58 +00:00
Jeremy Kemper
fa619b051b link_to_unless_current works with full URLs as well as paths. Closes #6891. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5896 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-12 07:02:38 +00:00
Jeremy Kemper
fe736a54f9 Set request.env['REQUEST_URI'] when absent. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5895 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-12 07:01:39 +00:00
Jeremy Kemper
89b472aa0c Test proving render_to_string result passed to partial works. Closes #2541. [smeade] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5893 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-12 06:10:06 +00:00