TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
53,482 Commits 2 Branches 0 Tags 294 MiB
7ec1289e70
Commit Graph

244 Commits

Author SHA1 Message Date
Vipul A M
c417311c4a No need to specify log level, run at log level as all other Rails components. 2014-10-20 12:36:44 +05:30
Yves Senn
74a527cc63 Merge pull request #17329 from vipulnsward/mention-perform-later-docs 
Mention `perform_now` in AJ base docs to specify how to immediately invoke a job [ci skip]
 2014-10-20 09:04:39 +02:00
Yves Senn
e62554607c docs, It's "Active Job" not "Active job". [ci skip] 2014-10-20 09:00:16 +02:00
Vipul A M
e16592e744 Mention perform_now in AJ base docs to specify how to immediately invoke a job. [ci skip] 2014-10-20 00:26:38 +05:30
Vipul A M
8660853770 - Removed unused variable warnings from ActiveJob Adapters 2014-10-19 23:17:22 +05:30
Vipul A M
16c04040f4 Enable emitting of warnings from ActiveJob tests. 2014-10-19 23:05:03 +05:30
Yves Senn
64e64c6f04 tests, move original_ var assignments outside of begin. 2014-10-10 08:55:17 +02:00
Blake Gentry
4a1dbba108 ActiveJob: allow blank queue names 
As discussed in #17195, Que uses blank queue names by default for
performance reasons. At the very least, ActiveJob should allow users to
choose "" as their queue name. This commit allows blank queue names, as
well as tests to make sure that nil queue names still use the default.
 2014-10-09 19:42:43 -07:00
Ari Pollak
1472e0cf2c Don't pass retry option to Sidekiq 
* This would override whatever default is configured in Sidekiq
  system-wide, and retry is true by default anyway.
 2014-10-08 13:41:38 -04:00
Rafael Mendonça França
ee9f86e2e3 Point to a specific version of guide to make the redirect work 2014-10-08 11:24:16 -03:00
yuuji.yaginuma
a1e925db70 update error message when InlineAdapter is used 2014-10-08 11:24:02 +09:00
Jean-Philippe Boily
76056c627c update queue_classic details 2014-10-06 11:58:45 -04:00
mo khan
bc6421c9ef Add documentation on Active Job. 
This adds documentation for the Active Job API. It includes
documentation on how to configure the queue_adapter, and how to create
new jobs. It adds links to the various other sections of the Active Job
documentation.
 2014-10-02 10:57:30 -06:00
Robin Dupret
1fac7b79f3 Follow up to #16613 
Since we want this flag to be enabled anytime we are running the tests
under JRuby, let's enable this at the Rakefile level so people get the
performance boost on their local checkout.

Moreover, we avoid having to update this particular line anytime the
option changes on the JRuby side.

The only drawback is that we have to define it in every Rakefile but
there's no big deal, this is already the case for other options.
 2014-09-28 12:04:06 +02:00
Robin Dupret
d63005447b Tiny follow-up to #16999 [ci skip] 
* Fix a typo
* Remove references to Rails version
* Remove an extra whitespace
 2014-09-27 16:22:15 +02:00
Matthew Draper
d7a058f785 Make AJ integration tests much less verbose 
In passing, avoid a blind retry in QC: instead, just fix the problem.
 2014-09-27 21:59:10 +09:30
Prathamesh Sonpatki
76ccbc2599 Fix some typos in ActiveJob 
[ci skip]
 2014-09-27 16:52:13 +05:30
yuuji.yaginuma
ab22946e51 [ci skip] fix typo in set examples 2014-09-27 15:07:24 +09:00
Rafael Mendonça França
4581d04477 Preparing for 4.2.0.beta2 release 2014-09-26 17:19:53 -03:00
Jeremy Kemper
3f1d04e3bb Fix string/gid collision in job arguments 
Serialize Global IDs as special objects, distinguishable from Strings
 2014-09-25 10:00:19 -07:00
Yves Senn
017294066f Merge pull request #17005 from y-yagi/fix_aj_test_helper 
add message to `assert` in `assert_enqueued_with`
 2014-09-23 10:44:44 +02:00
yuuji.yaginuma
39bef5823f add message to assert in assert_enqueued_with 2014-09-23 08:50:32 +09:00
Rafael Mendonça França
f4595e624b Merge pull request #16963 from collectiveidea/activejob-dj 
Cleaner queuing of jobs using Delayed Job

Conflicts:
	activejob/lib/active_job/queue_adapters/delayed_job_adapter.rb
 2014-09-22 14:33:29 -03:00
Cristian Bica
c9a4c2a5ce Added RDoc for each Active Job adapter 2014-09-22 17:33:02 +03:00
David Genord II
0b10565d96 Cleaner queuing of jobs using Delayed Job 2014-09-18 15:52:30 -04:00
Akshay Vishnoi
9fddcdd99e [ci skip] AJ docs fixes 
1. Indentation
2. Spaces issues
3. Spelling correction
4. Grammar correction
5. Add #:nodoc: to all internal classes
 2014-09-18 01:16:53 +05:30
Abdelkader Boudih
b820eb2027 simplify test_adapter 2014-09-14 22:11:52 +00:00
Jeremy Kemper
e3a65c6d7c Tighten up AJ::Arguments and its tests 
* Disallow deserialization of non-primitive objects
* Broaden coverage; remove superfluous tests
 2014-09-14 14:11:26 -07:00
Jeremy Kemper
01ac23423d Pare down and simplify Active Job's rake tasks 2014-09-14 14:01:16 -07:00
Rafael Mendonça França
6c0adddccf Se the test order of activejob tests 2014-09-12 14:33:09 -03:00
Rafael Mendonça França
a7dbfcf532 Change gid calls to to_gid 2014-09-12 14:33:09 -03:00
Abdelkader Boudih
ed9f71d11a Bump globalid version 2014-09-12 08:30:35 +00:00
Cristian Bica
175ba66664 ActiveJob Integration Tests 2014-09-11 00:38:56 +03:00
Yves Senn
ce43e8a6fc Merge pull request #16807 from tgxworld/carry_out_assignment_within_block 
Move variable assignment within logging block.
 2014-09-05 09:12:37 +02:00
Abdelkader Boudih
fbe116a248 correct rdoc [ci skip] 2014-09-05 06:35:19 +00:00
Guo Xiang Tan
3fe864f69d Move variable assignment within logging block. 2014-09-05 10:33:28 +08:00
David Heinemeier Hansson
4d8523c382 Merge pull request #16699 from cristianbica/aj-refactor-queueing 
Active Job partial refactor
 2014-09-04 18:50:28 -07:00
Matthew Draper
2198a9fc0d Fix a warning 2014-09-05 00:05:37 +09:30
Cristian Bica
15ddf60e05 Rename remaining :in / :at to :wait / :wait_until 2014-09-04 08:08:06 +03:00
Cristian Bica
1e237b4e44 Active Job refactoring 2014-09-03 23:01:46 +03:00
Cristian Bica
57d56aa933 [Active Job] Try to deserialize with GlobalID only strings and globalids 2014-09-03 15:06:10 +03:00
Cristian Bica
56f992fe15 Fix for double ActiveJob::DeserializationErorr 2014-09-03 14:23:47 +03:00
Abdelkader Boudih
a70bdfe6e3 Fix failing tests in ActiveJob Adapter 2014-09-02 20:27:32 +00:00
Rafael Mendonça França
2e500e5c93 Merge pull request #16724 from seuros/testcase 
[ActiveJob] TestCase
 2014-09-02 11:31:08 -03:00
Abdelkader Boudih
d7add5352e [ActiveJob] TestCase (Will squash before merge) 2014-09-02 14:26:43 +00:00
Cristian Bica
5255e4f39f ActiveJob: Implemented enqueue_at for QueueClassic 2014-09-02 14:35:53 +03:00
Abdelkader Boudih
fccf3d0b63 [ActiveJob] TestCase 2014-09-02 07:50:16 +00:00
Abdelkader Boudih
eb4245dd17 [ActiveJob] TestCase 2014-09-02 07:50:16 +00:00
Robin Dupret
84c0f73c8d Refer to the library name instead of the constant 
When we are loading a component and we want to know its version, we are
actually not speaking about the constant but the library itself.

[ci skip]

[Godfrey Chan & Xavier Noria]
 2014-08-30 11:58:23 +02:00
David Heinemeier Hansson
7475b43cdb Merge branch 'master' of github.com:rails/rails 2014-08-29 14:54:08 -07:00
Cristian Bica
02b63a5f9e Fixed Active Job Backburner adapter 2014-08-30 00:04:01 +03:00
Robin Dupret
1da209fa9b Avoid skipping Sidekiq tests on Rubinius 
Now that Travis provides support for Rubinius 2.2.10, we can run the
Sidekiq tests against this version.
 2014-08-29 12:43:24 +02:00
Robin Dupret
38d6c722b2 Some documentation fixes [ci skip] 2014-08-29 12:37:14 +02:00
Abdelkader Boudih
d56caea426 [ActiveJob] extract JobBuffer from helper 2014-08-29 08:50:09 +00:00
Abdelkader Boudih
7e99855dee [ActiveJob] Autoload adapters 2014-08-26 12:27:43 +00:00
Jeremy Kemper
5cdd02ddd4 Merge pull request #16681 from seuros/master 
[ActiveJob] Add activesupport as dependency [ci skip]
 2014-08-24 15:49:09 -07:00
Abdelkader Boudih
8fc99194ca [ActiveJob] Add activesupport as dependency [ci skip] 2014-08-24 22:16:48 +00:00
Robin Dupret
f3b8a0d375 Fix a few typos [ci skip] 2014-08-24 18:35:22 +02:00
Cristian Bica
23329d33d4 Raise ActiveJob::SerializationError when cannot serialize job arguments 2014-08-24 16:01:58 +03:00
Rafael Mendonça França
9cc74261d4 Merge pull request #16602 from thetron/active_job_que_enqueue_at_support 
Added enqueue_at support for QueAdapter in ActiveJob
 2014-08-22 17:11:31 -03:00
Abdelkader Boudih
e63a02ccfb [ActiveJob] Add hook for test_framework and test templates 2014-08-22 20:06:22 +00:00
Cristian Bica
e084d5bd7a Implemented enqueue_at for ActiveJob's Backburner adapter 2014-08-22 17:44:48 +03:00
Guo Xiang Tan
fb740239dc Pass logging message through block. 
This follows the good practice listed on http://guides.rubyonrails.org/debugging_rails_applications.html#impact-of-logs-on-performance
 2014-08-22 17:47:13 +08:00
Xavier Noria
a57f7b5797 ActiveJob -> Active Job [ci skip] 
See http://guides.rubyonrails.org/api_documentation_guidelines.html#wording
 2014-08-21 23:28:10 +02:00
Nicholas Bruning
9b319a53fa Added enqueue_at support for QueAdapter in ActiveJob 
* Added inline job runner for Que in test/support
* Updated QueAdapter to support enqueue_at
 2014-08-21 04:27:30 +00:00
Logan Hasson
d694ea259c [ci skip] Fix Active Job grammar in api docs 2014-08-20 15:36:58 -04:00
David Heinemeier Hansson
6a23bf0f4c Preparing for 4.2.0.beta1 release 2014-08-19 19:32:51 -07:00
Jeremy Kemper
9bea72b6fb Bump ActiveJob's GlobalID dep to 0.2.3+ to fix Railties tests 2014-08-19 12:45:04 -07:00
Peter Suschlik
01604c6ee5 Skip adapter queue_classic for JRuby 2014-08-19 15:40:45 +02:00
Yves Senn
1aa0550d40 use same idiom to define class method as in every other adapter. 2014-08-19 12:29:39 +02:00
Abdelkader Boudih
68c643f8e7 [ActiveJob] Add queue_name_prefix so all queue are prefixed . 
We can split queues on a per environement basis as well as seggregate per application so we can split queues on a per env basis

ActiveJob::Base.queue_name_prefix = 'foo'
 2014-08-18 20:04:02 +00:00
Akira Matsuda
6d92dcc7bd "warning: `*' interpreted as argument prefix" 2014-08-18 22:17:36 +09:00
Lucas Mazza
2f9179b4f4 Fix ActiveJob isolation tests. 2014-08-17 23:16:34 -03:00
Abdelkader Boudih
080296be61 [ActiveJob] require global_id/railtie 2014-08-17 23:17:38 +00:00
Cristian Bica
3faa61ede5 [ActiveJob] raise DeserializationError when got an error deserializing 2014-08-17 23:10:45 +00:00
Abdelkader Boudih
9a34262201 [ActiveJob] Add deserialize_arguments method to job 2014-08-17 23:10:45 +00:00
Abdelkader Boudih
931cfc4079 [ActiveJob] Fix tests for sucker_punch 2014-08-17 23:10:45 +00:00
Abdelkader Boudih
2f7b239fca [ActiveJob] Use globalid gem 2014-08-17 23:10:45 +00:00
Cristian Bica
59221cc4f1 [ActiveJob] make the resque-scheduler optional 2014-08-17 23:10:39 +00:00
Abdelkader Boudih
b06d91924f [ActiveJob] remove ruby warnings 2014-08-17 23:10:33 +00:00
Abdelkader Boudih
3954fdf5f3 [ActiveJob] Convert ActiveJob::Arguments into module 2014-08-17 23:10:28 +00:00
Abdelkader Boudih
fdc7dbc5b2 [ActiveJob] require files in logging.rb 2014-08-17 23:10:24 +00:00
Cristian Bica
b2cabb7ace Added docs for AJ::Callbacks; Added AJ to docs build map 2014-08-16 01:31:39 +03:00
Cristian Bica
788aee5acf Moved AR testing from using global variable to thread variable 2014-08-16 00:02:06 +03:00
Cristian Bica
c2f1eca194 Suggest the perform method can take arguments when generating an ActiveJob job 2014-08-15 23:35:06 +03:00
Cristian Bica
94ae25ecd5 ActiveJob: Reworked queue_base_name as default_queue_name + Allow configure ActiveJob from app.config.active_job 2014-08-15 23:32:08 +03:00
Abdelkader Boudih
8147e22a4d Update resque_adapter.rb 2014-08-14 22:54:56 +00:00
Abdelkader Boudih
9b209603d0 Clean adapter_test.rb and skip test for sidekiq in unsupported rubies 2014-08-13 13:55:08 +00:00
Abdelkader Boudih
67f8b6b2bc Added ActionMailer::DeliverLater 2014-08-13 11:36:32 +00:00
Cristian Bica
22ee993825 Modified activejob.gemspec to match other rails gems format 2014-08-12 16:04:24 +03:00
Cristian Bica
7c84dfb510 Update activejob's README 2014-08-12 15:43:43 +03:00
Cristian Bica
3ed69cd5f5 Fixed failing tests; Load active_job in railtie; Renamed generator to job 2014-08-12 13:53:46 +03:00
Abdelkader Boudih
0c232779ec Remove activejob integration tests 2014-08-12 10:07:21 +00:00
Abdelkader Boudih
a75f085941 Add 'activejob/' from commit '14f74a8331f94150dfee653224de8fc837797709' 
git-subtree-dir: activejob
git-subtree-mainline: b45b99894a60eda434abec94d133a1cfd8de2dda
git-subtree-split: 14f74a8331f94150dfee653224de8fc837797709
 2014-08-12 09:17:19 +00:00