Xavier Noria
ccd45618ed
Merge remote branch 'rails/master'
2010-07-30 02:35:24 +02:00
Xavier Noria
755af49755
edit pass to apply API guideline wrt the use of "# =>" in example code
2010-07-30 02:30:04 +02:00
Neeraj Singh
daad4454eb
itsy bitsy changes to ActionMailer documentation
2010-07-28 22:22:50 -04:00
David Heinemeier Hansson
856fc4bbc3
Prep for RC
2010-07-26 12:53:25 -05:00
Santiago Pastorino
e1d4e78b15
Removes unused vars
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-07-24 01:19:44 +02:00
José Valim
76b6136b00
Clean up AM and AC railties.
2010-07-24 00:48:12 +02:00
Jeroen van Dijk
ab62aa1c43
Mention that ActionMailer::Base.default_url_options is now deprecated
2010-07-22 01:28:31 +02:00
Benjamin Quorning
7e075e6247
Fixed many references to the old config/environment.rb and Rails::Initializer
2010-07-13 13:00:21 +02:00
Wincent Colaiuta
75b32a69a1
Fixes for "router" and "routes" terminology
...
Commit f7ba614c2db improved the internal consistency of the different
means of accessing routes, but it introduced some problems at the level
of code comments and user-visible strings.
This commit applies fixes on three levels:
Firstly, we remove or replace grammatically invalid constructs such as
"a routes" or "a particular routes".
Secondly, we make sure that we always use "the router DSL" or "the
router syntax", because this has always been the official terminology.
Finally, we make sure that we only use "routes" when referring to the
application-specific set of routes that are defined in the
"config/routes.rb" file, we use "router" when referring on a more
abstract level to "the code in Rails used to handle routing", and we use
"routing" when we need an adjective to apply to nouns such as
"url_helpers. Again this is consistent with historical practice and
other places in the documentation.
Note that this is not a sweep over the entire codebase to ensure
consistent usage of language; it is just a revision of the changes
introduced in commit f7ba614c2db.
Signed-off-by: Wincent Colaiuta <win@wincent.com>
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-07-03 22:42:31 +02:00
Piotr Sarnacki
f7ba614c2d
Unify routes naming by renaming router to routes
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-07-02 01:51:03 +02:00
Wincent Colaiuta
52c56f9f7e
docs: note that mail() accepts arbitrary headers
...
The documentation makes it sound like mail() only accepts a limited
set of headers in the headers hash, but it in fact accepts any
arbitrary headers, and there is a test ("can pass random headers in
as a hash to mail") for it in the test suite.
Signed-off-by: Wincent Colaiuta <win@wincent.com>
2010-06-30 17:07:19 +02:00
José Valim
6788db824a
Move Rails::LogSubscriber to ActiveSupport::LogSubscriber, allowing frameworks like ActiveRecord and ActiveResource to log outsude Rails::Application [ #4816 state:resolved]
2010-06-24 13:23:43 +02:00
Rizwan Reza
de65c82bfa
Changes call backs to callbacks.
2010-06-15 22:48:10 +04:30
Evgeniy Dolzhenko
ef404c771d
Fix a bunch of minor spelling mistakes
2010-06-15 12:04:22 +04:00
Xavier Noria
f17159b029
edit pass: the names of Rails components have a space, ie, "Active Record", not "ActiveRecord"
2010-06-14 23:22:04 +02:00
David Chelimsky
c125116013
docfix (email instead of emai)
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-06-13 22:10:45 +02:00
David Chelimsky
d588bbd431
Move ActionMailer::TC to AV::TC::Behavior
...
[#4843 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-06-12 15:34:31 +02:00
José Valim
30eaecb3df
subject is automatically looked up on I18n using mailer_name and action_name as scope as in t('.subject')
2010-06-12 15:33:12 +02:00
Evgeniy Dolzhenko
ccf9577aee
Fix a bunch of minor spelling mistakes
2010-06-11 14:15:34 +04:00
David Heinemeier Hansson
32d4330b81
Get ready for beta 4
2010-06-08 14:47:02 -04:00
Mikel Lindsaar
3762362eab
Updating readme for ActionMailer::Base
2010-06-07 23:14:54 -04:00
Mikel Lindsaar
311d99eef0
Adding inline attachment support to ActionMailer
2010-06-07 21:54:53 -04:00
David Heinemeier Hansson
08baa343c8
Extract assets paths and make them available to Action Mailer as well
2010-06-03 23:32:12 +10:00
Santiago Pastorino
52f905715e
Unforce text-format from AM
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-06-03 23:32:11 +10:00
Santiago Pastorino
fa5f93698d
Added missing require, we are using bind method defined on active_support/core_ext/proc
...
[#4610 state:committed]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-05-16 16:16:15 +02:00
wycats
458f5712dc
Remove the need for a special action_mailer.url_for initializer that loads before anything else
2010-05-15 06:09:07 -07:00
Mikel Lindsaar
058f7feafe
Cleaning up Action Mailer spelling with and without the space
2010-05-04 19:24:40 +02:00
Mikel Lindsaar
fb30feb48b
Adding more docs to ActionMailer
2010-05-04 19:24:40 +02:00
Justin George
731d4392e4
Change event namespace ordering to most-significant first [ #4504 state:resolved]
...
More work still needs to be done on some of these names
(render_template.action_view and render_template!.action_view particularly)
but this allows (for example) /^sql/ to subscribe to all
the various ORMs without further modification
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-05-02 22:45:54 +02:00
Mikel Lindsaar
ceaa100e59
Adding ability for the procs to be called within the instance, allows you to pass results from instance methods to the mail header
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-05-02 11:56:08 +02:00
Mikel Lindsaar
08b07b60b6
Adding ability to pass proc's to the ActionMailer class default method
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-05-02 11:56:08 +02:00
Nathan Weizenbaum
ef5dadaf93
Only run load hooks once a file has been fully loaded.
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2010-04-27 21:37:40 -07:00
Santiago Pastorino
66b55dbfea
Add missing require
2010-04-16 18:44:54 -03:00
José Valim
b4fd5e6f1a
template_name and template_path should not be added to mail headers.
2010-04-13 23:04:22 +02:00
José Valim
3fc609ee41
Fix ActionMailer test broken in 99d54599215c2a8cea7e57f609e8e578043d71b2
2010-04-12 10:50:27 +02:00
José Valim
b5f9a9fce3
Move set_fields! to the old API module.
2010-04-12 10:25:02 +02:00
Mikel Lindsaar
e157a3d222
Added explict setting of charset in set_fields! method to make sure Mail has the user defined default
2010-04-11 18:04:55 +10:00
Mikel Lindsaar
dbcf01e631
Removing quoting.rb, upgrade to 2.1.3.6, changing all utf-8 references to UTF-8, updating tests where incorrect encoding
2010-04-11 18:04:55 +10:00
Mikel Lindsaar
8f22be04dc
Removing quoting and adding Mail 2.3.5
2010-04-11 18:04:54 +10:00
José Valim
ee309d506c
Update versions (otherwise you install a gem from source as beta3 but internally it's beta2) and update CHANGELOG.
2010-04-10 12:17:34 +02:00
David Heinemeier Hansson
d868cb4f8a
Prep for beta2, depend on latest Bundler
2010-04-01 13:36:45 -07:00
wycats
4aded43b73
Replace the placeholder base_hook API with on_load. To specify some code that
...
should run during framework load do:
ActiveSupport.on_load(:action_controller) do
# Code run in the context of AC::Base
end
2010-03-29 17:08:50 -07:00
Xavier Noria
76f024ac8d
adds missing requires for Object#blank? and Object#present?
2010-03-28 14:15:02 +02:00
José Valim
a09e99259c
Ensure details are frozen after @details_keys lookup. The implementation waits to freeze until the last required moment, to avoid duping hashes.
2010-03-27 20:52:11 +01:00
José Valim
395d6648ce
Move application configuration to the application configuration object, remove railtie_name and engine_name and allow to set the configuration object.
2010-03-26 18:47:55 +01:00
José Valim
f28d856cec
Improve performance of the rendering stack by freezing formats as a sign that they shouldn't be further modified.
2010-03-19 17:20:20 +01:00
Jeremy Kemper
41af6d9a78
Use Array.wrap not Array()
2010-03-17 22:27:48 -07:00
wycats
cd9ffd11e1
Eliminate warnings for AM on 1.8
2010-03-16 23:24:00 -07:00
José Valim
2a12686832
Allow anything that responds to render to be given as :template and use find_template instead of find in views.
2010-03-12 14:25:10 +01:00
José Valim
00d6271d2b
Clean up the API required from ActionView::Template.
2010-03-09 13:12:11 +01:00