TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
38,028 Commits 2 Branches 0 Tags 294 MiB
8867e16a60
Commit Graph

38028 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
kennyj
bc5314a102 Raise ArgumentError to fix Rails 4.1 deprecation warn message. 2013-06-02 00:39:11 +09:00
kennyj
74f2b41ce0 Remove Mime::Type#verify_request? and Mime::Type.browser_generated_types were deprecated. 2013-06-02 00:07:58 +09:00
Rafael Mendonça França
6ff923a180 Merge pull request #10814 from kennyj/deprecations_4_1 
Remove some deprecation methods / options / files.
 2013-06-01 07:35:08 -07:00
kennyj
d3e8c149cb Remove ActionView::Template#mime_type was deprecated. 2013-06-01 23:22:12 +09:00
kennyj
5d75579eec Remove #sum with a block was deprecated. 2013-06-01 23:22:12 +09:00
kennyj
d8c6f52d3b Remove ActionController::RecordIdentifier was deprecated. 2013-06-01 23:22:12 +09:00
kennyj
dabb9d1c83 Remove action_controller/vendor/html-scanner.rb was deprecated. 2013-06-01 23:22:12 +09:00
kennyj
cb8348b56f Remove :confirm and :disable_with options from ActionView::Helpers::FormTagHelper were deprecated. 2013-06-01 23:22:01 +09:00
kennyj
825f4df23c Remove link_to_function / button_to_function from ActionView::Helpers::JavascriptHelper were deprecated. 2013-06-01 23:17:27 +09:00
kennyj
8b80d72327 Remove :confirm and :disable_with options for ActionView::Helpers::UrlHelper#link_to and #button_to were deprecated. 2013-06-01 23:17:16 +09:00
kennyj
6c2cbc6fff Remove active_support/testing/pending.rb was deprecated. 2013-06-01 21:23:19 +09:00
kennyj
f8f30c88ad Remove ActiveSupport::Benchmarkable#silence was deprecated. 2013-06-01 21:23:19 +09:00
kennyj
6f3e01e8b7 Remove active_support/json/variable was deprecated. 2013-06-01 21:23:19 +09:00
Xavier Noria
f2855f6ef1 revises the documentation of ActiveRecord::Relation#find_or_create_by [ci skip] 
* Inspect uses double quotes.

* Inspect puts a hash as in #<User ...>.

* Documents the return value, and makes explicit it can be an invalid record.

* Documents the method is not atomic.

* Documents a way to handle UNIQUE contraint violations in the event of a race condition.

* Removes the "Examples" header according to our guidelines.
 2013-06-01 10:23:08 +02:00
Brian Fontenot
0435d0ebcc Merge remote-tracking branch 'upstream/master' 
his merge is necessary,
 2013-06-01 00:39:15 -05:00
Brian Fontenot
6df9c595ad Add detailed steps on how to squash multiple commits into a single detailed commit 2013-06-01 00:27:24 -05:00
Graham Madden
b9822cc354 reword for grammar and clarity 2013-05-31 20:21:36 -04:00
wangjohn
7655fc0b6c Fixing a failing railtie test by using the ENV variable to specify a 
particular controller to search for in rake routes.
 2013-05-31 19:48:36 -04:00
Angelo capilleri
861ec91e8c add cache_if and cache_unless on caching doc 2013-05-31 17:59:06 +02:00
Xavier Noria
8ac8eb66c1 rewrites AR's reload documentation 
* It is no longer true that options are passed to find.

* Documents that ActiveRecord::RecordNotFound may be raised.

* Documents that the reload happens in-place.

* Documents that caches are wiped.

* Documents that the method returns self.

* Documents a couple of use cases.
 2013-05-31 13:02:40 +02:00
Steve Klabnik
8603bc06ad Add propery docs to ActionDispatch::Response [ci skip] 
After some discussion on Twitter with @skud, the documentation on ActionDispatch::Response is
a bit sparse. This class is useful when you're writing tests, as often you want to assert various
things about the response that's coming back. Better docs would make this easier for people new
to testing in Rails.

I only added some descriptions for various properties that were defined, and mostly just a sentence
or two. Most of these things are familliar if you're working with HTTP, but some words is better
than no words at all.

Hopefully further commits will fix up things that aren't just documentation.
 2013-05-30 20:34:53 -07:00
Rafael Mendonça França
e43a99e258 Merge pull request #10783 from wangjohn/rake_routes_additional_environment 
Adding the ability to filter routes by the verb
 2013-05-30 14:06:53 -07:00
Steve Klabnik
c71488b62e Merge pull request #10805 from pilaf/master 
Fix word order in documentation for with_lock [ci skip]
 2013-05-30 13:43:44 -07:00
Pedro Fayolle
1489e4f208 Fix word order in documentation for with_lock 2013-05-30 17:38:55 -03:00
Rafael Mendonça França
47f4d8d513 Merge pull request #10803 from gsamokovarov/extract-deep-munge 
Extract ActionDispatch::Request#deep_munge
 2013-05-30 12:21:17 -07:00
Steve Klabnik
87f3eb61c6 Merge pull request #10694 from steveklabnik/hsp_regression 
Fix regression in has_secure_password.
 2013-05-30 11:47:53 -07:00
Genadi Samokovarov
5438f6866e Extract ActionDispatch::Request#deep_munge 
ActionDispatch::Request#deep_munge was introduced as a private method,
but was turned into a public one for the use of
ActionDispatch::ParamsParser.

I have extracted it into ActionDispatch::Request::Utils, so it does not
get mixed up with the Request public methods.
 2013-05-30 21:26:37 +03:00
Phil Calvin
5d93ef8f45 Fix regression in has_secure_password. 
If the confirmation was blank, but the password wasn't, it would still save.
 2013-05-30 11:18:43 -07:00
RSL
48ac592bd9 Revert "change additional 'RESTful' routes to 'resourceful' routes as the additional actions may potentially get you farther away from RESTfulness" 
This reverts commit 382419d28fe8c43b88e39b83ac175973a36feca8.
 2013-05-30 12:43:40 -04:00
RSL
382419d28f change additional 'RESTful' routes to 'resourceful' routes as the additional actions may potentially get you farther away from RESTfulness 2013-05-30 12:17:40 -04:00
Rafael Mendonça França
6a6eae200d Merge pull request #10785 from senny/10782_routes_inspector_deals_with_controller_regexp 
`RoutesInspector` deals with routes using regexp as `:controller` option
 2013-05-30 08:38:17 -07:00
Yves Senn
88e8e951a2 RoutesInspector deals with routes using regexp as :controller option 2013-05-30 08:39:57 +02:00
wangjohn
42c9bd0617 Adding a test to make sure that using rake routes with the CONTROLLER 
environment works correctly.
 2013-05-29 17:30:06 -04:00
Kyle Fritz
6f30110cb4 correct no-replay@example.com to no-reply@example.com 2013-05-29 14:46:07 -03:00
Carlos Antonio da Silva
c2f3efffd9 Merge pull request #10767 from jmondo/master 
Use grep instead of select with === in QueryMethods
 2013-05-29 05:05:54 -07:00
Yves Senn
c44a929f49 Prevent side effects in Hash#with_indifferent_access. 2013-05-29 08:43:35 +02:00
John Gesimondo
c3ec0dbdd4 use grep over select for consistency and efficiency 
pass block directly to grep
 2013-05-28 22:15:55 -07:00
Rafael Mendonça França
e1b59a268b Merge pull request #10781 from arunagw/run-isolated-test 
Running isolated tests
 2013-05-28 11:19:22 -07:00
Arun Agrawal
5eaa30e47c Running isolated tests 
These stopped running don't know when. 
But these should be running now.
 2013-05-28 19:59:55 +02:00
Rafael Mendonça França
059e4fb594 Merge pull request #10766 from kylerippey/minor_schema_migration_refactor 
Minor refactor of ActiveRecord::SchemaMigration
 2013-05-28 09:30:54 -07:00
Rafael Mendonça França
6ecc360d88 Merge pull request #10495 from senny/postgres_test_cleanup 
PostgreSQL specific test cleanup
 2013-05-28 08:21:18 -07:00
Rafael Mendonça França
0397348a0f Merge branch 'fix-test_unit-railtie' 
This branch is composed of #10629 and #10708

Closes #10629
Closes #10708
Fixes #10628
 2013-05-28 12:13:21 -03:00
Rafael Mendonça França
04332e34d8 No need changelog entry 2013-05-28 12:12:20 -03:00
Oleg Sukhodolsky
82d8a1b9af condition simplified 2013-05-28 12:11:42 -03:00
Rafael Mendonça França
643e0b23d6 Merge pull request #10629 from stmpjmpr/bug_10628 
Fixes bug 10628.
 2013-05-28 12:11:29 -03:00
Rafael Mendonça França
e10262962b Merge pull request #10755 from lukewendling/master 
Add notice on server boot if binding to 0.0.0.0
 2013-05-28 07:39:48 -07:00
Sunny Ripert
91a1cf7013 Whitespace trimming in guides generation 2013-05-28 15:04:59 +02:00
Sunny Ripert
84675cae63 Consistent one-spaced bullets in guides release notes 2013-05-28 15:04:58 +02:00
Rafael Mendonça França
bf4f8211e1 Merge pull request #10775 from senny/postgres_adapter_test_cleanup 
test cleanup, replace `define_method` and `remove_method` with stubs.
 2013-05-28 05:39:28 -07:00
Sunny Ripert
2478b5e619 Remove references to deprecated test tasks 2013-05-28 14:38:02 +02:00