TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
71,352 Commits 2 Branches 0 Tags 294 MiB
8a23a0e8c2
Commit Graph

71352 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
David Heinemeier Hansson
d6621cc265 Use the correct route method 2018-12-14 09:19:21 -08:00
George Claghorn
51a148b552
Merge pull request #5 from kylekeesling/rails522-conductor-fix 
Development conductor ingress does not work with Rails 5.2.2
 2018-12-14 10:14:48 -05:00
Kyle Keesling
af72d95883
remove unimplemented arguement when adding mail message to ActiveStorage 
The indentify parameter is not yet implemented in Rails 5.2.2
 2018-12-14 09:21:59 -05:00
George Claghorn
a9653834ad
Merge pull request #4 from dixpac/dix/add_frozen_string_literals 
Add frozen_string_literal: true to match Rails codebase
 2018-12-14 08:48:21 -05:00
George Claghorn
36917b7eb6
Merge pull request #3 from frodsan/patch-1 
Fix typo [ci skip]
 2018-12-14 06:59:26 -05:00
Dino Maric
4412ca6dac Add frozen_string_literal: true to match Rails codebase 2018-12-14 11:06:12 +01:00
ujihisa
adb0c7bc51 http://localhost:3000/rails/info/properties shows more details for ease of bug reporting 
Hand-merging @ujihisa's ancient patch at https://lighthouseapp.com/projects/8994/tickets/3644
 2018-12-14 17:59:51 +09:00
Francesco Rodríguez
08ab646a49
Fix typo [ci skip] 2018-12-14 09:17:05 +01:00
Yuji Yaginuma
952cfbf149
Merge pull request #34702 from ysksn/test_deprecate_methods_without_alternate_method 
Test ActiveSupport::Deprecation.deprecate_methods
 2018-12-14 16:32:55 +09:00
Yosuke Kabuto
ccbdbca364 Test ActiveSupport::Deprecation.deprecate_methods 
There was no test without an alternate method name is given.
 2018-12-14 11:49:54 +09:00
George Claghorn
af7d237002
Merge pull request #2 from panckreous/patch-1 
fix minor typo
 2018-12-13 21:15:19 -05:00
Dan
b2dc442a30
fix minor typo 
https://www.merriam-webster.com/words-at-play/top-10-commonly-confused-words-vol-2
 2018-12-13 18:13:02 -08:00
Rafael Mendonça França
08e7b369bf
Do not show post install message on rails new 2018-12-13 20:14:19 -05:00
David Heinemeier Hansson
0327694405 Don't need to trip it up right away 2018-12-13 16:34:52 -08:00
David Heinemeier Hansson
2c17861470 Add installer 2018-12-13 16:34:02 -08:00
David Heinemeier Hansson
2746449085 Tidy up and example testing 2018-12-13 16:01:16 -08:00
David Heinemeier Hansson
e94864446a Simpler 2018-12-13 15:57:28 -08:00
George Claghorn
cbb2bdafd9 Document the ingress controllers 2018-12-13 10:05:53 -05:00
George Claghorn
7a2ff4ea09 Document ingress configuration 2018-12-13 07:41:50 -05:00
Ryuta Kamizono
f907b418ae Enable Layout/SpaceAfterSemicolon cop to avoid newly adding odd spacing 
Ref 59ff1ba30d (diff-38fb97fba84b1ef0f311c4110a597c44R35)
 2018-12-13 18:06:04 +09:00
yuuji.yaginuma
d0bb649cbf Use string for arguments in server test 
When actually execute from the command, the value of ARGV is passed to the
server. So they are String. So let's use the same type in the test.

Also, this removes the following warning in Ruby 2.6.

```
lib/rails/commands/server/server_command.rb:195: warning: deprecated Object#=~ is called on Integer; it always returns nil
```
 2018-12-13 16:15:58 +09:00
Ryuta Kamizono
1800300296
Merge pull request #34695 from shoy75/update-ruby-version-for-travis 
Update tested versions of Ruby on CI
 2018-12-13 13:22:11 +09:00
Ryuta Kamizono
144b57d925 Merge pull request #34693 from ahorek/match 
[perf] use #match?
 2018-12-13 13:20:14 +09:00
shoy75
f6a779c157 Update tested versions of Ruby on CI 2018-12-13 10:50:55 +09:00
David Heinemeier Hansson
f561912557 Need to explain testing too 2018-12-12 17:14:03 -08:00
David Heinemeier Hansson
c859cd256f Explain all test helpers 2018-12-12 17:13:35 -08:00
David Heinemeier Hansson
3e7ce697bf Stating the obvious 2018-12-12 17:13:26 -08:00
David Heinemeier Hansson
316ba4768b Routing documentation 2018-12-12 17:13:16 -08:00
David Heinemeier Hansson
0ef2fdb119 Consistent naming on all factory methods 2018-12-12 17:12:48 -08:00
David Heinemeier Hansson
6edccec1b9 Basic docs for most classes 2018-12-12 16:34:05 -08:00
David Heinemeier Hansson
1df26841b3 Note about incineration 2018-12-12 16:06:56 -08:00
David Heinemeier Hansson
de5e4d1936 Base note 2018-12-12 16:06:48 -08:00
David Heinemeier Hansson
68209ce069 Describe the conductor controller 2018-12-12 15:46:09 -08:00
David Heinemeier Hansson
19730e4891 George ended up doing a lot of the actual code 2018-12-12 15:42:03 -08:00
David Heinemeier Hansson
03166d4bd6 Basic description of the framework 2018-12-12 15:38:45 -08:00
pavel
01b0ccce32 use match? 2018-12-12 23:29:53 +01:00
Ryuta Kamizono
2c325182b8 Fix warning: shadowing outer local variable - attribute 2018-12-13 06:43:31 +09:00
Rafael França
3a3a3d607e
Merge pull request #32852 from gmcgibbon/fix_numericality_float_equality 
Fix numericality equality validation on floats
 2018-12-12 15:01:01 -05:00
Ryuta Kamizono
8fcaf3c26c Merge pull request #34691 from gmcgibbon/rm_helper_generator_suffix 
Remove redundant suffixes on generated helpers.
 2018-12-13 02:57:00 +09:00
Ryuta Kamizono
047d4f2605
Merge pull request #34690 from gmcgibbon/rm_integration_test_generator_suffix 
Remove redundant suffixes on generated integration tests.
 2018-12-13 02:48:06 +09:00
Gannon McGibbon
886ac1c308 Remove redundant suffixes on generated helpers. 2018-12-12 12:22:59 -05:00
Gannon McGibbon
9bf5545ef7 Remove redundant suffixes on generated integration tests. 2018-12-12 12:12:51 -05:00
Gannon McGibbon
d126c0d6c0 Fix numericality equality validation on floats 2018-12-12 12:02:12 -05:00
Rafael França
662f14814e
Merge pull request #34681 from gmcgibbon/fix_boolean_system_test_scaffold 
Fix boolean interaction in scaffold system tests
 2018-12-12 11:42:16 -05:00
Ryuta Kamizono
b0ac3694e6
Merge pull request #34689 from haruelico/beanstalkd 
kr/beanstalkd permanently moved to beanstalkd/beanstalkd
 2018-12-13 01:10:04 +09:00
Gannon McGibbon
ea89b4588b Fix boolean interaction in scaffold system tests 2018-12-12 10:56:25 -05:00
Harue Lico
f4a7144138 kr/beanstalkd permanently moved to beanstalkd/beanstalkd 
https://github.com/kr/beanstalkd has moved to
https://github.com/beanstalkd/beanstalkd as permanently.
 2018-12-13 00:32:12 +09:00
Kasper Timm Hansen
0fc6804c7e
Merge pull request #34686 from got2be/actioncable-channel-rescuable 
Add Missing ActiveSupport::Rescuable to ActionCable::Channel
 2018-12-12 15:30:44 +01:00
Ryuta Kamizono
7d83ef4f7b Ensure that preventing writes is invoked before materialize_transactions consistently 2018-12-12 23:14:26 +09:00
Ilia Kasianenko
87f407db3e Add Missing ActiveSupport::Rescuable to ActionCable::Channel 
[timthez, Ilia Kasianenko]
 2018-12-12 15:48:55 +02:00