To highlight ERB snippets, both `erb` and `html+erb` are used as a
language passed to the code block. However, only the former will be
correctly highlighted.
This could use in any translation because it's not limited to `[^a-z0-9]`.
Verify after this change, all guides still have same anchors.
[Robin Dupret & Juanito Fatas]
Resolve the following error when running `bundle exec rake guides:generate:html`:
```
/Users/senny/.rbenv/versions/2.0.0-p353/bin/ruby rails_guides.rb
Generating 2_2_release_notes.md as 2_2_release_notes.html
/Users/senny/Projects/rails/guides/rails_guides/helpers.rb:17:in `documents_by_section': uninitialized constant RailsGuides::Helpers::YAML (ActionView::Template::Error)
from /Users/senny/Projects/rails/guides/rails_guides/helpers.rb:32:in `docs_for_menu'
from /Users/senny/Projects/rails/guides/source/layout.html.erb:56:in `block in ___sers_senny__rojects_rails_guides_source_layout_html_erb___3094858039481335962_70118647133480'
from /Users/senny/Projects/rails/guides/source/layout.html.erb:54:in `each'
from /Users/senny/Projects/rails/guides/source/layout.html.erb:54:in `___sers_senny__rojects_rails_guides_source_layout_html_erb___3094858039481335962_70118647133480'
from /Users/senny/Projects/rails/actionview/lib/action_view/template.rb:143:in `block in render'
from /Users/senny/Projects/rails/activesupport/lib/active_support/notifications.rb:161:in `instrument'
from /Users/senny/Projects/rails/actionview/lib/action_view/template.rb:337:in `instrument'
from /Users/senny/Projects/rails/actionview/lib/action_view/template.rb:141:in `render'
from /Users/senny/Projects/rails/actionview/lib/action_view/renderer/template_renderer.rb:61:in `render_with_layout'
from /Users/senny/Projects/rails/actionview/lib/action_view/renderer/template_renderer.rb:47:in `render_template'
from /Users/senny/Projects/rails/actionview/lib/action_view/renderer/template_renderer.rb:17:in `render'
from /Users/senny/Projects/rails/actionview/lib/action_view/renderer/renderer.rb:42:in `render_template'
from /Users/senny/Projects/rails/actionview/lib/action_view/renderer/renderer.rb:23:in `render'
from /Users/senny/Projects/rails/actionview/lib/action_view/helpers/rendering_helper.rb:24:in `render'
from /Users/senny/Projects/rails/guides/rails_guides/markdown.rb:160:in `render_page'
from /Users/senny/Projects/rails/guides/rails_guides/markdown.rb:25:in `render'
from /Users/senny/Projects/rails/guides/rails_guides/generator.rb:205:in `block in generate_guide'
from /Users/senny/Projects/rails/guides/rails_guides/generator.rb:195:in `open'
from /Users/senny/Projects/rails/guides/rails_guides/generator.rb:195:in `generate_guide'
from /Users/senny/Projects/rails/guides/rails_guides/generator.rb:144:in `block in generate_guides'
from /Users/senny/Projects/rails/guides/rails_guides/generator.rb:142:in `each'
from /Users/senny/Projects/rails/guides/rails_guides/generator.rb:142:in `generate_guides'
from /Users/senny/Projects/rails/guides/rails_guides/generator.rb:97:in `generate'
from rails_guides.rb:63:in `<main>'
rake aborted!
Command failed with status (1): [/Users/senny/.rbenv/versions/2.0.0-p353/bi...]
/Users/senny/Projects/rails/guides/Rakefile:11:in `block (3 levels) in <top (required)>'
Tasks: TOP => guides:generate:html
(See full trace by running task with --trace)
```
Shelling out was there for authors convenience, but we are
rather going to have the tag or SHA1 always in RAILS_VERSION
and if the environment variable is blank, then just use
"local" as a reminder that you are just working locally.
The docs server has been updated to set the long SHA1 in
RAILS_VERSION when generating edge guides.
This reverts commit abf8de85519141496a6773310964ec03f6106f3f.
We should take a deeper look to those cases flat_map doesn't do deep
flattening.
irb(main):002:0> [[[1,3], [1,2]]].map{|i| i}.flatten
=> [1, 3, 1, 2]
irb(main):003:0> [[[1,3], [1,2]]].flat_map{|i| i}
=> [[1, 3], [1, 2]]
Selecting which key extensions to include in active_support/rails
made apparent the systematic usage of Object#in? in the code base.
After some discussion in
5ea6b0df9a
we decided to remove it and use plain Ruby, which seems enough
for this particular idiom.
In this commit the refactor has been made case by case. Sometimes
include? is the natural alternative, others a simple || is the
way you actually spell the condition in your head, others a case
statement seems more appropriate. I have chosen the one I liked
the most in each case.
As mentioned in http://redcloth.org/textile/writing-paragraph-text/#dashes
RedCloth converts double hyphens to emdashes. This causes problems in
the guides where options like --database, --full are rendered incorrectly.
This commit fixes it by customizing the emdash method in the
RedCloth::Formatters::HTML module to just return '--'. See their FAQ
http://redcloth.org/faq in the section 'How do I customize RedCloth?'
