TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
51,851 Commits 2 Branches 0 Tags 294 MiB
8bf60b02b8
Commit Graph

12213 Commits

Author SHA1 Message Date
Yves Senn
8bf60b02b8 Merge pull request #20659 from vngrs/strong_parameters_unpermitted_parameters_wrong_doc_fix 
Fix the documentation about ActionController::UnpermittedParameters [ci skip]
 2015-06-22 08:49:27 +02:00
Mehmet Emin İNAÇ
9f62180ab2 Fix the documentation about ActionController::UnpermittedParameters [ci skip] 2015-06-22 07:28:51 +03:00
Mehmet Emin İNAÇ
2489a27d4d Fix the documentation about ActionController::ParameterMissing [ci skip] 2015-06-22 05:02:09 +03:00
Arthur Neves
ffba8f79a2
Revert "Merge pull request #20584 from arthurnn/fix_url" 
This reverts commit 0b3397872582f2cf1bc6960960a6393f477c55e6, reversing
changes made to 56d52e3749180e6c1dcf7166adbad967470aa78b.

As pointed out on the PR, this will hide development mistakes too, which
is not ideal.
 2015-06-17 20:17:44 +02:00
Arthur Nogueira Neves
0b33978725 Merge pull request #20584 from arthurnn/fix_url 
Catch InvalidURIError on bad paths on redirect.
 2015-06-16 23:28:51 +02:00
Arthur Neves
e23b314945
Catch InvalidURIError on bad paths on redirect. 
Handle URI::InvalidURIError errors on the redirect route method, so it
wont raise a 500 if a bad path is given.
 2015-06-16 23:27:49 +02:00
Mehmet Emin İNAÇ
336c196351 Fix the comment about attr_reader of headers [ci skip] 2015-06-16 23:53:57 +03:00
Aaron Patterson
50176b59fa remove header= on the response object. 
People should be free to mutate the header object, but not to set a new
header object.  That header object may be specific to the webserver, and
we need to hide it's internals.
 2015-06-15 17:54:08 -07:00
Aaron Patterson
dd8c76d9b9 set the default charset in response initialize 
this way we don't have to mutate the instance (as much) when writing a
rack response
 2015-06-15 16:09:44 -07:00
Mehmet Emin İNAÇ
cf81a3bae0 Deprecate passing hash as first parameter into ActionController::Head 2015-06-15 23:53:45 +03:00
Kasper Timm Hansen
374b163999 Fix flakyness. 
Brought on by my own stupidity :)
 2015-06-15 22:04:43 +02:00
Robin Dupret
a023d5391e A few documentation edits [ci skip] 2015-06-15 18:16:40 +02:00
Yves Senn
863fcfa79a quick pass over changelogs. [ci skip] 2015-06-15 09:33:27 +02:00
Guillermo Iguaran
db62081235 Merge pull request #20559 from mtsmfm/fix-header-modification-by-ssl 
ActionDispatch::SSL should keep original header's behavior
 2015-06-14 15:10:30 -05:00
Kasper Timm Hansen
9e9cae7b37 Merge pull request #20558 from prathamesh-sonpatki/missing-header-word 
Add missing "header" word in documentation of Token#authentication_request [ci skip]
 2015-06-14 17:32:25 +02:00
Fumiaki MATSUSHIMA
bb0186cf55 ActionDispatch::SSL should keep original header's behavior 
`ActionDispatch::SSL` changes headers to `Hash`.
So some headers will be broken if there are some middlewares
on ActionDispatch::SSL and if it uses `Rack::Utils::HeaderHash`.
 2015-06-14 23:20:04 +09:00
Prathamesh Sonpatki
fe117ce776 Add missing "header" word in documentation of Token#authentication_request [ci skip] 2015-06-14 18:57:27 +05:30
Aaron Patterson
3692ca5ce7 don't hold a reference to env in the options object 
I want to decouple Rails from the rack ENV as much as possible.  We
should try to keep as few references to the env as possible
 2015-06-13 14:12:44 -07:00
Grey Baker
0a9b86b0c0 Handle param-parsing errors from Rack in ExceptionWrapper 2015-06-12 23:44:20 +01:00
Yves Senn
1d43458c14 Merge pull request #20480 from senny/test_runner 
use our own runner for Rails framework components `bin/test`
 2015-06-12 17:19:47 +02:00
Victor Costan
eb8042494f Update RDoc for ActionController::TestCase for kwargs. 2015-06-12 00:03:49 -04:00
Sean Griffin
e2dfa54db8 Merge pull request #20522 from colby-swandale/doc-update 
fixed sring to be string in ActiveRecord::Base params documentation [ci skip]
 2015-06-11 17:09:37 -06:00
Colby Swandale
5a1bbb2ea7 fixed sring to be string in ActiveRecord::Base params documentation 2015-06-12 06:49:26 +10:00
Santiago Pastorino
1fd42f3338 Mention that doing nothing in Rails API controllers returns 204 2015-06-11 16:54:17 -03:00
Jorge Bejar
6c16577311 Return 204 if render is not called in API controllers 2015-06-11 16:54:17 -03:00
Jorge Bejar
8d3e6e5f4d Add test coverage for implicit render in empty actions 2015-06-11 16:54:16 -03:00
Jorge Bejar
a2c9a73084 Include ParamsWrapper in AC::API 
ParamsWrapper was initially removed from API controllers according to
the following discusision:
https://github.com/rails-api/rails-api/issues/33

However, we're including it again so Rails API devs can decide
whether to enable or disable it.
 2015-06-11 16:54:16 -03:00
Santiago Pastorino
f3df21649a Add CHANGELOG entries for API apps functionality 2015-06-11 16:54:15 -03:00
Santiago Pastorino
7db63f3d35 Fix MimeResponds example in AC::API documentation 2015-06-11 16:54:14 -03:00
Jorge Bejar
11c71b207e Revert changes related with api apps in RouteWrapper 
See the following commit to have context about this change:
757a2bc3e3
 2015-06-11 16:54:14 -03:00
Jorge Bejar
08cfe34174 Rename test methods in api conditional get controller tests 2015-06-11 16:54:14 -03:00
Jorge Bejar
2487bfb39a Do not say that Api Controllers are faster than regular ones in docs 2015-06-11 16:54:14 -03:00
Jorge Bejar
fd2508522c Remove Compatibility module since we don't remember why it was added 😄 2015-06-11 16:54:14 -03:00
Jorge Bejar
674dab30bc Routes resources avoid :new and :edit endpoints if api_only is enabled 2015-06-11 16:54:14 -03:00
Santiago Pastorino
099055de66 Remove extra whitespaces 2015-06-11 16:54:13 -03:00
Santiago Pastorino
440b334cbb Use new hash syntax 2015-06-11 16:54:13 -03:00
Santiago Pastorino
b643d7a7c6 Refactor internal? to query internal_controller? and internal_asset? methods 2015-06-11 16:54:13 -03:00
Santiago Pastorino
e7b89f1081 Remove Unneeded ApiPublicExceptions middleware, PublicExceptions already does the work 2015-06-11 16:54:13 -03:00
Santiago Pastorino
38818c93a9 Remove api_rendering is not needed 2015-06-11 16:54:13 -03:00
Santiago Pastorino
4204778f8d Adhere to Rails convention for private indentation 2015-06-11 16:54:13 -03:00
Santiago Pastorino
4c1b437ed7 Use nex hash syntax on tests 2015-06-11 16:54:13 -03:00
Santiago Pastorino
3adb5eac3b Add ApiPublicException middleware 2015-06-11 16:54:10 -03:00
Santiago Pastorino
2d86b6d9ae Move Model test class inside RenderersApiController namespace 2015-06-11 16:54:09 -03:00
Santiago Pastorino
032778eefb Add ActionController API functionality 2015-06-11 16:54:09 -03:00
Zachary Scott
ed7d787e12 Merge pull request #20519 from colby-swandale/doc-update 
better clarity of params source in ActionController::Base documentation
 2015-06-11 13:23:15 -04:00
Yves Senn
9946788775 select the AR adapter through bin/test. 2015-06-11 14:24:56 +02:00
Yves Senn
54d84cbb77 use our runner (bin/test) for framework components. 
This adds a script `bin/test` to most Rails framework components. The
script uses the rails minitest plugin to augment the runner.
See https://github.com/rails/rails/pull/19571 for details about the
plugin.

I did not yet add `bin/test` for activerecord, activejob and railties.
These components rely on specific setup performed in the rake-tasks.
 2015-06-11 14:12:15 +02:00
Yuki Nishijima
a888c3cdc9 Change the index arg of ActionDispatch::Static#new to a kwarg 2015-06-11 04:34:11 -07:00
Colby Swandale
dc11b274a6 better clarity of params source in ActionController::Base documentation [ci skip] 2015-06-11 21:29:19 +10:00
Aaron Patterson
bbbe1a58e6 remove unused code 2015-06-08 17:33:45 -07:00