TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
15,672 Commits 2 Branches 0 Tags 294 MiB
8d99ec9a4d
Commit Graph

2987 Commits

Author SHA1 Message Date
Emilio Tagua
8d99ec9a4d Named scopes shouldn't test equality using to_a if it's not an Array, this was causing records to be loaded before they were needed. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-03-30 15:36:18 +02:00
wycats
4aded43b73 Replace the placeholder base_hook API with on_load. To specify some code that 
should run during framework load do:

ActiveSupport.on_load(:action_controller) do
  # Code run in the context of AC::Base
end
 2010-03-29 17:08:50 -07:00
José Valim
56bed512f9 Fix dom_id for ActiveRecord [#4296 state:resolved] 2010-03-30 01:32:26 +02:00
Ernie Miller
63026541b2 Fix honoring :primary_key option when joining or eager loading a belongs_to association 
[#765 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-29 15:24:27 -07:00
Emilio Tagua
7006aa1a85 Arel now handles ranges with excluded end. 2010-03-29 12:30:13 -03:00
Emilio Tagua
53ddbfc460 Warn scoped order and limit are ignored. [#4123 state:resolved] 2010-03-29 11:30:06 -03:00
wycats
5f7bc47303 Rename modularized_table_name_prefix to full_table_name_prefix [#4032 state:resolved] 2010-03-28 23:45:38 -07:00
Andrew White
67d1cec4c8 Add the ability to specify table_name_prefix on individual modules 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-28 23:43:28 -07:00
Aaron Patterson
98d2d8ce2c use the database to lower case strings rather than ruby. [#4293 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-28 22:16:34 -07:00
David Heinemeier Hansson
a4eab8f1f3 Update example of default_scope to use the new arel finder syntax 2010-03-28 19:11:06 -07:00
Eugene Pimenov
fc6746fc3f PostgreSQL adapter: escape_bytea, quote_string and unescape_bytea aren't thread-safe in Ruby 1.8 [#3237 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-28 18:04:46 -07:00
Matthew Rudy Jacobs
b0967cc5cf defining a named_scope which overwrites an existing method is now allowed we just log a warning. 
This was motivated by the fact that :open is defined on all classes
as such the named_scope "open" can never be used, without hacking
ActiveRecord with an "undef_method" [#4083 state:resolved]

Signed-off-by: wycats <wycats@gmail.com>
 2010-03-28 13:53:20 -07:00
Rizwan Reza
f1e5a9ff98 Add :dependent = to has_one and has_many [#3075 state:resolved] 2010-03-28 18:47:46 +04:30
Xavier Noria
76f024ac8d adds missing requires for Object#blank? and Object#present? 2010-03-28 14:15:02 +02:00
Xavier Noria
105f9b8154 adds missing requires for Object#duplicable? 2010-03-28 13:26:13 +02:00
Rizwan Reza
66d57d7ba8 Oops, a docfix. 2010-03-28 11:10:35 +04:30
Rizwan Reza
6c2a0675f1 When creating database with rake, create schemas in schema_search_path if it doesn't exist. 2010-03-28 11:01:15 +04:30
José Valim
ff522cf4bc Revert "primary_key now supports :limit for MySQL". Break Sam Ruby app. 
To reproduce, start a new application, create a scaffold and run test suite. [#876 state:open]

This reverts commit faeca694b3d4afebf6b623b493e86731e773c462.
 2010-03-27 14:39:43 +01:00
Rizwan Reza
faeca694b3 primary_key now supports :limit for MySQL 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-27 03:49:53 -07:00
José Valim
0cb3311d06 Revert "primary_key now supports :limit. [#876 state:resolved]" since it broke AR test suite. 
This reverts commit 41e5c7ed44fedb95636ef9b7a792c46ea03309bd.
 2010-03-27 11:05:37 +01:00
Aaron Patterson
3172db12e4 avoiding a few closure references by evaling. [#4223 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-27 01:41:44 -07:00
Rizwan Reza
41e5c7ed44 primary_key now supports :limit. [#876 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-27 01:33:42 -07:00
Pratik Naik
68ade93cde Revert "Changed behavior of touch and added touch! Originally implemented by Obie Fernandez, updated touch! to act as a thin wrapper to touch. [#2520 state:resolved]" 
This reverts commit 3a875e618487a06a56f6cf912cf5440f294921cc.
 2010-03-27 08:22:32 +00:00
Nathaniel Bibler
3a875e6184 Changed behavior of touch and added touch! Originally implemented by Obie Fernandez, updated touch! to act as a thin wrapper to touch. [#2520 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-27 00:35:39 -07:00
Kris Selden
afb786ad8a In PostgreSQLAdapter, switch tables query to use current_schemas function [#918 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-26 17:18:33 -07:00
wycats
197904341f Merge branch 'master' into docrails 2010-03-26 15:10:24 -07:00
José Valim
395d6648ce Move application configuration to the application configuration object, remove railtie_name and engine_name and allow to set the configuration object. 2010-03-26 18:47:55 +01:00
Rizwan Reza
5176b28852 Better MySQL Error message. [#3775 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-03-26 13:25:53 +01:00
chrisfinne
76d2c455c0 Add debugging documentation for _callback_chain to ActiveRecord::Callback 
Signed-off-by: Rizwan Reza <rizwanreza@gmail.com>
 2010-03-26 14:01:21 +04:30
Jeremy Roman
ffb22bd2be fix habtm documentation to correct typo 
Signed-off-by: Rizwan Reza <rizwanreza@gmail.com>
 2010-03-26 13:35:56 +04:30
Emilio Tagua
d06a754fdd Remove unused attributes_with_quotes method. 2010-03-25 15:47:16 -03:00
Emilio Tagua
fc2e25734a Move methods from association to relation finder methods. 2010-03-25 15:47:06 -03:00
Emilio Tagua
90a4709601 Refactor relation merging to create just one relation and then assign values, instead of creating multiple relation objects. 2010-03-25 13:03:30 -03:00
Emilio Tagua
e3a2fae05d Add add_limit_offset! to adapters. 2010-03-25 12:37:38 -03:00
Aaron Patterson
ed21f0c502 expand migration paths before requiring them. [#4240 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-23 18:22:46 -07:00
Sebastian Martinez
10825be40b rake tasks should use the new app generator path [#4257 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-03-23 14:26:27 +01:00
José Valim
b61f6f5980 Load generators from both lib/rails/generators and lib/generators. Using the former since it's less obstrusive. 2010-03-23 13:40:41 +01:00
Emilio Tagua
d289e15af9 From and lock should be defined to be consistent with other ivars. Limit and offset are always defined, no need to test that. 
[#4253 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-22 11:48:39 -07:00
Aaron Patterson
541194f641 switching migrations to use require cleans up many warnings [#4234 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-19 09:56:22 -07:00
Aaron Patterson
587f468282 kill where / having method redefine warnings. [#4225 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-18 13:30:59 -07:00
Aaron Patterson
3911a7c197 squelching more warnings in the AR tests. [#4218 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-18 10:24:16 -07:00
Aaron Patterson
b652aa8121 cleaning up a bunch of method already defined warnings [#4209 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-17 13:56:33 -07:00
Jeremy Kemper
067b350301 Move require closer to home 2010-03-17 10:11:38 -07:00
Aaron Patterson
843255a763 fixing activerecord tests [#4205 state:resolved] 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-17 10:09:14 -07:00
Aaron Patterson
df735cf5b7 fisting uninitialized ivar warnings. [#4198 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-16 15:11:00 -07:00
Aaron Patterson
8c3e46c093 clean up more warnings, remove unnecessary methods, fix eval line numbers. [#4193 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-16 11:48:34 -07:00
Aaron Patterson
5de3698e2b cleaning up many more warnings in activerecord [#4180 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-15 08:57:41 -07:00
Aaron Patterson
95bd56e3cc speeding up clone_attributes, changing readonly to be initialized in def initialize 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-14 17:29:25 -06:00
Aaron Patterson
115230e619 cleaning up some test warnings 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-14 17:28:27 -06:00
Xavier Noria
fe43bbd8c7 keep AssociationProxy#to_a to avoid warning in Array(post.author), and delegate it to @target in association collections 
[#4165 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-12 11:53:22 -08:00