TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
21,237 Commits 2 Branches 0 Tags 294 MiB
8e73e589a8
Commit Graph

2867 Commits

Author SHA1 Message Date
Xavier Noria
ebe4fa5fbe move the conditional definition of Float#round down 
Rails 3 cherry-picks as little as possible from Active Support. In particular
the framework requires the files where extensions are exactly defined, rather
than convenience entry points like float.rb and friends. Because of that, it
is better to define conditionally rather than require conditionally.
 2011-03-09 18:51:54 +01:00
Andrei Kulakov
532b77077f Use Rubys own Float#round method in versions 1.9 and above 2011-03-10 01:30:51 +08:00
Aaron Pfeifer
9798ee2619 Add better test scenario for around callback return results 2011-03-08 15:01:06 +08:00
Aaron Pfeifer
df615f127e Allow access to a callback event's return result from around callbacks 2011-03-08 15:01:05 +08:00
Aaron Patterson
1408b942d9 removing stubs. 1.9.3 implements Date.today in C so mocking the return value of Time.now does nothing 2011-03-07 15:44:39 -08:00
Aaron Patterson
33f222b9e1 fixing some tests on ruby 1.9.3 2011-03-07 14:01:51 -08:00
Xavier Noria
a0d7247d15 reorganizes the RDoc of Hash#to_param 2011-03-07 22:20:24 +01:00
Xavier Noria
89ecc0a5dc Merge branch 'master' of git://github.com/lifo/docrails 2011-03-07 22:11:47 +01:00
Aaron Patterson
5968d7a658 do not test explicit equality of predicate methods, they should be allowed to return truthy or falsey objects 2011-03-07 09:36:07 -08:00
Aaron Patterson
a032212e7c refactor calls to to_param in expand_key method 2011-03-07 09:33:19 -08:00
Aaron Patterson
9cee693213 Merge branch 'master' of github.com:rails/rails 
* 'master' of github.com:rails/rails: (44 commits)
  Fixed indentation in actionmailer base_test [#6538 state:committed]
  remove unused assigned variable
  removes merge conflicts
  removes Examples headers introduced in 9b96de6
  Revert "Fixed identation in actionmailer base_test"
  Report the correct value of nil.id in the exception message as different ruby implementations may have different values, for example Rubinius returns 53 for nil.id.
  Improve testing of cookies in functional tests: - cookies can be set using string or symbol keys - cookies are preserved across calls to get, post, etc. - cookie names and values are escaped - cookies can be cleared using @request.cookies.clear
  more style changes
  Some style changes
  style changes
  Revert "style changes"
  Raise ArgumentError if route name is invalid [#6517 state:resolved]
  style changes
  Allow model to be inherited from Hash [#6487 state:resolved]
  styles applied for usage
  added failing test for fields_for with a record object that inherits from Hash
  Fixed identation in actionmailer base_test
  wrong SQL statement
  commas to set off expressions that interrupt sentence flow
  typo changes
  ...
 2011-03-07 08:50:50 -08:00
Dalibor Nasevic
55d2a211d3 Improved docs for Hash#to_param method 2011-03-06 23:54:18 +01:00
Akira Matsuda
071ddb8281 more "SSL everywhere" for GitHub URLs 
see: https://github.com/blog/738-sidejack-prevention-phase-2-ssl-everywhere
 2011-03-07 06:18:32 +09:00
Akira Matsuda
5bed37779a "SSL everywhere" for GitHub URLs 
see: https://github.com/blog/738-sidejack-prevention-phase-2-ssl-everywhere
 2011-03-07 05:56:02 +09:00
Xavier Noria
3a621e7be4 removes merge conflicts 2011-03-06 20:34:56 +01:00
Xavier Noria
89d825d021 Merge branch 'master' of git://github.com/lifo/docrails 2011-03-06 17:52:30 +01:00
Xavier Noria
6ce844a3c1 removes Examples headers introduced in 9b96de6 
Example headers are discouraged in the API guidelines.
Code just flows with the text. They may be good in
places where there's a lot of stuff and structure may
add clarity
 2011-03-06 17:49:39 +01:00
Andrew White
5e7ce47fb9 Report the correct value of nil.id in the exception message 
as different ruby implementations may have different values,
for example Rubinius returns 53 for nil.id.

[#6444 state:resolved]
 2011-03-06 15:23:31 +00:00
suchasurge
b99fb66fb7 more style changes 2011-03-06 10:44:52 +01:00
suchasurge
9b96de6f3d Some style changes 2011-03-06 10:26:24 +01:00
Aaron Patterson
09d3e89cf0 use sort_by instead of sort() 2011-03-05 20:01:06 -08:00
Xavier Noria
9092052cb0 merges rails 2011-03-05 12:06:43 +01:00
Xavier Noria
2076817629 revises the RDoc of Hash#reverse_merge 2011-03-05 11:57:32 +01:00
Xavier Noria
5f99a899a8 copy-edits 108561f 2011-03-05 11:57:32 +01:00
R.T. Lechow
273700cbd0 Active Support typos. 2011-03-05 11:56:34 +01:00
Jonathon D. Jones
3eca9d5b43 Adds link to Object.blank? from Object.present? 2011-03-05 11:56:33 +01:00
Ben Orenstein
67af97c4c1 Fix incorrect example. 2011-03-05 11:56:32 +01:00
Ben Orenstein
ea6a2b7c11 Fix incorrect word. 2011-03-05 11:56:32 +01:00
Ben Orenstein
f305c60816 Clarify comment by removing french reference ('a la'). Should improve readability for non-native english speakers. 2011-03-05 11:56:31 +01:00
Ben Orenstein
ac4c5e9722 Example descriptions and their examples were flipped. Fix. 2011-03-05 11:56:31 +01:00
Ben Orenstein
4c27ad0c23 Correct example that did not do what it claimed. Rework explanation. 2011-03-05 11:56:30 +01:00
Diego Carrion
1f47061b48 reverted tests deleted by 080345baca1076a9788d, refactored implementations should not invalidate the validations 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-03-04 18:07:48 -02:00
Diego Carrion
7872cc992b refactored Time#<=> and DateTime#<=> by removing unnecessary calls without losing performance 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-03-04 16:50:24 -02:00
R.T. Lechow
80e3beb24b Active Support typos. 2011-03-04 01:01:42 -05:00
Jonathon D. Jones
108561f1cb Adds link to Object.blank? from Object.present? 2011-03-03 18:10:33 -05:00
Aaron Patterson
dc89e29f49 remove to_s implementation so that inspect is helpful 2011-03-02 15:17:13 -08:00
Aaron Patterson
b247c8d71a * LocalCache strategy is now a real middleware class, not an anonymous class 
posing for pictures.
 2011-03-02 14:05:06 -08:00
Aaron Patterson
272ede9b9a require deprecation so that we can deprecate methods! 2011-03-02 10:42:43 -08:00
Aaron Patterson
72405efe64 anonymous classes have blank names on ruby 1.8 2011-03-02 10:23:04 -08:00
Aaron Patterson
69e348013b adding deprecation noticies to deprecated class cache methods 2011-03-02 09:31:40 -08:00
Aaron Patterson
66245441d4 adding backwards compat for class cache references. <3<3 2011-03-02 09:18:05 -08:00
Aaron Patterson
f345e2380c yo dawg, directly use the class cache rather than the cache of the cache 2011-03-01 17:43:45 -08:00
Aaron Patterson
7b6bfe84f3 refactor Reference to a ClassCache object, fix lazy lookup in Middleware so that anonymous classes are supported 2011-03-01 17:20:35 -08:00
Aaron Patterson
e477fc1147 fixing test case test on 1.9.3dev 2011-03-01 10:14:09 -08:00
Sam Elliott
9cf3b1f671 Remove warnings about redefined test methods 
[#6490 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-03-01 12:39:04 -02:00
Josh Kalderimis
0f8d2794f2 updated Time, Date and DateTime current methods in AS to use Time.zone and not Time.zone_default. 
[#6410 state:committed]
 2011-02-28 14:05:49 -08:00
Ben Orenstein
726599df98 Remove redundant to_sym call. 
[#6483 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-02-28 16:43:12 -02:00
Oriol Gual and Josep M. Bach
f42562f97b Make ActiveSupport::Configurable work with modules 
[#6486 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-02-28 13:30:32 -02:00
Ben Orenstein
b95f8be594 Fix incorrect example. 2011-02-27 20:22:55 -05:00
Ben Orenstein
9bbbae06c5 Fix incorrect word. 2011-02-27 18:17:06 -05:00