Commit Graph

7 Commits

Author SHA1 Message Date
Rolf Timmermans
d89a7967b5 Revert "Revert "It should be possible to use ActiveSupport::DescendantTracker without getting ActiveSupport::Dependencies for free.""
This reverts commit 9f5b1e1ed08df9dbedded0a6b7798d919d43b9a6.

Tests have been refactored so they pass in isolation.
2011-03-13 17:08:33 +01:00
José Valim
9f5b1e1ed0 Revert "It should be possible to use ActiveSupport::DescendantTracker without getting ActiveSupport::Dependencies for free."
This reverts commit 46f6a2e3889bae420589f429b09722a37dbdf18d.

Caused failures on CI. rake test:isolated on activesupport directory show them.
2011-03-13 08:35:50 +01:00
Rolf Timmermans
46f6a2e388 It should be possible to use ActiveSupport::DescendantTracker without getting ActiveSupport::Dependencies for free. 2011-03-13 01:33:10 +08:00
Santiago Pastorino
21c4b0942f Don't shadow outer local variables 2010-07-22 15:48:52 -03:00
José Valim
a5dda97602 Define a convention for descendants and subclasses.
The former should be symmetric with ancestors and include all children. However, it should not include self since ancestors + descendants should not have duplicated. The latter is symmetric to superclass in the sense it only includes direct children.

By adopting a convention, we expect to have less conflict with other frameworks, as Datamapper. For this moment, to ensure ActiveModel::Validations can be used with Datamapper, we should always call ActiveSupport::DescendantsTracker.descendants(self) internally instead of self.descendants avoiding conflicts.
2010-07-05 13:01:27 +02:00
José Valim
d430db9fd4 Remove descendants warning while executing tests. 2010-06-19 17:16:11 +02:00
José Valim
8db8c6f4ce Add ActiveSupport::DescendantsTracker. 2010-06-19 16:44:35 +02:00