TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
59,494 Commits 2 Branches 0 Tags 294 MiB
951353e476
Commit Graph

11389 Commits

Author SHA1 Message Date
jpd800
cb66f19a32 Allow download of email attachments in the Mailer Preview template. 2016-09-02 15:25:37 -05:00
Xavier Noria
bb1ecdcc67 fixes remaining RuboCop issues [Vipul A M, Xavier Noria] 2016-09-01 23:41:49 +02:00
schneems
70dd041f35 Fix style 2016-08-30 15:04:23 -05:00
schneems
3ee9d0061f Address comment via @dhh, better option naming 2016-08-30 10:26:13 -05:00
schneems
893035782d Set unknown_asset_fallback false only new apps 2016-08-29 13:16:07 -05:00
schneems
58bd1124cf Move default to different initializer 
Is this usage correct? cc/ @prathamesh-sonpatki
 2016-08-29 13:16:07 -05:00
schneems
a7256c30ae Thanks rubocop 2016-08-29 13:16:07 -05:00
schneems
129e6ead3e Fix initializer 2016-08-29 13:16:07 -05:00
schneems
fc16af47ba Default assets.unknown_asset_fallback to false 2016-08-29 13:16:07 -05:00
schneems
b47970294e Favor public_folder: true over public_* 
Adding all those `public_*` methods is a bit heavy handed, we can change the API to instead  use `public_folder: true`. Change was pretty easy since it was already implemented that way.
 2016-08-29 13:16:07 -05:00
schneems
a22164a282 Fix formatting 2016-08-29 13:16:07 -05:00
schneems
9b22681cfc Add public_* helpers to all the _tag methods. 2016-08-29 13:16:07 -05:00
schneems
0a633b324e Test public_ methods. 2016-08-29 13:16:07 -05:00
Eileen M. Uchitelle
01a8e0c24e Merge pull request #26224 from jonatack/consistent-asset-precompile-examples 
Consistent examples and template for assets#precompile
 2016-08-19 16:52:16 -04:00
Jon Atack
b4c92be471 Consistent examples and template for assets#precompile 
Listening to a few developers today discussing their troubles in understanding how to use the asset pipeline, it turns out that the precompile examples in the guides and assets.rb template have over time become a bit inconsistent.

This PR makes the examples consistent in code style, spacing, and asset names, removes the old 'swfObject.js' example, and in a couple of places wraps lines at 80 characters including in the assets.rb template.

Re-add spaces inside array parentheses.
 2016-08-19 22:24:54 +02:00
yuuji.yaginuma
72831d75b6 run before_configuration callbacks as soon as application constant inherits from Rails::Application 
Until Rails 4.1, `before_configuration` run as soon as the application constant
inherits from `Rails::Application`.
However, in d25fe31c40928712b5e08fe0afb567c3bc88eddf, it has been modified to
run at instantiation process.

This modify to `before_configuration` is run at same timing as to Rails 4.1.

Fixes #19880
 2016-08-19 12:12:00 +09:00
yuuji.yaginuma
6e95682b14 refactor CommandsTasks 
Extract a common method of `Rails::CommandsTasks` and
`Rails::Engine::CommandsTasks` to the module.
 2016-08-17 11:36:39 +09:00
Rafael França
3fc0bbf008 Merge pull request #26157 from y-yagi/remove_test_mailers_when_skipping_action-mailer 
remove "test/mailers" directory when skipping action-mailer
 2016-08-16 05:01:30 -03:00
Rafael França
4497b53ee9 Merge pull request #26130 from yui-knk/drop_table 
Drop a temporary table before end of a test case
 2016-08-16 05:01:20 -03:00
Rafael Mendonça França
55f9b8129a
Add three new rubocop rules 
Style/SpaceBeforeBlockBraces
Style/SpaceInsideBlockBraces
Style/SpaceInsideHashLiteralBraces

Fix all violations in the repository.
 2016-08-16 04:30:11 -03:00
yuuji.yaginuma
a42ec22b0b remove "test/mailers" directory when skipping action-mailer 
Related to #26146
 2016-08-14 11:19:16 +09:00
yui-knk
445696c0ca Drop a temporary table before end of a test case 2016-08-14 00:44:24 +09:00
Brian Cardarella
16a257d4d0 Ensure app/mailers is removed when skipping action-mailer 
Closes #26145
 2016-08-12 21:24:46 -04:00
Nathan Long
33f116f22c Make cache max-age durations self-explanatory 2016-08-12 15:09:47 -04:00
Aaron Patterson
1663bab3a9
Integration test to prevent regression for the 5th time 
Fix unsafe query generation risk.

Redo of CVE-2012-2660, CVE-2012-2694 and CVE-2013-0155

CVE-2016-6317
 2016-08-11 13:29:47 -07:00
yuuji.yaginuma
6fc8b54621 add missing require rake 
In ff8035dfeed8c86594c32ef8e9204806e190cb58, require rake is deferred.
Therefore, it is necessary to require rake even `Engine::CommandsTasks.
 2016-08-11 20:54:23 +09:00
Ryuta Kamizono
f006de5dc5 Fix broken alignments caused by auto-correct commit 411ccbd 
Hash syntax auto-correcting breaks alignments. 411ccbdab2608c62aabdb320d52cb02d446bb39c
 2016-08-10 06:36:39 +09:00
Xavier Noria
a9dc45459a code gardening: removes redundant selfs 
A few have been left for aesthetic reasons, but have made a pass
and removed most of them.

Note that if the method `foo` returns an array, `foo << 1`
is a regular push, nothing to do with assignments, so
no self required.
 2016-08-08 01:12:38 +02:00
Xavier Noria
b45c9ca9b6 revises most Lint/EndAlignment offenses 
Some case expressions remain, need to think about those ones.
 2016-08-07 23:41:00 +02:00
Xavier Noria
f90ee8ce27 applies project convention for string literals 2016-08-07 23:17:24 +02:00
Kasper Timm Hansen
33ec865e7b Merge pull request #24260 from y-yagi/show_error_message_when_error_raised_in_rails_runner 
show error message when error raised in rails runner
 2016-08-07 17:19:33 +02:00
Kasper Timm Hansen
ff8035dfee Defer requiring Rake until it's needed. 
Eagerly requiring Rake could put 100ms on to the Rails boot time. Shimmy that
down to 0 by requiring Rake when no native Rails command exists and we try to
run a Rake task. Or when printing all the Rake commands through `rails help`.

Fixes #25029
 2016-08-07 17:09:29 +02:00
Ryuta Kamizono
762e3f05f3 Add Style/EmptyLines in .rubocop.yml and remove extra empty lines 2016-08-07 17:50:59 +09:00
Guillermo Iguaran
c53102b02e Merge pull request #26060 from siong1987/minor/puma-config 
.to_i is unnecessary for puma threads.
 2016-08-06 14:12:23 -05:00
Xavier Noria
b326e82dc0 applies remaining conventions across the project 2016-08-06 20:20:22 +02:00
Xavier Noria
80e66cc4d9 normalizes indentation and whitespace across the project 2016-08-06 20:16:27 +02:00
Xavier Noria
411ccbdab2 remove redundant curlies from hash arguments 2016-08-06 19:44:11 +02:00
Xavier Noria
477568ee33 modernizes hash syntax in railties 2016-08-06 19:38:55 +02:00
Xavier Noria
e6ab70c439 applies new string literal convention to the rest of the project 
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
 2016-08-06 19:28:46 +02:00
Xavier Noria
adca8154c6 applies new string literal convention in the gemspecs 
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
 2016-08-06 19:27:12 +02:00
Xavier Noria
783763bde9 applies new string literal convention in railties/test 
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
 2016-08-06 19:16:09 +02:00
Xavier Noria
69ab3eb57e applies new string literal convention in railties/lib 
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
 2016-08-06 19:15:47 +02:00
Teng Siong Ong
5ea4729cd7 .to_i is unnecessary. 2016-08-04 14:51:29 -07:00
yuuji.yaginuma
bf71b6a579 show error message when error raised in rails runner 2016-08-03 12:16:16 +09:00
Akira Matsuda
31c1ed95d3 Show supported DBs first in rails new --help 2016-08-03 03:36:35 +09:00
Santiago Pastorino
7732cf5b0f Merge pull request #26004 from y-yagi/remove_unnecessary_require_and_extend 
remove unnecessary require and extend
 2016-08-01 11:16:59 -03:00
yuuji.yaginuma
e3fc35b5d6 remove unnecessary require and extend 
`rack/test` is require at the top of file.
https://github.com/rails/rails/blob/master/railties/test/railties/engine_test.rb#L3

In addtion, `Rack::Test::Methods` is include in class, extend is unnecessary.
https://github.com/rails/rails/blob/master/railties/test/railties/engine_test.rb#L9
 2016-07-31 16:25:39 +09:00
yui-knk
29fa06a234 Suppress warnings 
This commit suppressed
`warning: instance variable @session_store not initialized`.
e5a6f7ee9e951dbe0e4e9ea2c0743b4dfb135c57 introduced these
warnings.
 2016-07-31 14:57:47 +09:00
Santiago Pastorino
1a2f1c48bd There are some cases where @@app is not defined 2016-07-26 22:04:56 -03:00
Ben Pickles
09ed4e95ac A generated app should not include Uglifier with --skip-javascript option. 2016-07-26 19:18:30 +01:00