TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
1,341 Commits 2 Branches 0 Tags 294 MiB
964a477340
Commit Graph

167 Commits

Author SHA1 Message Date
David Heinemeier Hansson
964a477340 Include Routing tests in rake run #1287 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1473 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-21 16:39:28 +00:00
David Heinemeier Hansson
c608ebeade Added TextHelper#word_wrap(text, line_length = 80) #1449 [tuxie@dekadance.se] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1465 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-21 07:16:11 +00:00
David Heinemeier Hansson
1e0d9a642f Added :xhr => true/false option to verify so you can ensure that a request is coming from an Ajax call or not #1464 [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1463 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-21 07:02:30 +00:00
David Heinemeier Hansson
bc6570dfcb Added tag_options as a third parameter to AssetHelper#auto_discovery_link_tag to control options like the title of the link #1430 [kevin.clark@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1460 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-21 06:52:05 +00:00
David Heinemeier Hansson
f2a021dc06 Added option to pass in parameters to CaptureHelper#capture, so you can create more advanced view helper methods #1466 [duane.johnson@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1459 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-21 06:43:14 +00:00
David Heinemeier Hansson
a49a784dc7 More tests for JavascriptHelper #1460 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1451 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-18 05:17:39 +00:00
David Heinemeier Hansson
92473b8f96 Fixed relative urls support for lighttpd #1048 [Nicholas Seckar/maznawak@nerim.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1450 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-18 05:17:18 +00:00
Jeremy Kemper
959707bfb6 r1335@iwill: jeremy | 2005-06-17 11:41:50 -0700 
Ticket 1458 - distance_of_time_in_words
 r1336@iwill:  jeremy | 2005-06-17 11:44:50 -0700
 Update changelog
 r1337@iwill:  jeremy | 2005-06-17 11:45:44 -0700
 Applied patch.
 r1361@iwill:  jeremy | 2005-06-17 11:48:02 -0700
 Merge changelog


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1449 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-17 13:42:23 +00:00
David Heinemeier Hansson
a895be0259 Fixed query parser to deal gracefully with equal signs inside keys and values #1345 [gorou] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1441 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 06:42:49 +00:00
David Heinemeier Hansson
a7a1c4e2cd Added cuba to country list #1351 [todd] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1440 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 06:36:09 +00:00
David Heinemeier Hansson
665ab93761 Added :extension option to NumberHelper#number_to_phone #1361 [delynnb] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1438 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 06:33:10 +00:00
David Heinemeier Hansson
43c470fae4 Added button_to as a form-based solution to deal with harmful actions that should be hidden behind POSTs. This makes it just as easy as link_to to create a safe trigger for actions like destroy, although it's limited by being a block element, the fixed look, and a no-no inside other forms. #1371 [tom@moertel.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1437 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 06:17:51 +00:00
David Heinemeier Hansson
89e06ed4c6 Fixed image_tag so an exception is not thrown just because the image is missing and alt value can't be generated #1395 [Marcel] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1434 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 06:04:23 +00:00
David Heinemeier Hansson
5b3bc3139a Added a third parameter to TextHelper#auto_link called href_options for specifying additional tag options on the links generated #1401 [tyler.kovacs@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1432 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 06:00:18 +00:00
David Heinemeier Hansson
691562746f Fixed TextHelper#highlight to return the text, not nil, if the phrase is blank #1409 [patrick@lenz.sh] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1429 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 05:42:47 +00:00
David Heinemeier Hansson
7b47f150fd Its Iraq, not Irak #1443 [ivan] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1427 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 05:05:43 +00:00
David Heinemeier Hansson
cc6c48f0a8 Fixed TagHelper such that :name and 'name' keys in the options doesn't result in two attributes #1455 [take_tk] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1426 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 05:04:17 +00:00
Jeremy Kemper
7bb486055e r1318@iwill: jeremy | 2005-06-15 01:08:22 -0700 
Ticket 1394 - Helper isolation
 r1319@iwill:  jeremy | 2005-06-15 01:10:00 -0700
 Formulate a test case for helper isolation.
 r1331@iwill:  jeremy | 2005-06-15 15:21:07 -0700
 Update changelog
 r1332@iwill:  jeremy | 2005-06-15 15:21:30 -0700
 Remove superfluous, broken layout_test
 r1333@iwill:  jeremy | 2005-06-15 15:24:10 -0700
 Use an anonymous Module to store helpers per-class instead of tossing them all in template_class.  Create a new helper module for subclasses which includes its superclass' helper module.  Remove unnecessary ActionView::Base.controller_delegate.  Update helper tests.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1425 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-15 17:17:58 +00:00
Jamis Buck
14c378cc7f render(:template) applies a layout by default. render("foo/bar") works with a layout again. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1424 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-15 13:20:17 +00:00
David Heinemeier Hansson
cb79118111 Fixed double-singularization on scaffolded pagination call (Address would be turned into Addres) #1216, #1404 [nilsga] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1422 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-15 04:17:45 +00:00
Jamis Buck
ed7bfc9662 Allow distance_of_time_in_words to work with any value that responds to #to_time (like dates) #969 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1420 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-14 15:19:03 +00:00
Jamis Buck
75fb0a32a8 Support :render option to :verify #1440 [TobiasLuetke] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1418 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-14 13:23:55 +00:00
Jamis Buck
b2b757be39 Fix broken test case caused by change of testing address from 127.0.0.1 to 0.0.0.0 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1417 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-14 10:31:31 +00:00
Jeremy Kemper
3cb26e9cb3 r2495@sedna: jeremy | 2005-05-27 22:07:18 -0700 
Branch to have scaffold use new render methods
 r2496@sedna:  jeremy | 2005-05-28 10:50:51 -0700
 axe unused process_request method
 r2497@sedna:  jeremy | 2005-05-28 10:51:58 -0700
 sanity assertions in process method check that @controller, @request, @response are set
 r2498@sedna:  jeremy | 2005-05-28 10:53:42 -0700
 clean up escaping.  use instance_variable_get instead of instance_eval.  put id in form action instead of hidden input (like the generated scaffolding)
 r2499@sedna:  jeremy | 2005-05-28 10:54:46 -0700
 clean up interpolation, remove tabs from stylesheet
 r2500@sedna:  jeremy | 2005-05-28 10:56:40 -0700
 modernize dynamic scaffolding.  use params[:id] instead of @params[id].  use consolidated render method instead of render_action, render_file, etc.  use builtin inflections rather than module methods.
 r2501@sedna:  jeremy | 2005-05-28 11:00:26 -0700
 modernize generated scaffolding.  use new-style assertions; use params[:id] instead of @params[id]; use consolidated render method instead of render_*
 r2542@sedna:  jeremy | 2005-06-12 02:24:06 -0700
 use :id => model instead of :id => model.id.  clean up the form helper method.  use flash[:notice] instead of flash['notice'].
 r2543@sedna:  jeremy | 2005-06-12 02:33:22 -0700
 whitespace
 r2544@sedna:  jeremy | 2005-06-12 02:56:57 -0700
 update changelogs
 r2545@sedna:  jeremy | 2005-06-12 03:26:23 -0700
 test dynamic form help when @post is not a new record
 r2546@sedna:  jeremy | 2005-06-12 03:44:14 -0700
 touch up TestCase#process sanity assertions


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1404 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-12 05:33:23 +00:00
Jamis Buck
f6ec9e3d66 Arrays sent via multipart posts are converted to strings #1032 [dj@omelia.org] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1397 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-10 12:21:25 +00:00
Jamis Buck
e4c047e489 render(:action) and render() are the only two render calls to use a layout by default. All others default to :layout => false. Also, allow :layout => true to be a synonym for :layout => nil. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1378 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-01 13:39:58 +00:00
Jamis Buck
6ce58318f5 render(:inline) defaults to :layout => false 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1372 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-30 09:12:12 +00:00
Jamis Buck
f8542a64b3 Make sure the benchmarking render method always returns the result of the render, regardless of whether logging is enabled or not. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1371 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-30 09:00:46 +00:00
Jamis Buck
f57ee365e1 render(:text), render(:partial), and render(:nothing) always default to :layout => false. This also fixes send_file, which was applying a layout if one existed for the current action. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1369 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-30 07:51:02 +00:00
Jamis Buck
613260606b verify with :redirect_to won't redirect if a redirect or render has already been performed #1350 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1367 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-30 07:24:46 +00:00
Jamis Buck
00db6f0faa render(:partial => "...") uses an empty hash for the local assigns #1365. render(:partial => true) is identical to the older render_partial() 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1366 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-30 07:20:37 +00:00
David Heinemeier Hansson
79d9794f09 Updated unit test style 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1355 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-22 17:12:29 +00:00
David Heinemeier Hansson
c41f0cc720 Test for no layout on nothing 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1354 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-22 16:59:55 +00:00
David Heinemeier Hansson
da0c4c5c96 Deprecated all render_* methods in favor of consolidating all rendering behavior in Base#render(options). This enables more natural use of combining options, such as layouts 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1350 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-22 08:58:43 +00:00
David Heinemeier Hansson
0367317dd6 Deprecated redirect_to_path and redirect_to_url in favor of letting redirect_to do the right thing when passed either a path or url. Introduced r as a unified method for render (still under construction) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1349 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-22 07:43:05 +00:00
David Heinemeier Hansson
d3704f888b Fixed assert_redirect_to to work with redirect_to_path #869 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1332 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 19:19:58 +00:00
David Heinemeier Hansson
dd8c92ea5b Fixed Request#remote_ip in testing #1251 [bitsweat] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1322 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 18:24:52 +00:00
David Heinemeier Hansson
473e5bde74 Fixed that compute_public_path should recognize external URLs, so image_tag("http://www.example.com/images/icon.gif") is not prefixed with the relative url path #1254 [victor-ronr-trac@carotena.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1321 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 18:06:12 +00:00
David Heinemeier Hansson
202d5c0751 Added support for descending year values in DateHelper#select_year, like select_year(Date.today, :start_year => 2005, :end_year => 1900), which would count down from 2005 to 1900 instead of the other way #1274 [nwoods@mail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1320 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 17:40:02 +00:00
David Heinemeier Hansson
496ee0cd1b Fixed that FormHelper#checkbox should return a checked checkbox if the value is the same as checked_value #1286 [Florian Weber] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1317 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 17:27:08 +00:00
David Heinemeier Hansson
aa20834222 Added accessors to logger, params, response, session, and headers from the view, so you can write <% logger.info "stuff" %> instead of <% @logger.info "others" %> -- more consistent with the preferred way of accessing these attributes and collections from the controller 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1307 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 16:00:04 +00:00
David Heinemeier Hansson
45780be2a7 Added TextHelper#sanitize that can will remove any Javascript handlers, blocks, and forms from an input of HTML. This allows for use of HTML on public sites, but still be free of XSS issues. #1277 [Jamis Buck] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1298 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-09 11:24:18 +00:00
David Heinemeier Hansson
dacb61c8ca Added that both AssetHelper#stylesheet_link_tag and AssetHelper#javascript_include_tag now accept an option hash as the last parameter, so you can do stuff like: stylesheet_link_tag "style", :media => "all" 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1281 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-03 14:39:57 +00:00
David Heinemeier Hansson
e6f3e5d900 Fixed action/fragment caching using the filestore when a directory and a file wanted to to use the same name. Now there's a .cache prefix that sidesteps the conflict #1188 [imbcmdth@hotmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1260 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-30 15:29:27 +00:00
David Heinemeier Hansson
98306bed05 Fixed missing id uniqueness in FormTag#radio_button #1207 [Jarkko] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1253 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-30 08:46:22 +00:00
David Heinemeier Hansson
b4fe4daa84 Fixed assert_redirected_to to work with :only_path => false #1204 [Alisdair McDiarmid] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1251 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-30 08:34:02 +00:00
David Heinemeier Hansson
3b9bf64130 Added support for web servers that use PATH_INFO instead of REQUEST_URI like IIS #1014 [BradG/Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1211 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-18 15:43:07 +00:00
David Heinemeier Hansson
806cf6d76a Added assert_tag and assert_no_tag as a much improved alternative to the deprecated assert_template_xpath_match #1126 [Jamis Buck] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1195 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 16:43:48 +00:00
David Heinemeier Hansson
dca7efa67e Deprecated the majority of all the testing assertions and replaced them with a much smaller core and access to all the collections the old assertions relied on. That way the regular test/unit assertions can be used against these. Added documentation about how to use it all. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1189 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 11:38:01 +00:00
David Heinemeier Hansson
8e8bf37aa9 Fixed DateHelper to return values on the option tags such that they'll work properly in IE with form_remote_tag #1024 [rscottmace@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1184 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 09:44:28 +00:00