TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
21,483 Commits 2 Branches 0 Tags 294 MiB
99da42c299
Commit Graph

570 Commits

Author SHA1 Message Date
Santiago Pastorino
99da42c299 Gem::Specification#has_rdoc= is deprecated since rubygems 1.7.0 2011-04-02 00:35:33 -03:00
Santiago Pastorino
4f90b28e06 Bring back AMo#i18n_key method 2011-03-30 16:29:43 -03:00
Santiago Pastorino
450f7cf01b use class_eval with a string when it's possible 2011-03-22 20:11:36 -03:00
Santiago Pastorino
da6c7bd4b4 Do not in place modify what table_name returns 2011-03-22 19:36:16 -03:00
Santiago Pastorino
445241d713 define_attr_method should be able to define methods that returns nil 2011-03-17 23:17:20 -03:00
Aaron Patterson
4532b39f5f remove misleading comment 2011-03-17 10:31:12 -07:00
Aaron Patterson
00f0879367 dup strings on return so that in place modifications do not break anything. I am looking at you "compute_table_name" 2011-03-17 10:26:11 -07:00
Santiago Pastorino
c834a751d2 define_attr_method correctly defines methods with invalid identifiers 2011-03-16 21:20:44 -03:00
Santiago Pastorino
fda45f4fc4 Add a define_attr_method test 2011-03-16 21:08:02 -03:00
Santiago Pastorino
5232077517 Add test for define_attr_method using as name an invalid identifier 2011-03-16 21:01:49 -03:00
Santiago Pastorino
cb44e99de4 Add test for define_attribute_method using as name an invalid identifier 2011-03-16 21:01:04 -03:00
Andrew White
e8458d37c5 Fix typo in assertion message 2011-03-16 10:28:40 +00:00
Norman Clarke
7bd70dcd6c Add messages to plain assertions. 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-03-15 10:44:14 -03:00
Santiago Pastorino
157c37f558 Refactor length validation 2011-03-12 21:12:44 -02:00
Andriy Tyurnikov
f48d3d4df6 length validation for fixnums 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-03-12 21:12:44 -02:00
Mike Gehard
58de03f077 Add additional text to NotImplementedErrors [#6328 state:resolved] 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-03-12 13:43:23 -02:00
Xavier Noria
89ecc0a5dc Merge branch 'master' of git://github.com/lifo/docrails 2011-03-07 22:11:47 +01:00
Vijay Dev
f99db5a6a8 formatting changes 2011-03-07 23:56:16 +05:30
Paco Guzman
8e0affbd86 Configuration options are symbols 2011-03-06 22:35:26 +01:00
Paco Guzman
14c254aba3 Remove Example headers. Code just flows with the text. 6ce844a3 2011-03-06 22:34:01 +01:00
Paco Guzman
7e9d45cc7f remove unused assigned variable 2011-03-06 22:24:22 +01:00
R.T. Lechow
86c15d8b89 Active Model typos. 2011-03-05 11:56:34 +01:00
Alexander Uvarov
24faddd60c Move ActiveModel::AttributeMethods#attribute_methods_generated? to ActiveRecord, so it's flexible now 
[#6428 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2011-03-01 20:22:45 +01:00
Santiago Pastorino
a00bed0c48 Revert "Properly interpolate i18n keys in modules [#5572 state:resolved]" 
This breaks #6448, you should use :"module/class" as key for namespacing
[#6448 state:committed]

This reverts commit 8d30193b08bd2321a7a78a1f481bd5e4d4d45557.
 2011-02-27 21:30:03 -02:00
Santiago Pastorino
acf0688fdd failing test for i18n key collision with namespaced models 2011-02-27 21:23:52 -02:00
Prem Sichanugrist
839d06f5f2 We're in 2011, let's update our license 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-02-22 18:24:20 -02:00
Xavier Noria
f826e05835 Merge branch 'master' of git://github.com/lifo/docrails 2011-02-21 11:42:26 +01:00
Xavier Noria
b481574a33 copy-edits 8d96b89 2011-02-21 11:37:08 +01:00
Xavier Noria
9297027e08 copy-edits 6d7a826 2011-02-21 11:01:26 +01:00
Xavier Noria
843a5b9a3a copy-edits 34316d8 2011-02-21 11:00:03 +01:00
Nicholas Rowe
34316d8b7e Docs: Update to_xml documentation to match as_json docuemntation 2011-02-20 21:35:43 -05:00
Nicholas Rowe
6d7a8267b9 Documentation: Added small comments to Observering module 2011-02-20 21:05:41 -05:00
Xavier Noria
e2d54fb3f1 documents the backported Range#cover?, and related stuff 2011-02-20 10:52:49 +01:00
Diego Carrion
511bf2a050 refactored ActiveModel::Validations::InclusionValidator#validate_each 
[#6455 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-02-19 23:24:38 -02:00
Peer Allan
8d96b89110 Clarification of ActiveRecord ActiveModel validation documentation 2011-02-18 20:51:56 -06:00
Xavier Noria
f41bf6938f merges docrails 2011-02-18 23:22:15 +01:00
Frederick Cheung
fbfa30a1ee Change validates inclusion to use cover? for Ranges in ruby 1.9 [#6453 state:committed] 
Signed-off-by: Xavier Noria <fxn@hashref.com>
 2011-02-18 21:32:28 +01:00
Nicholas Rowe
a906deabc6 fix type: remove extra period 2011-02-17 20:34:22 -05:00
Jimmy Cuadra
bd7d8665a0 add note about observer config for rails apps 
ActiveModel::Observer and ActiveRecord::Observer have similar
documentation, but a Rails user looking at the ActiveModel version
might not realize that a change to config/application.rb is
required to activate the observer. This change adds a note to
that effect, pointing to the AR version from the AM version.
 2011-02-16 14:15:48 -08:00
Tsutomu Kuroda
ad31549ab3 Override attributes_protected_by_default when has_secure_password is called. 
attr_protected should not be called, because it nullifies the
mass assignment protection that has been set by attr_accessible.

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-02-09 18:35:15 -02:00
Aaron Patterson
f48d32c0cf implementing include? on AM::Errors 2011-02-09 09:19:56 -08:00
Aaron Patterson
51d84c1d33 we do not need message to be an array 2011-02-09 08:42:13 -08:00
Aaron Patterson
c6b4ef082f use map rather than array concatenation 2011-02-09 08:32:43 -08:00
Aaron Patterson
307e6b2b74 favor composition over inheritence 2011-02-09 08:32:43 -08:00
Aaron Patterson
ed6e09c1b1 use 1 call to concat rather than calling << n times 2011-02-09 08:32:43 -08:00
Santiago Pastorino
933adce8f4 Use map + flatten here 2011-02-07 19:15:06 -02:00
Nathaniel Bibler
285fdbae2b Fixed broken, memoized attributes method example 
[#6245 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-02-07 14:44:37 -02:00
Carl Lerche
cf9324e590 Find all validators for multiple attributes 2011-02-05 20:27:02 -08:00
Carl Lerche
cd13fbd8d8 Optionally pass in the attribute being validated to an instance method validator 2011-02-05 16:44:35 -08:00
Carl Lerche
e9e9ed6b60 Be able to pass a validator method to #validates 2011-02-05 16:33:00 -08:00