David Heinemeier Hansson
|
b203b9b55b
|
Fixed broken test
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6231 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-02-25 20:11:18 +00:00 |
|
Jeremy Kemper
|
de0a0d700e
|
Routing: better support for escaped values in route segments. Closes #7544.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6185 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-02-21 10:05:07 +00:00 |
|
Rick Olson
|
7a49cb058f
|
fix form_for example in ActionController::Resources documentation. Closes #7362 [gnarg], Added enhanced docs to routing assertions. Closes #7359 [Rob Sanheim], improve error message for Routing for named routes. Closes #7346 [Rob Sanheim]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6113 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-02-04 19:07:08 +00:00 |
|
Nicholas Seckar
|
2cc9c8135c
|
Allow Routes to generate all urls for a set of options by specifying :generate_all => true. References #1739.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6082 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-01-28 17:29:51 +00:00 |
|
Jeremy Kemper
|
0eacdcf9a3
|
Use a consistent load path to avoid double requires. Fix some scattered Ruby warnings.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6057 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-01-28 07:16:55 +00:00 |
|
Rick Olson
|
d2205ea5e9
|
Improve Test Coverage for ActionController::Routing::Route#matches_controller_and_action? (Heckle++) #7115 [Kevin Clark]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5976 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-01-17 06:49:43 +00:00 |
|
Jeremy Kemper
|
f9f84d9f6d
|
Routing uses URI escaping for path components and CGI escaping for query parameters.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5803 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-12-28 21:04:44 +00:00 |
|
Nicholas Seckar
|
d1a2449220
|
Fix a bug in Routing where a parameter taken from the path of the current request could not be used as a query parameter for the next. Closes #6752.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5709 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-12-09 04:42:32 +00:00 |
|
David Heinemeier Hansson
|
2794f4164f
|
Dropped the idea of automatically routing :format for the vanilla routes -- that will be a treat for map.resources. Deprecated the name route root as it'll be used as a shortcut for map.connect '' in Rails 2.0 (Rails 1.2). Added map.root as an alias for map.connect '' (Rails 2.0)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5671 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-12-04 00:12:00 +00:00 |
|
Nicholas Seckar
|
d1529a71d1
|
Update Routing to complain when :controller is not specified by a route. Closes #6669.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5607 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-11-22 16:31:00 +00:00 |
|
Jeremy Kemper
|
f8486e8f10
|
silence const_set warning
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5503 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-11-13 01:17:10 +00:00 |
|
Rick Olson
|
cfb7dea783
|
clean up failing routing tests from missing :only_path option [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5337 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-10-22 23:48:52 +00:00 |
|
Nicholas Seckar
|
03b383853d
|
Fix routing to correctly determine when generation fails. Closes #6300.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5314 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-10-16 19:52:21 +00:00 |
|
Jamis Buck
|
39963b4b9d
|
remove an obsolete #dup call. avoid double negatives, to make the code easier to understand and explain
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5304 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-10-15 03:11:08 +00:00 |
|
Nicholas Seckar
|
bc85e6ac4c
|
Rename test assertion to prevent shadowing. Closes #6306.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5252 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-10-09 01:20:36 +00:00 |
|
Nicholas Seckar
|
8d809e724a
|
Clear the cache of possible controllers whenever Routes are reloaded.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5169 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-09-23 17:25:06 +00:00 |
|
Nicholas Seckar
|
4ae3db8366
|
Fix routing to respect user provided requirements and defaults when assigning default routing options (such as :action => 'index'). Closes #5950.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5151 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-09-20 17:45:03 +00:00 |
|
David Heinemeier Hansson
|
40762a4873
|
Fixed default routing NoMethodError downcase for nil when default controller provided (closes #5400) [kajism@yahoo.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4998 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-09-04 20:09:15 +00:00 |
|
Rick Olson
|
2b45e2d370
|
Add routing tests to assert that RoutingError is raised when conditions aren't met. Closes #6016 [Nathan Witmer]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4907 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-09-02 20:41:40 +00:00 |
|
Nicholas Seckar
|
caf546b675
|
Add test case from ticket #4090
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4805 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-08-22 07:18:24 +00:00 |
|
Nicholas Seckar
|
7678d123a7
|
Relax Routing's anchor pattern warning; it was preventing use of [^/] inside restrictions.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4763 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-08-15 02:04:11 +00:00 |
|
Nicholas Seckar
|
5baf7462c7
|
Add controller_paths variable to Routing; Assign Routing.controller_paths from initializer; fix script/about and rails info controller.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4762 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-08-15 01:28:06 +00:00 |
|
Rick Olson
|
8c4b599b7c
|
Fix assert_redirected_to issue with named routes for module controllers. [Rick Olson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4757 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-08-13 18:31:58 +00:00 |
|
Nicholas Seckar
|
127ee8c8f8
|
Make Routing noisy when an anchor regexp is assigned to a segment. Closes #5674
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4677 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-08-05 22:12:50 +00:00 |
|
Nicholas Seckar
|
e494b0a441
|
Add route_name_path method to generate only the path for a named routes. For example, map.person will add person_path.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4518 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-06-30 02:36:17 +00:00 |
|
Rick Olson
|
2bbcff8cf4
|
Fix that routes with *path segments in the recall can generate URLs. [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4454 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-06-17 00:25:24 +00:00 |
|
Rick Olson
|
2f58a467e3
|
add passing test to make sure unhandled requests don't load unnecessary classes. Closed #5408. [nkriege@hotmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4451 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-06-16 03:22:09 +00:00 |
|
Jamis Buck
|
816d67b104
|
Make sure passed routing options are not mutated by routing code. (closes #5314)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4444 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-06-07 16:27:14 +00:00 |
|
Jamis Buck
|
ae7029ddd1
|
Do some path normalization to prevent the possible_controllers list from containing invalid entries
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4443 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-06-07 16:16:37 +00:00 |
|
Jamis Buck
|
4e3543b467
|
Make sure named routes are never generated relative to some containing module
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4442 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-06-06 19:09:56 +00:00 |
|
Jamis Buck
|
e768dc694d
|
Improve parameter expiry handling to fix sticky-id issue. Add a more informative Route#to_s method.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4441 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-06-06 17:59:54 +00:00 |
|
Jamis Buck
|
6c04eb2115
|
Make sure changing the controller from foo/bar to bing/bang does not change relative to foo.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4438 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-06-05 15:48:29 +00:00 |
|
Jamis Buck
|
149f5cad85
|
Escape the entire path before trying to recognize it (closes #3671)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4436 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-06-05 15:30:09 +00:00 |
|
Jamis Buck
|
2ffc84d23f
|
Make sure :id and friends are properly unescaped (closes #5275).
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4435 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-06-05 14:51:27 +00:00 |
|
Jamis Buck
|
332fcfaf6b
|
Make sure regexp chunks are grouped when the segment has a regexp constraint so that captures are counted correctly (closes #5267)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4434 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-06-05 14:31:38 +00:00 |
|
Jamis Buck
|
b20c575ac0
|
New routes implementation. Simpler, faster, easier to understand. The published API for config/routes.rb is unchanged, but nearly everything else is different, so expect breakage in plugins and libs that try to fiddle with routes.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4394 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-06-01 15:42:08 +00:00 |
|
Rick Olson
|
04ef7f4be6
|
Small fix in routing to allow dynamic routes (broken after [4242]) [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4319 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-04-30 21:06:49 +00:00 |
|
Jamis Buck
|
e75d27f405
|
restore some commented lines
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4245 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-04-21 20:15:53 +00:00 |
|
Jamis Buck
|
0a0b5bd722
|
fix to ';' interpretation in route recognition--only follow a route with ';' if the segment in question actually contains a ';'
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4244 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-04-21 17:21:26 +00:00 |
|
Jamis Buck
|
1f80f540a7
|
Add support in routes for semicolon delimited "subpaths", like /books/:id;:action
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4242 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-04-21 15:17:02 +00:00 |
|
Nicholas Seckar
|
5450538563
|
Don't let arbitrary classes match as controllers
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3542 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-02-04 23:59:37 +00:00 |
|
Nicholas Seckar
|
427d0a8d14
|
Fix bad require for rake test
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3541 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-02-04 23:14:22 +00:00 |
|
Nicholas Seckar
|
cc768dc900
|
Fix routing tests to pass when run independently of the entire AP suite
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3540 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-02-04 23:12:15 +00:00 |
|
Nicholas Seckar
|
b381d8511d
|
Fix Routing tests. Fix routing where failing to match a controller would prevent the rest of routes from being attempted.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3539 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2006-02-04 23:09:26 +00:00 |
|
Nicholas Seckar
|
b9c79f195f
|
Add routing tests from #1945
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2257 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2005-09-18 14:37:43 +00:00 |
|
Nicholas Seckar
|
57e0cf8e95
|
Add a routing test case covering #2101
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2256 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2005-09-18 14:11:24 +00:00 |
|
Nicholas Seckar
|
27962ead03
|
Add ability to specify Route Regexps for controllers. Closes #1917.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2205 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2005-09-11 13:56:43 +00:00 |
|
Nicholas Seckar
|
9e5d64b3bb
|
Provide Named Route's hash methods as helper methods. Closes #1744.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2204 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2005-09-11 13:45:55 +00:00 |
|
Nicholas Seckar
|
741316dc71
|
Fixed construction of get parameters for arrays
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1857 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2005-07-18 03:12:45 +00:00 |
|
Nicholas Seckar
|
c0771fe7d8
|
Fix assert_routing with nested controllers. Closes #1582 and #1386.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1837 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2005-07-15 15:00:39 +00:00 |
|