TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
2,567 Commits 2 Branches 0 Tags 294 MiB
a0293c80f0
Commit Graph

1008 Commits

Author SHA1 Message Date
Jeremy Kemper
a0293c80f0 Improve expire_fragment documentation. Closes #2966. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3115 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 01:08:30 +00:00
Marcel Molina
55a3979a09 Correct docs for automatic layout assignment. Closes #2610. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3111 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-20 18:50:09 +00:00
Jeremy Kemper
da9f713d2c r3209@asus: jeremy | 2005-11-20 01:04:22 -0800 
If sessions are disabled, return a hash that raises an error when it's accessed.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3109 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-20 09:06:43 +00:00
Jeremy Kemper
63b792162b Make data writer private. Marshal/unmarshal handle nil. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3108 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-20 08:15:51 +00:00
Jeremy Kemper
c7bc10b2e4 Log ActiveRecordStore debugging. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3107 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-20 08:07:33 +00:00
Jeremy Kemper
991189b58d Document request.env and request.host. Strip trailing whitespace. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3103 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-20 05:31:33 +00:00
Jeremy Kemper
cd8686b456 r3173@asus: jeremy | 2005-11-18 23:34:41 -0800 
Ticket 2731 - sessions
 r3185@asus:  jeremy | 2005-11-19 18:02:51 -0800
 eliminate const redefinition warning
 r3186@asus:  jeremy | 2005-11-19 19:25:50 -0800
 Use :database option instead of :dbfile
 r3187@asus:  jeremy | 2005-11-19 19:34:31 -0800
 Data writer assigns to instance var.  Since nothing is calling write_attribute on the data column except for marshal_data, simplify data reader to lazy-unmarshal the data column (no worrying whether it's already unmarshaled)
 r3188@asus:  jeremy | 2005-11-19 19:35:40 -0800
 Explicitly create the session class so that subsequent requests for the session can find it in the database.  This is masking a problem with the controller losing its @session instance var and therefore requesting a new session.
 r3189@asus:  jeremy | 2005-11-19 19:36:40 -0800
 Using create unnecessarily  broadens the existing duck-typing so use new + save instead.
 r3194@asus:  jeremy | 2005-11-19 20:28:17 -0800
 Test creation of another instance while first instance is still active.  Should return same session_id.
 r3195@asus:  jeremy | 2005-11-19 20:39:45 -0800
 Always create new AR sessions rather than trying too hard to avoid database traffic.  References #2731.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3100 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-20 04:41:59 +00:00
Sam Stephenson
d777e506f2 Update to Prototype 1.4.0_rc4. Closes #2943 (old Array.prototype.reverse behavior can be obtained by passing false as an argument) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3091 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-19 06:59:07 +00:00
Sam Stephenson
b3c65bc849 Use Element.update('id', 'html') instead of uid=501(sam) gid=501(sam) groups=501(sam), 81(appserveradm), 79(appserverusr), 80(admin).innerHTML = 'html' in JavaScriptGenerator#replace_html so that script tags are evaluated 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3086 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-18 18:03:45 +00:00
Marcel Molina
62fe5bbfb1 Make rjs templates always implicitly skip out on layouts. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3084 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-18 08:32:17 +00:00
Jeremy Kemper
fb3fc46cdd Correct length for the truncate text helper. Closes #2913. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3080 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-18 01:25:39 +00:00
Sam Stephenson
173544f56c Update to Prototype 1.4.0_rc3. Closes #1893, #2505, #2550, #2748, #2783. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3079 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-18 00:53:11 +00:00
Marcel Molina
06e74b6c91 Add support for new rjs templates which wrap an update_page block. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3078 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-17 21:28:59 +00:00
Jeremy Kemper
e9a4e4d88b Inline a method used by render_partial. Closes #2881. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3073 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-17 19:08:53 +00:00
Marcel Molina
5cb2aa722d Rename Version constant to VERSION. Closes #2802. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3065 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-17 00:32:16 +00:00
Jeremy Kemper
98898ed798 Correct time_zone_options_for_select docs. Closes #2892. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3062 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-16 21:57:30 +00:00
Jeremy Kemper
9de738aadc Remove the unused, slow response_dump and session_dump variables from error pages. References #1222. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3060 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-16 21:34:24 +00:00
Jeremy Kemper
8da9d02e6e Include QUOTED_TYPE constant in ActionPack AR assertions tests. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3059 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-16 09:09:04 +00:00
Jeremy Kemper
ba942dfc45 fewer objects, no loop in convert_content_type. Closes #2883. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3058 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-16 09:05:04 +00:00
Jeremy Kemper
c63f3bdc7a Inline commonly-called template presence checks. Closes #2882. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3057 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-16 09:03:00 +00:00
Jeremy Kemper
ede505592c Avoid logging code if logger is nil. Closes #2881. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3056 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-16 09:00:23 +00:00
Jeremy Kemper
eb1dd6a206 Use Set instead of Array to speed up prototype helper include? calls. Closes #2880. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3055 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-16 08:53:26 +00:00
Jeremy Kemper
745ea39926 MemCache store may be given multiple addresses. Closes #2869. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3054 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-16 08:35:31 +00:00
Jeremy Kemper
05d580dffa Remove invalid links in ActionView::Helpers::UrlHelper documentation. Closes #1961. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3041 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-15 09:42:32 +00:00
Jeremy Kemper
08fd13d17c Handle cookie parsing irregularity for certain Nokia phones. Closes #2530. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3039 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-15 07:51:09 +00:00
Sam Stephenson
d99ed9bd6a Refactored JavaScriptHelper into PrototypeHelper and ScriptaculousHelper. Added PrototypeHelper::JavaScriptGenerator and PrototypeHelper#update_page for easily modifying multiple elements in an Ajax response. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3036 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-14 22:28:47 +00:00
Thomas Fuchs
415d27490f Update trunk to latests script.aculo.us 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3033 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-14 20:49:10 +00:00
Tobias Lütke
037f61c8e9 * Updated docs for in_place_editor, fixes a couple bugs and offers extended support for external controls [Justin Palmer] closes #2870 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3032 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-14 20:46:32 +00:00
Jeremy Kemper
5cd2f32697 Update documentation for render :file. References #2858. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3015 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-14 00:12:46 +00:00
Jeremy Kemper
da2d4d6d57 Note that the ruby-memcache bindings are required to use the memcache store. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3013 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-14 00:08:24 +00:00
Jeremy Kemper
44ca6f4b62 Only include builtin filters whose filenames match /^[a-z][a-z_]*_helper.rb$/ to avoid including operating system metadata such as ._foo_helper.rb. References #2855. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3007 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-13 22:21:19 +00:00
David Heinemeier Hansson
b0c23e589f hidden_field can also be in fields_for 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3006 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-13 12:54:00 +00:00
David Heinemeier Hansson
c6435b77de Make form_for work with additional options 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3005 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-13 12:53:03 +00:00
David Heinemeier Hansson
0306127bb5 Show with local vars 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3004 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-13 11:14:12 +00:00
David Heinemeier Hansson
947cec29d5 Added FormHelper#form_for and FormHelper#fields_for that makes it easier to work with forms for single objects also if they don't reside in instance variables [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3003 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-13 11:13:11 +00:00
Jeremy Kemper
b81c46e6bd options_for_select allows any objects which respond_to? :first and :last rather than restricting to Array and Range. Closes #2824. References [2126]. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2977 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-10 22:08:20 +00:00
Scott Barron
339fff7950 This does not need to be thread local (thanks skaes). 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2970 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-10 12:59:22 +00:00
Jeremy Kemper
adba181060 The auto_link text helper accepts an optional block to format the link text for each url and email address. References #2628. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2963 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-10 06:04:50 +00:00
Jeremy Kemper
3661eacfbd Include all of session creation in stale_session_check 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2958 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-09 20:34:44 +00:00
Jamis Buck
b7ce9c5a87 assert_tag uses exact matches for string conditions, instead of partial matches. Use regex to do partial matches. #2799 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2952 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-09 13:42:05 +00:00
Jeremy Kemper
bb4c32e2b5 Delete existing sessions with the same session id before creating a new session. Prevents duplication and hijacking. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2946 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-09 06:00:46 +00:00
Jeremy Kemper
0abaf3a2d8 CGI::Session::ActiveRecordStore.data_column_name = 'foobar' to use a different session data column than the 'data' default. References #2731. Remove error-prone method_missing passthrough to session model. Cleanup. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2944 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-09 01:03:24 +00:00
Jeremy Kemper
85baf07be8 Controllers with acronyms in their names (e.g. PDFController) require the correct default helper (PDFHelper in file pdf_helper.rb). Closes #2262. Do not raise an exception when default helper is missing; log a debug message instead. It's nice to delete empty helpers. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2938 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-08 08:23:13 +00:00
David Heinemeier Hansson
cd2b9a9498 Made ready for 0.14.3 (RC4) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2930 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-07 19:40:27 +00:00
David Heinemeier Hansson
3c31062c3d Added request as instance method to views, so you can do <%= request.env["HTTP_REFERER"] %>, just like you can already access response, session, and the likes [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2918 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-07 13:51:56 +00:00
David Heinemeier Hansson
6ab9f2bb40 Fix READMEs (closes #2680) [coffee2code] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2908 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-07 09:51:47 +00:00
David Heinemeier Hansson
01cfd2b00a Fix docs (closes #2725) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2906 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-07 09:36:43 +00:00
David Heinemeier Hansson
8dda7c5449 Fix conflict with assert_tag and Glue gem (closes #2255) [david.felstead@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2905 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-07 09:31:49 +00:00
Jamis Buck
0073a759f1 Add documentation to assert_tag indicating that it only works with well-formed XHTML 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2894 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-06 13:59:07 +00:00
Sam Stephenson
8a8b472fc2 Update changelog 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2881 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-05 03:04:41 +00:00