Jeremy Kemper
a69b28a8b1
Missing 1.8.7 backport extensions
2009-05-18 13:20:04 -07:00
Jeremy Kemper
37453e11e9
Revert "Get AR CI passing again by requiring the entire core_ext"
...
This reverts commit 8e6a18d8672f7efe6ef79b49185e4a6a23e4e547.
2009-05-18 11:55:06 -07:00
Emilio Tagua
28f5cfe066
Add missing model and fixtures to finder_test [ #2671 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
2009-05-18 15:58:25 +02:00
Benjamin Floering
27de7f150b
Fixed limited eager loading associations with numbers in the name [ #2668 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
2009-05-18 13:56:17 +02:00
Joshua Peek
01d7acd11d
Fix reset_session with ActiveRecord store [ #2200 state:resolved]
2009-05-17 14:42:36 -05:00
Mislav Marohnić
b33c0d9832
replace the aaa_create_tables_test hack with loading test database schema in the test helper [ #2663 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com>
2009-05-17 13:51:35 -05:00
Chris Kampmeier
4e8c36a741
Implement #many? for NamedScope and AssociationCollection using #size [ #1500 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
2009-05-17 18:56:06 +02:00
Daniel Guettler
25724eede9
has_one :through should not create a new association when assigned nil [ #698 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
2009-05-17 14:48:20 +02:00
Yehuda Katz
8e6a18d867
Get AR CI passing again by requiring the entire core_ext
...
Note that this includes Time and Date; we should
really figure out what parts of core_ext are really
required for AR and require just those.
2009-05-16 12:09:25 -07:00
Yehuda Katz + Carl Lerche
b6bac73b28
Merge commit 'origin/master'
...
Conflicts:
actionpack/lib/action_controller/abstract/base.rb
actionpack/lib/action_controller/routing.rb
2009-05-14 17:38:30 -07:00
Peter Marklund
afcbdfc15f
Changed ActiveRecord::Base#exists? to invoke find_initial so that it is compatible with, and doesn't lose, :include scopes (references to eager loaded tables)
...
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#2543 state:committed]
2009-05-14 20:42:00 +12:00
Jeremy Kemper
4f291fa528
Simple examples for require profiling
2009-05-13 12:00:49 -07:00
Jeremy Kemper
e8550ee032
Cherry-pick core extensions
2009-05-13 12:00:15 -07:00
Jeremy Kemper
fa5da8ad54
isolated_test task
2009-05-13 11:43:03 -07:00
Jeremy Kemper
a7ccc7c79f
Remove support for deprecated validation message interpolation format
2009-05-13 11:43:03 -07:00
Bryan Helmkamp
a2875bec9a
Use DependencyModule for included hooks in ActiveRecord
2009-05-11 22:23:47 -04:00
Jeremy Kemper
ddbeb15a5e
Revert "Fixed bug with polymorphic has_one :as pointing to an STI record"
...
[#2594 state:open]
This reverts commit 99c103be1165da9c8299bc0977188ecf167e06a5.
2009-05-11 12:20:54 -07:00
Mike Breen
9010ed2755
Allow you to pass :all_blank to :reject_if option to automatically create a Proc that will reject any record with blank attributes.
2009-05-10 15:02:00 +12:00
Anthony Crumley
026b78f907
Fixed eager load error on find with include => [:table_name] and hash conditions like {:table_name => {:column => 'value'}}
...
Signed-off-by: Michael Koziarski <michael@koziarski.com>
2009-05-10 13:36:51 +12:00
Frederick Cheung
235775de29
honour :inverse_of for joins based include
...
Signed-off-by: Michael Koziarski <michael@koziarski.com>
2009-05-10 12:50:03 +12:00
Frederick Cheung
ef6f22ab2a
honour inverse_of when preloading associations
...
Signed-off-by: Michael Koziarski <michael@koziarski.com>
2009-05-10 12:50:02 +12:00
Murray Steele
ccea98389a
Providing support for :inverse_of as an option to associations.
...
You can now add an :inverse_of option to has_one, has_many and belongs_to associations. This is best described with an example:
class Man < ActiveRecord::Base
has_one :face, :inverse_of => :man
end
class Face < ActiveRecord::Base
belongs_to :man, :inverse_of => :face
end
m = Man.first
f = m.face
Without :inverse_of m and f.man would be different instances of the same object (f.man being pulled from the database again). With these new :inverse_of options m and f.man are the same in memory instance.
Currently :inverse_of supports has_one and has_many (but not the :through variants) associations. It also supplies inverse support for belongs_to associations where the inverse is a has_one and it's not a polymorphic.
Signed-off-by: Murray Steele <muz@h-lame.com>
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2009-05-04 15:27:39 -07:00
Chris Kampmeier
d3ee8756c8
Don't use #tap before Active Support is available, since older versions of ruby don't have native implementations
...
[#2603 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2009-05-04 08:32:25 -07:00
Jeremy Kemper
945bf9c254
Check for sibling Active Support first
2009-05-02 15:16:12 -07:00
Ruy Asan
99c103be11
Fixed bug with polymorphic has_one :as pointing to an STI record
...
[#2594 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2009-05-01 14:47:56 -07:00
Alexander Podgorbunsky
db0bfe4ede
Default scope :order should be overridden by named scopes.
...
[#2346 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2009-05-01 14:44:24 -07:00
steve
60a6284a46
Tests should use ActiveRecord::Base.connection.rollback_db_transaction to rollback a transaction
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
2009-05-01 16:00:09 +01:00
steve
5501b99a19
Ensure ActiveRecord::Base.connection_pool.with_connection creates a new connection only when needed [ #1752 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
2009-05-01 14:58:10 +01:00
Ken Collins
b193f23390
Use table_exists? in #initialize_schema_migrations_table [ #1923 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
2009-05-01 14:24:40 +01:00
Jeremy Kemper
dc9f53b05b
Selectively require rake sshpublisher so full gem isn't required
2009-04-30 21:02:23 -07:00
Jeremy Kemper
9b852af497
Explicitly require builder for to_xml
2009-04-30 20:34:11 -07:00
Emilio Tagua
db892ea775
Fix duplicated test name
...
[#2581 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2009-04-29 15:46:43 -07:00
Emilio Tagua
4246a79a99
Show executed queries when assert_sql assertion fails [ #2573 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
2009-04-28 22:11:47 +01:00
Eloy Duran
da3c21ead5
Ensure the parent record is always saved when the child is invalid. [ #2249 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
2009-04-27 19:25:27 +01:00
Jeremy Kemper
6e3e00219b
Fix differing rails_to_json arity
2009-04-26 20:26:44 -07:00
Jeremy Kemper
706f313231
Use Array.wrap
2009-04-26 20:24:45 -07:00
Emilio Tagua
a841cd2503
Fix models load order to be able to run unit tests.
...
[#2550 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2009-04-23 16:02:11 -07:00
rick
3c4c6bd0df
* Add pluggable JSON backends with support for the JSON gem. [rick]
...
Example: ActiveSupport::JSON.backend = "JSONGem"
All internal Rails JSON encoding is now handled by ActiveSupport::JSON.encode(). Use of #to_json is not recommended, as it may clash with other libraries that overwrite it. However, you can recover Rails specific functionality
if you really want to use #to_json.
gem 'json'
ActiveSupport::JSON.backend = "JSONGem"
class ActiveRecord::Base
alias to_json rails_to_json
end
2009-04-23 00:08:40 -07:00
Jeremy Kemper
7f6779c1d5
Merge branch 'master' into cherry
...
Conflicts:
activesupport/lib/active_support.rb
2009-04-22 16:53:58 -07:00
Jeremy Kemper
6fee981fa4
Opt in to JSON
2009-04-22 16:48:58 -07:00
Jeremy Kemper
f5d720fb96
Opt in to Dependencies
2009-04-22 16:42:14 -07:00
Jeremy Kemper
ab321268f8
No more free lunch
2009-04-22 16:10:49 -07:00
Alex Pooley
504d16ccdf
Add microsecond support for sqlite adapter [ #1982 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
2009-04-21 18:05:07 +01:00
Pratik Naik
2e6d1bf43e
Change table to prevent copying indexes on sqlite2
2009-04-21 13:28:49 +01:00
Pratik Naik
2381f6f3dc
Specify :group with the table name for it to work on sqlite3
2009-04-21 13:11:56 +01:00
Pratik Naik
6513dde490
Fix tests for sqlite3 3.6.xx
2009-04-21 13:06:26 +01:00
Max Lapshin
f3ac4f387d
Fixed dumping from postgresql columns in index in wrong order. [ #2515 state:resolved]
...
Signed-off-by: Tarmo Tänav <tarmo@itech.ee>
2009-04-21 11:44:13 +01:00
Scott Woods
64b33b6cf9
Quote table names when casting to regclass so that capitalized tables are supported. [ #2418 state:resolved]
...
Signed-off-by: Tarmo Tänav <tarmo@itech.ee>
2009-04-21 11:43:38 +01:00
Max Lapshin
cdcd638c2f
Fixed wrong quoting of index names in postgres [ #2402 state:resolved]
...
Signed-off-by: Tarmo Tänav <tarmo@itech.ee>
2009-04-21 11:42:40 +01:00
Pratik Naik
de0ea38663
Ensure :dependent => :delete_all works for association with hash conditions
2009-04-20 18:12:40 +01:00