TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
4,641 Commits 2 Branches 0 Tags 294 MiB
aa7859c976
Commit Graph

1438 Commits

Author SHA1 Message Date
Jamis Buck
3f4cbccb9c When dealing with SQLite3, use the table_info pragma helper, so that the bindings can do some translation for when sqlite3 breaks incompatibly between point releases. Also, make current_adapter? use is_a? instead of instance_of? to account correctly for adapter subclassing. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6091 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-30 03:14:55 +00:00
Jeremy Kemper
d5e122002a Oracle: fix lob and text default handling. Closes #7344. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6090 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-29 22:06:08 +00:00
Jeremy Kemper
16f6bd4070 SQLServer: don't choke on strings containing 'null'. Closes #7083. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6084 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-28 17:51:21 +00:00
Jeremy Kemper
269ad9711d MySQL: blob and text columns may not have defaults in 5.x. Update fixtures schema for strict mode. Closes #6695. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6074 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-28 15:45:06 +00:00
Jeremy Kemper
5acea7fc9c update_all can take a Hash argument. sanitize_sql splits into two methods for conditions and assignment since NULL values and delimiters are handled differently. References #6583, closes #7365. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6073 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-28 15:12:54 +00:00
Jeremy Kemper
7ce6753526 Post title and body not null. References #6778. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6067 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-28 09:11:15 +00:00
Jeremy Kemper
8f5c12e451 MySQL: SET SQL_AUTO_IS_NULL=0 so 'where id is null' doesn't select the last inserted id. Closes #6778. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6064 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-28 08:49:23 +00:00
Jeremy Kemper
c6b15dde1b Use Date#to_s(:db) for quoted dates. Closes #7411. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6061 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-28 07:58:02 +00:00
Rick Olson
1a11bffde1 Don't create instance writer methods for class attributes. Closes #7401 [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6051 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-28 01:31:31 +00:00
David Heinemeier Hansson
0aa0c84c17 Nodoc the irrelevant (from 1.2) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6044 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-26 21:37:38 +00:00
Jeremy Kemper
873f5e2f3c Docs: validations examples. Closes #7343. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6031 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-24 12:17:14 +00:00
Rick Olson
d5bd679340 Add missing tests ensuring callbacks work with class inheritance. Closes #7339 [sandofsky] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6026 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-24 03:04:48 +00:00
Jeremy Kemper
0eb8398cfa Fixtures use the table name and connection from set_fixture_class. Closes #7330. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6023 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-24 01:29:49 +00:00
Rick Olson
8296c680d5 Remove useless code in #attribute_present? since 0 != blank?. Closes #7249 [Josh Susser]. Fix minor doc typos. Closes #7157 [Josh Susser] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6018 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-23 05:10:21 +00:00
Rick Olson
bc97a87138 Fix incorrect usage of #classify when creating the eager loading join statement. Closes #7044 [Josh Susser] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6017 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-23 05:07:35 +00:00
Jeremy Kemper
fee8856ff1 SQLServer: quote table name in indexes query. Closes #2928. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6014 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-23 04:23:29 +00:00
Jeremy Kemper
06afb8c746 Subclasses of an abstract class work with single-table inheritance. References #5704, closes #7284. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6013 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-23 04:19:16 +00:00
Jamis Buck
7359dc0028 Make sure sqlite3 driver closes open connections on disconnect (closes #7105) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6012 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-22 23:07:54 +00:00
Rick Olson
56c5535466 [DOC] clear up some ambiguity with the way has_and_belongs_to_many creates the default join table name. #7072 [jeremymcanally] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5960 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-16 06:30:02 +00:00
Michael Koziarski
71a4f7161f Allow the Oracle adapter to insert a string "null". Closes #6997 [laurelfan] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5958 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-16 01:39:05 +00:00
Michael Koziarski
8437be3380 Improve handling of LoadErrors with the oracle adapter. Closes #6780 [kubo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5956 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-16 01:31:25 +00:00
David Heinemeier Hansson
6d37c638e7 Made sure that connections are only removed for SQLite 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5955 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-15 22:12:40 +00:00
Jamis Buck
521ca37c3e be like a duck. Let's not rely on explicit classes, so we can pass proxy objects around and have them interpreted correctly by ActiveRecord's serialization routines 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5953 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-15 17:23:01 +00:00
Jeremy Kemper
d1917cfea2 Skip column options for primary keys. Closes #7048. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5944 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-15 15:48:38 +00:00
Michael Koziarski
51d840e272 Improve association documentation, closes #7022. [hasmanyjosh] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5939 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-15 06:43:47 +00:00
Jeremy Kemper
6019c26856 change_column accepts :default => nil. Closes #6956. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5937 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-15 02:22:53 +00:00
Jeremy Kemper
a491f92860 MySQL, PostgreSQL: change_column_default quotes the default value and doesn't lose column type information. References #3987, closes #6664. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5935 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-15 01:24:23 +00:00
Jeremy Kemper
e310344111 Oracle: create_table takes a :sequence_name option to override the 'tablename_seq' default. Closes #7000. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5933 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-15 00:34:43 +00:00
Jeremy Kemper
9ccb12a3dd Test that calculations don't modify their options hash. References #6929. [eventualbuddha] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5931 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-14 16:19:58 +00:00
Jeremy Kemper
0227f86eee MySQL: retain SSL settings on reconnect. Closes #6976. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5929 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-14 15:19:18 +00:00
Jeremy Kemper
b78458284b Aggregate reflection klass works with nested :class_name 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5923 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-14 12:08:44 +00:00
Jeremy Kemper
937eeab103 Oracle: correctly perform eager finds with :limit and :order. Closes #7021. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5919 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-13 07:43:35 +00:00
Tobias Lütke
e24d2f7234 Apply scoping during initialize instead of create. Fixes setting of foreign key when using find_or_initialize_by with scoping. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5913 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-12 21:14:36 +00:00
Jeremy Kemper
c302cdfcc4 Fix scope typo in add_lock! Closes #6482. [zubek] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5907 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-12 10:18:11 +00:00
Jeremy Kemper
c62e5e1a3a Demonstrate that a value's required. References #6156. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5903 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-12 08:52:08 +00:00
Jeremy Kemper
a66ad97dac Oops. References #6156. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5902 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-12 08:50:35 +00:00
Jeremy Kemper
dbd7b5e111 Test MySQL implicit NULL for integer columns. Closes #6156. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5901 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-12 08:46:01 +00:00
Jeremy Kemper
9073cef866 SQLServer: handle [quoted] table names. Closes #6635. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5891 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-12 05:44:28 +00:00
Jeremy Kemper
8d3ff3abc7 acts_as_nested_set works with single-table inheritance. Closes #6030. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5889 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-12 05:33:09 +00:00
Jeremy Kemper
ef4ac31de3 PostgreSQL: use a subselect to correctly perform eager finds with :limit and :order. Closes #4668. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5887 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-12 05:14:55 +00:00
Jeremy Kemper
3b6555acd4 Fix new_record? and id rollback. Closes #6910. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5886 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-12 05:10:06 +00:00
Jeremy Kemper
353238b6a4 Inline primary keys. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5885 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-12 04:58:08 +00:00
Jamis Buck
8dd08f98c7 dry up some duplicated code 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5883 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-11 18:19:23 +00:00
Jamis Buck
0d34c28199 treat create! like create and make sure the target is loaded first 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5882 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-11 18:10:42 +00:00
Jamis Buck
c398e83893 fix regression in has_one#create, that caused instances thus created to be orphaned 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5881 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-11 18:04:47 +00:00
Jeremy Kemper
28767075f4 Pass a range in :conditions to use the SQL BETWEEN operator. Closes #6974. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5876 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-10 10:13:18 +00:00
Michael Koziarski
b4282df966 Fix the Oracle adapter for serialized attributes stored in CLOBs. Closes #6825 [mschoen, tdfowler] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5866 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-05 23:42:03 +00:00
Rick Olson
1400e7f864 [DOCS] Apply more documentation for ActiveRecord Reflection. Closes #4055 [Robby Russell] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5855 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-05 20:22:41 +00:00
Rick Olson
606376bd44 [DOCS] Document :allow_nil option of #validate_uniqueness_of. Closes #3143 [Caio Chassot] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5853 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-05 20:17:37 +00:00
Michael Koziarski
84481dd3b4 Sybase adapter fixes. Closes #6926 [jsheets] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5839 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-05 00:12:06 +00:00